Fellow Reports - July 2021

[Mariusz Felisiak]

Week ending July 11, 2021

Triaged:
    https://code.djangoproject.com/ticket/32661 - An exception should be raised when trying to save datetime/time object and the UTC offset isn't known. (invalid)
    https://code.djangoproject.com/ticket/32899 - enhance JSONResponse safe=True kwarg docs (accepted)
    https://code.djangoproject.com/ticket/32901 - BaseForm.__getitem__() does unneeded work in the happy path (accepted)
    https://code.djangoproject.com/ticket/32902 - CsrfViewMiddleware.process_response()'s csrf_cookie_needs_reset and csrf_cookie_set logic isn't right (accepted)
    https://code.djangoproject.com/ticket/32898 - get_or_create() with filter() has surprising behaviour (wontfix)
    https://code.djangoproject.com/ticket/32903 - admin page in Google-Chrome does not show the columns like in Firefox or Chrome (invalid)
    https://code.djangoproject.com/ticket/32905 - Add `nonform` CSS class for non form errors in FormSets (accepted)
    https://code.djangoproject.com/ticket/32904 - Tighten up the regular expression used by parse_time to accept less 'invalid' options. (accepted)
    https://code.djangoproject.com/ticket/32907 - Allow duplicate headers while sending email (invalid)
    https://code.djangoproject.com/ticket/32909 - strftime got None on sqlite (invalid)
    https://code.djangoproject.com/ticket/32911 - django.forms.BaseFormSet.is_valid does not respect TOTAL_FORM_COUNT (needsinfo)
    https://code.djangoproject.com/ticket/32912 - Using label_from_instance on ModelChoiceField requires resetting queryset first (duplicate)
    https://code.djangoproject.com/ticket/32906 - Explain JSONBAgg benefit (accepted)
    https://code.djangoproject.com/ticket/24243 - Allow HashedFilesMixin to handle file name fragments (wontfix)
    https://code.djangoproject.com/ticket/24475 - Add a new testconnections management command (wontfix)
    https://code.djangoproject.com/ticket/32914 - DiscoverRunner doesn't always group tests by class (accepted)
    https://code.djangoproject.com/ticket/32915 - ./manage runserver --nostatic still doesn't return a traceback (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/14591 - Refs #24121 -- Added __repr__() to AdminSite, DefaultAdminSite, and ModelAdmin.
    https://github.com/django/django/pull/14574 - Fixed #32226 -- Fixed JSON format of QuerySet.explain() on PostgreSQL.
    https://github.com/django/django/pull/14586 - Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert".
    https://github.com/django/django/pull/14596 - Fixed #32901 -- Optimized BaseForm.__getitem__().
    https://github.com/django/django/pull/14575 - Fixed #32776 -- Added support for Array subqueries on PostgreSQL.
    https://github.com/django/django/pull/14582 - Fixed #32892 -- Optimized django.utils.dateparse functions by using fromisoformat().
    https://github.com/django/django/pull/14600 - Added test for errors when saving timezone-aware times if not supported.
    https://github.com/django/django/pull/14539 - Fixed #32866 -- Fixed trimming trailing punctuation from escaped string in urlize().
    https://github.com/django/django/pull/14602 - Fixed #32904 -- Made parse_time() more strict.
    https://github.com/django/django/pull/14585 - Fixed #32840 -- Optimized Field.get_col().
    https://github.com/django/django/pull/14137 - Fixed #24522 -- Added a --shuffle option to DiscoverRunner.
    https://github.com/django/django/pull/14494 - Fixed #27021 -- Allowed lookup expressions in annotations, aggregations, and QuerySet.filter().

Authored:
    https://github.com/django/django/pull/14592 - Fixed isolation of test_filename_traversal_upload().
    https://github.com/django/django/pull/14595 - Fixed isolation of RouterTestCase.test_m2m_cross_database_protection().
    https://github.com/django/django/pull/14603 - Fixed #32908 -- Allowed select_for_update(skip_locked) on MariaDB 10.6+.
    https://github.com/django/django/pull/14605 - Fixed inspectdb and schema tests on MariaDB 10.6+.
    https://github.com/django/django/pull/14610 - Fixed isolation of GenericRelationTests.test_filter_targets_related_pk().
    https://github.com/django/django/pull/14616 - Fixed isolation of NonAutocommitTests.test_orm_query_after_error_and_rollback().

Best,
Mariusz

[Mariusz Felisiak]

Week ending July 18, 2021

Triaged:
   https://code.djangoproject.com/ticket/32917 - Add an internal _value_from_datadict() method to BaseForm (accepted)
   https://code.djangoproject.com/ticket/32918 - Increase logging of authentication flow (duplicate)
   https://code.djangoproject.com/ticket/32916 - CsrfViewMiddleware's request.META["CSRF_COOKIE_USED"] and request.csrf_cookie_needs_reset can be combined (accepted)
   https://code.djangoproject.com/ticket/32921 - Incorrect SQL generation for JSON has_key__in (invalid)
   https://code.djangoproject.com/ticket/32925 - TextField default text not populate to MySQL data when migrate (invalid)
   https://code.djangoproject.com/ticket/32927 - Multi geometries cause Segmentation fault 11 on Macbook with M1 CPU with gdal 3.3.1 (duplicate)
   https://code.djangoproject.com/ticket/32928 - Confirm support for GDAL 3.3. (created)
   https://code.djangoproject.com/ticket/32929 - AsyncRequestFactory.get() ignores data parameter (accepted)
   https://code.djangoproject.com/ticket/32931 - Add further and clear instruction to see effect of Http404 in tutorial 3 (wontfix)
   https://code.djangoproject.com/ticket/32932 - Unique indexes (duplicate)
   https://code.djangoproject.com/ticket/32935 - Test suite fails with sqlite 3.36 and spatialite 5. (needsinfo)

Reviewed/committed:
   https://github.com/django/django/pull/14621 - Fixed #32914 -- Prevented test --shuffle from skipping test methods.
   https://github.com/django/django/pull/14588 - Refs #32880 -- Created a new logging how-to document.
   https://github.com/django/django/pull/14620 - Refs #23359 -- Corrected showmigrations help text for the --database option.
   https://github.com/django/django/pull/14629 - Fixed #32917 -- Added BaseForm._widget_data_value()/_field_data_value().
   https://github.com/django/django/pull/14630 - Refs #32880 -- Made some titles consistent in how-to documents.
   https://github.com/django/django/pull/14598 - Fixed #32899 -- Added note about avoiding non-dict objects in JsonResponse docs.
   https://github.com/django/django/pull/14415 - Completed test coverage for django.utils.dateformat and simplified some formats.
   https://github.com/django/django/pull/14608 - Fixed #32905 -- Added CSS class for non-form errors of formsets.
   https://github.com/django/django/pull/14173 - Refs #32508 -- Raised Type/ValueError instead of using "assert" in django.db.models.
   https://github.com/django/django/pull/14639 - Fixed #32929 -- Fixed handling query strings in AsyncRequestFactory.
   https://github.com/django/django/pull/14646 - Fixed #32928 -- Confirmed support for GDAL 3.3.
   https://github.com/django/django/pull/14649 - Prevented SQLCompiler.execute_sql() from closing cursor twice.
   https://github.com/django/django/pull/14647 - Fixed #32655 -- Deprecated extra_tests argument for DiscoverRunner.build_suite()/run_tests().

Reviewed:
   https://github.com/django/django/pull/14634 - Fixed #21936 -- Allowed DeleteView to work with custom Forms and SuccessMessageMixin.

Authored:
   https://github.com/django/django/pull/14624 - Refs #32074 -- Used Enum.repr() format proposed for Python 3.10.
   https://github.com/django/django/pull/14635 - Refs #31676 -- Removed Django Core-Mentorship mailing list references in docs.
   https://github.com/django/django/pull/14636 - Fixed #32910 -- Unified different plural equations for the same language in contrib apps.

Best,

Mariusz

[Mariusz Felisiak]

Week ending July 25, 2021

Triaged:
   https://code.djangoproject.com/ticket/32942 - Confirm support for PostGIS 3.1 (accepted)
   https://code.djangoproject.com/ticket/32943 - Add support for covering indexes and exclusion constraints for SP-GiST in PostgreSQL 14+. (someday/maybe)
   https://code.djangoproject.com/ticket/32945 - Improve performance of HttpRequest._current_scheme_host() (invalid)
   https://code.djangoproject.com/ticket/32944 - Simplify where clause creation where the WhereNode is immediately created and then added to and then returned. (accepted)
   https://code.djangoproject.com/ticket/32947 - Missing call make_hashable on through_fields in ManyToManyRel. (accepted)
   https://code.djangoproject.com/ticket/32952 - Django is not generating new session (invalid)
   https://code.djangoproject.com/ticket/32951 - Remove Query.where_class in favor of using WhereNode directly. (accepted)
   https://code.djangoproject.com/ticket/32946 - Prefer non-kwargs construction of dynamically generated Q objects. (accepted)
   https://code.djangoproject.com/ticket/32955 - widthratio does not round properly (invalid)
   https://code.djangoproject.com/ticket/32956 - Modernise spellings of Web, Email et al (accepted)
   https://code.djangoproject.com/ticket/32959 - URLValidator test cases can be defined in a Python module (accepted)
   https://code.djangoproject.com/ticket/32958 - URLValidator tests don't obviously test how long validation takes (needsinfo)
   https://code.djangoproject.com/ticket/32957 - Make documentation of Model.save() arguments easier to find and get to (accepted)

Reviewed/committed:
   https://github.com/django/django/pull/14662 - Fixed #32942 -- Confirmed support for PostGIS 3.1.
   https://github.com/django/django/pull/14659 - Fixed #32941 -- Removed get_format_modules()'s unused reverse argument.
   https://github.com/django/django/pull/14026 - Fixed #10929 -- Added default argument to aggregates.
   https://github.com/django/django/pull/14658 - Fixed #32940 -- Removed unnecessary branch and unused squash parameter in Node.add().
   https://github.com/django/django/pull/14665 - Fixed #32944 -- Avoided unnecessary WhereNode.add() calls.
   https://github.com/django/django/pull/14667 - Fixed #32704 -- Fixed list of deferred fields when chaining QuerySet.defer() after only().
   https://github.com/django/django/pull/14674 - Fixed #32951 -- Removed Query.where_class & co.
   https://github.com/django/django/pull/14650 - Fixed #32930 -- Fixed URLValidator when port numbers < 10.
   https://github.com/django/django/pull/13799 - Fixed #32275 -- Added scrypt password hasher.
   https://github.com/django/django/pull/14682 - Fixed #32950 -- Removed myproject from imports in admin docs where appropriate.
   https://github.com/django/django/pull/14599 - Fixed #32902 -- Fixed CsrfViewMiddleware.process_response()'s cookie reset logic.
   https://github.com/django/django/pull/14660 - Fixed #32913 -- Made watchman reloader tests less flaky.
   https://github.com/django/django/pull/14681 - Fixed #32329 -- Made CsrfViewMiddleware catch more specific UnreadablePostError.

Authored:
   https://github.com/django/django/pull/14670 - Fixed #31676 -- Updated organization docs according to DEP 0010.

Best,
Mariusz

[Mariusz Felisiak]

Week ending August 1, 2021

Triaged:
   https://code.djangoproject.com/ticket/29112 - Make it easier to update specific keys within nested Django JSONField data. (duplicate)
   https://code.djangoproject.com/ticket/32962 - Consolidate string concatenations in BaseDatabaseSchemaEditor.column_sql(). (accepted)
   https://code.djangoproject.com/ticket/32963 - Combination of filter on the annotation and random order. (duplicate)
   https://code.djangoproject.com/ticket/32948 - Optimise Q combination and inversion (accepted)
   https://code.djangoproject.com/ticket/32965 - Django related manager allways choose db_for_read router and fail update/delete (invalid)
   https://code.djangoproject.com/ticket/32966 - time-related _check_fix_default_value() methods can be optimized / simplified (accepted)
   https://code.djangoproject.com/ticket/32967 - Buggy Migrations when `float("nan")` in `Q` objects (wontfix)
   https://code.djangoproject.com/ticket/32969 - Improve pickling of HttpResponse instances (accepted)
   https://code.djangoproject.com/ticket/32973 - Pass generator expression to str.join() instead of list / tuple throughout code base (wontfix)
   https://code.djangoproject.com/ticket/32972 - Django ORM raw query not playing nice with Geometric Point objects (invalid)
   https://code.djangoproject.com/ticket/32971 - System check methods can yield their items instead of creating lists at every layer (wontfix)
   https://code.djangoproject.com/ticket/32974 - multiple form (invalid)
   https://code.djangoproject.com/ticket/32977 - conditionalize Class Meta. I want to achieve something like this. How can i do it? (invalid)

Reviewed/committed:
   https://github.com/django/django/pull/14672 - Fixed #32947 -- Fixed hash() crash on reverse M2M relation when through_fields is a list.
   https://github.com/django/django/pull/14684 - Fixed #32957 -- Improved visibility of arguments sections in Model.save() docs.
   https://github.com/django/django/pull/14691 - Fixed #32743 -- Added foreign key altering when altering type of referenced primary key with MTI.
   https://github.com/django/django/pull/14640 - Fixed #32906 -- Added docs and tests for using key and index lookups on JSONBAgg results.
   https://github.com/django/django/pull/14700 - Refs #32743 -- Fixed recreation of foreign key constraints when altering type of referenced primary key with MTI.
   https://github.com/django/django/pull/14702 - Refs #32956 -- Changed "afterwards" to "afterward" in docs and comments.
   https://github.com/django/django/pull/14701 - Fixed #32962 -- Consolidated string concatenations in BaseDatabaseSchemaEditor.column_sql().
   https://github.com/django/django/pull/14699 - Fixed #32946 -- Changed internal usage of dynamic Q() objects construction to use non-kwargs initialization.
   https://github.com/django/django/pull/14705 - Fixed #32959 -- Moved tests URLs to validators.tests.
   https://github.com/django/django/pull/14697 - Refs #32956 -- Lowercased "internet" and "email" where appropriate.
   https://github.com/django/django/pull/14708 - Fixed #32956 -- Lowercased spelling of "web" and "web framework" where appropriate.
   https://github.com/django/django/pull/14664 - Fixed #23895 -- Prevented pickling of ResolverMatch.
   https://github.com/django/django/pull/14688 - Fixed #32916 -- Combined request.META['CSRF_COOKIE_USED'] and request.csrf_cookie_needs_reset.
   https://github.com/django/django/pull/14712 - Removed unused and unnecessary words from docs/spelling_wordlist.
   https://github.com/django/django/pull/14717 - Fixed #32966 -- Fixed TimeField.check() crash for timezone-aware times in default when USE_TZ = True.
   https://github.com/django/django/pull/14713 - Refs #32956 -- Updated words ending in -wards.

Authored:
   https://github.com/django/django/pull/14698 - Updated Python license for 2021.
   https://github.com/django/django/pull/14716 - Refs #32880 -- Made remaining titles consistent in how-to documents.
   https://github.com/django/djangoproject.com/pull/1106 - Used GitHub Actions workflow.

Best,
Mariusz