Fellow Reports - November 2020

[Mariusz Felisiak]

Week ending November 8, 2020.

Triaged:
    https://code.djangoproject.com/ticket/32161 - Strict form of semantic versioning in Django. (wontfix)
    https://code.djangoproject.com/ticket/32159 - AsyncTestClient does not respect extra headers. (accepted)
    https://code.djangoproject.com/ticket/32163 - Admin change password is not handled gracefully (error 500) (invalid)
    https://code.djangoproject.com/ticket/32164 - Broken content_length header in AsyncTestClient when doing post requests with json data (duplicate)
    https://code.djangoproject.com/ticket/32162 - AsyncTestClient crashes on requests with JSON data. (accepted)
    https://code.djangoproject.com/ticket/32166 - Remove redundant Greatest class in test_expression_on_aggregation (accepted)
    https://code.djangoproject.com/ticket/32167 - app.ready() is called after models ready, but the site's urlpatterns are not parsed yet, so how to add code after the whole site is ready? (invalid)
    https://code.djangoproject.com/ticket/32168 - Remove serial pk assumptions in aggregation_regress tests (accepted)
    https://code.djangoproject.com/ticket/32169 - Added distinct support for JSONBAgg (accepted)
    https://code.djangoproject.com/ticket/32171 - Unable to use ProjectState and ModelState correctly to make changes to MySQL (invalid)
    https://code.djangoproject.com/ticket/32172 - Adapt signals to allow async handlers (accepted)
    https://code.djangoproject.com/ticket/32173 - Autoreloader doesn't work with asyncio. (accepted)
    https://code.djangoproject.com/ticket/32175 - FORCE_SCRIPT_NAME documentation doesn't explain how the prefix is prepended with regard to relative vs. absolute paths. (invalid)
    https://code.djangoproject.com/ticket/32176 - Outdated LOCATION requirement in Filesystem caching docs. (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/11304 - Protected Watchman autoreloader against busy loops.
    https://github.com/django/django/pull/13592 - Fixed #32132 -- Fixed column types in m2m intermediary tables for Positive(Big/Small)IntegerFields.
    https://github.com/django/django/pull/13634 - Fixed #32166 -- Removed redundant definition of Greatest in test_expression_on_aggregation.
    https://github.com/django/django/pull/13632 - Fixed #32162 -- Fixed setting Content-Length header in AsyncRequestFactory.
    https://github.com/django/django/pull/13638 - Fixed various tests on CockroachDB.
    https://github.com/django/django/pull/13332 - Fixed #31910 -- Fixed crash of GIS aggregations over subqueries.
    https://github.com/django/django/pull/13389 - Fixed #31983 -- Added system check for file system caches location.
    https://github.com/django/django/pull/13641 - Fixed #32169 -- Added distinct support to JSONBAgg.
    https://github.com/django/django/pull/13639 - Fixed #32168 -- Removed serial pk assumption in aggregation_regress tests.
    https://github.com/django/django/pull/13633 - Fixed #31550 -- Adjusted ASGI test_file_response for various Windows content types.
    https://github.com/django/django/pull/13557 - Fixed #31235 -- Made assertQuerysetEqual() compare querysets directly.
    https://github.com/django/django/pull/13570 - Fixed #32045 -- Doc'd GenericRelatedObjectManager methods.

Reviewed:
    https://github.com/django/django/pull/13635 - Fixed #32159 -- Ensured AsyncRequestFactory correctly sets headers.

Authored:
    https://github.com/django/django/pull/13629 - Refs #32061 -- Fixed test_crash_password_does_not_leak() crash on Windows.
    https://github.com/django/django/pull/13648 - Refs #32074 -- Fixed handling memoryview content by HttpResponse on Python 3.10+.

Best,
Mariusz

[Mariusz Felisiak]

Week ending November 15, 2020.

Triaged:
   https://code.djangoproject.com/ticket/32180 - Add a warning if the file system cache location is relative. (accepted)
   https://code.djangoproject.com/ticket/32178 - Allow database backends to skip tests and mark expected failures (accepted)
   https://code.djangoproject.com/ticket/32177 - ManagementUtility instantiates CommandParser without passing already-computed prog argument (accepted)
   https://code.djangoproject.com/ticket/32181 - ModelBackend used hardcoded global variable UserModel that cannot be overrided. (wontfix)
   https://code.djangoproject.com/ticket/32182 - Nested KeyTransform errors when used with a subquery on PostgreSQL. (accepted)
   https://code.djangoproject.com/ticket/32183 - shell command crashes when passing (with -c) the python code with functions. (accepted)
   https://code.djangoproject.com/ticket/25370 - Error display when makemigrations' field serializing fails with ValueError (wontfix)
   https://code.djangoproject.com/ticket/32190 - Support for model relationships defined pre-save (duplicate)
   https://code.djangoproject.com/ticket/32191 - Not RFC 6265 compliant cookies in contrib.messages. (accepted)
   https://code.djangoproject.com/ticket/32192 - Replacing the quotation marks with apostrophe marks in admin/base.html. (wontfix)

Reviewed/committed:
   https://github.com/django/django/pull/13656 - Removed BaseSpatialOperations.geometry and geography.
   https://github.com/django/django/pull/13657 - Fixed #32182 -- Fixed crash of JSONField nested key transforms with subquery annotations on PostgreSQL.
   https://github.com/django/django/pull/13658 - Fixed #32177 -- Made execute_from_command_line() use program name from the argv argument.
   https://github.com/django/django/pull/13637 - Refs #31672 -- Made technical 500 debug page include exceptions without tracebacks.
   https://github.com/django/django/pull/13664 - Avoided direct styles in admin templates.
   https://github.com/django/django/pull/13661 - Added SpatialFeatures.unsupported_geojson_options.
   https://github.com/django/django/pull/13665 - Fixed #31762 -- Made reloading the database for tests use the base manager.
   https://github.com/django/django/pull/13660 - Fixed #32183 -- Fixed shell crash when passing code with nested scopes.
   https://github.com/django/django/pull/13655 - Fixed #32180 -- Added system check for file system caches absolute location.
   https://github.com/django/django/pull/13183 - Fixed #31757 -- Adjusted system check for SECRET_KEY to warn about autogenerated default keys.
   https://github.com/django/django/pull/13566 - Fixed #31122 -- Clarified that Lookup acts as a query expression.
   https://github.com/django/django/pull/13670 - Fixed #32149 -- Added support for years < 1000 to DateFormat.y().
   https://github.com/django/django/pull/13615 - Fixed #29712 -- Made makemessages warn if locales have hyphens and skip them.
   https://github.com/django/django/pull/13678 - Unified admin action description generation.
   https://github.com/django/django/pull/13675 - Changed docs and a code comment to use gender-neutral pronouns.

Best,
Mariusz

[Mariusz Felisiak]

Week ending November 22, 2020.

Triaged:

   https://code.djangoproject.com/ticket/32193 - Deprecate MemcachedCache. (created)
   https://code.djangoproject.com/ticket/32194 - Issue while rendering view with Django 3.1.3. (invalid)
   https://code.djangoproject.com/ticket/32198 - Passwords of users created in admin user interface possibly not hashed? (invalid)
   https://code.djangoproject.com/ticket/32197 - Misleading error when loading a database backend fails with ImportError (accepted)
   https://code.djangoproject.com/ticket/32199 - Missing documentation of JSONField in ModelForm field mapping (accepted)
   https://code.djangoproject.com/ticket/32201 - remove obsolete isort:skip's (accepted)
   https://code.djangoproject.com/ticket/32200 - Aggregating when grouping on an ExpressionWrapper omits the expression from the group by (accepted)
   https://code.djangoproject.com/ticket/32202 - django-admin runserver and get_child_arguments() crashes on Windows and Python < 3.8. (accepted)
   https://code.djangoproject.com/ticket/32208 - add filter is unable to concatenate strings with lazy string (accepted)
   https://code.djangoproject.com/ticket/32211 - Add Codespaces Configuration (wontfix)
   https://code.djangoproject.com/ticket/32210 - Django Admin with Inlines not using UUIDField default value (accepted)
   https://code.djangoproject.com/ticket/32213 - QuerySet.values()/.values_list() on KeyTransforms return wrong values for double-quoted strings on SQLite and Oracle (accepted)
   https://code.djangoproject.com/ticket/32215 - documentation possible error - minor (invalid)
   https://code.djangoproject.com/ticket/32214 - Add django.core.exceptions.NON_FIELD_ERRORS key to the settings (wontfix)
   https://code.djangoproject.com/ticket/32216 - Can not execute tests with spatialite as database backend (invalid)
   https://code.djangoproject.com/ticket/32218 - storage.StaticFilesStorage.post_process substitutes relative URLs in comments (duplicate)
   https://code.djangoproject.com/ticket/32220 - Add a 'durable' flag to transaction.atomic() (accepted)

Reviewed/committed:
   https://github.com/django/django/pull/13677 - Refs #24474 -- Changed AdminSite.empty_value_display property to an attribute.
   https://github.com/django/django/pull/13674 - Doc'd that admin site booleans are tri-state.
   https://github.com/django/django/pull/13503 - Fixed #31496 -- Fixed QuerySet.values()/values_list() crash on combined querysets ordered by annotations.
   https://github.com/django/django/pull/13684 - Fixed #32197 -- Improved error message when loading a database backend fails.
   https://github.com/django/django/pull/13667 - Fixed #31507 -- Added QuerySet.exists() optimizations to compound queries.
   https://github.com/django/django/pull/13687 - Fixed #32201 -- Removed obsolete isort:skip's.
   https://github.com/django/django/pull/13689 - Fixed #32200 -- Fixed grouping by ExpressionWrapper() with Q objects.
   https://github.com/django/django/pull/13464 - Fixed #32053 -- Fixed accessibility issues on the 'Congrats' page.
   https://github.com/django/django/pull/11288 - Refs #15053 -- Clarified debug message when skipping templates to avoid recursion.

Reviewed:
   https://github.com/django/djangoproject.com/pull/1032 - Update to Django 3.1 and other requirements with related fixes.
   https://github.com/django/django/pull/13693 - Fixed #32202 -- Fixed autoreloader argument generation on Windows with Python 3.7-.
   https://github.com/django/django/pull/13651 - Fixed #32172 -- Adapted signals to allow async handlers.

Authored:
   https://github.com/django/django/pull/13697 - Simplified JSONField key transforms by using JSON_OBJECT() on Oracle.

Best,
Mariusz

[Mariusz Felisiak]

Week ending November 29, 2020.

Triaged:
   https://code.djangoproject.com/ticket/32217 - Add warning about missing 'migrations' package to migration docs (invalid)
   https://code.djangoproject.com/ticket/32222 - Unbalanced quotes in contrib/admin and contrib/gis templates. (duplicate)
   https://code.djangoproject.com/ticket/32219 - Use Admin Inline verbose_name as default for Inline verbose_name_plural (accepted)
   https://code.djangoproject.com/ticket/32223 - Path.resolve(strict=True) can raise a PermissionError in autoreloader. (created)
   https://code.djangoproject.com/ticket/32224 - SQLite3 bad filepath raising as JSON extension error. (accepted)
   https://code.djangoproject.com/ticket/32225 - Edit popup in model 'change' page results in a not found if the foreign key model contains a space (d
uplicate)
   https://code.djangoproject.com/ticket/32227 - DebugSQLTextTestResult crashes when database error is raised in setUpTestData(). (created)
   https://code.djangoproject.com/ticket/32228 - csrf_exempt decorator async support (duplicate)
   https://code.djangoproject.com/ticket/32229 - correct ordinals in italian (invalid)
   https://code.djangoproject.com/ticket/32230 - Add support for pathlib.Path to the django.contrib.gis.gdal.DataSource. (created)
   https://code.djangoproject.com/ticket/24157 - Prompt to add a new field after renaming (duplicate)

Reviewed/committed:
   https://github.com/django/django/pull/13497 - Improved bidirectionality on the 'Congrats' page.
   https://github.com/django/django/pull/13691 - Fixed #32203 -- Fixed QuerySet.values()/values_list() crash on KeyTransforms with non-string values o
n SQLite.
   https://github.com/django/django/pull/13680 - Refs #27095 -- Allowed (non-nested) arrays containing expressions for ArrayField lookups.
   https://github.com/django/django/pull/13685 - Fixed #25534, Fixed #31639 -- Added support for transform references in expressions.
   https://github.com/django/django/pull/13708 - Fixed #32220 -- Added durable argument to transaction.atomic().
   https://github.com/django/django/pull/13727 - Fixed #32230 -- Made DataSource and LayerMapping support pathlib.Path.
   https://github.com/django/django/pull/13718 - Fixed #21021 -- Changed BaseGeometryWidget's default geometry type to 'Geometry'.
   https://github.com/django/django/pull/13719 - Fixed #32227 -- Prevented crash when setUpTestData() errors with --debug-sql.

Authored:
   https://github.com/django/django/pull/13714 - Fixed #32224 -- Avoided suppressing connection errors in supports_json_field on SQLite.
   https://github.com/django/django/pull/13713 - Fixed #32223 -- Removed strict=True in Path.resolve() in autoreloader.
   https://github.com/django/django/pull/13730 - Refs #31978 -- Fixed hint in admin's password reset confirmation form for custom username fields.

Best,
Mariusz