Fellow Reports - March 2021
Mariusz Felisiak
Week ending March 7, 2021
Renamed branch "master" to "main" for:
- django/djangoproject.com
- django/django-docs-translations
Triaged:
https://code.djangoproject.com/ticket/32492 - Add django API
for Postgres pg_trgm word_similarity, fuzzy full-text search.
(accepted)
https://code.djangoproject.com/ticket/32494 - Admin's
raw_id_field check admin.E002 doesn't catch .attname
mis-references (accepted)
https://code.djangoproject.com/ticket/28458 - Add
ModelMultipleChoiceField.validate_choices() (wontfix)
https://code.djangoproject.com/ticket/32495 - Migrations that
modify constraints raise an exception on multi-schema databases
(duplicate)
https://code.djangoproject.com/ticket/32496 - Screencast on
How to contribute to Django (invalid)
https://code.djangoproject.com/ticket/32497 - setup django app
in IIS windows server 2012 (invalid)
https://code.djangoproject.com/ticket/32498 - setup django app
in IIS windows server 2012 (duplicate)
https://code.djangoproject.com/ticket/32500 - Error
"ValueError: Cannot serialize" while migrating a field containing
uppercase letters (invalid)
https://code.djangoproject.com/ticket/32501 - Add support for
INSERT...RETURNING on SQLite 3.35+ (created)
https://code.djangoproject.com/ticket/32502 - Replace SQLite
schema table rebuild by ALTER functions when supported
(someday/maybe)
https://code.djangoproject.com/ticket/32503 - AlterField
migration to TextField with default fails on MySQL 8.0.13+
(accepted)
https://code.djangoproject.com/ticket/32504 - Update admin's
jQuery to 3.6.X. (created)
https://code.djangoproject.com/ticket/32506 - exclude =
'__all__' treated as an iterable in fields_for_model (wontfix)
https://code.djangoproject.com/ticket/25408 - Pass additional
arguments to BaseForm.__init__ from BaseModelForm.__init__
(needsinfo)
https://code.djangoproject.com/ticket/32508 - Raise proper
exceptions instead of using "assert". (accepted)
https://code.djangoproject.com/ticket/32507 -
assertInHTML('<a>', '<a><b/></a>') fails
when tag implicitly closed (accepted)
https://code.djangoproject.com/ticket/32509 - Manytomany
relations not loaded even it exists (needsinfo)
https://code.djangoproject.com/ticket/32510 - Add option to
hide the password change link in the admin site. (wontfix)
https://code.djangoproject.com/ticket/32512 -
autocomplete_fields not displaying correctly in dark theme
(accepted)
https://code.djangoproject.com/ticket/32517 - Allow calling
reversed() on an OrderedSet (accepted)
https://code.djangoproject.com/ticket/32516 -
reorder_suite(reverse=True) isn't a strict reversal when
duplicates are present (accepted)
https://code.djangoproject.com/ticket/32515 - m2m_changed
signal not received with custom through model (invalid)
https://code.djangoproject.com/ticket/32518 - Document that
QuerySet.contains() should not be overused. (created)
Reviewed/committed:
https://github.com/django/django/pull/14043 - Fixed #32456 --
Added dbshell support for specifying a password file on
PostgreSQL.
https://github.com/django/django/pull/14058 - Refs #23919 --
Removed unneeded AttributeError catching in collectstatic's
link_file().
https://github.com/django/django/pull/14059 - Fixed #22640 --
Raised TypeError when instantiating model with keyword and
positional args for the same field.
https://github.com/django/django/pull/14069 - Fixed #32271 --
Improved consistency of docs CBV examples.
https://github.com/django/django/pull/14045 - Refs #24121 --
Added __repr__() to URLNode.
https://github.com/django/django/pull/13854 - Refs #21429 --
Added SimpleTestCase.assertNoLogs() on Python < 3.10.
https://github.com/django/django/pull/14066 - Fixed #32493 --
Removed redundant never_cache uses from admin views.
https://github.com/django/django/pull/14056 - Fixed #27854 --
Added system check for nonexistent directories in STATICFILES_DIRS
setting.
https://github.com/django/django/pull/14071 - Fixed #32494 --
Adjusted system check for raw_id_fields to warn about
Field.attname.
https://github.com/django/django/pull/14076 - Fixed #32489 --
Added iter_test_cases() to iterate over a TestSuite.
https://github.com/django/django/pull/14083 - Fixed #32507 --
Added link to assertHTMLEqual() in assertInHTML() docs.
https://github.com/django/django/pull/13038 - Fixed #24141 --
Added QuerySet.contains().
Reviewed:
https://github.com/django/django/pull/14033 - Refs #28458 --
Added validate_choices to ModelMultipleChoiceField.
https://github.com/django/django/pull/13981 - Refs #32412 --
Adjusted Contributing Guide start page.
Authored:
https://github.com/django/django/pull/14075 - Refs #32483 --
Doc'd caveat about using JSONField key transforms to booleans with
QuerySet.values()/values_list() on SQLite.
https://github.com/django/django/pull/14077 - Fixed #32483 --
Fixed QuerySet.values()/values_list() on JSONField key transforms
with booleans on SQLite.
Best,
Mariusz
Mariusz Felisiak
- django/django
- django/django-docker-box
Triaged:
https://code.djangoproject.com/ticket/32520 - Making the admin keyboard-only friendly (duplicate)
https://code.djangoproject.com/ticket/32521 - Possible documentation error re. template directories (invalid)
https://code.djangoproject.com/ticket/32522 - Improved error message on DoesNotExist (duplicate)
https://code.djangoproject.com/ticket/10494 - show query params DoesNotExist from QuerySet.get (wontfix)
https://code.djangoproject.com/ticket/32524 - unexpected behavior when using gettattr for related object (invalid)
https://code.djangoproject.com/ticket/32511 - Deferred fields incorrect when following prefetches back to the "parent" object (accepted)
https://code.djangoproject.com/ticket/32519 - Add support for using key and path transforms in update() for JSONFields. (accepted)
https://code.djangoproject.com/ticket/32525 - Class Cast throws DataError when column contains numeric string or alphabet string in postgres (wontfix)
https://code.djangoproject.com/ticket/32527 - needs_rollback flag issue with implementation of backend that does not support savepoint (needsinfo)
https://code.djangoproject.com/ticket/32528 - Replace django.utils.topological_sort with graphlib. (someday/maybe)
https://code.djangoproject.com/ticket/32529 - Delay creating a test suite inside DiscoverRunner.build_suite() (accepted)
https://code.djangoproject.com/ticket/32530 - readonly makes field return None on cleaned_data? (duplicate)
https://code.djangoproject.com/ticket/32526 - Class based custom template filters seem to be broken since Django 2.0 (invalid)
https://code.djangoproject.com/ticket/32532 - Provide friendlier error if a file path is passed as a test label when running tests (accepted)
https://code.djangoproject.com/ticket/32534 - Allow using StatReloader even if watchman is available. (wontfix)
https://code.djangoproject.com/ticket/32536 - Add references to get() methods in CBV docs. (accepted)
https://code.djangoproject.com/ticket/32538 - Easy - Small Update in Django Writing your first app 07 (duplicate)
https://code.djangoproject.com/ticket/32539 - Support accessing the current filtered queryset from within SimpleListFilter.lookups() (accepted)
https://code.djangoproject.com/ticket/32540 - Only do "top level" detection in DiscoverRunner.build_suite() when needed (accepted)
https://code.djangoproject.com/ticket/32537 - RequestSite and IDN (needsinfo)
https://code.djangoproject.com/ticket/32542 - Native postgres json field support is broken (invalid)
https://code.djangoproject.com/ticket/32544 - Add support for GDAL 3.2 and GEOS 3.9. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/14089 - Fixed #32517 -- Made OrderedSet reversible.
https://github.com/django/django/pull/14085 - Refs #32489 -- Simplified some test suite functions.
https://github.com/django/code.djangoproject.com/pull/107 - Updated Git branch "master" to "main".
https://github.com/django/djangoproject.com/pull/1070 - Updated Git branch "master" to "main" for Django repository.
https://github.com/django/deps/pull/72 - Renamed Git branches "master" to "main".
https://github.com/django/django/pull/14048 - Rename Git branch "master" to "main".
https://github.com/django/django/pull/14101 - Fixed #32516 -- Fixed reorder_suite() with duplicates and reverse=True.
https://github.com/django/django/pull/14094 - Refs #24121 -- Added __repr__() to OrderedSet.
https://github.com/django/django/pull/14088 - Fixed #32512 -- Fixed admin dark theme for autocomplete fields.
https://github.com/django/django/pull/14108 - Refs #31235 -- Improved assertQuerysetEqual() warning message with stacklevel=2.
https://github.com/django/django/pull/14103 - Refs #24121 -- Added __repr__() to MiddlewareMixin and subclasses.
https://github.com/django/django/pull/14107 - Refs #32508 -- Raised ImproperlyConfigured instead of using "assert" in middlewares.
https://github.com/django/django/pull/14104 - Fixed #32529 -- Delayed creating a test suite in build_suite().
https://github.com/django/django/pull/14116 - Refs #31516, Refs #31703 -- Made makemigrations always name initial migrations "initial".
https://github.com/django/django/pull/14090 - Added GitHub action with welcome message for first-time contributors.
https://github.com/django/django/pull/14109 - Fixed #31516 -- Improved naming of migrations with multiple operations.
Reviewed:
https://github.com/django/djangoproject.com/pull/1072 - Refs #1052 -- Added max_value validation to donations.
https://github.com/django/django/pull/14031 - Fixed #32466 -- Adjusted autocomplete widget to use pk when resolving to_field_name.
Authored:
https://github.com/django/django/pull/14095 - Refs #32018 -- Corrected color variable for toggle links in admin.
https://github.com/django/django/pull/14096 - Refs #32018 -- Used --darkened-bg for <pre> elements.
https://github.com/django/django/pull/14099 - Refs #32508 -- Raised TypeError instead of using "assert" on unsupported operations for sliced querysets.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/32547 - assertHTMLEqual()/assertHTMLNotEqual() allow invalid HTML. (accepted)
https://code.djangoproject.com/ticket/32549 - Add `Q.empty()` to check for nested empty Q objects like `Q(Q())` (wontfix)
https://code.djangoproject.com/ticket/32548 - Support passing conditional expressions to Q(). (accepted)
https://code.djangoproject.com/ticket/32550 - Translation Error (invalid)
https://code.djangoproject.com/ticket/32545 - Admin foreign key raw inputs are too small when referring to a UUID field (accepted)
https://code.djangoproject.com/ticket/32546 - Meta.ordering fields must not be included in GROUP BY clause (accepted)
https://code.djangoproject.com/ticket/32551 - Need a direct reference of MEDIA_URL and MEDIA_ROOT in file uploads (invalid)
https://code.djangoproject.com/ticket/32553 - Allow UserAttributeSimilarityValidator to validate against fields of related models (wontfix)
https://code.djangoproject.com/ticket/32555 - DecimalField Rounding inconsistency (PostgreSQL) (duplicate)
https://code.djangoproject.com/ticket/24522 - Add --random option to test command to run test cases in random order (accepted)
https://code.djangoproject.com/ticket/32556 - assertHTMLEqual gives a confusing error message with empty attributes (accepted)
https://code.djangoproject.com/ticket/32560 - Make --pdb cooperate with --buffer (accepted)
https://code.djangoproject.com/ticket/32564 - admin/base.html : Add block "end_of_body" for JS includes (wontfix)
https://code.djangoproject.com/ticket/32563 - Cannot override database used with RelatedManager (invalid)
https://code.djangoproject.com/ticket/32570 - Documentation example for AppConfig is overloaded (accepted)
https://code.djangoproject.com/ticket/32571 - CsrfViewMiddleware assumes referer header can be parsed (accepted)
https://code.djangoproject.com/ticket/32557 - Fail tests when unraisable exceptions occur (accepted)
https://code.djangoproject.com/ticket/32558 - Fail tests when unhandled thread exceptions occur (accepted)
https://code.djangoproject.com/ticket/32574 - Add support for Proj 8.x. (accepted)
https://code.djangoproject.com/ticket/32575 - Add support for SpatiaLite 5.x. (accepted)
https://code.djangoproject.com/ticket/32576 - Correct documentation for dumpdata --exclude (accepted)
https://code.djangoproject.com/ticket/18096 - Overiding delete permissions in the Admin (fixed)
Reviewed/committed:
https://github.com/django/django/pull/14120 - Fixed #32540 -- Optimized DiscoverRunner.build_suite() by calling find_top_level() only if is_discoverable() is true.
https://github.com/django/django/pull/14114 - Refs #32508 -- Raised ValueError instead of using "assert" in lazy().
https://github.com/django/django/pull/14129 - Fixed #32536 -- Added links to BaseDetailView/BaseListView.get() methods in CBV docs.
https://github.com/django/django/pull/14122 - Fixed #32546 -- Avoided Meta.ordering columns in GROUP BY clauses.
https://github.com/django/django/pull/14132 - Refs #32508 -- Raised ImproperlyConfigured instead of using "assert" in SessionStorage.
https://github.com/django/django/pull/14119 - Refs #24121 -- Added __repr__() to Origin and Template.
https://github.com/django/django/pull/14139 - Fixed #32560 -- Fixed test runner with --pdb and --buffer on fail/error.
https://github.com/django/django/pull/14126 - Fixed #32548 -- Fixed crash when combining Q() objects with boolean expressions.
https://github.com/django/django/pull/14143 - Fixed #32547 -- Corrected notes about validation in HTML assertions docs.
https://github.com/django/django/pull/12580 - Fixed #31370 -- Added support for parallel tests with --buffer.
https://github.com/django/django/pull/14144 - Fixed #32556 -- Fixed assertHTMLEqual() to handle empty string as boolean attributes value.
https://github.com/django/django/pull/13829 - Fixed #16010 -- Added Origin header checking to CSRF middleware.
https://github.com/django/django/pull/14135 - Refs #32508 -- Raised Type/ValueError instead of using "assert" in django.core.
https://github.com/django/django/pull/14151 - Fixed #32571 -- Made CsrfViewMiddleware handle invalid URLs in Referer header.
https://github.com/django/django/pull/14152 - Fixed #32570 -- Removed unnecessary default_auto_field in app config example.
https://github.com/django/django/pull/14148 - Fixed #32556 -- Fixed handling empty string as non-boolean attributes value by assertHTMLEqual().
Reviewed:
https://github.com/django/django/pull/14031 - Fixed #32466 -- Corrected autocomplete to_field resolution for complex cases.
Authored:
https://github.com/django/django/pull/14133 - Fixed #32353 -- Confirmed support for PROJ 7.X.
https://github.com/django/django/pull/14145 - Corrected signatures in "Advanced testing topics" docs.
https://github.com/django/django/pull/14163 - Fixed RemoteTestResultTest tests without tblib.
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/32578 - Handle request.get_host() raising DisallowedHost in CsrfViewMiddleware._origin_verified() (accepted)
https://code.djangoproject.com/ticket/32581 - to_locale should be idempotent (accepted)
https://code.djangoproject.com/ticket/32580 - Document that HttpRequest.get_host() can raise DisallowedHost (accepted)
https://code.djangoproject.com/ticket/32582 - Extra dot in cloned test database file names on SQLite when using --parallel. (accepted)
https://code.djangoproject.com/ticket/32583 - Allow mass emails with EmailMessage Object (wontfix)
https://code.djangoproject.com/ticket/32573 - Query optimization in YearLookup breaks filtering by "__iso_year" (accepted)
https://code.djangoproject.com/ticket/32579 - Two outdated code comments in CsrfViewMiddleware.process_view() (accepted)
https://code.djangoproject.com/ticket/32585 - Value() with DecimalField crashes on SQLite. (accepted)
https://code.djangoproject.com/ticket/32586 - ASGI responses from Django do not provide lowercased HTTP headers as required by the spec (invalid)
https://code.djangoproject.com/ticket/32588 - Exception handling in contrib.postgres (invalid)
https://code.djangoproject.com/ticket/32590 - Add option to avoid subtransactions by default when using transaction.atomic() (wontfix)
https://code.djangoproject.com/ticket/32592 - Add places argument to Round database function. (duplicate)
https://code.djangoproject.com/ticket/32593 - Cast() to DecimalField() raises DataError. (invalid)
https://code.djangoproject.com/ticket/32587 - Use RelatedManager of parent object in get_queryset of inlines and support prefetching (duplicate)
https://code.djangoproject.com/ticket/32594 - Signal.disconnect() returns None when passing sender as string (accepted)
https://code.djangoproject.com/ticket/32595 - mysql DatabaseSchemaEditor can't `quote_value` on byte strings (invalid)
https://code.djangoproject.com/ticket/32596 - Add a method to CsrfViewMiddleware to encapsulate its referer logic (accepted)
https://code.djangoproject.com/ticket/32572 - ResolverMatch.__repr__() doesn't handle functools.partial() nicely. (accepted)
https://code.djangoproject.com/ticket/32598 - Issue in models.SlugField (invalid)
https://code.djangoproject.com/ticket/32599 - django.contrib.auth.forms.py should always refer to User as get_user_model() (duplicate)
https://code.djangoproject.com/ticket/32600 - Multi geometries cause Segmentation fault 11 on Macbook with M1 CPU (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/14164 - Fixed #32581 -- Prevented to_locale() from corrupting locale names.
https://github.com/django/django/pull/14160 - Fixed #32576 -- Corrected dumpdata docs for passing model names to the --exclude option.
https://github.com/django/django/pull/14153 - Refs #31732 -- Fixed django.utils.inspect caching for bound methods.
https://github.com/django/django/pull/13906 - Optimized django.utils.text.capfirst().
https://github.com/django/django/pull/14170 - Fixed #32573 -- Fixed bounds in __iso_year lookup optimization.
https://github.com/django/django/pull/14022 - Fixed #32460 -- Allowed "label"/"do_not_call_in_templates" members in model choice enums.
https://github.com/django/django/pull/14149 - Fixed #29606 -- Added type check for ALLOWED_HOSTS setting.
https://github.com/django/django/pull/14177 - Refs #32532 -- Added DiscoverRunner.load_tests_for_label().
https://github.com/django/django/pull/14169 - Fixed #32582 -- Removed unnecessary dot in names of cloned test databases on SQLite.
https://github.com/django/django/pull/14176 - Fixed #32579 -- Fixed outdated comments in CsrfViewMiddleware.process_view().
https://github.com/django/django/pull/14179 - Fixed #32578 -- Fixed crash in CsrfViewMiddleware when a request with Origin header has an invalid host.
https://github.com/django/django/pull/14183 - Refs #31003 -- Moved note about return value of QuerySet.bulk_create() to the first paragraph.
https://github.com/django/django/pull/14181 - Fixed #32580 -- Doc'd that HttpRequest.get_host() may raise DisallowedHost.
https://github.com/django/django/pull/14192 - Refs #32355 -- Corrected comments about Python's _NamespacePath.
https://github.com/django/django/pull/14191 - Fixed #32591 -- Made DiscoverRunner order _FailedTest objects first.
Reviewed:
https://github.com/django/djangoproject.com/pull/1078 - Re-added reCaptcha to fundraising page.
Authored:
https://github.com/django/django/pull/14167 - Refs #32353, Refs #32352 -- Fixed GIS tests with PROJ 7.X.