Use of TIME_INPUT_FORMATS in TimeField

[Arthur Pemberton]

The documentation (https://docs.djangoproject.com/en/5.0/ref/forms/fields/#timefield) says that " the default input formats are taken from the active locale format TIME_INPUT_FORMATS key, or from TIME_INPUT_FORMATS if localization is disabled". However, neither my reading of the code, or my actual experience shows settings.TIME_INPUT_FORMATS ever being used, even with "USE_I18N = False"

TimeField gets the formats from `input_formats = formats.get_format_lazy("TIME_INPUT_FORMATS")` which is a lazy version of `formats.get_format` -- the documentation of which says "If use_l10n is provided and is not None, it forces the value to be localized (or not), otherwise it's always localized."

so even with "USE_I18N = False" settings.TIME_INPUT_FORMATS seems to be ignored.

How does one use settings.TIME_INPUT_FORMATS ?

Arthur Pemberton

[David Sanders]

Define TIME_INPUT_FORMATS in your local formats.py setup as per: https://docs.djangoproject.com/en/5.0/topics/i18n/formatting/#creating-custom-format-files

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CA%2BX4dQRAjfSJnAK9iZ%3DhJMkN%2BTfoShX6%2BNRsjM0oMF6jGDSuZg%40mail.gmail.com.

[Arthur Pemberton]

Thanks, I'll look into that. But does that mean that settings.TIME_INPUT_FORMATS no longer has any use? I don't see any logic flows that lead to it being used.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CADyZw-5Vb6K4HQjVbcr1aQGCdozoHkA%2B2Q4Vczp8L63ROX%2BDtQ%40mail.gmail.com.

[Adam Johnson]

USE_I18N does not disable localization, but internationalization. USE_L10N was the setting to enable/disable localization, but it was deprecated in Django 4.0: https://docs.djangoproject.com/en/4.0/releases/4.0/#localization . It was removed completely in Django 5.0, in this commit: https://github.com/django/django/commit/8d98f99a4ab5de6f2c730399f53eba8bf6bea470 .

So I think the phrase “if localization is disabled” is at least a little bit wrong. But I don’t think the setting is ignored, as there are tests confirming that it works: https://github.com/django/django/blob/8d98f99a4ab5de6f2c730399f53eba8bf6bea470/tests/forms_tests/tests/test_input_formats.py#L123-L125 . The line that reads the setting should be this one: https://github.com/django/django/blob/8d98f99a4ab5de6f2c730399f53eba8bf6bea470/django/utils/formats.py#L132 .

If you can provide a failing minimal project, that would be useful to keep debugging. I have some minimal django project templates at https://github.com/adamchainz/django-startproject-templates .

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CA%2BX4dQTQwnqe%3DpJf3bmiZH5LHJ87df%2B8-Rq5LbpLcctp9jNfjA%40mail.gmail.com.

[Arthur Pemberton]

I haven't yet checked the tests thoroughly enough to determine why things didn't work for me in practice. I do know they didn't work. And I do see that the tests pass. But I suspect that the tests may not be fully mimicking the read-world use case in this scenario.

I'll return here once I have some evidence either way,

Arthur Pemberton

[Natraj Kavander]

Thank you 🙏🏿

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CA%2BX4dQTocxCwXAj4RjmYxM7B-bz8tEc4J47T6AwVYPF%3DKrFSFA%40mail.gmail.com.