#3461 'DatabaseWrapper should pass through args and kwargs to underlying database adapter'

2 views
Skip to first unread message

Ramiro Morales

unread,
Mar 4, 2009, 3:36:33 PM3/4/09
to django-d...@googlegroups.com
Hi all,

I'm working on fixing and updating the patch for this ticket and found that
neither cx_Oracle nor pysqlite2/sqlite3 connection cursor() methods take *args
and **kwargs parameters.

Further research shows that the same is true for mysql-python.

The current patch for this ticket adds these parameters to the the postgresql*
and mysql backends DatabaseWrapper _cursor() methods, although, because of the
above, in the latter case they remain unused.

Should the same strategy be implemented for sqlite3 and oracle?

Regards,

--
Ramiro Morales
http://rmorales.net

Malcolm Tredinnick

unread,
Mar 4, 2009, 7:15:32 PM3/4/09
to django-d...@googlegroups.com

If they don't support it, we shouldn't either. A lot of people try to
guess at how to use Django and it always leads to tears. So we should be
as strict as possible in what we accept there so that problems are
identified early.

Certainly the documentation should mention which databases support it,
probably both a short note in the section about raw SQL usage and
something in the database specific notes for PostgreSQL.

Amazing what a bit of research can do for completing a ticket like that.
Thanks for doing this, Ramiro. :-)

Regards,
Malcolm


Reply all
Reply to author
Forward
0 new messages