Possible AuthenticationForm Max Length Regression in Django 2.1?

100 views
Skip to first unread message

cbode...@live.com

unread,
Sep 16, 2019, 5:56:05 PM9/16/19
to Django developers (Contributions to Django itself)
I had posted this in the Django Forums, but I was told to repost here. The link to the forum post is below.
The tl;dr is: Was it intentional to remove the max length HTML form validation from the AuthenticationForm in Django 2.1, or is it a regression?

Mariusz Felisiak

unread,
Sep 17, 2019, 2:16:17 AM9/17/19
to Django developers (Contributions to Django itself)
Thanks for the report.

Previously AuthenticationForm's username field had "max_length" always set to 254, currently it should use "max_length" from the model's username field (see https://code.djangoproject.com/ticket/27515 and https://github.com/django/django/commit/5ceaf14686ce626404afb6a5fbd3d8286410bf13). However HTML "maxlength" attribute is not set anymore so it's a regression I created a new ticket https://code.djangoproject.com/ticket/30776.

Best,
Mariusz
Reply all
Reply to author
Forward
0 new messages