"Streaming" patches

0 views
Skip to first unread message

Ivan Sagalaev

unread,
Apr 8, 2006, 3:31:09 AM4/8/06
to django-d...@googlegroups.com
May I kindly ask some attention (especially commiters' :-) ) to a pair
of tickets that enable uploading and downloading large files:

http://code.djangoproject.com/ticket/1484 - request part
http://code.djangoproject.com/ticket/1569 - response part

I use them both on a daily basis in two projects and I think thay are
pretty stable. Both are backwards-compatible. Can they be evaluated and
commited? To be honest this behavior seems pretty natural for a
framework :-)

One note: both patches change httpwrappers.py (http/__init__.py in
magic-removal) and it may be difficult to apply them one by one. I could
create a cumulative patch as they are both im my local tree.

Jacob Kaplan-Moss

unread,
Apr 8, 2006, 9:43:15 AM4/8/06
to django-d...@googlegroups.com
On Apr 8, 2006, at 2:31 AM, Ivan Sagalaev wrote:
> May I kindly ask some attention (especially commiters' :-) ) to a pair
> of tickets that enable uploading and downloading large files:
>
> http://code.djangoproject.com/ticket/1484 - request part
> http://code.djangoproject.com/ticket/1569 - response part

This looks pretty good to me; a unified patch certainly would make it
easier to apply both tickets at once (since they seem analogous).
Want to open a unified ticket with a single patch?

Jacob

Adrian Holovaty

unread,
Apr 8, 2006, 11:45:28 AM4/8/06
to django-d...@googlegroups.com
On 4/8/06, Ivan Sagalaev <Man...@softwaremaniacs.org> wrote:
> May I kindly ask some attention (especially commiters' :-) ) to a pair
> of tickets that enable uploading and downloading large files:
>
> http://code.djangoproject.com/ticket/1484 - request part
> http://code.djangoproject.com/ticket/1569 - response part
>
> I use them both on a daily basis in two projects and I think thay are
> pretty stable. Both are backwards-compatible. Can they be evaluated and
> commited? To be honest this behavior seems pretty natural for a
> framework :-)

I'll try to evaluate these today.

Adrian

--
Adrian Holovaty
holovaty.com | djangoproject.com

Maniac

unread,
Apr 10, 2006, 5:12:33 AM4/10/06
to Django developers
Sorry for not replying for past 2 days, Google caught a bounce from my
mail host and stopped to send new mails :-(

I just saw that Adrian has now commited the "response" part so unified
patch is not needed anymore. I'll update "request" patch for new lines
count (and try to fix code styling issues as I keep writing it wrong
:-( ).

Ivan Sagalaev

unread,
Apr 10, 2006, 5:38:53 AM4/10/06
to django-d...@googlegroups.com
Maniac wrote:

>I just saw that Adrian has now commited the "response" part so unified
>patch is not needed anymore. I'll update "request" patch for new lines
>count (and try to fix code styling issues as I keep writing it wrong
>:-( ).
>
>

Done

Reply all
Reply to author
Forward
0 new messages