Fellow Reports - September 2019

[Mariusz Felisiak]

Week ending September 8, 2019.

Released Django 2.2.5, 2.1.12, and 1.11.24.

Triaged:

https://code.djangoproject.com/ticket/30747 - Rename internal is_safe_url() to better state effective scope. (accepted)
https://code.djangoproject.com/ticket/30748 - Abstract model class specifies foreign key – MySQL doesn't have it. (worksforme)
https://code.djangoproject.com/ticket/30750 - Add support for check constraints on MySQL 8.0.16+. (created)
https://code.djangoproject.com/ticket/30751 - IntegrityError with TransactionTestCase and serialized_rollback=True. (needsinfo)
https://code.djangoproject.com/ticket/30752 - Allow using ExceptionReporter subclass in django.views.debug.technical_500_response (accepted)
https://code.djangoproject.com/ticket/20648 - Template variable and loss of precision (duplicate)
https://code.djangoproject.com/ticket/30757 - Add check to ensure max_length fits longest choice. (accepted)
https://code.djangoproject.com/ticket/30762 - Code detail error in tutorial 03. (worksforme)
https://code.djangoproject.com/ticket/30761 - The floatformat filter sometimes returns "-0" instead of "0". (wontfix)
https://code.djangoproject.com/ticket/30758 - DateTimeRangeField with default crashes in django admin (object has no attribute 'strip'). (accepted)
https://code.djangoproject.com/ticket/30763 - call_command fails when argument of required mutually exclusive group is passed in kwargs. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/11734 - Fixed #30739 -- Fixed exclusion of multi-valued lookup against outer rhs.
https://github.com/django/django/pull/11736 - Fixed #30747 -- Renamed is_safe_url() to url_has_allowed_host_and_scheme().
https://github.com/django/django/pull/11740 - Fixed #30691 -- Made migrations autodetector find dependencies for foreign keys altering.
https://github.com/django/django/pull/11021 - Fixed #29714 -- Allowed using ExceptionReporter subclass with AdminEmailHandler.
https://github.com/django/django/pull/11540 - Fixed #27910 -- Added enumeration helpers for use in Field.choices.
https://github.com/django/django/pull/11749 - Fixed #30763 -- Fixed management commands when using required mutually exclusive groups.
https://github.com/django/django/pull/11482 - Fixed #30573 -- Rephrased documentation to avoid words that minimise the involved difficulty.

Reviewed:

https://github.com/django/django/pull/11452 - Fixed #12990 -- Added JSONField model field.

Authored:

https://github.com/django/django/pull/11743 - Fixed #30750 -- Added support for check constraints on MySQL 8.0.16+.
https://github.com/django/django/pull/11745 - Bootstrapped Django 3.1.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending September 15, 2019.

Added https://code.djangoproject.com/wiki/Version3.1Roadmap.

Triaged:

https://code.djangoproject.com/ticket/30768 - django.forms.boundfield.as_widget() causes an exception when used. (invalid)
https://code.djangoproject.com/ticket/19528 - CachedFilesMixin does not rewrite rules for css selector with path. (invalid)
https://code.djangoproject.com/ticket/18929 - CachedFilesMixin is not compatible with S3BotoStorage. (invalid)
https://code.djangoproject.com/ticket/29513 - Make TransactionTestCase.multi_db documentation more discoverable. (fixed)
https://code.djangoproject.com/ticket/16713 - Fixture loading for tests ignore database specific names. (invalid)
https://code.djangoproject.com/ticket/24680 - In testing, warnings appear when loading database-specific fixtures. (duplicate)
https://code.djangoproject.com/ticket/15063 - multi_db flag on TestCase causes invalid error reporting when loading fixtures. (duplicate)
https://code.djangoproject.com/ticket/23714 - `date` filter raises an exception for naive datetimes during DST change (fixed)
https://code.djangoproject.com/ticket/30769 - Access JSON key crashes when using annotated field from subquery. (accepted)
https://code.djangoproject.com/ticket/30152 - MySQL: "Cannot change column 'id': used in a foreign key constraint" when altering pk referenced by ManyToMany relation. (fixed)
https://code.djangoproject.com/ticket/27338 - Running an AlterField to change a CharField primary key to AutoField crashes. (fixed)
https://code.djangoproject.com/ticket/30771 - Filtering on query result overrides GROUP BY of internal query (accepted)
https://code.djangoproject.com/ticket/30770 - Incorrect escaping TruncBase on ExpressionWrapper for date arithmetic. (duplicate)
https://code.djangoproject.com/ticket/30773 - Support Algorithm parameter on MySQL migrations. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/11751 - Fixed #30426 -- Changed X_FRAME_OPTIONS setting default to DENY.
https://github.com/django/django/pull/11742 - Fixed #30757 -- Added a system check to ensure max_length fits the longest choice.
https://github.com/django/django/pull/9983 - Refs #29444 -- Allowed returning multiple fields from INSERT statements on PostgreSQL.
https://github.com/django/django/pull/11606 - Fixed #28107 -- Added DatabaseFeatures.allows_group_by_selected_pks_on_model() to allow enabling optimization for unmanaged models.
https://github.com/django/django/pull/11757 - Fixed #30754 -- Prevented inclusion of aliases in partial index conditions.
https://github.com/django/django/pull/11683 - Fixed #30591 -- Fixed recreation of foreign key constraints on MySQL when altering type of referenced unique field.
https://github.com/django/django/pull/11775 - Increased the default PBKDF2 iterations for Django 3.1.
https://github.com/django/djangoproject.com/pull/933 - Refs #838 -- Marked current release on downloads page as LTS (if so).
https://github.com/django/django/pull/11756 - Fixed #29823 -- Doc'd limitation of DecimalField on SQLite.

Reviewed:

https://github.com/django/djangoproject.com/pull/943 - Fixed #942 -- Added docs warning banner to preview releases.

Authored:

https://github.com/django/django-contrib-comments/pull/145 - Used python_2_unicode_compatible() from six.
https://github.com/django/code.djangoproject.com/pull/97 - Changed header to "Issues".
https://github.com/django/djangoproject.com/pull/945 - Updated docs-related model fixtures for 2.2 release.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending September 22, 2019.

Triaged:

https://code.djangoproject.com/ticket/30774 - Migrations uses value of enum object instead of its name. (accepted)
https://code.djangoproject.com/ticket/30776 - AuthenticationForm's username field doesn't set maxlength HTML attribute. (created)
https://code.djangoproject.com/ticket/30778 - Use lowercased app_labels for generated table names. (wontfix)
https://code.djangoproject.com/ticket/30777 - File isn't treated correctly, when in user-defined field. (invalid)
https://code.djangoproject.com/ticket/30780 - Make "Getting Help" documentation much more prominent. (accepted)
https://code.djangoproject.com/ticket/30782 - "ptyhon" typo in a Chinese translation of "Advanced tutorial: How to write reusable apps". (invalid)
https://code.djangoproject.com/ticket/30783 - Support gin__int_ops option for PostgreSQL intarray. (invalid)
https://code.djangoproject.com/ticket/30785 - Documentation missing info about subdomain wildcard for SESSION_COOKIE_DOMAIN. (accepted)
https://code.djangoproject.com/ticket/30789 - Add list of required fields to ModelForm. (wontfix)
https://code.djangoproject.com/ticket/30784 - Documentation for django-admin uses "either one" for three possibilities. (invalid)
https://code.djangoproject.com/ticket/30788 - Fix concatenation of tuple to list (or vice versa). (needsinfo)

Reviewed/committed:

https://github.com/django/django/pull/11784 - Fixed #30769 -- Fixed a crash when filtering against a subquery JSON/HStoreField annotation.
https://github.com/django/django/pull/11781 - Fixed #30775 -- Added admonition about missing imports to "Running tests" section in tutorial 5.
https://github.com/django/django/pull/11727 - Fixed #29376 -- Allowed hiding "Save and Add Another" button in admin.
https://github.com/django/django/pull/11755 - Fixed #30758 -- Made RangeFields use multiple hidden inputs for initial data.
https://github.com/django/django/pull/11766 - Fixed #30725 -- Fixed width of DateTimeField inputs in admin tabular inline.
https://github.com/django/django/pull/11790 - Fixed #30776 -- Restored max length validation on AuthenticationForm.UsernameField.   
https://github.com/django/django/pull/11772 - Fixed #30772 -- Optimized make_template_fragment_key().
https://github.com/django/django/pull/11798 - Fixed #30786 -- Used CONVERT_TZ to check if the time zone definitions are installed on MySQL.
https://github.com/django/django/pull/11797 - Fixed #30771 -- Fixed exact lookup against queries with selected columns.
https://github.com/django/django/pull/11670 - Refs #28622 -- Clarified security implications of PASSWORD_RESET_TIMEOUT.
https://github.com/django/django/pull/11705 - Fixed #28622 -- Allowed specifying password reset link expiration in seconds and deprecated PASSWORD_RESET_TIMEOUT_DAYS.
https://github.com/django/djangoproject.com/pull/951 - Fixed #948 -- Added issue template.

Reviewed:

https://github.com/django/django/pull/11792 - Fixed #27462 -- Clarifed pk_set difference in m2m_changed signal receivers for add() and remove().

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending September 29, 2019.

Triaged:

https://code.djangoproject.com/ticket/30793 - Add a SECURITY.md file. (invalid)
https://code.djangoproject.com/ticket/30794 - inspectdb should generate related_name for ForeignKey. (duplicate)
https://code.djangoproject.com/ticket/30785 - Documentation missing info about subdomain wildcard for SESSION_COOKIE_DOMAIN. (invalid)
https://code.djangoproject.com/ticket/30795 - Django cannot serialize value into migration file. (invalid)
https://code.djangoproject.com/ticket/30797 - LoginView Error when going back to login page (invalid)
https://code.djangoproject.com/ticket/30798 - models.E015 is raised when Meta.ordering contains "pk" of a related field. (created)
https://code.djangoproject.com/ticket/30800 - Altering field crashes for fields with custom db_type() on PostgreSQL. (created)
https://code.djangoproject.com/ticket/30801 - Improve guidance for making good use of signals. (accepted)
https://code.djangoproject.com/ticket/30810 - WatchmanReloaderTests.test_setting_timeout_from_environment_variable() fails with AttributeError. (accepted)
https://code.djangoproject.com/ticket/30812 - ConditionalGetMiddleware returns 304 if ETag is the same but Last-Modified has changed. (accepted)
https://code.djangoproject.com/ticket/30761 - The floatformat filter sometimes returns "-0" instead of "0". (accepted)
https://code.djangoproject.com/ticket/30807 - test_extract_file_permissions test fails when umask is set to 000. (accepted)
https://code.djangoproject.com/ticket/30811 - Django throws 'UnicodeEncodeError' when using Cyrillic symbols to override field upload_to. (invalid)
https://code.djangoproject.com/ticket/30813 - dumpdata > flush > loaddata. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/10643 - Fixed #29915 -- Added support for values with hyphens to pattern lookups for UUIDField on backends without UUID datatype.
https://github.com/django/django/pull/11729 - Fixed #13296 -- Fixed ordering by Options.order_with_respect_to after deleting objects.
https://github.com/django/django/pull/11787 - Fixed #30732 -- Doc'd that SameSite cookies flags can affect xframe_options_exempt.
https://github.com/django/django/pull/11810 - Fixed #30796 -- Prevented select_related() from mutating a queryset on chaining.
https://github.com/django/django/pull/11802 - Refs #26601 -- Used new-style middlewares in documentation.
https://github.com/django/django/pull/11782 - Fixed #29444 -- Allowed returning multiple fields from INSERT statements on Oracle.
https://github.com/django/django/pull/11579 - Removed some outdated backwards compatibility imports and misleading comments.
https://github.com/django/django/pull/11564 - Fixed #25598 -- Added SCRIPT_NAME prefix to STATIC_URL and MEDIA_URL set to relative paths.
https://github.com/django/django/pull/11833 - Fixed #30810 -- Fixed WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.
https://github.com/django/django/pull/11822 - Fixed #27921 -- Clarified usage of make_aware() with is_dst argument.
https://github.com/django/django/pull/11839 - [2.2.x] Fixed #30216 -- Doc'd that BooleanField is no longer blank=True in Django 2.1.
https://github.com/django/django/pull/11820 - Fixed #30798 -- Fixed Meta.ordering validation for pk of related fields.
https://github.com/django/django/pull/11842 - Refs #30597 -- Added a warning about dependent apps when unapplying migrations.
https://github.com/django/django/pull/11821 - Fixed #30597 -- Clarified how to unapply migrations.

https://github.com/django/django/pull/11824 - Fixed #30802 -- Prevented manifest creation when running collectstatic in dry run mode.

Authored:

https://github.com/django/django/pull/11817 - Fixed #30800 -- Fixed migrations crash when altering a field with custom db_type().
https://github.com/jacobian/dj-database-url/pull/124 - Add testing for Django 3.0
https://github.com/sebleier/django-redis-cache/pull/174 - Add support for Django 3.0
https://github.com/django/django-contrib-comments/pull/146 - Added testing for Django 3.0.

Best regards,

Mariusz