Fellow Reports - June 2021

[Mariusz Felisiak]

Week ending June 6, 2021

Participated in the DjangoCon Europe conference.

Triaged:
    https://code.djangoproject.com/ticket/32800 - CsrfViewMiddleware unnecessarily masks CSRF cookie (accepted)
    https://code.djangoproject.com/ticket/32804 - Add 'link' attribute to admin display function to enable custom link (wontfix)
    https://code.djangoproject.com/ticket/32805 - makemigrations seems to generate an unnecessary AlterField (invalid)
    https://code.djangoproject.com/ticket/32806 - Send email with a content_type=text/* attachment (invalid)
    https://code.djangoproject.com/ticket/32807 - JSONField.bound_data raises TypeError when data is None (accepted)
    https://code.djangoproject.com/ticket/32205 - sqlmigrate crashes after removing squashed migrations. (invalid)
    https://code.djangoproject.com/ticket/32808 - DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns (accepted)
    https://code.djangoproject.com/ticket/32802 - Ability to generate GenericForeignKey from class properties (wontfix)
    https://code.djangoproject.com/ticket/32803 - Not obvious interaction between Postgresql trgm index and icontains lookup (duplicate)
    https://code.djangoproject.com/ticket/32809 - Filtering with Q and OR gets duplicated entries (needsinfo)
    https://code.djangoproject.com/ticket/32811 - Annotate removes Meta.ordering (invalid)
    https://code.djangoproject.com/ticket/32810 - django.utils.formats.number_format calculates a value for use_l10n which isn't re-used for calls to get_format (accepted)
    https://code.djangoproject.com/ticket/32815 - Failed to reset ContextVars in sync/async middlewares (invalid)
    https://code.djangoproject.com/ticket/32814 - Improve performance of TextNode rendering by providing a special-case of render_annotated (accepted)
    https://code.djangoproject.com/ticket/32816 - QuerysetEqual Test error on the polls app. (invalid)
    https://code.djangoproject.com/ticket/32818 - Add pyproject.toml config for black formatter (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/14460 - Refs #24121 -- Added __repr__() to Engine.
    https://github.com/django/django/pull/14471 - Fixed #32796 -- Changed CsrfViewMiddleware to fail earlier on badly formatted cookie tokens.
    https://github.com/django/django/pull/14150 - Refs #32552 -- Added DiscoverRunner.log() to allow customization.
    https://github.com/django/django/pull/14474 - Fixed #28154 -- Prevented infinite loop in FileSystemStorage.save() when a broken symlink with the same name exists.
    https://github.com/django/django/pull/14476 - Refs #32641 -- Made DiscoverRunner's "Found X tests" message work for finding one test.
    https://github.com/django/django/pull/14477 - Refs #32668 -- Refactored runtests.py's setup() and get_test_modules().
    https://github.com/django/django/pull/14483 - Fixed #32812 -- Restored immutability of named values from QuerySet.values_list().
    https://github.com/django/django/pull/14391 - Refs #32338 -- Improved accessibility of RadioSelect examples in docs.
    https://github.com/django/django/pull/14427 - Made SerializeMixin check lockfile attr at import time.
    https://github.com/django/django/pull/14492 - Fixed #32810 -- Optimized django.utils.formats.number_format() a bit.
    https://github.com/django/django/pull/14491 - Refs #32668 -- Simplified start_at/start_after logic in runtests.py's setup().

Authored:
    https://github.com/django/django/pull/14478 - Fixed #32808 -- Prevented DiscoverRunner.build_suite() from mutating test loader patterns.
    https://github.com/django/django/pull/14482 - Refs #31356 -- Changed IRC links to the Libera.Chat webchat.
    https://github.com/django/django/pull/14486 - Refs #32355 -- Used addClassCleanup() in tests.

Best,
Mariusz

[Mariusz Felisiak]

Week ending June 13, 2021

Triaged:
   https://code.djangoproject.com/ticket/32820 - Fields’ errors should be programmatically associated with fields. (accepted)
   https://code.djangoproject.com/ticket/32819 - Fields’ help text and errors should be associated with input. (accepted)
   https://code.djangoproject.com/ticket/32822 - Docs that send_email()'s from_email doesn't work in Gmail. (wontfix)
   https://code.djangoproject.com/ticket/32817 - Include in CsrfViewMiddleware's bad CSRF token message where the token is from (accepted)
   https://code.djangoproject.com/ticket/32823 - Cannot pass extra AJAX settings to admin autocomplete (duplicate)
   https://code.djangoproject.com/ticket/32825 - Django unit tests with postgres can take an exceeding long time (needsinfo)
   https://code.djangoproject.com/ticket/32826 - Allow for custom groupings in Django Admin (duplicate)
   https://code.djangoproject.com/ticket/32824 - Potential micro-optimisations for NodeList.render (accepted)
   https://code.djangoproject.com/ticket/32801 - Support for non-aggregation subqueries in FROM clause (duplicate)
   https://code.djangoproject.com/ticket/32828 - Wrong .count() for GROUP BY on ordered queryset (invalid)
   https://code.djangoproject.com/ticket/32829 - clearsessions help text is incorrect (accepted)
   https://code.djangoproject.com/ticket/32830 - The 'last' filter in django template default tags give negative index error (invalid)
   https://code.djangoproject.com/ticket/32831 - Flaky test in CI: cache.tests.BaseMemcachedTests.test_touch (accepted)
   https://code.djangoproject.com/ticket/32832 - Adding nullable TextField/JSONField with default fails on MySQL 8.0.13+. (accepted)
   https://code.djangoproject.com/ticket/32834 - DEFAULT_AUTO_FIELD should allow for diable migration for existing models (invalid)
   https://code.djangoproject.com/ticket/32835 - ManyRelatedManager should support replace method (invalid)
   https://code.djangoproject.com/ticket/32836 - User needs both change and view permissions for autocomplete to work, not one or the other. (invalid)
   https://code.djangoproject.com/ticket/32837 - Flatpages manipulates url before get_object_or_404 leads to error (invalid)
   https://code.djangoproject.com/ticket/32838 - Migrations create extra index when foreign key is also part of a unique constraint (wontfix)
   https://code.djangoproject.com/ticket/32839 - Unnecessary qoutes around table name with in subquery (duplicate)

Reviewed/committed:
   https://github.com/django/django/pull/14466 - Refs #24121 -- Added __repr__() to ChangeList and BaseStorage.
   https://github.com/django/django/pull/14497 - Fixed #32821 -- Updated os.scandir() uses to use a context manager.
   https://github.com/django/django/pull/14493 - Fixed #32716 -- Fixed ManifestStaticFilesStorage crash when max_post_process_passes is 0.
   https://github.com/django/django/pull/14484 - Fixed #32668 -- Separated test-collection setup from test-run setup in runtests.py.
   https://github.com/django/django/pull/14487 - Fixed #32814 -- Improved performance of TextNode.
   https://github.com/django/django/pull/13559 - Fixed #31653 -- Added AddConstraintNotValid()/ValidateConstraint() operations for PostgreSQL.
   https://github.com/django/django/pull/14500 - Fixed #25255 -- Recorded unapplied squashed migrations.
   https://github.com/django/django/pull/13682 - Fixed #32195 -- Added system check for invalid view in path() and improved error messages.
   https://github.com/django/django/pull/14506 - Fixed #32829 -- Updated help text for clearsessions management command.
   https://github.com/django/django/pull/14428 - Refs #27734 -- Prevented creation of more parallel workers than TestCases.
   https://github.com/django/django/pull/14504 - Refs #24121 -- Added __repr__() to AdminForm, BlockContext, BlockTranslateNode, and IncludeNode.
   https://github.com/django/django/pull/14507 - Fixed #32609 -- Updated runtests.py to support directory path test labels.
   https://github.com/django/django/pull/14513 - Fixed #25250 -- Clarified partially recorded state of squashed migrations in showmigrations --list.
   https://github.com/django/django/pull/14503 - Fixed #32824 -- Improved performance of NodeList.render().

Reviewed:
   https://github.com/django/django/pull/14508 - Fixed #30427, Fixed #16176 -- Corrected setting descriptor in Field.contribute_to_class().

Authored:
   https://github.com/django/django/pull/14501 - Refs #32355 -- Used addClassCleanup() in SimpleTestCase and SerializeMixin.
   https://github.com/django/django/pull/14502 - Refs #14357 -- Updated docs about interaction between aggregations and QuerySet.order_by().
   https://github.com/django/djangoproject.com/pull/1099 - Added list of Django Core Developers.
   https://github.com/django/django/pull/14512 - Fixed #32832 -- Fixed adding BLOB/TEXT nullable field with default on MySQL 8.0.13+.

Best,
Mariusz

[Mariusz Felisiak]

Week ending June 20, 2021

    Holidays 🏃🏊☀️

Best,
Mariusz

[Mariusz Felisiak]

Week ending June 27, 2021

Triaged:
   https://code.djangoproject.com/ticket/32856 - Django 2.2 not compatible with psycopg 2.9 (wontfix)
   https://code.djangoproject.com/ticket/32862 - Order By in Postgres When Using Annotations Causes Ambiguous Field Name (needsinfo)
   https://code.djangoproject.com/ticket/32867 - django admin - protect againt mutual edit of same object (duplicate)
   https://code.djangoproject.com/ticket/32659 - Autocomplete field: The results could not be loaded. (needsinfo)
   https://code.djangoproject.com/ticket/32865 - manage.py makemigrations command gives an unexpected issue in check_consistent_history. (invalid)
   https://code.djangoproject.com/ticket/32869 - Bug while migrating a OneToOneField to ForeignKey on PostgreSQL. (worksforme)
   https://code.djangoproject.com/ticket/32870 - Added message when user mispells 'urlpatterns' in some 'urls' module (accepted)
   https://code.djangoproject.com/ticket/32868 - Add system check or warning for model fields shadowing methods / other attributes (wontfix)
   https://code.djangoproject.com/ticket/32875 - Which is prefered for `default_related_name`? (invalid)
   https://code.djangoproject.com/ticket/32876 - The parametered `all` is not preserved after save object in django admin. (invalid)
   https://code.djangoproject.com/ticket/32877 - request.POST sending array (invalid)
   https://code.djangoproject.com/ticket/32878 - Seems that browsing releases in Django Project website interchanged "Prev" and "Next" links. (invalid)
   https://code.djangoproject.com/ticket/32880 - Improve logging documentation (accepted)
   https://code.djangoproject.com/ticket/32881 - Inconsistent user models in contrib.auth.forms. (duplicate)
   https://code.djangoproject.com/ticket/25265 - DB Backend cannot specify query class. (someday/maybe)
   https://code.djangoproject.com/ticket/24096 - GROUP BY on oracle fails with TextField and BinaryField (duplicate)
   https://code.djangoproject.com/ticket/25456 - Make GenericIPAddressField normalize IPv4 addresses (fixed)

Reviewed/committed:
   https://github.com/django/django/pull/14535 - Fixed #32859 -- Simplified compress_string() by using gzip.compress().
   https://github.com/django/djangoproject.com/pull/1100 - Made docs permalinks focusable to improve accessibility.
   https://github.com/django/django/pull/14537 - Fixed #32860 -- Made docs permalinks focusable to improve accessibility.
   https://github.com/django/django/pull/14536 - Fixed #32858 -- Fixed ExclusionConstraint crash with index transforms in expressions.
   https://github.com/django/django/pull/14524 - Fixed #32842 -- Refactored out CsrfViewMiddleware._check_token().
   https://github.com/django/django/pull/14453 - Fixed #32870 -- Improved error message when URLconf is empty.
   https://github.com/django/django/pull/14389 - Refs #32338 -- Removed 'for ="..."' from RadioSelect's <label>.
   https://github.com/django/django/pull/14549 - Fixed #32863 -- Skipped system check for specifying type of auto-created primary keys on models with invalid app_label.
   https://github.com/django/django/pull/14531 - Refs #24121 -- Added __repr__() to StreamingHttpResponse and subclasses.
   https://github.com/django/django/pull/14542 - Removed options parameter from djangoAdminSelect2.
   https://github.com/django/django/pull/14518 - Fixed #32817 -- Added the token source to CsrfViewMiddleware's bad token error messages.
   https://github.com/django/django/pull/14368 - Fixed #32727 -- Allowed spaces before time zone offset in parse_datetime().
   https://github.com/django/django/pull/14555 - Refs #32880 -- Improved some headings and text in logging topic.
   https://github.com/django/django/pull/14545 - Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert" in various code.
   https://github.com/django/django/pull/14557 - Refs #32880 -- Improved some how-to notes in logging topic.

Authored:
   https://github.com/django/django/pull/14547 - [2.2.x] Refs #32856 -- Doc'd that psycopg2 < 2.9 is required.

Best,
Mariusz

[Mariusz Felisiak]

Week ending July 4, 2021

Released Django 3.2.5 and 3.1.13.

Triaged:

   https://code.djangoproject.com/ticket/32884 - Login header title is slightly off-center (accepted)
   https://code.djangoproject.com/ticket/32885 - CsrfViewMiddlewareTestMixin contains some logic specific to the CSRF_USE_SESSIONS=False case (accepted)
   https://code.djangoproject.com/ticket/32882 - Problems when comparing two fields with None value using F() in Case() (duplicate)
   https://code.djangoproject.com/ticket/32887 - v3.2.4 regression - Invalid path type: PurePosixPath (invalid)
   https://code.djangoproject.com/ticket/17292 - Add support for several authors in syndication framework (wontfix)
   https://code.djangoproject.com/ticket/32888 - Using select_for_update with self as an of-argument gets dropped when only selecting fields on related model (invalid)
   https://code.djangoproject.com/ticket/32890 - Consider ranking the documentation search results. (invalid)
   https://code.djangoproject.com/ticket/32892 - Optimisation for parse_datetime by preferring datetime.fromisoformat for well-formed values. (accepted)

   https://code.djangoproject.com/ticket/32894 - isinstance() checks with non-configured LazySettings raise an exception. (needsinfo)
   https://code.djangoproject.com/ticket/32895 - Incorrectly disallowing negative integer for window range end (duplicate)
   https://code.djangoproject.com/ticket/32896 - Exclude on expressions not being negated as expected (duplicate)

Reviewed/committed:

   https://github.com/django/django/pull/14560 - [3.2.x] Updated translations from Transifex.
   https://github.com/django/django/pull/14485 - Refs #32800 -- Improved CsrfViewMiddleware test coverage.
   https://github.com/django/django/pull/14552 - Fixed some inconsistencies in tests for JSONBAgg.
   https://github.com/django/django/pull/14558 - Fixed #32807 -- Fixed JSONField crash when redisplaying None values.
   https://github.com/django/django/pull/14561 - Refs #32880 -- Rearranged logging security notes.
   https://github.com/django/django/pull/14559 - Fixed #32381 -- Made QuerySet.bulk_update() return the number of objects updated.
   https://github.com/django/django/pull/14567 - Fixed #32884 -- Fixed centering of the header on admin login page.
   https://github.com/django/django/pull/14565 - Fixed #32843 -- Ensured CSRF tests' _get_GET_csrf_cookie_request() sets request.method.
   https://github.com/django/django/pull/14436 - Refs #29898 -- Moved state_forwards()'s logic from migration operations to ProjectState.
   https://github.com/django/django/pull/14572 - Refs #32655 -- Improved error if iter_test_cases() is passed a string.
   https://github.com/django/django/pull/14566 - Refs #32880 -- Moved logging reference to new document.
   https://github.com/django/django/pull/14570 - Fixed #32885 -- Removed cookie-based token specific logic from CsrfViewMiddlewareTestMixin.
   https://github.com/django/django/pull/14448 - Fixed #32786 -- Moved subquery ordering clearing optimization to the _in lookup.
   https://github.com/django/django/pull/14564 - Fixed #32850 -- Doc'd Sitemap.paginator.

   https://github.com/django/django/pull/14576 - Refs #32880 -- Renamed/reordered logging topic sections.
   https://github.com/django/django/pull/14580 - Fixed #32893 -- Fixed serialization of models.Model class in migrations.
   https://github.com/django/django/pull/14430 - Fixed #26430 -- Fixed coalesced aggregation of empty result sets.
   https://github.com/django/django/pull/14367 - Fixed #28935 -- Fixed display of errors in extended blocks.
   https://github.com/django/django/pull/14584 - Fixed #30934 -- Included database alias in django.db.backends log messages.

Authored:
   https://github.com/django/django/pull/14562 - Refs #26430 -- Added tests for PostgreSQL-specific aggregates on EmptyQuerySets.

Best,
Mariusz