has_changed as property

[Sven R. Kunze]

Good afternoon,

I would like to follow up on https://groups.google.com/forum/#!searchin/django-developers/is_authenticated$20as$20property%7Csort:relevance/django-developers/7k6Z8JxKH5Q/RoNKv66xcAMJ with regards to Form.has_changed.

It's is not as security relevant as is_authenticated but the remaining arguments of "is_authenticated as property" still hold. I also suggest the usage of CallableBool as a good temporary backwards-compatibility measure.

Best

Sven

NOTE: this one hid an especially annoying bug (also performance-wise) in production for us.

[Tim Graham]

Unless there are different arguments for has_changed vs. is_valid, I suggest we discuss both attributes on the nearly identical "is_valid as property" thread.

[Sven R. Kunze]

That's works for me.

[Sven R. Kunze]

One additional note: has_changed is a lot more subtle than is_valid because it is used less often than is_valid (checked by grepping through our sources).