Fellow Reports - June 2023
Mariusz Felisiak
Week ending June 11, 2023
Triaged:
https://code.djangoproject.com/ticket/31617 - Improve overall
admin accessibility. (invalid)
https://code.djangoproject.com/ticket/9519 - Add
QuerySet.bulk_delete() that issues only a single SQL query
(wontfix)
https://code.djangoproject.com/ticket/34610 -
Django_migrations unique constraint (duplicate)
https://code.djangoproject.com/ticket/30490 - migrations
unique_index on (app, name). (wontfix)
https://code.djangoproject.com/ticket/34632 - Let
makemigrations output an error message with --check (wontfix)
https://code.djangoproject.com/ticket/34633 - Add
prefetch_related() cache invalidation for create() in reverse
many-to-one managers. (accepted)
https://code.djangoproject.com/ticket/34634 - Creating objects
with nested MTI crashes. (created)
https://code.djangoproject.com/ticket/34631 -
Expression.identity() performance (wontfix)
https://code.djangoproject.com/ticket/24863 - Make
`django.db.models.Manager.from_queryset` copy over properties and
not just methods (wontfix)
https://code.djangoproject.com/ticket/34635 - ModelChoiceField
with a to_attr that can have an EMPTY_VALUE (wontfix)
https://code.djangoproject.com/ticket/34636 - Add
documentation for Query's function `sql_with_params` (wontfix)
https://code.djangoproject.com/ticket/34637 - Add support for
database defaults in questioner. (needsinfo)
https://code.djangoproject.com/ticket/34614 - Natural keys for
nullable foreign keys (worksforme)
https://code.djangoproject.com/ticket/34639 - MySQL 8.0 hangs
indefinitely when using the admin search with a Foreign Key and
Annotate (invalid)
https://code.djangoproject.com/ticket/34640 - Add query_params
argument to test Client methods (duplicate)
https://code.djangoproject.com/ticket/34644 -
social-app-django's JSONField doesn't work as expected. (invalid)
https://code.djangoproject.com/ticket/34643 - Move admin form
labels to a more accessible place (needsinfo)
https://code.djangoproject.com/ticket/24472 - Define internal
types explicitly for related fields (wontfix)
https://code.djangoproject.com/ticket/34646 - Ordering a
Django admin column based on multiple model fields (duplicate)
https://code.djangoproject.com/ticket/34647 - Foreign Key
index names are not renamed when a model is renamed causing
duplicate key if a model with the origin name and column is added
(duplicate)
Reviewed/committed:
https://github.com/django/django/pull/16899 - Fixed #34601 --
Added field name to check message for ModelAdmin.readonly_fields.
https://github.com/django/django/pull/16926 - Fixed #34621 --
Made admin site header render in <div> tag.
https://github.com/django/django/pull/16927 - Fixed #34622 --
Improved accessibility of related widget wrapper in admin.
https://github.com/django/django/pull/16948 - Fixed #34609 --
Deprecated calling format_html() without arguments.
https://github.com/django/django/pull/16947 - Added
MultiPartParser tests for parsing base64-encoded fields.
https://github.com/django/django/pull/16900 - Fixed #30355 --
Doc'd interaction between custom managers and prefetch_related().
https://github.com/django/django/pull/16957 - Refs #34445 --
Fixed string-casting of non-string lazy objects when value may be
bytes.
https://github.com/django/django/pull/16958 - Simplified and
optimized django.utils.functional.lazy().
https://github.com/django/django/pull/16901 - Fixed #34604 --
Corrected fallback SQL for n-ary logical XOR.
https://github.com/django/django/pull/16959 - Fixed #23049 --
Added %a and %A support to Date.strftime.
https://github.com/django/django/pull/16949 - Added tests for
HttpResponseBase.charset/reason_phrase setters.
https://github.com/django/django/pull/16964 - Refs #34233 --
Updated black target-version to Python 3.10.
https://github.com/django/django/pull/16951 - Fixed #34638 --
Fixed admin change list selected row highlight on editable boolean
fields.
Authored:
https://github.com/django/django/pull/16945 - Refs #26706,
Refs #34633 -- Added test for prefetch_related() cache
invalidation in ManyRelatedManager.create().
https://github.com/django/django/pull/16946 - Fixed
lookup.tests.LookupTests.test_exclude() on PostgreSQL 16 beta 1.
https://github.com/django/django/pull/16961 - Fixed #34645 --
Restored alignment for admin date/time timezone warnings.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/34652 - Async support in admin view (wontfix)
https://code.djangoproject.com/ticket/34569 - Unify all model fields to call get_prep_value from get_db_prep_value (accepted)
https://code.djangoproject.com/ticket/34655 - Tests for RadioSelect and Select have diverged considerably, potentially leaving RadioSelect undertested (accepted)
https://code.djangoproject.com/ticket/34656 - Wrong HTML generation in Django admin's change_password form (accepted)
https://code.djangoproject.com/ticket/34659 - mysql backend creates queries using CONVERT_TZ even when this is not supported (duplicate)
https://code.djangoproject.com/ticket/34660 - Use RFC3339 format and input type=(date|time|datetime-local) for date/time/datetime form fields (duplicate)
https://code.djangoproject.com/ticket/34658 - New assertion `assertNotInHTML`, like `assertContains` has `assertNotContains` (wontfix)
https://code.djangoproject.com/ticket/34662 - Translation strings of ArrayField length validators depend on wrong ngettext key (accepted)
https://code.djangoproject.com/ticket/34663 - Documentation typo in using Argon2 with Django. (worksforme)
Reviewed/committed:
https://github.com/django/django/pull/16954 - Simplified and improved django.utils.functional.lazy().
https://github.com/django/django/pull/16934 - Fixed #34628 -- Improved icons accessibility of related widget wrapper in admin.
https://github.com/django/django/pull/16970 - Made SeleniumTests.test_select_multiple less flaky by adding explicit Selenium wait.
https://github.com/django/django/pull/16965 - Fixed #34649 -- Fixed headless deprecation warning on Selenium 4.8+.
https://github.com/django/django/pull/16973 - Fixed date_time_picker_shortcuts() tests on Windows.
https://github.com/django/django/pull/16974 - Refs #32143 -- Removed superflous constraints on excluded query.
https://github.com/django/django/pull/16903 - Fixed #33414 -- Fixed creating diamond shaped MTI objects for common ancestor with primary key that has a default.
https://github.com/django/django/pull/16966 - Added GitHub action to run Selenium tests.
https://github.com/django/django/pull/16745 - Fixed #34473 -- Fixed step validation for form fields with non-zero minimum value.
https://github.com/django/django/pull/16939 - Fixed #34629 -- Added filtering support to GIS aggregates.
https://github.com/django/django/pull/16981 - Added Selenium tests to daily builds.
https://github.com/django/django/pull/16989 - Made SeleniumTests.test_inline_uuid_pk_add_with_popup less flaky by waiting until popup is closed.
https://github.com/django/django/pull/16986 - Fixed #34662 -- Corrected number in error messages for Array(Min/Max)LengthValidator.
Reviewed:
https://github.com/django/django/pull/16967 - Updated PyPI setup access in prerequisites checklist of release how-to.
Authored:
https://github.com/django/djangoproject.com/pull/1374 - Fixed HTML of community page.
https://github.com/django/django/pull/16990 - Improved names for Selenium daily builds.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34665 - CreateModel with manually added RenameField crashes on SQLite. (invalid)
https://code.djangoproject.com/ticket/34661 - Peppering user passwords (duplicate)
https://code.djangoproject.com/ticket/34666 - Mysql issue using afirst "The client was disconnected by the server because of inactivity" (needsinfo)
https://code.djangoproject.com/ticket/34658 - New assertion `assertNotInHTML`, like `assertContains` has `assertNotContains` (accepted)
https://code.djangoproject.com/ticket/31827 - Add test runner option to show N slowest tests (duplicate)
https://code.djangoproject.com/ticket/34668 - Unvalidated Redirect from "PATH_INFO" URI Parameter on "/admin/auth/group/{n}/change/" page. (invalid)
https://code.djangoproject.com/ticket/34669 - Unvalidated Redirect from "next" Parameter on "/admin/login/" page. (invalid)
https://code.djangoproject.com/ticket/34670 - Django Admin light theme flickers on dark system (needsinfo)
https://code.djangoproject.com/ticket/34671 - Inspectdb collation issue with oracle views (accepted)
https://code.djangoproject.com/ticket/34673 - Migrations ordering: add constraint run_immediately_after (invalid)
https://code.djangoproject.com/ticket/34674 - Updating the file contents of a Django FileField during upload results in I/O error (duplicate)
https://code.djangoproject.com/ticket/34678 - README.rst does not mention the Django Discord or Django forum (accepted)
https://code.djangoproject.com/ticket/34676 - Normalise MeasureBase unit not found exceptions to use AttributeError (accepted)
Reviewed/committed:
https://github.com/django/django/pull/16988 - Refs #34517 -- Restored skipping ImageFileField.update_dimension_fields without width/height fields.
https://github.com/django/django/pull/16982 - Fixed #34656 -- Fixed unclosed div in admin password change template.
https://github.com/django/django/pull/16991 - Refs #27079 -- Used addClassCleanup() in SeleniumTestCase.
https://github.com/django/django/pull/16983 - Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical.
https://github.com/django/django/pull/16996 - Improved style of n-tuple wording in docs and comments.
https://github.com/django/django/pull/16831 - Refs #31949 -- Made @sensitive_variables/sensitive_post_parameters decorators to work with async functions.
https://github.com/django/django/pull/16999 - Refs #31949 -- Simplified @sensitive_variables a bit.
Authored:
https://github.com/django/django/pull/17000 - Refs #34391 -- Updated asgiref dependency for 5.0 release series.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/34680 - inspectdb on mysql timestamp fields leads to timezone issues (duplicate)
https://code.djangoproject.com/ticket/34681 - Optimize memcache_key_warnings() (accepted)
https://code.djangoproject.com/ticket/34682 - System check for CSRF_TRUSTED_ORIGINS raises errors for http://localhost:port. (worksforme)
https://code.djangoproject.com/ticket/34683 - get_object_or_404 and get_list_or_404 custom messaging (wontfix)
https://code.djangoproject.com/ticket/34684 - Drop support for GDAL 2.2 and 2.3. (created)
https://code.djangoproject.com/ticket/34685 - Drop support for GEOS 3.6 and 3.7. (created)
https://code.djangoproject.com/ticket/34686 - Confirm/Add support for GEOS 3.12. (created)
https://code.djangoproject.com/ticket/34687 - Apps.clear_cache() does not clear get_swappable_settings_name cache. (accepted)
https://code.djangoproject.com/ticket/34688 - Deprecate contrib.sitemaps.ping_google(). (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17006 - Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units.
https://github.com/django/django/pull/17008 - Fixed #34678 -- Added Django Forum and Discord server to README.rst.
https://github.com/django/django/pull/16752 - Refs #31949 -- Made http decorators to work with async functions.
https://github.com/django/django/pull/17001 - Fixed #34675 -- Fixed creating remote webdriver for Selenium 4.10.0+.
https://github.com/django/django/pull/16636 - Fixed #34391 -- Added async-compatible interface to auth functions and related methods test clients.
https://github.com/django/django/pull/17019 - Fixed #34681 -- Optimized memcache_key_warnings().
https://github.com/django/django/pull/17023 - Refs #34572 -- Added missing GDAL_PIXEL_TYPES from GDAL 3.5+.
https://github.com/django/django/pull/17028 - Refs #30382 -- Added more tests for using force_insert with model inheritance.
https://github.com/django/django/pull/16830 - Fixed #30382 -- Allowed specifying parent classes in force_insert of Model.save().
https://github.com/django/django/pull/17029 - Fixed #34687 -- Made Apps.clear_cache() clear get_swappable_settings_name() cache.
Authored:
https://github.com/django/django/pull/17012 - Fixed #34671 -- Fixed collation introspection for views and materialized views on Oracle.
https://github.com/django/django/pull/17013 - Refs #34233 -- Bumped minimum supported versions of Selenium to 4.8.0.
https://github.com/django/django/pull/17022 - Fixed RecorderTests.test_has_table_cached() on databases that perform multiple queries when introspecting tables.
https://github.com/django/django/pull/17024 - Fixed #34572 -- Added support for GDAL 3.7.
https://github.com/django/django/pull/17025 - Fixed #34684 -- Dropped support for GDAL 2.2 and 2.3.
https://github.com/django/django/pull/17027 - Fixed #34685 -- Dropped support for GEOS 3.6 and 3.7.
https://github.com/django/django/pull/17031 - Fixed RelatedGeoModelTest.test_centroid_collect_filter().
https://github.com/django/djangoproject.com/pull/1384 - Added PyCharm banners for 2023 fundraiser.
Mariusz