Last call: Meta API (GSoC 2014/PR 3114) is ready for commit

214 views
Skip to first unread message

Russell Keith-Magee

unread,
Jan 5, 2015, 12:12:41 AM1/5/15
to Django Developers
Hi all,

Following up on my pre-Christmas email - I believe that PR 3114 - the formalisation of _meta - is now ready to land.


The code has received a detailed review by several members of the core team, including Tim, Carl, Collin, and myself; we've had review notes from many others. The documentation has also been reviewed. The issues raised by those code and documentation reviews have all (to the best of my knowledge) been addressed.

Other than last-minute cleanups (e.g., PEP8 compliance, -Wall checks etc), and the conclusion of one discussion about how to express one particular set of relationships in code, I believe the branch is ready to land.

Unless there are objections, my intention is to land this patch later this week (around Wednesday/Thursday UTC). If anyone has any objections, speak now, etc etc.

Once again, a huge thanks to Daniel for his great work over the summer (and continued work into the winter as we refined the patch for trunk), and to everyone else who has contributed to reviewing his work.

Yours,
Russ Magee %-)

Tom Christie

unread,
Jan 5, 2015, 5:11:13 AM1/5/15
to django-d...@googlegroups.com
Wonderful - great work Daniel and thanks to everyone else for their hard work on review & guidance.
Lovely stuff.

  Tom

Daniel Pyrathon

unread,
Jan 7, 2015, 8:14:52 PM1/7/15
to django-d...@googlegroups.com
Hi all,

My project has just landed in master, since last night (EU time).

I just wanted to say THANK YOU for everyone that helped me review and fix my project. I would have never managed to reach such maturity by myself, and one of the best things is that I really learned a lot by contributing to Django (Yes! this is also a pitch to any potential SoC applicants for next year).

First of all, I want to thank my mentor (Russell) for his enormous patience and for all the time he dedicated to the project.
Secondly, I want to thank all the community and everyone who got involved in my pull request by submitting comments and/or contacting me directly for suggestions and advice, your suggestions have greatly shaped the final release and have also helped me improve as a developer.
Last but not least, I want to (re)thank the people from Django Under the Hood because the brainstorming that happened over the sprints as well as the very technical talks have greatly helped this project grow.

This is not a farewell, I plan on sticking around (as I am sure tickets will be assigned to me very soon!) so feel free to blame me on IRC or Twitter (PirosB3).

Daniel Pyrathon

Josh Smeaton

unread,
Jan 7, 2015, 9:39:20 PM1/7/15
to django-d...@googlegroups.com
Congratulations on taking this all the way Daniel!

Carl Meyer

unread,
Jan 8, 2015, 5:45:46 PM1/8/15
to django-d...@googlegroups.com
Congratulations, Daniel! Thanks for sticking around long past the end of
the GSoC to make this change happen.

Carl

On 01/07/2015 06:14 PM, Daniel Pyrathon wrote:
> Hi all,
>
> My project has just landed in master, since last night (EU time).
>
> I just wanted to say THANK YOU for everyone that helped me review and fix
> my project. I would have never managed to reach such maturity by myself,
> and one of the best things is that I really learned a lot by contributing
> to Django (Yes! this is also a pitch to any potential SoC applicants for
> next year).
>
> First of all, I want to thank my mentor (Russell) for his *enormous*
signature.asc
Reply all
Reply to author
Forward
0 new messages