Fellow Reports - November 2021
Mariusz Felisiak
Week ending November 7, 2021
Released Django 3.2.9.
Triaged:
https://code.djangoproject.com/ticket/33246 - --squashed-name
can overwrite existing migration files (accepted)
https://code.djangoproject.com/ticket/33248 - inspectdb
command doesn't introspect on_delete option. (invalid)
https://code.djangoproject.com/ticket/33250 - EmailField's
label in PasswordResetForm doesn't match the verbose_name of
AbstractUser's EmailField (wontfix)
https://code.djangoproject.com/ticket/33251 - RadioSelect HTML
change is missing in Django 4.0 changelog. (invalid)
https://code.djangoproject.com/ticket/33252 - CacheMiddleware
and FetchFromCacheMiddleware are not thread safe. (accepted)
https://code.djangoproject.com/ticket/33231 - authenticate()
doesn't raise ImproperlyConfigured for incorrect authentication
backends. (wontfix)
https://code.djangoproject.com/ticket/33240 -
get_image_dimensions() raises ValueError on some .ico files.
(needsinfo)
https://code.djangoproject.com/ticket/33254 - Issue with
django.forms.fields.FilePathField() and callable path (invalid)
https://code.djangoproject.com/ticket/33255 - Closing
</Body> tag inside textarea is being lowercased. (invalid)
https://code.djangoproject.com/ticket/33256 - Some schema
tests don't clean up their tables (accepted)
https://code.djangoproject.com/ticket/33259 -
Model._meta.related_objects returns different values in shell and
from the request. (needsinfo)
https://code.djangoproject.com/ticket/33257 - Case() and
ExpressionWrapper() doesn't work with DecimalField on SQLite.
(accepted)
https://code.djangoproject.com/ticket/33260 - Crash when using
query set select_for_update(of=(...)) with exists() (accepted)
https://code.djangoproject.com/ticket/33264 - DiscoverRunner
doesn't counts unexpectedSuccess as an error (accepted)
https://code.djangoproject.com/ticket/33266 - Auto-reload not
detecting changes in Django 3.2 (needsinfo)
https://code.djangoproject.com/ticket/33265 -
Form.get_context() backward-incompatibility (invalid)
https://code.djangoproject.com/ticket/33268 - No translations
for day and month in Marathi and Gujarati locales (invalid)
https://code.djangoproject.com/ticket/33269 - Raise an error
if a string is passed into has_perms() instead of a list
(accepted)
Reviewed/committed:
https://github.com/django/django/pull/15040 - Fixed #33245 --
Made django.utils.html.urlize() thread-safe.
https://github.com/django/django/pull/15035 - Added Google
Cloud Spanner to list of third-party DB backends.
https://github.com/django/django/pull/15038 - Fixed #33246 --
Made squashmigrations raise CommandError when squashed_name
already exists.
https://github.com/django/django/pull/15027 - Fixed #33224 --
Removed DatabaseFeatures.supports_mixed_date_datetime_comparisons.
https://github.com/django/django/pull/15037 - Fixed #33187 --
Made inspectdb handle ForeignKey.to_field attribute.
https://github.com/django/django/pull/14986 - Fixed #32691 --
Made Exact lookup on BooleanFields compare directly to a boolean
value on MySQL.
https://github.com/django/django/pull/15048 - Refs #33245 --
Minor edits to django.utils.html.urlize() changes.
https://github.com/django/django/pull/15044 - Fixed #33252 --
Made cache middleware thread safe.
https://github.com/django/django/pull/14750 - Fixed #32996 --
Cached PathInfos on relations.
https://github.com/django/django/pull/15053 - Refs #33247 --
Pinned Sphinx version for RTD builds.
https://github.com/django/django/pull/15051 - Fixed #33260 --
Fixed crash when chaining QuerySet.exists() after
select_for_update(of=()).
https://github.com/django/django/pull/15052 - Fixed #33262 --
Fixed crash of conditional aggregation on Exists().
https://github.com/django/django/pull/15039 - Refs #33247 --
Fixed rendering of Unicode chars and emojis in PDF docs build.
https://github.com/django/django/pull/14538 - Fixed #27147 --
Allowed specifying bounds of tuple inputs for non-discrete range
fields.
https://github.com/django/django/pull/15056 - Fixed #33237 --
Fixed detecting source maps in ManifestStaticFilesStorage for
multiline files.
https://github.com/django/django/pull/15059 - Refs #33263 --
Expanded release notes for DeleteView adopting FormMixin.
https://github.com/django/django/pull/15061 - Fixed #33235 --
Removed "for = ..." from MultiWidget's <label>.
Reviewed:
https://github.com/django/django/pull/15050 - Fixed #33247 --
Added configuration for Read The Docs.
Authored:
https://github.com/django/django/pull/15045 - Fixed isolation
of admin_views.tests.ValidXHTMLTests.
https://github.com/django/django/pull/15054 - Corrected
multiply defined labels in docs.
https://github.com/django/django/pull/15064 - Fixed #33253 --
Reverted "Fixed #32319 -- Added ES module support to
ManifestStaticFilesStorage."
https://github.com/django/code.djangoproject.com/pull/117 -
Fixed "New ticket" crash when logging out.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/33267 - Add Hyperlink to related model in admin change form. (needsinfo)
https://code.djangoproject.com/ticket/33272 - Non-installed model error isn't raised if the module is in the submodule of an installed app (invalid)
https://code.djangoproject.com/ticket/33275 - DiscoverRunner.setup_databases() creates db based on ordering of aliases from unordered set. (duplicate)
https://code.djangoproject.com/ticket/33278 - Use a custom exception type with django.test.testcases._DatabaseFailure (accepted)
https://code.djangoproject.com/ticket/33279 - Time zones with minus in names are incorrectly converted. (accepted)
https://code.djangoproject.com/ticket/33280 - Migration with django-database-view don't work with multiple databases. (invalid)
https://code.djangoproject.com/ticket/33281 - intcomma template filter doesn't depend on the USE_L10N setting. (invalid)
https://code.djangoproject.com/ticket/33284 - JSONFIeld decode error with Python 3.9 (needsinfo)
https://code.djangoproject.com/ticket/33285 - Server Reload Error... (duplicate)
https://code.djangoproject.com/ticket/33283 - Support for map function on ModelAdmin.prepopulated_fields. (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14724 - Fixed #32980 -- Made models cache related managers.
https://github.com/django/code.djangoproject.com/pull/116 - Removed reference to "core developers" in Someday/Maybe stage description.
https://github.com/django/django/pull/15062 - Fixed #33257 -- Fixed Case() and ExpressionWrapper() with decimal values on SQLite.
https://github.com/django/django/pull/15060 - Fixed #33264 -- Made test runner return non-zero error code for unexpected successes.
https://github.com/django/django/pull/15028 - Refs #16063 -- Added tests for searching against multiple related fields in admin changelist.
https://github.com/django/django/pull/15074 - Fixed DatabaseIntrospection.get_relations() docstring.
https://github.com/django/django/pull/15073 - Fixed #6106 -- Prevented makemessages from changing .po files when up to date.
https://github.com/django/django/pull/14969 - Fixed #33269 -- Made AnonymousUser/PermissionsMixin.has_perms() raise ValueError on string or non-iterable perm_list.
https://github.com/django/django/pull/15078 - Fixed #33279 -- Fixed handling time zones with "-" sign in names.
https://github.com/django/django/pull/14919 - Fixed #33161 -- Enabled durability check for nested atomic blocks in TestCase.
Authored:
https://github.com/django/django/pull/15063 - Refs #33263 -- Added warning to BaseDeleteView when delete() method is overridden.
https://github.com/django/django/pull/15075 - Removed DatabaseIntrospection.get_key_columns().
https://github.com/django/django/pull/15079 - Refs #33247 -- Used XeLaTeX for PDF docs build.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33288 - SQLite schema introspection should use PRAGMA instead of parsing to retrieve foreign keys (accepted).
https://code.djangoproject.com/ticket/33290 - Docs for versions in the extended support should indicate lack of support. (invalid)
https://code.djangoproject.com/ticket/33292 - Failing GIS tests with MySQL (invalid)
https://code.djangoproject.com/ticket/33291 - Allow blocks with same name in if/else (wontfix)
https://code.djangoproject.com/ticket/33293 - Wrong redirect behind reverse proxy (invalid)
https://code.djangoproject.com/ticket/33294 - opclasses missing in PostGIS's 3D geometry indexes (needsinfo)
https://code.djangoproject.com/ticket/33295 - AttributeError is raised when a list is passed into self.stdout.write(). (wontfix)
https://code.djangoproject.com/ticket/33296 - Allow manage.py changepassword to use DJANGO_SUPERUSER_PASSWORD (wontfix)
https://code.djangoproject.com/ticket/33299 - Add @request_passes_test decorator. (wontfix)
https://code.djangoproject.com/ticket/33298 - get_object_or_404()/get_list_or_404() don't document or test passing *args. (accepted)
https://code.djangoproject.com/ticket/33300 - Hidden fields are visible on small screens. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/15087 - Fixed #33288 -- Made SQLite introspection use information schema for relations.
https://github.com/django/django/pull/15082 - Fixed #33278 -- Improved error for connection/query attempts against disallowed databases in tests.
https://github.com/django/django/pull/15088 - Fixed #33287 -- Made GeoJSON serializer use json.loads() instead of eval().
https://github.com/django/django/pull/15093 - Refs #32800 -- Added more CSRF tests and avoided use of _does_token_match().
https://github.com/django/django/pull/15091 - Fixed #28357 -- Fixed ModelAdmin.prepopulated_fields on newly added stacked inline.
https://github.com/django/django/pull/14925 - Fixed #33163 -- Added example of connection signal handlers in AppConfig.ready() to docs.
https://github.com/django/django/pull/15099 - Added Malay language.
https://github.com/django/django/pull/14111 - Refs #24121 -- Added __repr__() to BaseDatabaseWrapper, JoinPromoter, and SQLCompiler.
https://github.com/django/django/pull/15081 - Fixed #33229 -- Fixed BaseDatabaseOperations.adapt_datetimefield_value()/adapt_timefield_value() crash with expressions.
Authored:
https://github.com/django/django/pull/15094 - Fixed crash building HTML docs since Sphinx 4.3.
Mariusz
Mariusz Felisiak
Released Django 4.0rc1.
Triaged:
https://code.djangoproject.com/ticket/33303 - LEVEL_TAGS not updated when using @override_settings (accepted)
https://code.djangoproject.com/ticket/33307 - Model got both positional and keyword arguments for field 'id'. (invalid)
https://code.djangoproject.com/ticket/33309 - DISTINCT ON fails with mixed-case field aliases (accepted)
https://code.djangoproject.com/ticket/33310 - Remove unused "actions.selected" CSS class. (accepted)
https://code.djangoproject.com/ticket/33315 - A little question about writing your first Django application, Part 5 (invalid)
https://code.djangoproject.com/ticket/33314 - Migration Fail with MTI and Many2Many relation when switching PK type (duplicate)
https://code.djangoproject.com/ticket/33316 - History view should be paginated by default. (accepted)
https://code.djangoproject.com/ticket/33312 - Instances with deferred fields cannot be used for copying. (accepted)
https://code.djangoproject.com/ticket/33311 - Disallow overriding parent blocks within conditionals. (duplicate)
https://code.djangoproject.com/ticket/22617 - Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge") (needsinfo)
https://code.djangoproject.com/ticket/33318 - Truncator class recognizes different length of ellipsis(...) depending on the LANGUAGE_CODE. (invalid)
https://code.djangoproject.com/ticket/33319 - Query.change_aliases raises an AssertionError (accepted)
https://code.djangoproject.com/ticket/33313 - Inheriting from multiple abstract models with same field causes name collision when overriding field is direct parent (fixed)
https://code.djangoproject.com/ticket/33317 - Add note about not overriding parent blocks within conditionals (accepted)
https://code.djangoproject.com/ticket/33320 - Inconsistencies around --no-input flags (invalid)
https://code.djangoproject.com/ticket/33322 - Saving parent object after setting on child leads to unexpected data loss in bulk_update(). (accepted)
https://code.djangoproject.com/ticket/33327 - Missing template for the LoginView in the contrib.auth.views module (invalid)
Reviewed/committed:
https://github.com/django/django/pull/15104 - Fixed #33305 -- Fixed autodetector crash for ForeignKey with hardcoded "to" attribute.
https://github.com/django/django/pull/15103 - Fixed 33302 -- Made element_id optional argument for json_script template filter.
https://github.com/django/django/pull/15108 - Fixed #33304 -- Allowed passing string expressions to Window(order_by).
https://github.com/django/django/pull/15119 - Fixed #33309 -- Fixed QuerySet.distinct() crash on mixed case annotation.
https://github.com/django/django/pull/15117 - Fixed #33310 -- Removed unused rule from admin CSS.
https://github.com/django/django/pull/15112 - Fixed #33298 -- Added docs and tests for using Q objects with get_object_or_404()/get_list_or_404().
https://github.com/django/django/pull/15102 - Fixed #4282 -- Made startapp/startproject management commands honor umask.
https://github.com/django/django/pull/15096 - Fixed #33024 -- Fixed height of admin selector boxes in collapsed fieldset.
https://github.com/django/django/pull/15111 - Fixed #32397 -- Made startapp/startproject management commands set User-Agent.
https://github.com/django/django/pull/15127 - Fixed #33303 -- Changed messages' level tags on MESSAGE_TAGS setting change.
https://github.com/django/django/pull/15106 - Fixed #33301 -- Clarified the type of arguments required by custom assertions.
Authored:
https://github.com/django/django/pull/15113 - Corrected signatures of QuerySet's methods.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/33329 - Allow more whitespace control on template tags (invalid)
https://code.djangoproject.com/ticket/33330 - Printing QuerySet.query from non-default DB can throw an error (duplicate)
https://code.djangoproject.com/ticket/33333 - Models with a BinaryField fail to deepcopy in setUpTestData() on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/33334 - Alphabetize form and model fields in docs. (accepted)
https://code.djangoproject.com/ticket/33336 - Widget.Media.JS ESM support (duplicate)
https://code.djangoproject.com/ticket/33337 - Part of admin template is ignored when deploying (invalid)
https://code.djangoproject.com/ticket/33340 - DatabaseCache backend doesn't quote all fields in queries (accepted)
https://code.djangoproject.com/ticket/33339 - bulk_create() uses TO_CLOB() for NCLOB fields on Oracle. (accepted)
https://code.djangoproject.com/ticket/33338 - Document that @never_cache and add_never_cache_headers() set the Expires header. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/15135 - Fixed #33322 -- Fixed loss of assigned related object when saving relation with bulk_update().
https://github.com/django/django/pull/15136 - Fixed #32545 -- Improved admin widget for raw_id_fields for UUIDFields.
https://github.com/django/django/pull/14776 - Fixed #32800 -- Changed CsrfViewMiddleware not to mask the CSRF secret.
https://github.com/django/django/pull/15137 - Refs #25706 - Removed inline JavaScript from OpenLayers template.
https://github.com/django/django/pull/15134 - Fixed #33047 -- Added constraint support for PostGIS and MySQL GIS backends.
https://github.com/django/django/pull/14899 - Fixed #30398 -- Added CONN_HEALTH_CHECKS database setting.
https://github.com/django/django/pull/15143 - Fixed #33282 -- Fixed a crash when OR'ing subquery and aggregation lookups.
https://github.com/django/django/pull/15145 - Fixed #33334 -- Alphabetized form and model fields in reference docs.
https://github.com/django/django/pull/15146 - Made various GeoIP2 cleanups.
https://github.com/django/django/pull/15149 - Fixed #33339 -- Made QuerySet.bulk_create() use TO_NCLOB() for TextFields on Oracle.
https://github.com/django/django/pull/15098 - Fixed #33078 -- Added support for language regions in i18n_patterns().
https://github.com/django/django/pull/15144 - Fixed #33333 -- Fixed setUpTestData() crash with models.BinaryField on PostgreSQL.
https://github.com/django/djangoproject.com/pull/1125 - Updated download page for 4.0 release.
https://github.com/django/djangoproject.com/pull/1126 - Updated docs-related model fixtures for 4.0 release.
https://github.com/django/django/pull/15153 - Refs #33333 -- Fixed PickleabilityTestCase.test_annotation_with_callable_default() crash on Oracle.
Best,
Mariusz