Django 5.1 - LoginRequiredMiddleware

[אורי‎]

Hi,

I read about LoginRequiredMiddleware in Django 5.1 release notes, where it's written "The new LoginRequiredMiddleware redirects all unauthenticated requests to a login page."

I wanted to check so I installed django-5.1rc1 and I checked static pages without login locally, and they work without change - I'm not redirected to login urls. What am I missing? Is this the expected behavior?

Thanks,

Uri.

אורי

u...@speedy.net

[Adam Johnson]

Did you add the middleware to the MIDDLEWARE setting?

--

You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.

To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABD5YeG2i59m-P%3DB-qBW%3DiVyKNJG71cDE7WKoqz%2BBazHt2dRMw%40mail.gmail.com.

[אורי‎]

אורי

u...@speedy.net

On Tue, Aug 6, 2024 at 8:37 PM 'Adam Johnson' via Django developers (Contributions to Django itself) <django-d...@googlegroups.com> wrote:

Did you add the middleware to the MIDDLEWARE setting?

No. I didn't see in the documentation of LoginRequiredMiddleware any MIDDLEWARE setting.

https://docs.djangoproject.com/en/5.1/ref/middleware/#django.contrib.auth.middleware.LoginRequiredMiddleware

https://docs.djangoproject.com/en/5.1/releases/5.1/#middleware-to-require-authentication-by-default

I thought that LoginRequiredMiddleware is always enabled in Django 5.1.

 

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/c77d5930-8d5b-4fae-85d6-28fd167b72d3%40app.fastmail.com.

[James Bennett]

On Tue, Aug 6, 2024 at 4:37 PM אורי <u...@speedy.net> wrote:

No. I didn't see in the documentation of LoginRequiredMiddleware any MIDDLEWARE setting.

https://docs.djangoproject.com/en/5.1/ref/middleware/#django.contrib.auth.middleware.LoginRequiredMiddleware

https://docs.djangoproject.com/en/5.1/releases/5.1/#middleware-to-require-authentication-by-default

I thought that LoginRequiredMiddleware is always enabled in Django 5.1.

The set of middlewares which will be turned on by default when generating a new project is documented:

https://docs.djangoproject.com/en/5.1/topics/http/middleware/#activating-middleware

Any middleware not listed there needs to be explicitly added to your project's MIDDLEWARE setting before it will have any effect.

I don't see anything in the documentation of LoginRequiredMiddleware which implies that it is enabled by default or will be turned on automatically by upgrading Django. And I think it's highly unlikely the LoginRequiredMiddleware would ever become a default-enabled middleware, since people would probably be upset about suddenly having their sites login-walled by a Django upgrade.

[אורי‎]

אורי

u...@speedy.net

OK, I understand. Thank you. I read the documentation but I misunderstood and thought that LoginRequiredMiddleware is enabled by default.

Uri.

 

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAL13Cg_wEWKBOkjnCzqiMH_n5jyycpgCnBQst84b8twq0Jc7DA%40mail.gmail.com.

[Adam Johnson]

I’ve opened a PR for a small docs tweak that may help clarify the release note: https://github.com/django/django/pull/18455 .

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABD5YeFcD15GAQuFge5wW5-oqTvtcYN-gh%2B%2BcheMfkmpytz%2B%2BA%40mail.gmail.com.

[אורי‎]

Thank you.

אורי

u...@speedy.net

[אורי‎]

Hi,

I read the updated Django 5.1 release notes and I think now it's more clear that LoginRequiredMiddleware is only enabled if we enable it, and is not enabled by default.

Thanks,

Uri.

אורי

u...@speedy.net