Fellow Reports - January 2022

[Mariusz Felisiak]

Week ending January 9, 2022

Triaged:
    https://code.djangoproject.com/ticket/33406 - Micro-optimisation for Value._resolve_output_field (by modifying CharField.__init__) (accepted)
    https://code.djangoproject.com/ticket/33407 - Radiolist etc. styling has changed since it's using div elements not ul elements (accepted)
    https://code.djangoproject.com/ticket/33408 - Adding nullable OneToOneField crashes on SQLite. (accepted)
    https://code.djangoproject.com/ticket/33409 - Django logs out after a redirect with a long Cyrillic message (needsinfo)
    https://code.djangoproject.com/ticket/33410 - captureOnCommitCallbacks executes callbacks multiple times. (accepted)
    https://code.djangoproject.com/ticket/33412 - Postgres db backend does not restart connection after disconnect (duplicate)
    https://code.djangoproject.com/ticket/33415 - @classproperty breakes @abc.abstractmethod (needsinfo)
    https://code.djangoproject.com/ticket/33417 - Made month and year selectable in the admin calender widget. (duplicate)
    https://code.djangoproject.com/ticket/33419 - forms.Field.help_text shouldn't be HTML-escaped when form is rendered with as_ul(), as_p(), as_table(). (created)
    https://code.djangoproject.com/ticket/33420 - Cannot import name RequestSite from partially initialized module. (fixed)
    https://code.djangoproject.com/ticket/33421 - Skip consistency checks on makemigrations (wontfix)
    https://code.djangoproject.com/ticket/33423 - Load urls from function in URLResolver (wontfix)
    https://code.djangoproject.com/ticket/33424 - Jsonfield data being returned as str (duplicate)
    https://code.djangoproject.com/ticket/33425 - Technical 404 debug page reported incorrect view name for CBVs. (created)

Reviewed/committed:
    https://github.com/django/django/pull/15274 - Refs #31026 -- Changed @jinja2_tests imports to be relative.
    https://github.com/django/django/pull/15266 - Refs #29026 -- Allowed customizing InteractiveMigrationQuestioner's prompt destination.
    https://github.com/django/django/pull/15277 - Fixed #33406 -- Avoided creation of MaxLengthValidator(None) when resolving Value.output_field for strings.
    https://github.com/django/django/pull/15268 - Fixed #33402 -- Optimized multiple AlterFooTogether operations.
    https://github.com/django/django/pull/15276 - Avoided suggestion of plain text database password in sessions topic.
    https://github.com/django/django/pull/15269 - Refs #33216 -- Made @deconstructible do not change path for subclasses.
    https://github.com/django/django/pull/15284 - Fixed malformed attribute directives in docs.
    https://github.com/django/django/pull/15280 - Fixed #32511 -- Corrected handling prefetched nested reverse relationships.
    https://github.com/django/django/pull/15267 - Fixed #33400 -- Added support for msg_prefix and count arguments to assertTemplateUsed()/assertTemplateNotUsed() used as context managers.
    https://github.com/django/django/pull/15285 - Fixed #33410 -- Fixed recursive capturing of callbacks by TestCase.captureOnCommitCallbacks().
    https://github.com/django/django/pull/15282 - Refs #33348 -- Deprecated passing errors=None to SimpleTestCase.assertFormError()/assertFormsetErrors().
    https://github.com/django/django/pull/15228 - Avoided isinstance(…, Variable) calls in FilterExpression.resolve().
    https://github.com/django/django/pull/15161 - Fixed #33216 -- Simpilified deconstructed paths for some expressions.
    https://github.com/django/django/pull/15132 - Fixed #28628 -- Changed \d to [0-9] in regexes where appropriate.
    https://github.com/django/django/pull/15289 - Fixed #33419 -- Restored marking forms.Field.help_text as HTML safe.
    https://github.com/django/django/pull/15292 - Fixed #33425 -- Fixed view name for CBVs on technical 404 debug page.

Authored:
    https://github.com/django/django/pull/15278 - Fixed #33408 -- Fixed adding primary keys/unique fields on SQLite.
    https://github.com/django/django/pull/15290 - Refs #32355 -- Removed unnecessary list() calls before reversed() on dictviews.

Week ending January 16, 2022

Triaged:
    https://code.djangoproject.com/ticket/33414 - Diamond inheritance causes duplicated PK error when creating an object, if the primary key field has a default. (accepted)
    https://code.djangoproject.com/ticket/33426 - ResolverMatch repr is incorrect for Class Based Views (accepted)
    https://code.djangoproject.com/ticket/33428 - Confirm support for PostGIS 3.2 (accepted)
    https://code.djangoproject.com/ticket/33429 - Wrong results when using .values().distinct() with default ordering (duplicate)
    https://code.djangoproject.com/ticket/33418 - Alternates does not use langcodes in alternate urls (invalid)
    https://code.djangoproject.com/ticket/33422 - Document @isolate_apps (accepted)
    https://code.djangoproject.com/ticket/33432 - Missing comma in 'How to create CSV output' (accepted)
    https://code.djangoproject.com/ticket/33430 - Calling command via `call_command` with option that is `required` and has set `dest` leads to an error (invalid)
    https://code.djangoproject.com/ticket/33433 - Avoid calling resolve() when unnecessary in technical_404_response (accepted)
    https://code.djangoproject.com/ticket/33434 - Browser font resizing doesn’t work in Django admin due to pixel values (accepted)
    https://code.djangoproject.com/ticket/33435 - Subquery.as_sql() generates invalid SQL. (accepted)
    https://code.djangoproject.com/ticket/33436 - Remove test_restrictions_with_no_joining_columns (wontfix)
    https://code.djangoproject.com/ticket/33439 - SMTPAuthenticationError in EmailMessage/EmailMultiAlternatives when using 'Some Name <em...@gmail.com>'. (invalid)
    https://code.djangoproject.com/ticket/33441 - Model Field.__hash__() should be immutable. (accepted)
    https://code.djangoproject.com/ticket/33440 - Cannot escape % character when using gettext(). (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/15291 - Simplified @stringfilter decorator and Library with unwrap().
    https://github.com/django/django/pull/15297 - Fixed #33426 -- Fixed ResolverMatch.__repr_() for class-based views.
    https://github.com/django/django/pull/15298 - Fixed #33428 -- Confirmed support for PostGIS 3.2.
    https://github.com/django/django/pull/14751 - Fixed #29026 -- Added --scriptable option to makemigrations.
    https://github.com/django/django/pull/15248 - Fixed #13251 -- Made pre/post_delete signals dispatch the origin.
    https://github.com/django/django/pull/15270 - Fixed #11715 -- Changed default value of ModelAdmin.actions/inlines to empty tuples.
    https://github.com/django/django/pull/15304 - Fixed #33432 -- Fixed typo in docs/howto/outputting-csv.txt.
    https://github.com/django/django/pull/15302 - Alphabetized field attributes in form topic docs.
    https://github.com/django/django/pull/15305 - Fixed #33433 -- Avoided unnecessary resolve() calls in technical_404_response().
    https://github.com/django/django/pull/13910 - Added exception to SuspiciousOperation logging.
    https://github.com/django/django/pull/15311 - Refs #33426 -- Simplified technical_404_response() with ResolverMatch._func_path.
    https://github.com/django/django/pull/15310 - Changed django.utils.log.log_response() to take exception instance.
    https://github.com/django/django/pull/15286 - Fixed #33396 -- Added view name to technical 500 debug page.
    https://github.com/django/django/pull/15190 - Improved Model.__init__() properties loop.
    https://github.com/django/django/pull/15139 - Fixed #29708 -- Deprecated PickleSerializer.
    https://github.com/django/django/pull/15256 - Refs #28135 -- Refactored out _find_groups()/_get_group_start_end() hooks in admindocs.
    https://github.com/django/django/pull/15194 - Clarified how contrib.auth picks a password hasher for verification.
    https://github.com/django/django-docker-box/pull/40 - Fixed #29 -- Fixed crash of docs.
    https://github.com/django/django/pull/15315 - Fixed #33441 -- Restored immutability of models.Field.__hash__().
    https://github.com/django/django/pull/15316 - Fixed #28135 -- Made simplify_regex() handle non-capturing groups.

Authored:
    https://github.com/django/django/pull/15300 - Refs #30141 -- Removed unused branch in parse_duration().
    https://github.com/django/django/pull/15307 - Updated Python license for 2022.
    https://github.com/django/django/pull/15308 - Refs #32681 -- Fixed VariableDoesNotExist when rendering some admin template.
    https://github.com/django/asgiref/pull/310 - Added testing for Python 3.10.

Best,
Mariusz

[Mariusz Felisiak]

Week ending January 23, 2022

Triaged:
   https://code.djangoproject.com/ticket/33444 - Add an option with default answer for makemigrations questions. (wontfix)
   https://code.djangoproject.com/ticket/33443 - Conditions when PasswordResetView sends email should be listed more clearly (accepted)
   https://code.djangoproject.com/ticket/33445 - MultiWidget doesn't call subwidgets' render() methods. (needsinfo)
   https://code.djangoproject.com/ticket/23816 - Ability to defer model field by default (wontfix)
   https://code.djangoproject.com/ticket/33446 - ManifestStaticFilesStorage doesn't update CSS source map references (accepted)
   https://code.djangoproject.com/ticket/33448 - timezone difference causes problem with admin panel time (needsinfo)
   https://code.djangoproject.com/ticket/33449 - Migration autodetector crashes on models with field named _order, but not using order_with_respect_to. (accepted)
   https://code.djangoproject.com/ticket/33451 - queryset_object.query results does not add quotes around string values (duplicate)
   https://code.djangoproject.com/ticket/33452 - Save buttons in admin are too close together on medium screen sizes (accepted)
   https://code.djangoproject.com/ticket/33450 - Integer primary key is wrongly casted to UUID when filtering GenericRelation on model with UUID primary key. (accepted)
   https://code.djangoproject.com/ticket/33453 - Drop support for GDAL 2.1. (created)
   https://code.djangoproject.com/ticket/33455 - Missleading error message when running selenium tests without selenium. (accepted)
   https://code.djangoproject.com/ticket/33456 - Make underscore in hostname error more explicit (wontfix)
   https://code.djangoproject.com/ticket/33454 - Django4 does not pick up tests according to tags. (invalid)
   https://code.djangoproject.com/ticket/32088 - Django Database Sessions - Can't Retrieve expire_date from request.session (SessionStore) (wontfix)
   https://code.djangoproject.com/ticket/33458 - Messages framework incorrectly serializes/deserializes extra_tags when it's an empty string (accepted)
   https://code.djangoproject.com/ticket/33457 - Expanding local vars in technical 500 causes horizontal scrolling (accepted)

Reviewed/committed:
   https://github.com/django/django/pull/14847 - Fixed #33443 -- Clarified when PasswordResetView sends an email.
   https://github.com/django/django/pull/15320 - Fixed #33435 -- Fixed invalid SQL generatered by Subquery.as_sql().
   https://github.com/django/django/pull/15329 - Fixed #33446 -- Added CSS source map support to ManifestStaticFilesStorage.
   https://github.com/django/django/pull/15325 - Updated GEOS/GDAL links in docs and comments.
   https://github.com/django/django/pull/13065 - Fixed #31685 -- Added support for updating conflicts to QuerySet.bulk_create().
   https://github.com/django/django/pull/15324 - Fixed #33062 -- Made MultiPartParser remove non-printable chars from file names.
   https://github.com/django/django/pull/15335 - Improved wording in running Django’s test suite in contributing tutorial.
   https://github.com/django/django/pull/15339 - Fixed #33449 -- Fixed makemigrations crash on models without Meta.order_with_respect_to but with _order field.
   https://github.com/django/django/pull/15240 - Fixed #26760 -- Added --prune option to migrate command.
   https://github.com/django/django/pull/15338 - Fixed #33455 -- Improved error message when selenium is not installed.

Reviewed:
   https://github.com/django/django/pull/15344 - Stopped including type="text/css" attributes for CSS link tags.

Authored:
   https://github.com/django/django/pull/11692 - Fixed #29338 -- Allowed using combined queryset in Subquery.
   https://github.com/django/django/pull/15332 - Added tests for SpatialReference.to_esri()/from_esri().
   https://github.com/django/django/pull/15337 - Fixed #33453 -- Dropped support for GDAL 2.1.

Best,
Mariusz

[Mariusz Felisiak]

Week ending January 30, 2022

Triaged:
   https://code.djangoproject.com/ticket/33459 - Explain how to optimize full text search with SearchVectorField and GinIndex (wontfix)
   https://code.djangoproject.com/ticket/33460 - Change SQLite backend to generate INSERT statements using VALUES instead of UNION. (accepted)
   https://code.djangoproject.com/ticket/30209 - Union with group by don't generate correct Subquery (duplicate)
   https://code.djangoproject.com/ticket/29482 - simplify KeyTransform to always use the 'nested_operator' (wontfix)
   https://code.djangoproject.com/ticket/33463 - bulk_update() does not work with plain F('...') expressions. (accepted)
   https://code.djangoproject.com/ticket/33464 - Django db expressions doesn't combine MOD (duplicate)
   https://code.djangoproject.com/ticket/33465 - Introduce empty __slots__ protocol for SafeString & SafeData (accepted)
   https://code.djangoproject.com/ticket/33466 - Specify the order of columns in the table. (invalid)
   https://code.djangoproject.com/ticket/33467 - Small Framework to create Demo-Systems (wontfix)
   https://code.djangoproject.com/ticket/33468 - aggregate() with 'default' after annotate() crashes. (accepted)
   https://code.djangoproject.com/ticket/28949 - Multibyte table name or column name causes miscalculation of the length of index name. (wontfix)
   https://code.djangoproject.com/ticket/33472 - slugify() don't work when used in model's save() method. (worksforme)

Reviewed/committed:
   https://github.com/django/django/pull/15347 - Fixed #33458 -- Fixed encoding of messages with empty string as extra_tags.
   https://github.com/django/django/pull/15348 - Fixed #33457 -- Fixed "Local vars" scrolling in technical 500 debug page.
   https://github.com/django/django/pull/15354 - Fixed #33460 -- Used VALUES clause for insert in bulk on SQLite.
   https://github.com/django/django/pull/15334 - Fixed #29984 -- Added QuerySet.iterator() support for prefetching related objects.
   https://github.com/django/django/pull/15203 - Refs #20349 -- Avoided loading testing libraries when not needed.
   https://github.com/django/django/pull/15159 - Fixed #33048 -- Doc'd that DEBUG static files requests don't use middleware chain.
   https://github.com/django/django/pull/15355 - Used GitHub actions for Windows tests.
   https://github.com/django/django/pull/15362 - Adjusted CBV resolver_match example in testing tools docs.
   https://github.com/django/django/pull/15368 - Fixed #33463 -- Fixed QuerySet.bulk_update() with F() expressions.
   https://github.com/django/django/pull/14725 - Fixed #26142 -- Allowed model formsets to prevent new object creation.
   https://github.com/django/django/pull/15371 - Fixed #33459 -- Clarified index type in full text search docs.
   https://github.com/django/django/pull/15361 - Fixed #33461 -- Escaped template errors in the technical 500 debug page.
   https://github.com/django/django/pull/15370 - Fixed #33465 -- Added empty __slots__ to SafeString and SafeData.
   https://github.com/django/django/pull/15376 - [4.0.x] Updated translations from Transifex.

Reviewed:
   https://github.com/django/django/pull/15333 - Fixed #33407 -- Fixed .radiolist admin CSS.

Authored:
   https://github.com/django/django/pull/15351 - Fixed wrapping of long values in technical 500 debug page.
   https://github.com/django/django/pull/15359 - Fixed wrapping of long messages in the admin.
   https://github.com/django/django/pull/15360 - Increased test coverage for django.contrib.gis.gdal.layer.Layer.
   https://github.com/django/django/pull/15364 - Fixed #33462 -- Fixed migration crash when altering type of primary key with MTI and foreign key.
   https://github.com/django/django/pull/15373 - Fixed #33452 -- Fixed admin change-form layout for submit buttons on mid-sized displays.
   https://github.com/django/django/pull/15375 - Fixed #33468 -- Fixed QuerySet.aggregate() after annotate() crash on aggregates with default.

Best,

Mariusz