Fellow Reports - May 2023

[Mariusz Felisiak]

Week ending May 7, 2023

Released Django 4.2.1, 4.1.9, and 3.2.19.

Triaged:
    https://code.djangoproject.com/ticket/34528 - Reduce Add/RemoveIndex migration operations. (created)
    https://code.djangoproject.com/ticket/34529 - Squashing migrations with Meta.index_together -> indexes transition should remove deprecation warnings. (created)
    https://code.djangoproject.com/ticket/34069 - get_language_from_request should not fallback to settings.LANGUAGE_CODE (duplicate)
    https://code.djangoproject.com/ticket/34532 - Form.default_renderer is ignored in formsets. (accepted)
    https://code.djangoproject.com/ticket/34534 - Reduce index/constraints operations. (accepted)
    https://code.djangoproject.com/ticket/34537 - Add an User inline to the default GroupAdmin (duplicate)
    https://code.djangoproject.com/ticket/34538 - Incorrect query generated with on subquery WHERE depending on the order of the Q() objects (duplicate)
    https://code.djangoproject.com/ticket/34541 - StorageRouter (wontfix)
    https://code.djangoproject.com/ticket/34525 - index_together warning after migration to new style (invalid)
    https://code.djangoproject.com/ticket/34543 - Thousand separator breaking templates (needsinfo)
    https://code.djangoproject.com/ticket/34544 - DBMS_LOB.SUBSTR() is unnecessary for "IS NULL" condition on Oracle. (accepted)
    https://code.djangoproject.com/ticket/34545 - Typo in "FAQ: Installation". (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16809 - Fixed #33759 -- Avoided unnecessary subquery in QuerySet.delete() with self-referential subqueries if supported.
    https://github.com/django/django/pull/16816 - Fixed #34513 -- Added system check for relational fields in ModelAdmin.list_display.
    https://github.com/django/django/pull/16801 - Fixed #34517 -- Avoided connection post_init signal to ImageField without width/height fields.
    https://github.com/django/django/pull/16824 - Fixed #34535 -- Fixed SQLite dbshell crash on pathlib.Path when handling exceptions.
    https://github.com/django/django/pull/16827 - Removed unnecessary workarounds for Sphinx < 4.3.0.
    https://github.com/django/django/pull/16828 - Corrected code-block directives in docs.
    https://github.com/django/djangoproject.com/pull/1356 - Corrected og title and description for teams page.

Authored:
    https://github.com/django/django/pull/16813 - Fixed #34523 -- Fixed TransactionManagementError in QuerySet.update_or_create() with MyISAM storage engine.
    https://github.com/django/django/pull/16819 - Fixed #34528 -- Reduced Add/RemoveIndex operations when optimizing migrations.
    https://github.com/django/django/pull/16820 - Fixed #34529, Refs #34525 -- Reduced index operations with Meta.indexes/index_together when optimizing migrations.
    https://github.com/django/django/pull/16826 - Fixed MultipleFileFieldTest.test_file_multiple_validation() test if Pillow isn't installed.
    https://github.com/django/django/pull/16829 - Refs #27236 -- Made more cosmetic edits to Meta.index_together deprecation.

Best,
Mariusz

[Mariusz Felisiak]

Week ending May 14, 2023

Triaged:
    https://code.djangoproject.com/ticket/34546 - Failed migration yields to unmigratable app:""OperationalError: (1050, "Table '<name>' already exists") (invalid)
    https://code.djangoproject.com/ticket/34547 - Deprecate DatabaseOperations.field_cast_sql(). (created)
    https://code.djangoproject.com/ticket/34549 - Extra select query when parent model consists of primary key only (duplicate)
    https://code.djangoproject.com/ticket/34539 - `get_prep_value` no longer called for JSONField (accepted)
    https://code.djangoproject.com/ticket/34550 - Send email with EMAIL_USE_TLS=True but get SSL error. (duplicate)
    https://code.djangoproject.com/ticket/34551 - Case-When aggregation over aggregated fields doesn't work since 4.2 (accepted)
    https://code.djangoproject.com/ticket/34554 - Reverse(Value(...)) crashes on Oracle. (created)
    https://code.djangoproject.com/ticket/34555 - Dynamic model fields without using a metaclass (invalid)
    https://code.djangoproject.com/ticket/34557 - Time-based model field cleaning and TypeErrors (duplicate)
    https://code.djangoproject.com/ticket/34558 - QuerySet.bulk_create() crashes with Now() on Oracle. (created)
    https://code.djangoproject.com/ticket/34552 - Delaying get_from_clause call as much as possible. (needsinfo)
    https://code.djangoproject.com/ticket/34560 - Update admin's jQuery to 3.7.X. (created)
    https://code.djangoproject.com/ticket/34561 - "DatabaseError: Forced update did not affect any rows" on SessionStore save() (invalid)
    https://code.djangoproject.com/ticket/34564 - returning None instead of zero in Count annotation (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16834 - Fixed #34545 -- Corrected the number of months in installation FAQ.
    https://github.com/django/django/pull/16836 - Refs #34534 -- Reduced Add/RemoveConstraint and Add/RenameIndex operations when optimizing migrations.
    https://github.com/django/django/pull/16840 - Fixed #34553 -- Fixed improper % escaping of literal in constraints.
    https://github.com/django/django/pull/16092 - Fixed #470 -- Added support for database defaults on fields.

Authored:
    https://github.com/django/django/pull/16835 - Fixed #34544 -- Avoided DBMS_LOB.SUBSTR() wrapping with IS NULL condition on Oracle.
    https://github.com/django/django/pull/16842 - Fixed #34554 -- Fixed Reverse(Value(…)) crash on Oracle.

Best,
Mariusz

[Mariusz Felisiak]

Week ending May 21, 2023

Triaged:
    https://code.djangoproject.com/ticket/34565 - Add acheck_password() async method. (accepted)
    https://code.djangoproject.com/ticket/34563 - ManifestStaticFilesStorage support for CSS module scripts in Javascript files. (someday/maybe)
    https://code.djangoproject.com/ticket/34567 - slugify template filter with allow_unicode (duplicate)
    https://code.djangoproject.com/ticket/28056 - Reverse migration for model rename with cross-app ForeignKey fails (duplicate)
    https://code.djangoproject.com/ticket/34570 - QuerySet.defer() raises an AttributeError when the field is ManyToManyField or GenericForeignKey (accepted)
    https://code.djangoproject.com/ticket/34568 - makemigrations --update should respect the --name option. (accepted)
    https://code.djangoproject.com/ticket/34572 - Confirm/Add support for GDAL 3.7. (created)
    https://code.djangoproject.com/ticket/34521 - Use __slots__ for template Node classes (wontfix)
    https://code.djangoproject.com/ticket/34573 - Typo in "Writing your first Django app, part 5" - assertQuerysetEqual() (invalid)
    https://code.djangoproject.com/ticket/34574 - Extend docs for `autoescape` and `escape` with examples using filters that operate with sequences (accepted)
    https://code.djangoproject.com/ticket/34577 - New template filter `escapeseq` (accepted)
    https://code.djangoproject.com/ticket/34579 - Documentation points to `django-developers` mailing list as primary point of contact for discussion (accepted)
    https://code.djangoproject.com/ticket/34578 - Template filter `join` should not escape the joining string if `autoescape` is `off` (accepted)
    https://code.djangoproject.com/ticket/34585 - Can we use Class with urlpatterns attribute for parameter in include method? (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/16858 - Fixed #34539 -- Restored get_prep_value() call when adapting JSONFields.
    https://github.com/django/django/pull/16862 - Fixed #34570 -- Silenced noop deferral of many-to-many and GFK.
    https://github.com/django/django/pull/16869 - Avoided parallel assignment in template classes.
    https://github.com/django/django/pull/16855 - Fixed #34565 -- Added support for async checking of user passwords.
    https://github.com/django/django/pull/16873 - Fixed #34578 -- Made "join" template filter respect autoescape for joiner.
    https://github.com/django/django/pull/16800 - Refs #31949 -- Made @xframe_options_(deny/sameorigin/exempt) decorators to work with async functions.

Reviewed:
    https://github.com/django/django/pull/16805 - Fixed #34521 -- Used __slots__ for more template classes.

Authored:
    https://github.com/django/djangoproject.com/pull/1359 - Fixed Stripe webhooks crash when object is empty.
    https://github.com/django/django/pull/16865 - Fixed #34568 -- Made makemigrations --update respect --name option.

Best,

Mariusz

[Mariusz Felisiak]

Week ending May 28, 2023

Triaged:
    https://code.djangoproject.com/ticket/34588 - 404 error in default_urlconf.html (accepted)
    https://code.djangoproject.com/ticket/34589 - exclude does not support nested ForeignKey relationship (invalid)
    https://code.djangoproject.com/ticket/34586 - create() does not save reverse OneToOne relationship nor raise an Exception (accepted)
    https://code.djangoproject.com/ticket/34593 - Django admin list does same Count query twice when there are no filters (wontfix)
    https://code.djangoproject.com/ticket/34594 - KT doesn’t work across foreign keys (wontfix)
    https://code.djangoproject.com/ticket/34595 - format_html() should explicitely mention format_string is not escaped. (accepted)
    https://code.djangoproject.com/ticket/34596 - subclassing models.TextChoices (invalid)
    https://code.djangoproject.com/ticket/34598 - Load new settings after start up (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/16882 - Fixed #34580 -- Avoided unnecessary computation of selected expressions in SQLCompiler.
    https://github.com/django/django/pull/16877 - Fixed #34577 -- Added escapeseq template filter.
    https://github.com/django/django/pull/16884 - Fixed #34588 -- Removed usage of nonexistent stylesheet in the 'Congrats' page.
    https://github.com/django/django/pull/16885 - Fixed references to django.core.cache in docs.
    https://github.com/django/django/pull/16883 - Fixed #34587 -- Allowed customizing table name normalization in inspectdb command.
    https://github.com/django/django/pull/16878 - Fixed #34579 -- Added Django Forum to contributing guides.
    https://github.com/django/django/pull/16879 - Fixed #34551 -- Fixed a crash on combined aggregation over a subquery.
    https://github.com/django/django/pull/16874 - Refs #31949 -- Made @no_append_slash decorator to work with async functions.
    https://github.com/django/django/pull/16889 - Corrected documentation of Log database function.
    https://github.com/django/django/pull/16893 - Fixed #34592 -- Removed Safari/Chrome workaround for system fonts.
    https://github.com/django/django/pull/16888 - Fixed #34590 -- Reverted "Refs #33308 -- Improved adapting DecimalField values to decimal."
    https://github.com/django/django/pull/16892 - Made MigrationRecorder cache has_table() result if django_migrations table exists.
    https://github.com/django/django/pull/16871 - Fixed #34574 -- Noted unexpected outcomes in autoescape/escape docs.

Authored:
    https://github.com/django/django/pull/16887 - Refs #34118 -- Fixed FunctionalTests.test_cached_property_reuse_different_names() on Python 3.12+.
    https://github.com/django/django/pull/16898 - Optimized @condition decorator a bit.

Best,
Mariusz

[Mariusz Felisiak]

Week ending June 4, 2023

I was in Edinburgh 🏴󠁧󠁢󠁳󠁣󠁴󠁿 and participated in the DjangoCon Europe conference.

Triaged:
    https://code.djangoproject.com/ticket/34600 - Review reference to bleach in docs (accepted)
    https://code.djangoproject.com/ticket/34603 - ~Q() incorrectly interpreted as full rather than empty (wontfix)
    https://code.djangoproject.com/ticket/34606 - Right() function on Oracle and SQLite returns improper value when the length is zero. (accepted)
    https://code.djangoproject.com/ticket/34604 - On databases lacking XOR, Q(…) ^ Q(…) ^ Q(…) wrongly interpreted as exactly-one rather than parity (accepted)
    https://code.djangoproject.com/ticket/34597 - Queryset (split) exclude's usage of Exists is significantly slower than subquery (accepted)
    https://code.djangoproject.com/ticket/34609 - Deprecate format_html calls without args or kwargs (accepted)
    https://code.djangoproject.com/ticket/34611 - Support getting None in qs.get() (duplicate)
    https://code.djangoproject.com/ticket/34612 - QuerySet.only() doesn't work with select_related() on a reverse OneToOneField relation. (accepted)
    https://code.djangoproject.com/ticket/34615 - queryset.order_by().first() is not consistent with other queryset behaviours (wontfix)
    https://code.djangoproject.com/ticket/34616 - Incorrect code example in 5.0 release notes (accepted)
    https://code.djangoproject.com/ticket/34618 - Admin action log entry types should be communicated to screen reader users (accepted)
    https://code.djangoproject.com/ticket/34613 - add support for Partitioned cookies (needsinfo)
    https://code.djangoproject.com/ticket/34619 - Ensures select element has an accessible name (accepted)
    https://code.djangoproject.com/ticket/34620 - Serialization of m2m relation fails with custom manager using select_related (accepted)
    https://code.djangoproject.com/ticket/34623 - Swappable dependencies always depend on first migration of app (duplicate)
    https://code.djangoproject.com/ticket/34622 - RelatedFieldWidgetWrapper links don’t convey their state for screen reader users (accepted)
    https://code.djangoproject.com/ticket/34626 - Documentation: "Writing your first patch for Django" - Example test file "test_make_toast.py" is not loaded by test suite (invalid)
    https://code.djangoproject.com/ticket/34625 - FilteredSelectMultiple widget’s elements aren’t labelled (accepted)
    https://code.djangoproject.com/ticket/34630 - Neither `pgettext` nor `pgettext_lazy` return contextual markers in PO files (worksforme)

Reviewed/committed:
    https://github.com/django/django/pull/16907 - Fixed #34600 -- Removed references to bleach in docs.
    https://github.com/django/django/pull/16902 - Fixed #34606 -- Fixed Right() function with zero length on Oracle and SQLite.

    https://github.com/django/django/pull/16912 - Fixed #34616 -- Corrected label examples in 5.0 release notes.
    https://github.com/django/django/pull/16913 - Fixed #34595 -- Doc'd that format_string arg to format_html() is not escaped.
    https://github.com/django/django/pull/16914 - Fixed #34617 -- Enabled user zooming on mobile devices in the admin.
    https://github.com/django/django/pull/16915 - Added local copy of Django to deps in tox.ini.
    https://github.com/django/django/pull/16910 - Fixed #34612 -- Fixed QuerySet.only() crash on reverse relationships.
    https://github.com/django/django/pull/16917 - Fixed #34618 -- Added icon descriptions in "Recent Actions" on the admin index.
    https://github.com/django/django/pull/16861 - Fixed #23528 -- Doc'd django.db.migrations.swappable_dependency().

Authored:
    https://github.com/django/django/pull/16936 - Refs #23528 -- Made cosmetic edits to swappable_dependency() docs.
    https://github.com/django/django/pull/16938 - Fixed #34620 -- Fixed serialization crash on m2m fields without natural keys when base querysets use select_related().

Best,
Mariusz