Fellow Reports - March 2024
Mariusz Felisiak
Week ending March 10
Triaged:
https://code.djangoproject.com/ticket/35268 - Migrations raise
UnicodeDecodeError on PostgreSQL. (needsinfo)
https://code.djangoproject.com/ticket/35266 - Optimize
RelatedField._check_clashes() (accepted)
https://code.djangoproject.com/ticket/35267 - Correct
TIME_ZONE setting reference in time zone topic. (accepted)
https://code.djangoproject.com/ticket/35269 - GeneratedFields
can't be defined on RelatedFields (needsinfo)
https://code.djangoproject.com/ticket/35275 - Constraints
validation fails on UniqueConstraint using OpClass (accepted)
https://code.djangoproject.com/ticket/35277 - Issue with the
new "formset:added" event (invalid)
https://code.djangoproject.com/ticket/35279 - Memory Leak with
`prefetch_related` (accepted)
https://code.djangoproject.com/ticket/35280 - iriencode
example incorrect (accepted)
https://code.djangoproject.com/ticket/35283 - Dynamic admin
site titles (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/17931 - Refs #9847 --
Added tests for handler403 resolution.
https://github.com/django/django/pull/17930 - Fixed #35265 --
Added AdminSite tests for changing titles.
https://github.com/django/django/pull/17927 - Refs #21286 --
Removed invalid commented out models and tests from serializer
tests.
https://github.com/django/django/pull/17926 - Fixed #35261 --
Corrected Media JS example of object-based paths in docs.
https://github.com/django/django/pull/17932 - Fixed #35266 --
Deferred formatting in RelatedField._check_clashes().
https://github.com/django/django/pull/17938 - Fixed #35267 --
Clarified time zone topic for PostgreSQL in docs.
https://github.com/django/django/pull/17908 - Fixed #35252 --
Optimized _route_to_regex().
https://github.com/django/django/pull/17940 - Updated broken
links in docs/ref/contrib/gis/tutorial.txt.
https://github.com/django/django/pull/17810 - Fixed #35021 --
Fixed capturing queries when using client-side parameters binding
with psycopg 3+.
https://github.com/django/django/pull/17947 - Refs #30397 --
Optimized interpolation of index and constraint names a bit.
https://github.com/django/django/pull/17942 - Fixed typos in
docstrings and docs.
https://github.com/django/django/pull/17621 - Fixed #35030 --
Made django.contrib.auth decorators to work with async functions.
https://github.com/django/django/pull/17951 - Refs #30397 --
Optimized interpolation of index and constraint names a bit more.
https://github.com/django/django/pull/17939 - Fixed #35223 --
Made Model.full_clean() ignore fields with db_default when
validating empty values.
https://github.com/django/django/pull/17831 - Fixed #35044 --
Avoided clearing reverse relations and private fields when
accessing deferred fields.
https://github.com/django/django/pull/17936 - Fixed #35270 --
Optimized model's Options._property_names.
https://github.com/django/django/pull/17956 - Moved --failfast
to DiscoverRunner.
https://github.com/django/django/pull/17959 - Fixed #35280 --
Improved iriencode filter example in docs.
https://github.com/django/django/pull/17961 - Fixed #35286 --
Updated broken link in django/template/smartif.py docstring.
https://github.com/django/django/pull/17962 - Applied
BoundingCircle test to only one country.
Authored:
https://github.com/django/django/pull/17935 - Updated fuzzy
translations in tests.i18n.patterns.
https://github.com/django/django/pull/17937 - Used
sys_platform in tests requirements.
https://github.com/django/django/pull/17941 - Fixed broken
links and redirects in docs.
https://github.com/django/django/pull/17943 - Refs #35030 --
Added more tests for @user_passes_test decorator.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/35287 - manage createsuperuser too restrictive (duplicate)
https://code.djangoproject.com/ticket/35291 - Whitenoise Not Working when DEBUG = FALSE - Django - Hosting Static Files (duplicate)
https://code.djangoproject.com/ticket/35290 - Whitenoise Not Working when DEBUG = FALSE - Django - Hosting Static Files (invalid)
https://code.djangoproject.com/ticket/35295 - Use INSERT with multiple rows on Oracle 23c+ (created)
https://code.djangoproject.com/ticket/35296 - The autoescape parameter to Engine() seems to have no effect on Context. (invalid)
https://code.djangoproject.com/ticket/35294 - Queryset explain can be truncated. (accepted)
https://code.djangoproject.com/ticket/35299 - Remove ValueError in Create method with OneToOne relation (duplicate)
https://code.djangoproject.com/ticket/35300 - Simple COUNT without OUTER JOIN (invalid)
https://code.djangoproject.com/ticket/35301 - Overriding a @property of an abstract model with a GenericRelation causes a models.E025 error. (accepted)
https://code.djangoproject.com/ticket/35303 - Add async implementations to contrib.auth backends (accepted)
https://code.djangoproject.com/ticket/35302 - Property on AppConfig and ModelAdmin for ordering apps and models in admin sidebar (wontfix)
https://code.djangoproject.com/ticket/35309 - Remove Order by on models when prefetching by id (wontfix)
https://code.djangoproject.com/ticket/35307 - make async generic views (invalid)
https://code.djangoproject.com/ticket/35305 - No-op rename of field with `db_column` drops and recreates constraints/indexes. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17957 - Fixed #35285 -- Optimized ForeignObject._check_unique_target().
https://github.com/django/django/pull/17958 - Fixed #25595 -- Doc'd that URLValidator rejects file:// URIs without a host.
https://github.com/django/django/pull/17928 - Fixed #14831 -- Extended template style guide in docs.
https://github.com/django/django/pull/17372 - Fixed #34901 -- Added async-compatible interface to session engines.
https://github.com/django/django/pull/17971 - Refs #30686 -- Made django.utils.html.VOID_ELEMENTS a frozenset.
https://github.com/django/django/pull/17946 - Fixed #35273 -- Fixed rendering AdminFileWidget's attributes.
https://github.com/django/django/pull/17950 - Fixed #28541 -- Fixed migrations crash when changing primary key on SQLite.
https://github.com/django/django/pull/17973 - Fixed #35294 -- Fixed TEXT format of QuerySet.explain() for long plans.
https://github.com/django/django/pull/17985 - Fixed #35301 -- Fixed Options._property_names for overriden properties.
Authored:
https://github.com/django/django/pull/17964 - Optimized DatabaseOperations.bulk_insert_sql() a bit on Oracle.
https://github.com/django/django/pull/17966 - Used SessionBase.__setitem__() in setdefault().
https://github.com/django/django/pull/17968 - Removed unused clean() method in file-based session.
https://github.com/django/django/pull/17969 - Fixed #35295 -- Used INSERT with multiple rows on Oracle 23c.
https://github.com/django/django/pull/17970 - Refs #32673, Refs #35295 -- Avoided wrapping rhs direct values in lookups.
https://github.com/django/django/pull/17979 - Refs #34900 -- Fixed SafeMIMEText.set_payload() crash on Python 3.13.
https://github.com/django/django/pull/17980 - Refs #33996 -- Updated CheckConstraint validation on NULL values on Oracle 23c+.
https://github.com/django/django/pull/17982 - Stopped skipping model_fields.test_jsonfield.TestQuerying.test_usage_in_subquery on Oracle 23c.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/35312 - FileNotFoundError escapes from run_formatters() (invalid)
https://code.djangoproject.com/ticket/34059 - Validation of check constraints on JSONField key transforms with None produces invalid SQL on PostgreSQL. (fixed)
https://code.djangoproject.com/ticket/35316 - Support scalars as query parameters in admin changelist filters (for backward compatibility). (wontfix)
https://code.djangoproject.com/ticket/35318 - QuerySet.exclude() docs contain a potentially misleading statement regarding the restrictiveness of examples. (invalid)
https://code.djangoproject.com/ticket/35319 - Move the link to add a related object inside the .selector-available column for FilteredSelectMultiple. (accepted)
https://code.djangoproject.com/ticket/35317 - Add the possibility to do prefetches for only a subset of instances (wontfix)
https://code.djangoproject.com/ticket/35321 - Django Admin in Mobile Safari zooms in on text inputs (accepted)
https://code.djangoproject.com/ticket/35320 - Remove unnecessary django.core.files.move._samefile() hook. (accepted)
https://code.djangoproject.com/ticket/35325 - CharField max_length ignored (duplicate)
https://code.djangoproject.com/ticket/35327 - Add note to create custom user model in tutorial (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/17963 - Refs #31014 -- Added srid argument to FromWKB/FromWKT() GIS functions.
https://github.com/django/django/pull/17984 - Fixed #35309 -- Made prefetch clear ordering for single-valued relationships.
https://github.com/django/django/pull/17916 - Fixed #35257 -- Corrected resolving output_field for IntegerField/DecimalField with NULL.
https://github.com/django/code.djangoproject.com/pull/188 - Fixed #187 -- Restored support for restructuredtext on wiki pages.
https://github.com/django/django/pull/18000 - Fixed #35320 -- Removed unnecessary django.core.files.move._samefile() hook.
https://github.com/django/django/pull/17266 - Fixed #34841 -- Avoided rendering apps on state still requiring mutation.
https://github.com/django/django/pull/18001 - Fixed #35323 -- Prevented file_move_safe() from trying to overwrite existing file when allow_overwrite is False.
Reviewed:
https://github.com/django/django/pull/17545 - Updated docs for Django releases, including details about fetching and processing translations.
Authored:
https://github.com/django/django/pull/17988 - Stopped using byte-compiled 3rd-party packages in daily builds for byte-compiled Django.
https://github.com/django/django/pull/17989 - Refs #34059, Refs #34060 -- Removed outdated warning about validation of JSONField constraints.
https://github.com/django/django/pull/17993 - Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
https://github.com/django/django/pull/17997 - Fixed ResourceWarning from unclosed SQLite connection in test_utils on Python 3.13+.
https://github.com/django/django/pull/18004 - Added ModelState.from_model() test for abstract model with unnamed indexes.
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/35330 - The update of related objects fails in the admin when the related model is camel case. (accepted)
https://code.djangoproject.com/ticket/35331 - Adding a new related entry using the "+" sign from M2M field doesn't update lists. (accepted)
https://code.djangoproject.com/ticket/35332 - Bad performance in django.template.load.render_to_string (needsinfo)
Reviewed/committed:
https://github.com/django/django/pull/17981 - Fixed #35233 -- Moved template engine system checks to backend methods.
Authored:
https://github.com/django/djangoproject.com/pull/1494 - Retired myself.
https://github.com/django/django/pull/18015 - Increased test coverage for django.db.migrations.operations.special.
https://github.com/django/django/pull/18016 - Removed unused _alter_column_collation_sql() in PostgreSQL DatabaseSchemaEditor.
https://github.com/django/django/pull/18022 - Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct.
https://github.com/django/django/pull/18030 - Refs #35234 -- Skipped CheckConstraint system checks if not supported.
Best,
