Fellow Reports - October 2019

[Mariusz Felisiak]

Week ending October 6, 2019.

Triaged:

https://code.djangoproject.com/ticket/30817 - Document that Sitemap.items() can return an iterable. (accepted)
https://code.djangoproject.com/ticket/30818 - Django can't handle m2m relations well sometimes. (invalid)
https://code.djangoproject.com/ticket/30816 - Clarify how to test changes with an existing Django project. (accepted)
https://code.djangoproject.com/ticket/28726 - Brackets illegal in DEFAULT_FROM_EMAIL name part. (fixed)
https://code.djangoproject.com/ticket/30820 - DateRange__contains does not work as filter. (worksforme)

https://code.djangoproject.com/ticket/30822 - Oracle Bulk Create TextField fails when there is a mix of short and long string. (duplicate)
https://code.djangoproject.com/ticket/30823 - Postgres + Django. (invalid)
https://code.djangoproject.com/ticket/30821 - Add "iso_week_day" lookup type to DateField/DateTimeField. (accepted)
https://code.djangoproject.com/ticket/30819 - Locales that prioritize 2-digit years shows invalid year in admin date picker. (accepted)
https://code.djangoproject.com/ticket/30824 - Test Cases for Multi-db and unmanged models are failing. (invalid)
https://code.djangoproject.com/ticket/14722 - @last_modified should ignore lack of etag method when USE_ETAGS is enabled. (wontfix)
https://code.djangoproject.com/ticket/30826 - Chaining __contains lookup with JSONField key transforms crashes. (accepted)
https://code.djangoproject.com/ticket/30010 - Add support for running the test suite through docker with docker-compose (fixed)
https://code.djangoproject.com/ticket/30831 - Django doesn't respect overriding the maxlength widget attribute for CharFields in ModelForm. (invalid)
https://code.djangoproject.com/ticket/30832 - django custom relationship (duplicate)
https://code.djangoproject.com/ticket/30833 - Use field label when available to display errors in forms. (invalid)
https://code.djangoproject.com/ticket/30834 - Supported databases should be listed above the fold. (accepted)
https://code.djangoproject.com/ticket/30836 - Installation FAQ needs some copy editing. (invalid)
https://code.djangoproject.com/ticket/30838 - Please modify message about unapplied migrations. (wontfix)
https://code.djangoproject.com/ticket/30841 - Using __isnull lookup to a non-boolean value doesn't promote join. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/11846 - Doc'd that migrate commmand accepts a unique migration name prefix.
https://github.com/django/django/pull/11815 - Fixed #30774 -- Made serialization in migrations use members names for Enums.
https://github.com/django/django/pull/11848 - Fixed #28690 -- Fixed handling of two-digit years in parse_http_date().

https://github.com/django/django/pull/11857 - Fixed #30510 -- Fixed crash of QuerySet.bulk_create() with mixed-length texts on Oracle.
https://github.com/django/django/pull/11808 - Fixed #30651 -- Made __eq__() return NotImplemented for not implemented comparisons.
https://github.com/django/django/pull/11856 - Fixed #30821 -- Added ExtractIsoWeekYear database function and iso_week_day lookup.
https://github.com/django/django/pull/11855 - Fixed #30817 -- Clarified return value of Sitemap.items().
https://github.com/django/django/pull/11738 - Refs #28699 -- Clarified CSRF middleware ordering in relation to RemoteUserMiddleware.
https://github.com/django/django/pull/11838 - Refs #30010 -- Doc'd running tests with django-docker-box.
https://github.com/django/django/pull/11827 - Refs #15396 -- Mentioned full path to GZipMiddleware in documentation.
https://github.com/django/django/pull/11858 - Refs #27914 -- Fixed serialization of nested enum.Enum classes in migrations.
https://github.com/django/django/pull/11867 - Fixed #30834 -- Added explicit list of supported databases to the databases docs.
https://github.com/django/django/pull/11868 - Made minor edits and small fixes to docs/faq/install.txt.

Reviewed:

https://github.com/django/django/pull/11416 - Fixed #30510 -- Adjust Oracle bulk insert column types to match.

Authored:

https://github.com/jazzband/django-formtools/pull/152 - Refs #151 -- Implemented Jazzband guidelines.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending October 13, 2019.

Triaged:

https://code.djangoproject.com/ticket/30845 - Simple explanation of default app folder structure. (invalid)
https://code.djangoproject.com/ticket/30844 - Add after_db_init() hook method to model (wontfix)
https://code.djangoproject.com/ticket/30843 - New argument for FileField and descendants: size_field. (wontfix)
https://code.djangoproject.com/ticket/30839 - Form Field’s __deepcopy__ does not (deep)copy the error messages. (accepted)
https://code.djangoproject.com/ticket/30841 - Prevent using __isnull lookup with non-boolean value. (accepted)
https://code.djangoproject.com/ticket/30847 - Geodjango not respecting spatial_index=False. (worksforme)
https://code.djangoproject.com/ticket/30848 - GeoDjango GeometryZ Field Wanted. (wontfix)
https://code.djangoproject.com/ticket/30850 - Overriding the default admin requires the custom admin site not to be in admin.py. (duplicate)
https://code.djangoproject.com/ticket/30846 - postgis backend doesn't respect custom index names. (accepted)
https://code.djangoproject.com/ticket/30851 - Humanize isn't fully translated into Armenian. (invalid)
https://code.djangoproject.com/ticket/30853 - field__foo__contains dont work in 2.2.6 on JSONField (duplicate)
https://code.djangoproject.com/ticket/30854 - Selecting multiple FilteredRelation's returns only the last one. (accepted)
https://code.djangoproject.com/ticket/30855 - JSON has_key causes 'TypeError: can only concatenate tuple (not "list") to tuple' in Django 2.2.6 (duplicate)
https://code.djangoproject.com/ticket/30857 - When subclassing a model field, max_length cannot be passed as an argument to __init__(). (invalid)
https://code.djangoproject.com/ticket/30863 - Queryset __repr__ can overload a database server in some cases. (duplicate)
https://code.djangoproject.com/ticket/29241 - ConditionalGetMiddleware and x-sendfile. (wontfix)
https://code.djangoproject.com/ticket/30870 - "migrate --plan" outputs "IRREVERSIBLE" on RunPython operations without docstrings. (accepted)
https://code.djangoproject.com/ticket/30869 - Setting to confirm destructive/weird migrations. (wontfix)
https://code.djangoproject.com/ticket/30871 - override_settings() does not restore partially deleted settings. (invalid)
https://code.djangoproject.com/ticket/30868 - ForeignKey's to_field parameter gets the old field's name when renaming a PrimaryKey. (accepted)
https://code.djangoproject.com/ticket/30873 - I'm looking option to get the selected value from MultipleChoiceField (invalid)

Reviewed/committed:

https://github.com/django/django/pull/11851 - Refs #10348 -- Doc'd that ModelAdmin ignores list_select_related when QuerySet.select_related() was already called.
https://github.com/django/django/pull/11871 - Fixed #28273 -- Doc'd fast nullable column creation with defaults.
https://github.com/django/django/pull/11880 - Fixed #30839 -- Fixed Field.__deepcopy__() so forms don't share error messages.
https://github.com/django/django/pull/11445 - Fixed #28790 -- Doc'd how to avoid running certain test classes in parallel.
https://github.com/django/django/pull/11888 - Improved performance of django.template.base.Parser.
https://github.com/django/django/pull/11885 - Fixed #30856 -- Combined fast-delete queries by model during cascade deletion.
https://github.com/django/django/pull/11887 - Fixed #30860 -- Disabled unneeded NULLS FIRST/LAST workaround on SQLite 3.30+.
https://github.com/django/django/pull/11884 - Fixed #11097 -- Added note about parent link fields in formsets for multi-table inheritance models.
https://github.com/django/django/pull/11141 - Fixed #30300 -- Allowed migrations to be loaded from directories without __init__.py files.
https://github.com/django/django/pull/11891 - Fixed #30812 -- Made ConditionalGetMiddleware set ETag only for responses with non-empty content.
https://github.com/django/django/pull/11829 - Fixed #23755 -- Added support for multiple field names in the no-cache Cache-Control directive to patch_cache_control().
https://github.com/django/django/pull/11901 - Fixed #30854 -- Fixed QuerySet.select_related() with multiple FilteredRelations.
https://github.com/django/django/pull/11863 - Fixed #30826 -- Fixed crash of many JSONField lookups when one hand side is key transform.
https://github.com/django/django/pull/11003 - Fixed #30014 -- Fixed ModelChoiceField validation when initial value is a model instance.
https://github.com/django/django/pull/11760 - Clarified that SECURE_REDIRECT_EXEMPT patterns should not include leading slashes.

Reviewed:

https://github.com/django/django/pull/11892 - Refs #27086 -- Corrections to unit testing contributor docs.

Authored:

https://github.com/django/django/pull/11890 - Refs #26608 -- Refs #26608 -- Fixed DatabaseFeatures.supports_frame_range_fixed_distance on SQLite 3.28+, MariaDB 10.2+, and MySQL 8.0.2+.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending October 20, 2019.

Released Django 3.0.b1.

Triaged:

https://code.djangoproject.com/ticket/30877 - User Password Automatically changes after 15 days. (invalid)
https://code.djangoproject.com/ticket/30876 - Move classproperty to the django.utils.functional. (accepted)
https://code.djangoproject.com/ticket/30878 - Django catched a request error when deploy nameserver to IP. (invalid)
https://code.djangoproject.com/ticket/30880 - Optimize the _tx_resource_for_name() function in django/scripts/manage_translations.py (wontfix)
https://code.djangoproject.com/ticket/24042 - Custom AutoField fields do not work correctly on postgres. (fixed)
https://code.djangoproject.com/ticket/30879 - Nested foreign key test failures in 3.0~beta1. (invalid)
https://code.djangoproject.com/ticket/30882 - Promote that Django already drop Python 2.7 support. (invalid)
https://code.djangoproject.com/ticket/30885 - Drop support for MariaDB 10.1. (created)
https://code.djangoproject.com/ticket/30886 - Bug in TestCase tutorial. (invalid)
https://code.djangoproject.com/ticket/30890 - Support relate spatial lookup on MariaDB 10.1+. (created)
https://code.djangoproject.com/ticket/30889 - gis.measure: Distance/Distance should error. (wontfix)
https://code.djangoproject.com/ticket/30891 - Convert a Dictionary Into Query-Set and Perform All Orm Queries into it without hitting database. (wontfix)
https://code.djangoproject.com/ticket/30893 - Django tutorial part 3 documentation minor fix. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/11910 - Fixed #30868 -- Prevented unnecessary AlterField when renaming a referenced pk.
https://github.com/django/django/pull/11872 - Fixed #30808 -- Added the Django Forum to contributing index.
https://github.com/django/django/pull/11906 - Fixed #30816 -- Doc'd how to create projects with a local copy of Django.
https://github.com/django/django/pull/11903 - Fixed #30872 -- Improved unknown command message when settings are manually configured.
https://github.com/django/django/pull/11847 - Refs #28816 -- Prevented silencing data loss when decreasing CharField.max_length for ArrayField.base_field on PostgreSQL.
https://github.com/django/django/pull/11935 - Fixed #28337 -- Preserved extra headers of requests made with django.test.Client in assertRedirects().
https://github.com/django/django/pull/7436 - Fixed #27391 -- Implemented SimpleTestCase.debug().

Reviewed:

https://github.com/django/django/pull/11452 - Fixed #12990 -- Added JSONField model field.

Authored:

https://github.com/django/django/pull/11911 - Fixed #30870 -- Fixed showing that RunPython operations are irreversible by migrate --plan.
https://github.com/django/django/pull/11922 - Fixed #30859 -- Fixed DatabaseFeatures.supports_aggregate_filter_clause on SQLite 3.30.1+.
https://github.com/django/django/pull/11925 - Refs #28436 -- Corrected docs regarding MySQL support of distance lookups.
https://github.com/django/django/pull/11927 - Fixed #30562 -- Doc'd MariaDB support for GIS spatial lookups.
https://github.com/django/django/pull/11928 - Fixed #30885 -- Dropped support for MariaDB 10.1.
https://github.com/django/django/pull/11933 - Fixed #30890 -- Added MariaDB support for the relate lookup.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending October 27, 2019.

Triaged:

https://code.djangoproject.com/ticket/30892 - slugify() doesn't return a valid slug for "İ". (accepted)
https://code.djangoproject.com/ticket/30898 - Multi FormSet form Error object has no attribute instance. (invalid)
https://code.djangoproject.com/ticket/30896 - "OperationalError: (1054, "Unknown column ...)" error when running migrations on an empty MySQL database. (needsinfo)
https://code.djangoproject.com/ticket/30897 - Improved QuerySet.explain() for newer versions of MariaDB and MySQL. (accepted)
https://code.djangoproject.com/ticket/29926 - Python 3.8 compatibility (accepted)
https://code.djangoproject.com/ticket/30899 - Lazily compile regular expressions. (accepted)
https://code.djangoproject.com/ticket/30900 - ASGI and async tests are failing on Python 3.8 and Windows. (created)
https://code.djangoproject.com/ticket/30905 - render() got an unexpected keyword argument 'renderer'. (invalid)
https://code.djangoproject.com/ticket/30903 - Creating an index with specified ordering and opclass results in syntax error. (accepted)
https://code.djangoproject.com/ticket/30907 - SplitArrayField.has_changed() returns True for unchanged fields when using remove_trailing_nulls. (accepted)
https://code.djangoproject.com/ticket/30908 - FilePathField raises FileNotFoundError for nonexistent path. (accepted)
https://code.djangoproject.com/ticket/30914 - Queryset errors on any operation. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/11905 - Fixed #30841 -- Deprecated using non-boolean values for isnull lookup.
https://github.com/django/django/pull/11945 - Fixed #30876 -- Moved classproperty() decorator to the django.utils.functional.
https://github.com/django/django/pull/11861 - Fixed #30827 -- Made batch_size arg of QuerySet.bulk_create() respect DatabaseOperations.bulk_batch_size().
https://github.com/django/django/pull/11916 - Fixed #20577 -- Deferred filtering of prefetched related querysets.
https://github.com/django/django/pull/11959 - Refs #26601 -- Removed obsolete workarounds for MIDDLEWARE_CLASSES setting.
https://github.com/django/django/pull/10606 - Fixed #29919 -- Fixed RelatedOnlyFieldListFilter crash with reverse relationships.
https://github.com/django/django/pull/11966 - Fixed #30903 -- Fixed migrations crash on PostgreSQL when adding Index with opclasses and ordering.
https://github.com/django/django/pull/11931 - Fixed #23576 -- Implemented multi-alias fast-path deletion in MySQL backend.
https://github.com/django/django/pull/11956 - Refs #29926 -- Added Python 3.8 to classifiers and tox.ini.
https://github.com/django/django/pull/11955 - Fixed #30897 -- Improved QuerySet.explain() for newer versions of MariaDB, MySQL and PostgreSQL.
https://github.com/django/django/pull/11971 - Fixed #30906 -- Fixed an example of using the template system to generate CSV.
https://github.com/django/django/pull/11972 - Fixed #30904 -- Doc'd caveat about using filtered queryset with select_for_update() on MySQL.
https://github.com/django/django/pull/11964 - Fixed #30902 -- Added __str__() for model choice enums.
https://github.com/django/django/pull/10403 - Fixed #29770 -- Added LinearRing.is_counterclockwise property.

Authored:

https://github.com/django/django/pull/11961 - Refs #29926 -- Skipped RemoteTestResultTest.test_add_failing_subtests() on Python 3.8+ and tblib <= 1.4.0.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending November 3, 2019.

Triaged:

https://code.djangoproject.com/ticket/30911 - Django query returns no data; pasting query into MySQL prompt shows correct data. (needsinfo)
https://code.djangoproject.com/ticket/30918 - timesince() ignores time_strings argument for the same dates. (accepted)
https://code.djangoproject.com/ticket/30920 - Choice enumeration types should not enforce enum.unique(). (wontfix)
https://code.djangoproject.com/ticket/30908 - FilePathField raises FileNotFoundError for nonexistent path. (wontfix)
https://code.djangoproject.com/ticket/30919 - Template-loader postmortem should list non-existent directories. (wontfix)
https://code.djangoproject.com/ticket/30921 - _DeadlockError is raised when using StatReloader (duplicate).
https://code.djangoproject.com/ticket/30922 - Admin's date_hierarchy excludes 31 october when using timezone with DST in northern hemisphere. (accepted)
https://code.djangoproject.com/ticket/30915 - Implication for Q object. (wontfix)
https://code.djangoproject.com/ticket/30928 - Update documentation about MariaDB and MySQL support for nowait and skip_locked arguments. (accepted)
https://code.djangoproject.com/ticket/30927 - Use assertWarnsMessage() in the example of deprecation warnings. (accepted)
https://code.djangoproject.com/ticket/30929 - get_previous/next_by_FOO functions are undocumented. (invalid)
https://code.djangoproject.com/ticket/30930 - Many to Many Doc. (invalid)
https://code.djangoproject.com/ticket/30931 - Cannot override get_FOO_display() in Django 2.2+. (accepted)
https://code.djangoproject.com/ticket/30932 - ConnectionResetError: [Errno 54] Connection reset by peer. (invalid)
https://code.djangoproject.com/ticket/30935 - Problem with makemigrations/migrate (AUTH_USER_MODEL) and duplication of tables. (invalid)
https://code.djangoproject.com/ticket/30936 - Enabled timezone collides with date_hierarchy of django admin. (duplicate)
https://code.djangoproject.com/ticket/30938 - DEFAULT_CONTENT_TYPE django.utils.deprecation.RemovedInDjango30Warning. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/11970 - Fixed #30907 -- Fixed SplitArrayField.has_changed() with removal of empty trailing values.
https://github.com/django/django/pull/11982 - Fixed #30918 -- Made timesince()/timeuntil() respect custom time strings for future and the same datetimes.
https://github.com/django/django/pull/11977 - Fixed #30899 -- Lazily compiled import time regular expressions.
https://github.com/django/django/pull/11983 - Fixed #30922 -- Fixed ModelAdmin.date_hierarchy queries with DST changes.
https://github.com/django/django/pull/11954 - Used more specific unittest assertions in tests.
https://github.com/django/django/pull/11989 - Refs #28428 -- Made filepath_to_uri() support pathlib.Path.
https://github.com/django/django/pull/11988 - Fixed #30927 -- Simplified an example of test for the deprecation warning with assertWarnsMessage().
https://github.com/django/django/pull/11908 - Refs #20456 -- Moved initialization of HEAD method based on GET to the View.setup() for generic views.
https://github.com/django/django/pull/11996 - Refs #23576 -- Disabled MySQL multi-alias deletion path on MariaDB >= 10.3.2.
https://github.com/django/django/pull/11953 - Refs #28428 -- Made FileSystemStorage.save() to support pathlib.Path.

https://github.com/django/django/pull/11997 - Fixed #30761 -- Prevented floatformat filter from returning a negative zero.

Reviewed:

https://github.com/django/django/pull/11975 - Fixed #13750 -- Clarified need to reopen models.ImageField.image file to access raw image data.
https://github.com/django/django/pull/11999 - Fixed #30931 -- Added example of overriding model extra instance methods to docs.

Best regards,

Mariusz