Fellow Reports - September 2021
Mariusz Felisiak
Week ending September 5, 2021
Released Django 3.2.7.
Triaged:
https://code.djangoproject.com/ticket/33066 - Add
annotation about accepting ISO 8601 formats by DateTimeField() to
the DATETIME_INPUT_FORMATS docs. (wontfix)
https://code.djangoproject.com/ticket/33067 - Acknowledge
existence of verbatim template tag in templatetag documentation
(accepted)
https://code.djangoproject.com/ticket/33062 - File upload
crash when a file extension contains null characters. (accepted)
https://code.djangoproject.com/ticket/33069 - Comment to match
code in django.form.widget.Widget.value_from_datadict (invalid)
https://code.djangoproject.com/ticket/33068 - makemessages is
inconvenient when overriding default django translations
(worksforme)
https://code.djangoproject.com/ticket/33056 - makemessages
overrides the *.po files even if they are already up to date
(duplicate)
https://code.djangoproject.com/ticket/33072 - Providing Django
Channels Documentation within djangoproject.com documentation
(invalid)
https://code.djangoproject.com/ticket/33071 - ContentType
selects wrong DB in multiple DB setup (duplicate)
https://code.djangoproject.com/ticket/33070 - Select2 doesn't
load translations with subtags. (accepted)
https://code.djangoproject.com/ticket/33073 - AttributeError
when annotating with Exists(none()) and aggregation (accepted)
https://code.djangoproject.com/ticket/33074 - Do not require
fields on UpdateView/CreateView if form specified (invalid)
https://code.djangoproject.com/ticket/33075 - '__date' returns
None in MySQL while it returns date object in Sqlite3 (invalid)
https://code.djangoproject.com/ticket/33076 - SyntaxError when
using __in lookup with F() expression. (duplicate)
https://code.djangoproject.com/ticket/6106 - make-messages.py
should not touch POT-Creation-Date (accepted)
https://code.djangoproject.com/ticket/33080 - Changing
nullability for fields which allow empty string should not change
nullability on Oracle. (accepted)
https://code.djangoproject.com/ticket/33081 - TypeError:
scandir: path should be string, bytes, os.PathLike or None, not
function (invalid)
https://code.djangoproject.com/ticket/33079 - Prevent
get_image_dimensions() crash on nonexistent images. (accepted)
https://code.djangoproject.com/ticket/33082 -
test_subparser_invalid_option regression with Python 3.9.7
(accepted)
Reviewed/committed:
https://github.com/django/django/pull/14796 - Fixed #33054 --
Made TestCase.captureOnCommitCallbacks() capture callbacks
recursively.
https://github.com/django/django/pull/14792 - Fixed #32992 --
Restored offset extraction for fixed offset timezones.
https://github.com/django/django/pull/14495 - Fixed #24900 --
Allowed migrating backward to squashed migrations.
https://github.com/django/django/pull/14810 - Fixed #33061 --
Fixed handling nonexistent keys with negative deltas in
incr()/decr() in memcached backends.
https://github.com/django/django/pull/14694 - Fixed #25264 --
Allowed suppressing base command options in --help output.
https://github.com/django/django/pull/13827 - Fixed #32309 --
Added --exclude option to startapp/startproject management
commands.
https://github.com/django/django/pull/14818 - Fixed #33073 --
Fixed queryset crash with aggregation and empty/extra queryset
annotation.
https://github.com/django/django/pull/14820 - Fixed #33044 --
Reallowed editable install into user site directory.
https://github.com/django/django/pull/14441 - Fixed #33079 --
Fixed get_image_dimensions() on nonexistent images.
https://github.com/django/django/pull/14827 - Refs #33012 --
Moved PickleSerializer to django.core.serializers.base and added
tests.
https://github.com/django/django/pull/14812 - Fixed #32975 --
Fixed admin system check for inlines with foreign keys to proxy
models.
https://github.com/django/django/pull/14817 - Fixed #33067 --
Improved templatetag docs.
Authored:
https://github.com/django/django/pull/14809 - Fixed #33057 --
Fixed recreation of foreign key constraints in m2m tables when
altering type of referenced primary key on Oracle.
https://github.com/django/django/pull/14814 - Refs #33061 --
Removed unnecessary BaseMemcachedCache.decr().
https://github.com/django/django/pull/14822 - Fixed #33080 --
Preserved nullability of textual fields on Oracle.
https://github.com/django/django/pull/14826 - Fixed #33082 --
Fixed CommandTests.test_subparser_invalid_option on Python 3.9.7+.
https://github.com/django/django/pull/14832 - Fixed #30086,
Refs #32873 -- Made floatformat template filter independent of
USE_L10N.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33068 - makemessages is inconvenient when overriding default django translations (invalid)
https://code.djangoproject.com/ticket/33083 - "Select All" in admin changelist does not work when both action_on_bottom and actions_on_top are True. (accepted)
https://code.djangoproject.com/ticket/33086 - ArrayField with JSONField and custom encoder raises error on serialization with "django.core.serializers.json". (wontfix)
https://code.djangoproject.com/ticket/33084 - Removed incorrect fields.W343 check and notes about limit_choices_to restrictions for ManyToManyField. (accepted)
https://code.djangoproject.com/ticket/33088 - Remaining connection slots are reserved for non-replication superuser connections (invalid)
https://code.djangoproject.com/ticket/33087 - Postgres: SSL connection has been closed unexpectedly (invalid)
https://code.djangoproject.com/ticket/33089 - Unable to run db migration (invalid)
https://code.djangoproject.com/ticket/33090 - Extend sensitive post parameter filtering to be applicable to exceptions in middleware. (accepted)
https://code.djangoproject.com/ticket/33091 - A FieldError should be raised when trying to update MTI inherited field with F reference to child field (accepted)
https://code.djangoproject.com/ticket/33094 - "Show all" is ambiguous (wontfix)
https://code.djangoproject.com/ticket/33096 - AdminEmailHandler emails blocked by gmail antivirus (accepted)
https://code.djangoproject.com/ticket/33097 - Class based simple tag that takes context fails with simple_tag(). (invalid)
https://code.djangoproject.com/ticket/33035 - Autocomplete and populating Subcategories based on selected Categories (Admin and Forms) (needsinfo)
https://code.djangoproject.com/ticket/33099 - Improve performance of import_string(). (created)
https://code.djangoproject.com/ticket/33101 - Improve output of non-interactive migration questioner (duplicate)
https://code.djangoproject.com/ticket/33102 - Nested natural join query (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14836 - Refs #32508 -- Raised TypeError/ValueError instead of using "assert" in encode() methods of remaining password hashers.
https://github.com/django/django/pull/14837 - Refs #32363 -- Made shell ignore a missing sys.___interactivehook__.
https://github.com/django/django/pull/14802 - Fixed #33060 -- Added BaseCache.make_and_validate_key() hook.
https://github.com/django/django/pull/13547 - Fixed #32076 -- Added async methods to BaseCache.
https://github.com/django/django/pull/14838 - Refs #32219 -- Added admin model inline tests for verbose names.
https://github.com/django/django/pull/13710 - Fixed #32219 -- Made InlineModelAdmin.verbose_name_plural fallback to its verbose_name.
https://github.com/django/django/pull/14842 - Fixed #33084 -- Removed incorrect system check for ManyToManyField with limit_choices_to.
https://github.com/django/django/pull/14840 - Fixed #33096 -- Fixed <form> nesting in technical 500 template.
https://github.com/django/django/pull/13299 - Fixed #31867 -- Made TabularInline handling of hidden fields with view-only permissions consistent with StackedInline.
https://github.com/django/django/pull/13771 - Refs #31055 -- Doc'd 'databases' argument of check functions.
https://github.com/django/django/pull/14850 - Fixed #33099 -- Improved performance of import_string().
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33104 - Long words overflow readonly fields (accepted)
https://code.djangoproject.com/ticket/33105 - Undocumented behavior: A default ordering doesn't affect GROUP BY queries. (invalid)
https://code.djangoproject.com/ticket/33108 - Makemigrations allows on-off default when adding non-nullable unique field (wontfix)
https://code.djangoproject.com/ticket/33109 - Testing the presence of SameSite and Secure cookies doesn't work. (needsinfo)
https://code.djangoproject.com/ticket/33111 - Conditionally changing ModelAdmin inlines based on object's field breaks when changing object and new inlines should appear. (accepted)
https://code.djangoproject.com/ticket/33114 - StringAgg() should set output_field to TextField. (accepted)
https://code.djangoproject.com/ticket/33115 - Connection issue after a HEAD is used (duplicate)
https://code.djangoproject.com/ticket/33116 - 'str' object is not callable error appears from contrib.messages. (needsinfo)
https://code.djangoproject.com/ticket/13926 - GeometryCollections are not visible in OSMGeoAdmin (needsinfo)
https://code.djangoproject.com/ticket/11634 - OpenLayers default position (invalid)
https://code.djangoproject.com/ticket/33118 - JSON Generic view (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14841 - Made CSRF JavaScript example more reusable.
https://github.com/django/django/pull/14853 - Fixed #33104 -- Fixed wrapping of long words in admin readonly fields.
https://github.com/django/django/pull/14846 - Fixed #32873 -- Deprecated settings.USE_L10N.
https://github.com/django/django/pull/14437 - Fixed #33012 -- Added Redis cache backend.
https://github.com/django/django/pull/14767 - Doc'd Jinja2 FORM_RENDERER setting.
https://github.com/django/django/pull/14857 - Refs #27624 -- Changed Query.explain_info to namedtuple.
https://github.com/django/django/pull/13733 - Fixed #27674 -- Deprecated GeoModelAdmin and OSMGeoAdmin.
https://github.com/django/django/pull/14864 - Refs #31026 -- Moved Template tests to separate class.
https://github.com/django/django/pull/14833 - Fixed #32492 -- Added TrigramWordSimilarity() and TrigramWordDistance() on PostgreSQL.
https://github.com/django/django/pull/14855 - Fixed #33077 -- Fixed links to related models for admin's readonly fields in custom admin site.
Reviewed:
https://github.com/django/django/pull/14848 - Fixed #32365 -- Made zoneinfo the default timezone implementation.
Authored:
https://github.com/django/django/pull/14858 - Fixed #33107 -- Fixed import_string() crash on not fully initialized modules.
https://github.com/django/django/pull/14860 - Bootstrapped Django 4.1.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33120 - Add OGC-compliant models for GeoDjango running on MySQL 8.0 (accepted)
https://code.djangoproject.com/ticket/33121 - Mention custom users in the tutorial 02. (wontfix)
https://code.djangoproject.com/ticket/33117 - sitemap.xml template used with alternates for multiple languages returns an invalid xml (invalid)
https://code.djangoproject.com/ticket/33119 - Change casing of a model's name referenced by ManyToManyField generates unnecessary migrations. (fixed)
https://code.djangoproject.com/ticket/33123 - Django admin urls are not working, they just redirect to back to the admin root. (invalid)
https://code.djangoproject.com/ticket/33127 - "&" and "|" operators are silently ignored after QuerySet.union(), intersection(), and difference(). (accepted)
https://code.djangoproject.com/ticket/33124 - Avoid accessing ConnectionsHandler.__getitem__ until it's strictly necessary. (accepted)
https://code.djangoproject.com/ticket/33125 - Changing model field to become PK creates redundant UNIQUE constraint (accepted)
https://code.djangoproject.com/ticket/33129 - Drop support for MariaDB 10.2. (created)
https://code.djangoproject.com/ticket/33130 - ErrorDict doesn't pass the dict type check in JsonResponse. (accepted)
https://code.djangoproject.com/ticket/33133 - NullBooleanField doesn't work in historical migrations. (created)
https://code.djangoproject.com/ticket/33134 - Circular contexts when rendering Form with BoundFields. (created)
https://code.djangoproject.com/ticket/33135 - Add read_only parameter to Model fields for virtual columns. (duplicate)
https://code.djangoproject.com/ticket/33138 - Tuple comparison for efficient lexicographic ordering on multiple columns (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/14709 - Fixed #32970 -- Changed WhereNode.clone() to create a shallow copy of children.
https://github.com/django/django/pull/14867 - Refs #33119 -- Added tests for changing model name case referenced by ManyToManyField.
https://github.com/django/django/pull/14865 - Refs #27624 -- Optimized Query.clone() for non-combined queries.
https://github.com/django/django/pull/14819 - Fixed #31026 -- Switched form rendering to template engine.
https://github.com/django/django/pull/14871 - Fixed #33070 -- Fixed loading translations with language subtags in admin's Select2 widget.
https://github.com/django/django/pull/14861 - Fixed #33111 -- Fixed passing object to ModelAdmin.get_inlines() when editing in admin change view.
https://github.com/django/django/pull/14870 - Fixed #33083 -- Fixed selecting all items in the admin changelist when actions are both top and bottom.
https://github.com/django/django/pull/14877 - Removed blocking wait in admin inlines selenium test.
https://github.com/django/django/pull/13944 - Optimized handling case-insensitive mappings.
https://github.com/django/django/pull/14385 - Fixed #32499 -- Removed additional metacharacters in simplify_regex().
https://github.com/django/django/pull/14890 - Fixed #33127 -- Added error messages on | and & operators with combined querysets.
https://github.com/django/django/pull/14884 - Fixed #33130 -- Restored form errors to be a dict.
https://github.com/django/django/pull/14876 - Fixed #33124 -- Avoided accessing the database connections when not necessary.
https://github.com/django/django/pull/14893 - Removed obsolete GEOS 3.5 requirement note.
Authored:
https://github.com/django/django/pull/14872 - [4.0.x] Updated source translation catalogs.
https://github.com/django/django/pull/14873 - Fixed broken links and redirects in docs.
https://github.com/django/django/pull/14874 - Refs #31026 -- Fixed forms_tests if Jinja2 is not installed.
https://github.com/django/django/pull/14881 - Fixed #33129 -- Dropped support for MariaDB 10.2.
https://github.com/django/django/pull/14882 - Skipped GitHub actions for linters and JavaScript tests on purely doc changes.
https://github.com/django/django-contrib-comments/pull/146 - Added testing for Django 3.0.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/33144 - get_elided_page_range() method doesn't work properly. (invalid)
https://code.djangoproject.com/ticket/33146 - Wrong command in ASGI deployment-guide using uvicorn (invalid)
https://code.djangoproject.com/ticket/33147 - django-admin runserver --settings=mysite.settings errors out (worksforme)
https://code.djangoproject.com/ticket/33141 - Rename Aggregate.empty_aggregate_value to empty_result_set_value. (accepted)
https://code.djangoproject.com/ticket/33148 - Set `Cache-Control: max-age=0` header on static files response so that files are easily refreshable during development (duplicate)
https://code.djangoproject.com/ticket/33139 - Using IPython for the manage.py REPL interface clobbers __main__, where the normal python REPL doesn't. (wontfix)
https://code.djangoproject.com/ticket/33149 - Make --pdb work with subTest(). (accepted)
https://code.djangoproject.com/ticket/33131 - Improve error messages for reverse accessor clashes. (accepted)
https://code.djangoproject.com/ticket/33150 - EmailBackend.write_message crashes when self.steam is BufferedWriter (invalid)
https://code.djangoproject.com/ticket/33153 - "database table is locked" error on SQLite when testing with mirror database (duplicate)
https://code.djangoproject.com/ticket/33154 - The Exact lookup generates suboptimal queries for BooleanField on MySQL (duplicate)
https://code.djangoproject.com/ticket/33152 - Document the fact that a DB connection can be closed mid-request when a HTTP client disconnects prematurely (invalid)
https://code.djangoproject.com/ticket/33151 - createsuperuser doesn't work in non-interactive mode if a ManyToManyField/ForeignKey is in REQUIRED_FIELDS. (accepted)
https://code.djangoproject.com/ticket/33155 - ModelChoiceIteratorValue is not hashable. (accepted)
https://code.djangoproject.com/ticket/33157 - Consider back-porting the fix of #32889 to version 3.2.x (wontfix)
https://code.djangoproject.com/ticket/33156 - Admin Sidebar search value stays forever (accepted)
https://code.djangoproject.com/ticket/33159 - Missing table alias in generated query after used in subquery (accepted)
https://code.djangoproject.com/ticket/33160 - DatabaseWrapper._nodb_cursor() raises wrong warnings in case of errors from queries on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/32961 - Add support for BIT_XOR aggregate in PostgreSQL 14+. (accepted)
https://code.djangoproject.com/ticket/32943 - Add support for covering indexes and exclusion constraints for SP-GiST in PostgreSQL 14+. (accepted)
https://code.djangoproject.com/ticket/33161 - Do not ignore transaction durability errors within TestCase (accepted)
https://code.djangoproject.com/ticket/33162 - Add __file__ to Settings. (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14898 - Fixed #33114 -- Defined default output_field of StringAgg.
https://github.com/django/django/pull/14897 - Refs #32355 -- Modernized subprocess.run() calls.
https://github.com/django/django/pull/14892 - Fixed #33136 -- Added GEOSGeometry.make_valid() method.
https://github.com/django/django/pull/14896 - Fixed #33125 -- Avoided redundant unique constraint when converting a non-unique field to primary key on MySQL and PostgreSQL.
https://github.com/django/django/pull/14785 - Fixed #33033 -- Prevented models.DecimalField from accepting NaN values.
https://github.com/django/django/pull/14903 - Fixed #33134 -- Fixed recursion depth error when rendering Form with BoundFields.
https://github.com/django/django/pull/14771 - Fixed #33027 -- Made autoreloader pass -X options.
https://github.com/django/django/pull/14894 - Fixed #33141, Fixed #33018 -- Fixed annotations with empty queryset.
https://github.com/django/django/pull/14915 - Fixed #33155 -- Made ModelChoiceIteratorValue instances hashable.
https://github.com/django/django/pull/14918 - Fixed #33160 -- Avoided suppressing query errors in _nodb_cursor() on PostgreSQL.
https://github.com/django/django/pull/14689 - Fixed #32961 -- Added BitXor() aggregate to django.contrib.postgres.
https://github.com/django/django/pull/14663 - Fixed #32943 -- Added support for covering indexes and exclusion constraints for SP-GiST on PostgreSQL 14+.
Authored:
https://github.com/django/django/pull/14908 - Corrected field and model check messages in docs.
https://github.com/django/django/pull/14916 - Fixed #33159 -- Reverted "Fixed #32970 -- Changed WhereNode.clone() to create a shallow copy of children."
https://github.com/django/django-docker-box/pull/32 - Used PyMemcacheCache instead of MemcachedCache backend.