Fellow Reports - February 2022
Mariusz Felisiak
Week ending February 6, 2022
Released Django 4.0.2, 3.2.12, and 2.2.27.
Triaged:
https://code.djangoproject.com/ticket/33474 - Introduce
slots definition to Variable and FilterExpression (accepted)
https://code.djangoproject.com/ticket/33471 - AlterField
operation should be noop when adding/changing choices. (accepted)
https://code.djangoproject.com/ticket/33470 - Avoid SQL
comments with descriptions of noop operations in sqlmigrate.
(wontfix)
https://code.djangoproject.com/ticket/33476 - Formatting Code
with Black (created)
https://code.djangoproject.com/ticket/33477 - Union Operator
merges annotated values wrongfully (invalid)
https://code.djangoproject.com/ticket/33479 - Change Username
on Django Forums (invalid)
https://code.djangoproject.com/ticket/33480 - Migration
autodetector crashes when renaming a model and field. (created)
https://code.djangoproject.com/ticket/33485 -
inlineformset_factory generate more db subquerys when the model
have fk (duplicate)
https://code.djangoproject.com/ticket/33486 - Allow
translations' variants based on objects count for admin's delete
selected confirmation messages (wontfix)
https://code.djangoproject.com/ticket/33475 - Add a
SESSION_KEY_LENGTH setting (wontfix)
https://code.djangoproject.com/ticket/33483 - Index name
migration instability between database engines (wontfix)
https://code.djangoproject.com/ticket/33491 - Rows are
selected only on Chrome when going back from the confirmation
page. (accepted)
https://code.djangoproject.com/ticket/33492 - Getting Errors
for code that is commented (invalid)
https://code.djangoproject.com/ticket/33489 - Autocomplete
broken on ManyToManyField (invalid)
https://code.djangoproject.com/ticket/33493 - It's
counter-intuitive how QuerySet.iterate() works with
prefetch_related (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/15380 - Fixed #33480 --
Fixed makemigrations crash when renaming model and field.
https://github.com/django/django/pull/15198 - Fixed #30360 --
Added support for secret key rotation.
https://github.com/django/django/pull/15382 - Fixed #33482 --
Fixed QuerySet filtering againts negated Exists() with empty
queryset.
https://github.com/django/django/pull/15378 - Fixed #33474 --
Added __slots__ to Variable and FilterExpression.
https://github.com/django/django/pull/15390 - Added Redis to
warning about using cached sessions in docs.
https://github.com/django/django/pull/15245 - Fixed #32243 --
Added docs examples for manually saving Files.
https://github.com/django/django/pull/15388 - Fixed #33473 --
Fixed detecting changes by autoreloader in .py files inside
template directories.
https://github.com/django/django/pull/15393 - Refs #32559 --
Added selenium test for FloatField client-side validation.
Authored:
https://github.com/django/django/pull/15379 - Refs
#33476 -- Used vertical hanging indentation for format lists
with inline comments.
https://github.com/django/django/pull/15392 - Refs
#33476 -- Refactored problematic code before reformatting by
Black.
https://github.com/django/django/pull/15394 - Disabled caching
in GitHub actions for Windows tests.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33496 - Auto database mirroring. (wontfix)
https://code.djangoproject.com/ticket/33500 - Django ORM bug: overloading delete() method of models (invalid)
https://code.djangoproject.com/ticket/33501 - order_with_respect_to uses incorrect database alias (accepted)
https://code.djangoproject.com/ticket/33497 - Database persistent connections do not work with ASGI in 4.0 (needsinfo)
https://code.djangoproject.com/ticket/33502 - Move Field attributes to class attributes. (needsinfo)
https://code.djangoproject.com/ticket/33503 - docs.djangoproject.com does not serve objects.inv by Sphinx (invalid)
https://code.djangoproject.com/ticket/33506 - QuerySet.bulk_update() should perform atomic writes against routed db_for_write. (accepted)
https://code.djangoproject.com/ticket/33504 - Admin autocomplete search input does not get focused on click (invalid)
https://code.djangoproject.com/ticket/33507 - Use native UUID data type on MariaDB 10.7+ (created)
https://code.djangoproject.com/ticket/33508 - MariaDB 10.8+ supports ordering on individual columns in the index. (created)
https://code.djangoproject.com/ticket/33509 - Add SQL comment to describe deliberately no-op migration operations (accepted)
https://code.djangoproject.com/ticket/33510 - dumpdata misses models subclassed from other non-abstract models (invalid)
https://code.djangoproject.com/ticket/33511 - Single-select admin autcomplete widget has lost its auto-focus (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/15391 - Fixed #32518 -- Doc'd that QuerySet.contains() should not be overused.da
https://github.com/django/django/pull/15414 - Fixed #33506 -- Made QuerySet.bulk_update() perform atomic writes against write database.
https://github.com/django/django/pull/15413 - Fixed #33495 -- Improved debug logging message about adapting handlers for middlewares.
https://github.com/django/django/pull/15409 - Fixed #33501 -- Made order_with_respect_to respect database routers.
https://github.com/django/django/pull/15349 - Fixed #29490 -- Added support for object-based Media CSS and JS paths.
https://github.com/django/django/pull/15400 - Fixed #26287 -- Added support for addition operations to SimpleLazyObject.
https://github.com/django/django/pull/15412 - Refs #33476 -- Made management commands use black.
https://github.com/django/django/pull/15420 - Refs #32074 -- Recommended aiosmtpd for minimal SMTP server.
Authored:
https://github.com/django/django/pull/15407 - Refs #33482 -- Fixed QuerySet selecting and filtering againts negated Exists() with empty queryset.
https://github.com/django/django/pull/15387 - Refs #33476 -- Reformatted code with Black.
https://github.com/django/django/pull/15071 - [4.0.x] Refs #33476 -- Reformatted code with Black.
https://github.com/django/django/pull/15417 - Refs #32502 -- Avoided table rebuild when removing fields on SQLite 3.35+.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33512 - Creating a child instance with a parent containing DateTimeField(auto_add_now=True) raises IntegrityError. (duplicate)
https://code.djangoproject.com/ticket/33505 - Inconsistent Behavior with Abstract Models and Signals (invalid)
https://code.djangoproject.com/ticket/33513 - Custom authentication class: raising AuthenticationFailed leads to 403 (invalid)
https://code.djangoproject.com/ticket/33514 - Fallback to a more generic language variant for Select2 translations. (accepted)
https://code.djangoproject.com/ticket/33515 - ManyToManyField to lowercased swappable setting causes generating infinite migrations. (accepted)
https://code.djangoproject.com/ticket/33518 - Add alias RemovedAfterNextVersionWarning for deprecations after next version (accepted)
https://code.djangoproject.com/ticket/33517 - Extracting seconds also returns fractional seconds on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/33519 - Recursive {% include %} crashes silently. (wontfix)
https://code.djangoproject.com/ticket/33521 - New tables are not created from the models (invalid)
https://code.djangoproject.com/ticket/33525 - decorator @html_safe removes completely old class.__str__ method. (wontfix)
https://code.djangoproject.com/ticket/33524 - ModelAdmin with defined radio_fields override empty_label (accepted)
https://code.djangoproject.com/ticket/33523 - remove dangerous text from translated message about csrf error (invalid)
https://code.djangoproject.com/ticket/33526 - Accept truthy/falsy values in security checks. (wontfix)
https://code.djangoproject.com/ticket/33527 - Remove unnecessary code in ModelAdmin._changeform_view(). (accepted)
https://code.djangoproject.com/ticket/33529 - Possibly Incorrect statement in the docs about CRSF tokens (invalid)
Reviewed/committed:
https://github.com/django/django/pull/15419 - Refs #25684 -- Removed double newline from request/response output of runserver.
https://github.com/django/django/pull/15425 - Refs #33348 -- Made SimpleTestCase.assertFormError()/assertFormsetErrors() raise an error for unbound forms/formsets.
https://github.com/django/django/pull/15426 - Refs #33348 -- Made SimpleTestCase.assertFormsetErrors() raise an error when form_index is too big.
https://github.com/django/django/pull/15427 - Refs #33348 -- Improved messages raised by SimpleTestCase.assertFormError()/assertFormsetErrors().
https://github.com/django/django/pull/15428 - Refs #33348 -- Made SimpleTestCase.assertFormError() raise ValueError when "field" is passed without "form_index".
https://github.com/django/django/pull/15423 - Fixed #28358 -- Prevented LazyObject from mimicking nonexistent attributes.
https://github.com/django/django/pull/15415 - Made Field.error_messages a cached property.
https://github.com/django/django/pull/15434 - Refs #27468 -- Updated django.core.signing docstring.
https://github.com/django/django/pull/15435 - Refs #28358 -- Fixed infinite recursion in LazyObject.__getattribute__().
https://github.com/django/django/pull/15438 - Fixed #33514 -- Added fallbacks to subsequent language codes in Select2 translations.
https://github.com/django/django/pull/15244 - Fixed #33379 -- Added minimum database version checks.
https://github.com/django/django/pull/15441 - Refs #33173 -- Fixed MailTests.test_backend_arg() on Windows and Python 3.11+.
Authored:
https://github.com/django/django/pull/15433 - Fixed #33515 -- Prevented recreation of migration for ManyToManyField to lowercased swappable setting.
https://github.com/django/django/pull/15443 - Refs #33526 -- Made CSRF_COOKIE_SECURE/SESSION_COOKIE_SECURE/SESSION_COOKIE_HTTPONLY don't pass on truthy values.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33528 - Add an option in ModelAdmin to validate data without saving anything. (wontfix)
https://code.djangoproject.com/ticket/33531 - Random ORDER BY not working with MSSQL (invalid)
https://code.djangoproject.com/ticket/33537 - Cloning test database fails with mysql-client 8.x and older mysql-server or mariadb-server (invalid)
https://code.djangoproject.com/ticket/33538 - Migrations autodetector change for djangopolymorphicmodel (invalid)
https://code.djangoproject.com/ticket/9076 - Inline forms can result in a "Please correct the errors below." message with no errors listed. (fixed)
https://code.djangoproject.com/ticket/33541 - Database exceptions / django.db.utils.Error and subclasses are not documented (invalid)
https://code.djangoproject.com/ticket/33542 - TemplateResponse example missing definition of request (invalid)
Reviewed/committed:
https://github.com/django/django/pull/15447 - Fixed #33530 -- Fixed typo in docs/ref/templates/builtins.txt.
https://github.com/django/django/pull/15444 - Fixed #33518 -- Added RemovedAfterNextVersionWarning.
https://github.com/django/django/pull/15446 - Refs #33476 -- Mentioned black in docs about pre-commit checks.
https://github.com/django/django/pull/15442 - Fixed #20296 -- Prevented mark_safe() from evaluating lazy objects.
https://github.com/django/django/pull/15450 - Refs #33517 -- Prevented second lookup from returning fractional seconds on PostgreSQL.
https://github.com/django/django/pull/15318 - Fixed #19580 -- Unified behavior of reverse foreign key and many-to-many relations for unsaved instances.
https://github.com/django/django/pull/15328 - Removed redundant QuerySet.all() calls in docs and tests.
https://github.com/django/django/pull/15272 - Fixed #27844 -- Added optimizemigration management command.
https://github.com/django/django/pull/15455 - Refs #32873 -- Avoided looking up settings._USE_L10N_INTERNAL twice.
https://github.com/django/django/pull/15321 - Fixed #33434 -- Changed font-size in admin CSS to use rem units.
https://github.com/django/django/pull/15233 - Fixed #33328 -- Transformed formset:added/removed to native JS events.
https://github.com/django/django/pull/15453 - Fixed #33532 -- Optimized CaseInsensitiveMapping instantiation for dicts.
https://github.com/django/django/pull/15459 - Fixed #33539 -- Fixed spaces in WITH SQL for indexes on PostgreSQL.
https://github.com/django/django/pull/15301 - Fixed #33267 -- Added link to related item to related widget wrapper in admin.
https://github.com/django/django/pull/15401 - Fixed #31486 -- Deprecated passing unsaved objects to related filters.
https://github.com/django/django/pull/15452 - Fixed #33508 -- Fixed DatabaseFeatures.supports_index_column_ordering on MariaDB 10.8+.
https://github.com/django/django/pull/15465 - Fixed #33527 -- Removed unnecessary code in ModelAdmin._changeform_view().
Reviewed:
https://github.com/django/code.djangoproject.com/pull/121 - Built and pushed Docker image to Github Packages.
Authored:
https://github.com/django/django/pull/15451 - Removed unnecessary str type from @keep_lazy for escape()/escapejs().
https://github.com/django/django/pull/15454 - Refs #33476 -- Added warning to optimizemigration/squashmigrations commands when black cannot be applied.
https://github.com/django/django/pull/15462 - Optimized docs images.