Fellow Reports - December 2021
Mariusz Felisiak
Week ending December 12, 2021
Released Django 3.2.10, 3.1.14, 2.2.25, and 4.0.
Triaged:
https://code.djangoproject.com/ticket/33342 - Allow
ExclusionConstraint to use the OpClass expression (accepted)
https://code.djangoproject.com/ticket/33343 - update_or_create
seems to issue wrongly limited query to the database (invalid)
https://code.djangoproject.com/ticket/33344 - Define bounds
transform for discrete postgres range fields (needsinfo)
https://code.djangoproject.com/ticket/33345 - Forms does not
search external template directories (invalid)
https://code.djangoproject.com/ticket/33346 -
assertFormsetError() crashes on formset named "form". (accepted)
https://code.djangoproject.com/ticket/33347 -
django.contrib.gis.geos.MultiPolygon segfault on arm (duplicate)
https://code.djangoproject.com/ticket/33348 - Change API of
assertFormError to take an actual form object (accepted)
https://code.djangoproject.com/ticket/33350 - some view
decorators do not work with Django REST framework in Django 4.0
(needsinfo)
https://code.djangoproject.com/ticket/30681 - SQL script from
sqlsequencereset doesn't work on Postgres 11.3. (worksforme)
https://code.djangoproject.com/ticket/33352 -
ModelAdmin.list_display option should support double-underscore
notation to express field-of-associated-model (duplicate)
https://code.djangoproject.com/ticket/33353 - Can't collect
static files if don't have vendor's JavaScript source map files
(invalid)
https://code.djangoproject.com/ticket/28897 -
QuerySet.update() raises FieldError on queryset ordered by an
annotated field. (accepted)
https://code.djangoproject.com/ticket/33351 - path()/re_path()
should raise a TypeError when kwargs is not a dict. (accepted)
https://code.djangoproject.com/ticket/33349 - Add option to
produce duration_string without days (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/15154 - Fixed #33335 --
Made model validation ignore functional unique constraints.
https://github.com/django/django/pull/15138 - Removed unused
map_options JS variable.
https://github.com/django/django/pull/15164 - Improved release
notes wording for template-based form rendering.
https://github.com/django/django/pull/14984 - Refs #25265 --
Allowed customizing Query's datastructure classes.
https://github.com/django/django/pull/15147 - Refs #32290 --
Optimized construct_relative_path() by delay computing has_quotes.
https://github.com/django/django/pull/15165 - Fixed #33346 --
Fixed SimpleTestCase.assertFormsetError() crash on a formset named
"form".
https://github.com/django/django/pull/15128 - Fixed #33319 --
Fixed crash when combining with the | operator querysets with
aliases that conflict.
https://github.com/django/django/pull/15069 - Refs #32338 --
Added Boundfield.legend_tag().
https://github.com/django/django/pull/15166 - Fixed #33340 --
Fixed unquoted column names in queries used by DatabaseCache.
https://github.com/django/django/pull/15171 - Moved
ManagementForm's fields to class attributes.
Authored:
https://github.com/django/django/pull/15160 - [4.0.x] Updated
translations from Transifex.
https://github.com/django/djangoproject.com/pull/1127 -
Updated robots.docs.txt for Django 4.0.
https://github.com/django/django/pull/15163 - Updated asgiref
dependency for 4.0 release series.
https://github.com/django/django/pull/15168 - Fixed
inspectdb.tests.InspectDBTestCase.test_custom_fields() on SQLite
3.37+.
https://github.com/django/django/pull/15175 - Refs #32502 --
Avoided table rebuild when adding fields with no default on
SQLite.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33358 - Adding duration field with default <24h raises an error on Oracle. (accepted)
https://code.djangoproject.com/ticket/33359 - Don't close database connections after every TestCase (needsinfo)
https://code.djangoproject.com/ticket/33361 - Redis cache backend doesn't allow storing bool values (accepted)
https://code.djangoproject.com/ticket/33355 - Optimize SQLite backend connection functions (accepted)
https://code.djangoproject.com/ticket/33362 - ALLOWED_HOSTS no longer accepts a non-list/tuple iterable. (invalid)
https://code.djangoproject.com/ticket/33350 - never_cache()/cache_control() decorators raise error on duck-typed requests. (accepted)
https://code.djangoproject.com/ticket/33364 - Improve Documentation by having list of topics fixed on the left and table of contents on the right (invalid)
https://code.djangoproject.com/ticket/33365 - Functionality change in 3.2.10 for re_path(). (invalid)
https://code.djangoproject.com/ticket/27864 - Limit the number of terms in an admin search (wontfix)
https://code.djangoproject.com/ticket/33366 - Migration autodetector doesn't handle placeholders in related_name for ForeignKey. (accepted)
https://code.djangoproject.com/ticket/33369 - Add through_defaults as argument for m2m_changed signal (wontfix)
https://code.djangoproject.com/ticket/33370 - {% if %} tag incorreclty being evaluated (invalid)
https://code.djangoproject.com/ticket/33371 - Unnecessary colon with blank label (needsinfo)
https://code.djangoproject.com/ticket/33372 - GISModelAdmin.gis_widget_kwargs cannot be used due to signature mismatch. (invalid)
https://code.djangoproject.com/ticket/33373 - Support expressions on rhs for __has_keys, __has_any_keys JSONField lookups. (needsinfo)
https://code.djangoproject.com/ticket/33374 - ExpressionWrapper for ~Q(pk__in=[]) crashes. (accepted)
https://code.djangoproject.com/ticket/33376 - django.contrib.auth.urls don't function when enclosed within an application namespace. (duplicate)
https://code.djangoproject.com/ticket/33377 - Django Ignoring updates to urls.py (invalid)
Reviewed/committed:
https://github.com/django/django/pull/15180 - Fixed #33351 -- Made path()/re_path() raise TypeError when kwargs argument is not a dict.
https://github.com/django/django/pull/15182 - Refs #33355 -- Fixed Trunc() with years < 1000 on SQLite.
https://github.com/django/django/pull/15176 - Fixed #33338 -- Doc'd and tested that never_cache() decorator set Expires header.
https://github.com/django/django/pull/15186 - Improved wording in password validators docs and docstrings.
https://github.com/django/django/pull/15191 - Fixed #33361 -- Fixed Redis cache backend crash on booleans.
https://github.com/django/django/pull/15183 - Fixed #33358 -- Fixed handling timedelta < 1 day in schema operations on Oracle.
https://github.com/django/django/pull/15196 - Fixed unescape_string_literal() crash on empty strings.
https://github.com/django/django/pull/15022 - Fixed #16063 -- Adjusted admin changelist searches spanning multi-valued relationships.
https://github.com/django/django/pull/15157 - Fixed #33316 -- Added pagination to admin history view.
https://github.com/django/django/pull/15152 - Fixed admin CSS for calendar widget for RTL languages.
https://github.com/django/django/pull/15199 - Fixed #30127 -- Deprecated name argument for cached_property().
https://github.com/django/django/pull/15205 - Fixed #33366 -- Fixed case handling with swappable setting detection in migrations autodetector.
https://github.com/django/django/pull/15185 - Changed signatures of setting_changed signal receivers.
Authored:
https://github.com/django/django/pull/15200 - Refs #33365, Refs #30530 -- Doc'd re_path() behavior change in Django 2.2.25, 3.1.14, and 3.2.10.
https://github.com/django/django/pull/15201 - Used subTest() in forms.URLField() tests.
https://github.com/django/django/pull/15206 - Fixed #33350 -- Reallowed using cache decorators with duck-typed HttpRequest.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/32600 - GEOS Polygons and Collections (across versions) cause segmentation faults on macOS arm64 (M1) (accepted)
https://code.djangoproject.com/ticket/33378 - ImproperlyConfigured error is raised when installing apps in subdirectory (duplicate)
https://code.djangoproject.com/ticket/33379 - Add minimum database version checks (accepted)
https://code.djangoproject.com/ticket/33381 - List filter in django admin (v3.2 - v4) covers/hide part of data table (invalid)
https://code.djangoproject.com/ticket/33382 - Different count and len result for a distinct QuerySet (duplicate)
https://code.djangoproject.com/ticket/33383 - Inconsistent capitalization in admin's msgid "the web/Web site today" (invalid)
Reviewed/committed:
https://github.com/django/django/pull/15204 - Fixed #33368 -- Fixed parse_duration() crash on invalid separators for decimal fractions.
https://github.com/django/django/pull/15202 - Fixed #33367 -- Fixed URLValidator crash in some edge cases.
https://github.com/django/django/pull/15218 - Refs #27674 -- Added tests for GISModelAdmin.gis_widget_kwargs.
https://github.com/django/django/pull/15212 - Increased test coverage of django.db.migrations.questioner.
https://github.com/django/django/pull/15213 - Fixed #33374 -- Fixed ExpressionWrapper annotations with full queryset.
https://github.com/django/django/pull/15221 - Used assertRaisesMessage() in test_client_regress.AssertFormErrorTests.
https://github.com/django/django/pull/15222 - Refs #24121 -- Added __repr__() to BaseFormSet.
https://github.com/django/django/pull/15214 - Fixed #32600 -- Fixed Geometry collections and Polygon segmentation fault on macOS ARM64.
https://github.com/django/django/pull/15224 - Refs #31026 -- Updated TemplatesSetting docs to refer to forms.
https://github.com/django/django/pull/15225 - Refs #33355 -- Optimized Trunc() on SQLite by using f-strings.
https://github.com/django/django/pull/15227 - Refs #32339 -- Added rendering tests for forms with CheckboxSelectMultiple and SelectMultiple widgets.
https://github.com/django/django/pull/15173 - Fixed #33355 -- Optimized SQLite backend connection functions.
https://github.com/django/django/pull/15072 - Refs #31617 -- Changed dark mode primary-fg to give higher contrast to secondary.
https://github.com/django/django-docker-box/pull/23 - Used the official PostGIS docker image.
https://github.com/django/django-docker-box/pull/37 - Fixed #36 - Used slim-bullseye.
https://github.com/django/django/pull/15162 - Fixed #33342 -- Added support for using OpClass() in exclusion constraints.
Authored:
https://github.com/django/djangoproject.com/pull/1133 - Made fundraising views generate initial id in admin.
https://github.com/django/django/pull/15226 - Refs #32355 -- Bumped required psycopg2 version to 2.8.4.
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33387 - Separate between words in Django commands and methods (wontfix)
https://code.djangoproject.com/ticket/33388 - Improve documentation for file uploads outside of request context (duplicate)
https://code.djangoproject.com/ticket/33386 - Autocomplete on refresh with Firefox interacts badly with ModelMultipleChoiceField in forms (accepted)
https://code.djangoproject.com/ticket/33389 - Admin label contrast issues & light background elements in dark mode (needsinfo)
https://code.djangoproject.com/ticket/33390 - PermissionsMixin.is_superuser (invalid)
https://code.djangoproject.com/ticket/33392 - Removing composed indexes fails on MySQL (duplicate)
https://code.djangoproject.com/ticket/33393 - Weird title level in logging how-to (invalid)
https://code.djangoproject.com/ticket/33394 - Adding inlines doesn't work with a manually crafted HTML. (invalid)
https://code.djangoproject.com/ticket/33395 - No error raised when FILE_UPLOAD_TEMP_DIR is not accessible (duplicate)
https://code.djangoproject.com/ticket/33396 - Add the ResolverMatch's name to the technical 500 page. (accepted)
https://code.djangoproject.com/ticket/33398 - ModelAdmin.empty_value_display example in docs should use list_display. (accepted)
https://code.djangoproject.com/ticket/33399 - Overriding Choices for a field in the Form not working when using ModelForm. (invalid)
https://code.djangoproject.com/ticket/33391 - Clarify Aggregate.empty_result_set_value docs. (accepted)
https://code.djangoproject.com/ticket/33400 - assertTemplateUsed()/assertTemplateNotUsed() used as context managers ignore count and msg_prefix parameters. (accepted)
https://code.djangoproject.com/ticket/24125 - TemplateDetailView in admindocs requires a single Django templates engine (wontfix)
https://code.djangoproject.com/ticket/27437 - Can't create GinIndex on ArrayField(CITextField) (wontfix)
https://code.djangoproject.com/ticket/24803 - Collected SQL does not respect empty strings as params when formatting result sql (duplicate)
https://code.djangoproject.com/ticket/24991 - Range types not properly converted to SQL in QuerySet.query.__str__() (duplicate)
https://code.djangoproject.com/ticket/16979 - adds Q objects for related fields. (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/15238 - Refs #29517 -- Removed obsolete PositiveIntegerField test skip.
https://github.com/django/django/pull/15162 - Refs #33342 -- Deprecated ExclusionConstraint.opclasses.
https://github.com/django/django/pull/15242 - Updated example of YAML serialization format in docs.
https://github.com/django/django/pull/15247 - Refs #31617 -- Removed redundant title text in filter.html.
https://github.com/django/django/pull/15253 - Fixed wrapping of long values in technical 500 debug page.
https://github.com/django/django/pull/15252 - Fixed #23273 -- Avoided creation of django_migrations table when there are no migrations to apply.
https://github.com/django/django/pull/15255 - Fixed #33300 -- Ensured hidden elements are not displayed on small screens.
https://github.com/django/django/pull/15236 - Fixed #27936 -- Rewrote spanning multi-valued relationships docs.
https://github.com/django/django/pull/15259 - Fixed #33398 -- Improved @display(empty_value) example in ModelAdmin.empty_value_display docs.
Authored:
https://github.com/django/django/pull/15243 - Refs #22983 -- Added tests for squashing migrations with functions from migration files.
https://github.com/django/django/pull/15249 - Avoided counting attributes and methods in docs.
https://github.com/django/django/pull/15251 - Refs #26872 -- Fixed wrapping of long choices in ModelAdmin.list_filter.
https://github.com/django/django/pull/15261 - Refs #27753 -- Removed unused django.utils.text._replace_entity() and _entity_re.
https://github.com/django/django/pull/15263 - Fixed #33391 -- Clarified Aggregate.empty_result_set_value docs.
Best,
Mariusz