Correction of a docstring in urls.py template

98 views
Skip to first unread message

Jarek

unread,
Dec 8, 2022, 5:53:42 PM12/8/22
to Django developers (Contributions to Django itself)
Hello,

Forgive me if anything I suggest was mentioned or at some point or is considered noob talk. I am only just taking off with GitHub contributions and I probably should have started with some microscopic project not Django but here it is.

When I create Django project and get all the initial files the urls.py file has a docstring that is formatted differently from other files.

Zrzut ekranu 2022-12-8 o 23.27.26.png

I made a change in the template file, run Django's test suite as described HERE that passed OK and commited it to my forked repository. 

Zrzut ekranu 2022-12-8 o 23.36.18.png

And I wanted to ask before I made a pull request if it is a valid change. You can see my commit HERE

Thanks!

Adam Johnson

unread,
Dec 11, 2022, 3:28:26 AM12/11/22
to django-d...@googlegroups.com
Your commit seems fine. You can make a pull request. Whilst you're editing this, it would be good to check everything else in the project template for consistency.

Did you see the contributing guide? There is a tutorial for writing your first patch: https://docs.djangoproject.com/en/dev/internals/contributing/


--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/795a4446-986b-4379-baeb-8bc4e7604002n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages