Fellow Report - October 31, 2014
112 views
Skip to first unread message
Tim Graham
Oct 31, 2014, 7:04:04 PM10/31/14
to django-d...@googlegroups.com
Hello,
If you've read the djangoproject.com blog, you know that Berker Peksag and I have been appointed as "Django Fellows" during the three month pilot program. Part of those duties (which started this week) is to provide a weekly summary of our activities to this mailing list. That report follows.
Also, I wanted to mention that part of the purpose of the fellowship program is to provide resources to review code, as that is clearly a bottleneck in our contribution process. If you have tried contributing before and your patch languished without review, I'd encourage you to reach out and try again. While I am not an expert in all areas of Django, I will do my beast to try to help you find someone to review your work if I can't do so myself. Though I'll remind you that *anyone* in the Django community is welcome to review patches and mark them as "ready for checkin", not just core developers. Reviewing patches is a big help and a great way to earn the trust of the team. If you have any feedback on my work, feel free to leave it here or contact me privately.
Thanks for your support of the Django Software Foundation, which makes this program possible!
Tim
Report for week ending October 31, 2014:
In addition to the triage and review work listed below, I updated the Ansible playbooks for Jenkins to run on Ubuntu 14.04 so that we can have a continuous integration server with some newer database versions. (These playbooks need some minor adjustments so as not to reveal passwords before they can be made public.) Upon running Django's test suite on the new machine, I discovered a couple unexpected test failures:
1. 37 test failures with Python 3.2.6. I investigated the failures and created a ticket in the Python tracker that outlines the issue: http://bugs.python.org/issue22758. Corresponding with a Python core developers in that ticket, I learned that the fix for Python's "lax cookie parsing" issue was incomplete and that when it's fixed properly, Django likely won't be compatible with the fixed versions of Python! This affects the Python 2.7 and 3.2+ branches. The remedy for Django (which is altering our workaround for a bug in Python) is outlined in https://code.djangoproject.com/ticket/23730. I created a ticket and submitted a patch to fix the issue in Python itself so we can eventually remove our workaround in Django: http://bugs.python.org/issue22775.
2. A migrations GIS test failure revealed an incompatibility with MySQL 5.6+. I authored a fix for this issue as outlined in https://code.djangoproject.com/ticket/23719.
3. There are a couple of test failures with the version of SpatiaLite (4.1) that's included with Ubuntu 14.04 that I still need to investigate and ticket as necessary.
To briefly summarize the triage and review work, we continue to retrieve good bug reports for Django 1.7, particularly migration edge cases. I'd expect to see another bug fix release for the 1.7 series within a month of 1.7.1. One issue the core team will be addressing at the "Django: Under the Hood" conference in mid-November is adding more team members to the list of people who can release Django. The lack of availability of someone who has the time and privileges to do a release has been a bottleneck on occasion. In addition to bug fixing on the 1.7 branch, master (1.8) continues to receive a steady diet of new small features. A reminder that we expect Django 1.8 to become the next LTS version of Django, so if you have a pet bug or feature, now's a great time to get it fixed!
Triaged
-------
https://code.djangoproject.com/ticket/23681 - Document how to customize NullBooleanSelect choice names (accepted)
https://code.djangoproject.com/ticket/23720 - Login redirect should be glued to schema (invalid)
https://code.djangoproject.com/ticket/23725 - Inconsistent documentation about ForeignKey(User) (accepted)
https://code.djangoproject.com/ticket/23724 - Add overwrite mode to collectstatic (won't fix)
https://code.djangoproject.com/ticket/23729 - Small error in documentation (invalid)
https://code.djangoproject.com/ticket/23706 - Accessing related object of object from not default DB, queries default DB (needs info)
https://code.djangoproject.com/ticket/23718 - TEST_MIRROR setting doesn't work as expected (and has no tests) (accepted)
https://code.djangoproject.com/ticket/23727 - IntegrityError with TransactionTestCase and sqlite (accepted)
https://code.djangoproject.com/ticket/23734 - Templates intro talks about striptags without the appropriate security disclaimer (fixed)
https://code.djangoproject.com/ticket/23735 - Templates intro shouldn't assume admindocs is enabled (fixed)
https://code.djangoproject.com/ticket/23736 - Description of silent_variable_failure is incorrect (fixed)
https://code.djangoproject.com/ticket/23737 - RequestContext docs should recommend the render shortcut more clearly (fixed)
https://code.djangoproject.com/ticket/23739 - django 1.7.1 defer() throws AttributeError when using related_name (accepted)
https://code.djangoproject.com/ticket/23732 - select_related() documentation examples use incorrect fieldnames, and are slightly misleading (fixed)
Authored
--------
https://github.com/django/django/pull/3455 - Fixed #23730 -- Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to http.cookie
https://github.com/django/django/pull/3436 - Fixed #23719 -- Fixed MySQL 5.6 crash with GeometryFields in migrations.
https://github.com/django/django/pull/3451 - Fixed #23731 -- Fixed migrations crash when adding blank GeometryFields on PostGIS.
Reviewed/committed
------------------
https://github.com/django/django/pull/3419 - Fixed #23699 -- Flush command initial_data handling
https://github.com/django/django/pull/3353 - Fixed #23606 -- Implement the RequestFactory trace() method
https://github.com/django/django/pull/3421 - Limited lines to 119 characters in django/{contrib,db}.
https://github.com/django/django/pull/3430 - Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together
https://github.com/django/django/pull/3439 - Fixed #18731 -- Added an example about customizing "makemessages" comman...
https://github.com/django/django/pull/3443 - Fixed #23725 -- Modify documentation to keep consistency using settings.AUTH_USER_MODEL
https://github.com/django/django/pull/3444 - Fixed #23575 -- Added a code example for custom AdminSite
https://github.com/django/django/pull/3358 - Fixed #23558 -- documented slugify limitations
https://github.com/django/django/pull/3437 - FIRST_DAY_OF_WEEK for Ukrainian
https://github.com/django/django/pull/3291 - Fixed #8149 -- Fixed File.__iter__() to handle other newline types.
https://github.com/django/django/pull/3423 - Fixed #23152 -- Added support for transactional Spatialite metadata initialization.
https://github.com/django/django/pull/3446 - Fixed #23733 -- Manage multi-apps dependencies when squashing
https://github.com/django/django/pull/3448 - Adjust documentation about django admin documentation generator
https://github.com/django/django/pull/3449 - Fixed #23670 -- Prevented partial import state during module autodiscovery
https://github.com/django/django/pull/3450 - Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL
https://github.com/django/django/pull/3452 - Fixed #23738 -- Allowed migrating from NULL to NOT NULL with the same default value
https://github.com/django/django/pull/3447 -- Added checks for duplicate fixtures directories in loaddata
https://github.com/django/django/commit/3f651b3e88ac1ba8d04acd5a074362866a0a963a - Added a warning about direct settings manipulation in tests.
Reviews of core dev work
------------------------
https://github.com/django/django/pull/3425 - Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
https://github.com/django/django/pull/3049 - Stopped stripping microseconds with MySQL backend
https://github.com/django/django/pull/3365 - Fixed #23656 -- Made FormMixin.get_form's form_class argument optional.
https://github.com/django/django/pull/3323 - Fixed #23605 -- added relabeled_clone() method to sql.Query
In progress reviews
-------------------
https://github.com/django/django/pull/3284 - Fixed #16731 -- Made pattern lookups work properly with F() expressions
https://github.com/django/django/pull/3426 - Fixed #23641 -- Moved post_migrate signals registration for contrib apps to AppConfig.ready
https://github.com/django/django/pull/3427 - Fixed #13181 -- Added support for callable choices to forms.ChoiceField
https://github.com/django/django/pull/2545 - Fixed #18523 -- Added stream-like API to HttpResponse.
https://github.com/django/django/pull/3121 - Fixed #4444 -- Tidying up 'broken pipe' errors in runserver logs
If you've read the djangoproject.com blog, you know that Berker Peksag and I have been appointed as "Django Fellows" during the three month pilot program. Part of those duties (which started this week) is to provide a weekly summary of our activities to this mailing list. That report follows.
Also, I wanted to mention that part of the purpose of the fellowship program is to provide resources to review code, as that is clearly a bottleneck in our contribution process. If you have tried contributing before and your patch languished without review, I'd encourage you to reach out and try again. While I am not an expert in all areas of Django, I will do my beast to try to help you find someone to review your work if I can't do so myself. Though I'll remind you that *anyone* in the Django community is welcome to review patches and mark them as "ready for checkin", not just core developers. Reviewing patches is a big help and a great way to earn the trust of the team. If you have any feedback on my work, feel free to leave it here or contact me privately.
Thanks for your support of the Django Software Foundation, which makes this program possible!
Tim
Report for week ending October 31, 2014:
In addition to the triage and review work listed below, I updated the Ansible playbooks for Jenkins to run on Ubuntu 14.04 so that we can have a continuous integration server with some newer database versions. (These playbooks need some minor adjustments so as not to reveal passwords before they can be made public.) Upon running Django's test suite on the new machine, I discovered a couple unexpected test failures:
1. 37 test failures with Python 3.2.6. I investigated the failures and created a ticket in the Python tracker that outlines the issue: http://bugs.python.org/issue22758. Corresponding with a Python core developers in that ticket, I learned that the fix for Python's "lax cookie parsing" issue was incomplete and that when it's fixed properly, Django likely won't be compatible with the fixed versions of Python! This affects the Python 2.7 and 3.2+ branches. The remedy for Django (which is altering our workaround for a bug in Python) is outlined in https://code.djangoproject.com/ticket/23730. I created a ticket and submitted a patch to fix the issue in Python itself so we can eventually remove our workaround in Django: http://bugs.python.org/issue22775.
2. A migrations GIS test failure revealed an incompatibility with MySQL 5.6+. I authored a fix for this issue as outlined in https://code.djangoproject.com/ticket/23719.
3. There are a couple of test failures with the version of SpatiaLite (4.1) that's included with Ubuntu 14.04 that I still need to investigate and ticket as necessary.
To briefly summarize the triage and review work, we continue to retrieve good bug reports for Django 1.7, particularly migration edge cases. I'd expect to see another bug fix release for the 1.7 series within a month of 1.7.1. One issue the core team will be addressing at the "Django: Under the Hood" conference in mid-November is adding more team members to the list of people who can release Django. The lack of availability of someone who has the time and privileges to do a release has been a bottleneck on occasion. In addition to bug fixing on the 1.7 branch, master (1.8) continues to receive a steady diet of new small features. A reminder that we expect Django 1.8 to become the next LTS version of Django, so if you have a pet bug or feature, now's a great time to get it fixed!
Triaged
-------
https://code.djangoproject.com/ticket/23681 - Document how to customize NullBooleanSelect choice names (accepted)
https://code.djangoproject.com/ticket/23720 - Login redirect should be glued to schema (invalid)
https://code.djangoproject.com/ticket/23725 - Inconsistent documentation about ForeignKey(User) (accepted)
https://code.djangoproject.com/ticket/23724 - Add overwrite mode to collectstatic (won't fix)
https://code.djangoproject.com/ticket/23729 - Small error in documentation (invalid)
https://code.djangoproject.com/ticket/23706 - Accessing related object of object from not default DB, queries default DB (needs info)
https://code.djangoproject.com/ticket/23718 - TEST_MIRROR setting doesn't work as expected (and has no tests) (accepted)
https://code.djangoproject.com/ticket/23727 - IntegrityError with TransactionTestCase and sqlite (accepted)
https://code.djangoproject.com/ticket/23734 - Templates intro talks about striptags without the appropriate security disclaimer (fixed)
https://code.djangoproject.com/ticket/23735 - Templates intro shouldn't assume admindocs is enabled (fixed)
https://code.djangoproject.com/ticket/23736 - Description of silent_variable_failure is incorrect (fixed)
https://code.djangoproject.com/ticket/23737 - RequestContext docs should recommend the render shortcut more clearly (fixed)
https://code.djangoproject.com/ticket/23739 - django 1.7.1 defer() throws AttributeError when using related_name (accepted)
https://code.djangoproject.com/ticket/23732 - select_related() documentation examples use incorrect fieldnames, and are slightly misleading (fixed)
Authored
--------
https://github.com/django/django/pull/3455 - Fixed #23730 -- Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to http.cookie
https://github.com/django/django/pull/3436 - Fixed #23719 -- Fixed MySQL 5.6 crash with GeometryFields in migrations.
https://github.com/django/django/pull/3451 - Fixed #23731 -- Fixed migrations crash when adding blank GeometryFields on PostGIS.
Reviewed/committed
------------------
https://github.com/django/django/pull/3419 - Fixed #23699 -- Flush command initial_data handling
https://github.com/django/django/pull/3353 - Fixed #23606 -- Implement the RequestFactory trace() method
https://github.com/django/django/pull/3421 - Limited lines to 119 characters in django/{contrib,db}.
https://github.com/django/django/pull/3430 - Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together
https://github.com/django/django/pull/3439 - Fixed #18731 -- Added an example about customizing "makemessages" comman...
https://github.com/django/django/pull/3443 - Fixed #23725 -- Modify documentation to keep consistency using settings.AUTH_USER_MODEL
https://github.com/django/django/pull/3444 - Fixed #23575 -- Added a code example for custom AdminSite
https://github.com/django/django/pull/3358 - Fixed #23558 -- documented slugify limitations
https://github.com/django/django/pull/3437 - FIRST_DAY_OF_WEEK for Ukrainian
https://github.com/django/django/pull/3291 - Fixed #8149 -- Fixed File.__iter__() to handle other newline types.
https://github.com/django/django/pull/3423 - Fixed #23152 -- Added support for transactional Spatialite metadata initialization.
https://github.com/django/django/pull/3446 - Fixed #23733 -- Manage multi-apps dependencies when squashing
https://github.com/django/django/pull/3448 - Adjust documentation about django admin documentation generator
https://github.com/django/django/pull/3449 - Fixed #23670 -- Prevented partial import state during module autodiscovery
https://github.com/django/django/pull/3450 - Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL
https://github.com/django/django/pull/3452 - Fixed #23738 -- Allowed migrating from NULL to NOT NULL with the same default value
https://github.com/django/django/pull/3447 -- Added checks for duplicate fixtures directories in loaddata
https://github.com/django/django/commit/3f651b3e88ac1ba8d04acd5a074362866a0a963a - Added a warning about direct settings manipulation in tests.
Reviews of core dev work
------------------------
https://github.com/django/django/pull/3425 - Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None
https://github.com/django/django/pull/3049 - Stopped stripping microseconds with MySQL backend
https://github.com/django/django/pull/3365 - Fixed #23656 -- Made FormMixin.get_form's form_class argument optional.
https://github.com/django/django/pull/3323 - Fixed #23605 -- added relabeled_clone() method to sql.Query
In progress reviews
-------------------
https://github.com/django/django/pull/3284 - Fixed #16731 -- Made pattern lookups work properly with F() expressions
https://github.com/django/django/pull/3426 - Fixed #23641 -- Moved post_migrate signals registration for contrib apps to AppConfig.ready
https://github.com/django/django/pull/3427 - Fixed #13181 -- Added support for callable choices to forms.ChoiceField
https://github.com/django/django/pull/2545 - Fixed #18523 -- Added stream-like API to HttpResponse.
https://github.com/django/django/pull/3121 - Fixed #4444 -- Tidying up 'broken pipe' errors in runserver logs
Justin Myles Holmes
Oct 31, 2014, 8:28:26 PM10/31/14
to django-d...@googlegroups.com
Tim,
This truly is a stellar report. Thanks so much.
I do have one question about this statement:
> A reminder that we expect Django 1.8 to become the next LTS version of
Django, so if you have a pet bug or feature, now's a great time to get
it fixed!
You characterize this as a "reminder" - I didn't realize this had been
firmly decided, although it was obviously discussed at DjangoCon.
Although I'm definitely in support, I am curious: who made this decision
and when?
This truly is a stellar report. Thanks so much.
I do have one question about this statement:
> A reminder that we expect Django 1.8 to become the next LTS version of
Django, so if you have a pet bug or feature, now's a great time to get
it fixed!
firmly decided, although it was obviously discussed at DjangoCon.
Although I'm definitely in support, I am curious: who made this decision
and when?
Tim Graham
Oct 31, 2014, 9:19:45 PM10/31/14
to django-d...@googlegroups.com
Hi Justin,
Thanks for the feedback. Making 1.8 the next LTS was discussed a bit internally before I shared the idea and tentative schedule for the 1.8 release on the thread "1.8 release planning." The only feedback on that thread (2 weeks ago) was from Josh Smeaton who supported the details outlined there. There is still time to weigh in there if you like.
Tim
Thanks for the feedback. Making 1.8 the next LTS was discussed a bit internally before I shared the idea and tentative schedule for the 1.8 release on the thread "1.8 release planning." The only feedback on that thread (2 weeks ago) was from Josh Smeaton who supported the details outlined there. There is still time to weigh in there if you like.
Tim
Justin Myles Holmes
Oct 31, 2014, 9:46:07 PM10/31/14
to django-d...@googlegroups.com
Tim,
Yes I see. This is great. I agree with your assessments in full.
Yes I see. This is great. I agree with your assessments in full.
--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/98ff9e20-5bc9-474a-aef0-538b1b479aa7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages