Fellow Reports - August 2022
Mariusz Felisiak
Week ending August 7, 2022
Triaged:
https://code.djangoproject.com/ticket/33880 - Ambigous error
message in FilePathFields. (invalid)
https://code.djangoproject.com/ticket/33876 - "default.html"
deprecation warning raised for ManagementForm's (accepted)
https://code.djangoproject.com/ticket/33881 - ArrayField
doesn't set collation. (created)
https://code.djangoproject.com/ticket/33882 - async
transaction.atomic (needsinfo)
https://code.djangoproject.com/ticket/33883 - refactor: use
f-strings (wontfix)
https://code.djangoproject.com/ticket/33884 - REST API without
3rd party package (duplicate)
https://code.djangoproject.com/ticket/33885 - Drop automatic
PostGIS extension creation on PostGIS backend (duplicate)
https://code.djangoproject.com/ticket/33888 -
get_select2_language crashes when translations are deactivated
(accepted)
https://code.djangoproject.com/ticket/33889 - Error in
admin.site.register on pypy3.8 and Django 4.1+. (invalid)
https://code.djangoproject.com/ticket/33890 -
call_command('startproject', 'project_name', '.') raises
CommandError 'project_name' (invalid)
https://code.djangoproject.com/ticket/33891 - TypeError when
trying to run tests in parallel with spawn. (accepted)
https://code.djangoproject.com/ticket/33892 - Management
commands with flags using "store_false" creates inverted boolean
flags in call_command (duplicate)
https://code.djangoproject.com/ticket/33893 - Admin add model
page incorrectly redirects (accepted)
https://code.djangoproject.com/ticket/33894 - Underscore in
CharField as Primary Key breaks related link displayed by admin's
ForeignRawIdWidget (duplicate)
https://code.djangoproject.com/ticket/33895 - Case() crashes
with ~Q(pk__in=[]). (accepted)
https://code.djangoproject.com/ticket/33896 - TypeError:
requires_system_checks must be a list or tuple. (invalid)
https://code.djangoproject.com/ticket/33897 - django.request
log for all requests (wontfix)
https://code.djangoproject.com/ticket/33898 - Window()
expression with ArrayAgg() crashes. (accepted)
https://code.djangoproject.com/ticket/28889 - Use JavaScript
to prevent double submission of admin forms (wontfix)
https://code.djangoproject.com/ticket/33900 - Support for
finding paths in CSS source map comments seems to break manage.py
collectstatic when *.map file is missing (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/15897 - Made MapWidget a
JS class.
https://github.com/django/django/pull/15896 - Refs #25706 --
Removed inline CSS in the openlayers widget template.
https://github.com/django/django/pull/15843 - Fixed #33690 --
Added switch button for dark mode in the admin.
https://github.com/django/django/pull/15907 - Fixed #33887 --
Fixed test_fails_squash_migration_manual_porting() on final tags.
https://github.com/django/django/pull/15906 - Fixed #33886 --
Reallowed using GeoIP2() when GEOS is not installed.
https://github.com/django/django/pull/15909 - Fixed #33888 --
Fixed get_select2_language() crash with no language activated.
https://github.com/django/django/pull/15919 - Fixed #33893 --
Reverted "Fixed #28889 -- Prevented double submission of admin
forms."
Reviewed:
https://github.com/django/django/pull/15902 - Fixed #33876,
Refs #32229 -- Made management forms render with div.html
template.
https://github.com/django/django/pull/15904 - Doc'd
TextField.db_collation as optional.
https://github.com/django/django/pull/15912 - Refs #33173,
Refs #33755 -- Fixed ResourceWarning from unclosed files in ASGI
tests on Python 3.11
Authored:
https://github.com/django/django/pull/15899 - Fixed #33881 --
Added support for database collations to
ArrayField(Char/TextFields).
https://github.com/django/django/pull/15903 - [4.1.x] Updated
translations from Transifex.
https://github.com/django/django/pull/15911 - Fixed #33891 --
Fixed test command crash when running in parallel using spawn.
https://github.com/django/django/pull/15913 - Restricted
permissions for GitHub tokens.
https://github.com/django/django/pull/15924 - Fixed #33898 --
Fixed Window() expression crash with ArrayAgg().
Mariusz Felisiak
https://code.djangoproject.com/ticket/33902 - UniqueConstraint's validation crashes with string expressions. (accepted)
https://code.djangoproject.com/ticket/33904 - Many-To-Many field is deleted/ignored from internal JavaScript “filter” interface (fixed)
https://code.djangoproject.com/ticket/33905 - Validation of check constraints against ranges involving PostgreSQL's lower()/upper() functions produces invalid SQL. (accepted)
https://code.djangoproject.com/ticket/33906 - TestCase inconsistent behavior on Db integrity error. (invalid)
https://code.djangoproject.com/ticket/33907 - UniqueConstraints voided when using GenericTabularInline (needsinfo)
https://code.djangoproject.com/ticket/33908 - ImageField model doesn't have upload_to() method (invalid)
https://code.djangoproject.com/ticket/33909 - Signals docs omits **kwargs param to @receiver decorator? (accepted)
https://code.djangoproject.com/ticket/33911 - Add hook for BaseModelAdmin.raw_id_fields (duplicate)
https://code.djangoproject.com/ticket/33910 - Clearly explain where 'django.urls.reverse' gets its name (invalid)
https://code.djangoproject.com/ticket/33912 - In the admin, saving an object in a non-default DB with unique field fails when the default DB contains an object with the same unique field value but different PK (duplicate)
https://code.djangoproject.com/ticket/33913 - Django 4.1 class-based view, Chinese translation (invalid)
https://code.djangoproject.com/ticket/33914 - App level default_auto_field is ignored for m2m through tables (duplicate)
https://code.djangoproject.com/ticket/33915 - CheckboxSelectMultiple check first item (invalid)
https://code.djangoproject.com/ticket/33918 - __str__ method in Query object not wrapping strings in quotation marks (duplicate)
https://code.djangoproject.com/ticket/33917 - Optimize ModelBase.__new__ app_label setup (wontfix)
https://code.djangoproject.com/ticket/33920 - Document that LOGGING_CONFIG callback is not called when LOGGING dict is not set. (accepted)
https://code.djangoproject.com/ticket/33919 - Primary keys added in non-initial migration are not created as identity columns in PostgreSQL (accepted)
https://code.djangoproject.com/ticket/33921 - Removed LogoutView.get_next_page without any notice (accepted)
https://code.djangoproject.com/ticket/33923 - Swappable Model support for Group Model (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/15925 - Fixed #33899 -- Fixed migration crash when removing indexed field on SQLite 3.35.5+.
https://github.com/django/django/pull/15927 - Added test for non-HTTP request on ASGIStaticFilesHandler.
https://github.com/django/django/pull/15916 - Fixed #31721 -- Allowed ModelForm meta to specify form fields.
https://github.com/django/django/pull/15930 - Fixed #33895 -- Fixed Case() crash with filters that match everything in When().
https://github.com/django/django/pull/15931 - Fixed #33905 -- Fixed CheckConstraint() validation on range fields.
https://github.com/django/django/pull/15942 - Refs #26029 -- Doc'd django.core.files.storage.default_storage.
https://github.com/django/django/pull/15941 - Fixed #28975 -- Made PostGIS backend skip extension creation if installed.
https://github.com/django/django/pull/15945 - Replaced Expression.replace_references() with .replace_expressions().
https://github.com/django/django/pull/15953 - Fixed #33924 -- Deprecated BaseGeometryWidget.map_height/map_width attributes.
https://github.com/django/django/pull/15955 - Fixed #33921 -- Added release note for 5b8699e723d9daf373fff46c6859fed2b780a9bd.
Reviewed:
https://github.com/django/django/pull/15822 - Refs #30213 -- Removed post-startup check for Watchman availability.
Authored:
https://github.com/django/django/pull/15933 - Fixed #33902 -- Fixed Meta.constraints validation crash with F() expressions.
https://github.com/django/djangoproject.com/pull/1194 - Increased FeedItem.link/Feed.public_url max_length to 1023 characters.
https://github.com/django/django/pull/15940 - Refs #33895 -- Fixed Case() crash with filters that match everything in When() on Oracle.
https://github.com/django/django/pull/15952 - Fixed #33919 -- Fixed adding AutoFields on PostgreSQL.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33925 - Testing tools Management Commands example fails (invalid)
https://code.djangoproject.com/ticket/33916 - Support for serialization of combination of Enum flags. (accepted)
https://code.djangoproject.com/ticket/28405 - CICharField on a ModelFormSet doesn't catch unique constraint violations with different capitalization (duplicate)
https://code.djangoproject.com/ticket/33927 - Rendering a read-only ArrayField with choices crashes. (accepted)
https://code.djangoproject.com/ticket/28861 - Add schema tests for CIText fields (invalid)
https://code.djangoproject.com/ticket/33929 - Field Reference in FilteredRelation Does Not Recognize Previously Defined FilteredRelation (duplicate)
https://code.djangoproject.com/ticket/33930 - Add id="deleted-objects" to template admin/delete_confirmation.html (accepted)
https://code.djangoproject.com/ticket/28806 - Mechanism of fetching related objects violates READ COMMITTED assumption of Django ORM (wontfix)
https://code.djangoproject.com/ticket/33932 - Altering AutoFields with renaming a column crashes on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/33933 - Cannot use GeoIP2 without setting up gdal anymore (duplicate)
https://code.djangoproject.com/ticket/33935 - Support unaccent function in JSONField values (duplicate)
https://code.djangoproject.com/ticket/33936 - BaseModelForm.save() ValueError lacks useful information (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/15959 - Fixed #33901 -- Skipped varchar_pattern_ops/text_pattern_ops index creation when db_collation is set.
https://github.com/django/django/pull/15922 - Refs #28333 -- Added partial support for filtering against window functions.
https://github.com/django/django/pull/15957 - Fixed #26780 -- Added prefetch_related() support for sliced queries.
https://github.com/django/django/pull/15954 - Fixed #33778 -- Updated build-system configuration.
https://github.com/django/django/pull/15961 - Fixed #33909 -- Corrected django.dispatch.receiver() signature.
https://github.com/django/django/pull/15964 - Fixed #33932 -- Fixed altering AutoFields to OneToOneField on PostgreSQL.
https://github.com/django/django/pull/15967 - Fixed #33930 -- Eased customization of delete_confirmation.html template in the admin.
https://github.com/django/django/pull/15966 - Used CSS flex for admin's submit row.
Authored:
https://github.com/django/django/pull/15970 - Refs #26511 -- Fixed KeyTextTransform() on MySQL.
Best,
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33954 - NaN can be stored in DecimalField but cannot be retrieved (accepted)
https://code.djangoproject.com/ticket/33955 - AttributeError in admindocs ViewDetailView (accepted)
https://code.djangoproject.com/ticket/33941 - AutoField -> BigAutoField causes PostgreSQL sequence value changes (fixed)
https://code.djangoproject.com/ticket/33956 - timesince filter localization doesn't work for ru-RU (invalid)
https://code.djangoproject.com/ticket/33957 - The "Save and ..." buttons in the admin panel stopped working (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/15949 - Fixed #33916 -- Added support for serialization of enum.Flag in migrations.
https://github.com/django/django/pull/15982 - Refs #18707 -- Corrected django.test.Client signature in docs.
https://github.com/django/django/pull/15991 - Fixed #33830 -- Fixed VariableDoesNotExist when rendering ClearableFileInput.
https://github.com/django/django/pull/15973 - Fixed #33938 -- Fixed migration crash for m2m with a through model in another app.
https://github.com/django/django/pull/15993 - Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a noop for models with db_table."
https://github.com/django/django/pull/15969 - Fixed #33928 -- Avoided unnecessary queries when cascade updating.
https://github.com/django/django/pull/15995 - Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved instances.
https://github.com/django/django/pull/16002 - Fixed #33954 -- Prevented models.DecimalField from accepting NaN, Inf, and -Inf values.
Reviewed:
https://github.com/django/django/pull/15992 - Fixed #24179 -- Added filtering to selected side of vertical/horizontal filters.
Authored:
https://github.com/django/django/pull/16000 - Refs #30511 -- Updated docs about auto-incrementing primary keys on PostgreSQL.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/33958 - Missing imports in "Expressions can reference transforms" section. (accepted)
https://code.djangoproject.com/ticket/33959 - Missing import in "Expressions can reference transforms" section (duplicate)
https://code.djangoproject.com/ticket/33961 - Update admin's jQuery to 3.6.X. (created)
https://code.djangoproject.com/ticket/33962 - I want use Django without admin,auth,sessions,contenttypes or any other prebuild apps (invalid)
https://code.djangoproject.com/ticket/33963 - Combining Q objects with empty querysets crashes. (invalid)
https://code.djangoproject.com/ticket/33966 - Add support for using KeyTextTransform from lookup (accepted)
https://code.djangoproject.com/ticket/33967 - Make EmailValidator accept internationalized local part (duplicate)
https://code.djangoproject.com/ticket/33968 - Make EmailValidator and URLValidator IDNA 2008 compliant (wontfix)
https://code.djangoproject.com/ticket/33970 - select_for_update code snippet example selects for update outside of it's transaction (invalid)
https://code.djangoproject.com/ticket/33965 - Improve docs for PIL validation of ImageField (accepted)
https://code.djangoproject.com/ticket/33971 - admindocs breaks the admin if it appears before the admin in INSTALLED_APPS (accepted)
https://code.djangoproject.com/ticket/33973 - Performance regression when moving from 3.1 to 3.2 (needsinfo)
https://code.djangoproject.com/ticket/33974 - Serializer incorrectly serializes Integer ArrayField as string (wontfix)
https://code.djangoproject.com/ticket/33975 - __in doesn't clear selected fields on the RHS when QuerySet.alias() is used after annotate(). (accepted)
https://code.djangoproject.com/ticket/33976 - HTTP_HOST does not allow an ipv6 not enclosed in [] (invalid)
https://code.djangoproject.com/ticket/33977 - Grouping action in the ModelAdmin (duplicate)
https://github.com/django/django/pull/16005 - Fixed #33958 -- Added imports to examples in "Expressions can reference transforms" section.
https://github.com/django/django/pull/15985 - Fixed #21204 -- Tracked field deferrals by field instead of models.
https://github.com/django/django/pull/16003 - Refs #30947 -- Changed tuples to lists where appropriate.
https://github.com/django/django/pull/15958 - Added Central Kurdish (Sorani) language.
https://github.com/django/django/pull/15977 - Corrected the direction of arrows in admin selector boxes for RTL languages.
https://github.com/django/django/pull/16018 - Fixed #33965 -- Improved file-like object example of ImageField in docs.
https://github.com/django/django/pull/16021 - Fixed ReadOnlyPasswordHashWidget's template for RTL languages.
https://github.com/django/django/pull/15787 - Fixed #29799 -- Allowed registering lookups per field instances.
https://github.com/django/django/pull/16007 - Fixed #33960 -- Fixed migrations crash on SQLite < 3.20.
https://github.com/django/django/pull/16008 - Refs #33953 -- Fixed test_rename_model_with_db_table_rename_m2m() crash on SQLite < 3.26.
https://github.com/django/django/pull/16014 - Refs #26780 -- Made prefetch_related() don't use window expressions for sliced queries if not supported.
https://github.com/django/django/pull/16020 - Reverted "Fixed #30711 -- Doc'd django.contrib.postgres.fields.hstore.KeyTransform()."
https://github.com/django/django/pull/16024 - Fixed #33955, Fixed #33971 -- Reverted "Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs."
https://github.com/django/django/pull/16026 - Corrected heading level of "Registering and fetching lookups" section in docs.
Best,
Mariusz