Fellow Reports - April 2023

[Mariusz Felisiak]

Week ending April 9, 2023

Released Django 4.2 and 4.1.8.

Triaged:
    https://code.djangoproject.com/ticket/34451 - Incorrect handling of ImproperlyConfigured Exception in views in ASGI context (accepted)
    https://code.djangoproject.com/ticket/34453 - Parameterized raw queries no longer support lists (duplicate)
    https://code.djangoproject.com/ticket/34039 - Admin search bar is too small to use on small screens (fixed)
    https://code.djangoproject.com/ticket/34455 - i18n_patterns() not respecting prefix_default_language=False (accepted)
    https://code.djangoproject.com/ticket/34456 - Add a way to set allow_cascade=True in _fixture_teardown() (invalid)
    https://code.djangoproject.com/ticket/34457 - makemigrations --check no longer prints the changes (wontfix)
    https://code.djangoproject.com/ticket/34461 - Constructing urls outside the request cycle (wontfix)
    https://code.djangoproject.com/ticket/34463 - WHERE clause example missing from Q() documentation (accepted)
    https://code.djangoproject.com/ticket/34464 - QuerySet.count() regression on Django 4.2 with values() and annotate() (accepted)
    https://code.djangoproject.com/ticket/34028 - Django 'static' template tag fails to generate URLs with SCRIPT_NAME prefix (invalid)
    https://code.djangoproject.com/ticket/34469 - Push inspectdb to assimilate the foreign keys that are in other databases (duplicate)
    https://code.djangoproject.com/ticket/34470 - client_encoding is no longer set on PostgreSQL. (created)
    https://code.djangoproject.com/ticket/34471 - Cannot import name 'url' from 'django.conf.urls' (invalid)
    https://code.djangoproject.com/ticket/34468 - `Cycle` tag do not work with variables defined in `with`-tag. (invalid)
    https://code.djangoproject.com/ticket/34465 - Handle malformed CSRF cookie (needsinfo)
    https://github.com/django/djangoproject.com/issues/1341 - Update list of fellows on the fundraising page. (created)
    https://code.djangoproject.com/ticket/34473 - StepValueValidator does not take into account min_value (accepted)
    https://code.djangoproject.com/ticket/34478 - django 4.2 admin page issue (invalid)
    https://code.djangoproject.com/ticket/34477 - Asyncio send mail backend (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16716 - Prevented PostgreSQL's DatabaseCreation._execute_create_test_db() from hiding clause-less exceptions.
    https://github.com/django/django/pull/16698 - Fixed #34431 -- Improved Date/DateTimeField/TimeField.input_formats docs.
    https://github.com/django/django/pull/16603 - Fixed #33738 -- Allowed handling ASGI http.disconnects in long-lived requests.
    https://github.com/django/django/pull/16718 - Moved cache decorators tests into decorators/test_cache.py.
    https://github.com/django/django/pull/16719 - Fixed Central Kurdish (Sorani) translations of date-related strings.
    https://github.com/django/django/pull/16710 - Fixed #34450 -- Fixed multi-valued JOIN reuse when filtering by expressions.
    https://github.com/django/django/pull/16722 - Refs #34434 -- Added note about breaking changes in psycopg version 3 to release notes.
    https://github.com/django/django/pull/16724 - Fixed #34458 -- Fixed QuerySet.defer() crash on attribute names.
    https://github.com/django/django/pull/16732 - Refs #34028 -- Doc'd that get_script_prefix() cannot be used outside of the request-response cycle.
    https://github.com/django/django/pull/16733 - Fixed #34463 -- Corrected code-block directives in docs.
    https://github.com/django/django/pull/16734 - Fixed #34464 -- Fixed queryset aggregation over group by reference.
    https://github.com/django/django/pull/16736 - Fixed #34466 -- Reallowed setting cursor_factory in DATABASES["options"] on PostgreSQL.

Authored:
    https://github.com/django/django/pull/16713 - Updated Transifex configuration for new CLI.
    https://github.com/django/django/pull/16715 - [4.2.x] Updated translations from Transifex.
    https://github.com/django/django/pull/16729 - Refs #34118 -- Fixed CustomChoicesTests.test_uuid_unsupported on Python 3.12+.
    https://github.com/django/django/pull/16731 - Fixed #34459 -- Fixed SearchVector() crash for parameters with % characters.
    https://github.com/django/django/pull/16739 - Fixed #34470 -- Enforced UTF-8 encoding on PostgreSQL.

Best,
Mariusz

[Natalia Bidart]

Week ending April 9, 2023

Hello! I'm Natalia (AKA nessita), the new Django Fellow. I officially started on April 1st (really :-)) though I had a slow start since I had a long-time planned vacation.

So far I have held catch up calls with both current and former Django Fellows (thanks Mariusz and Carlton for your patience and support!), and I have been deep diving into documentation.

I'm looking forward to working with you all!

Thank you!

Natalia.

[Adam Johnson]

Welcome Natalia 😊

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CA%2BfOnFbRDqYGpBGPTB28EknOuP8PQcAJTvYwNGuqNKmL0zeHtQ%40mail.gmail.com.

[Paolo Melchiorre]

Welcome Natalia 🤗

--

[Mariusz Felisiak]

Week ending April 16, 2023

Triaged:
    https://code.djangoproject.com/ticket/34480 - Annotating with Chr raises ValueError (accepted)
    https://code.djangoproject.com/ticket/34481 - Admin check for reversed foreign key used in "list_display" (accepted)
    https://code.djangoproject.com/ticket/34482 - Unable to access "non-picklable" attributes of empty HttpRequest and HttpResponse objects after shallow copy. (accepted)
    https://code.djangoproject.com/ticket/34483 - Negative result of django.utils.timesince.timesince (accepted)
    https://code.djangoproject.com/ticket/34486 - SearchHeadline crashes without an active connection. (accepted)
    https://code.djangoproject.com/ticket/34484 - HttpRequest.__deepcopy__ doesn't deepcopy attributes (accepted)
    https://code.djangoproject.com/ticket/34487 - Django crashes due to ManifestStaticFilesStorage plugin in 4.2 (needsinfo)
    https://code.djangoproject.com/ticket/34488 - ClearableFileInput widget forgets "Clear" selection when form is not valid (duplicate)
    https://code.djangoproject.com/ticket/34492 - I get an error when using BinaryField in sqllite3. (invalid)
    https://code.djangoproject.com/ticket/34491 - Unable to have constraints with same name on different models (wontfix)
    https://code.djangoproject.com/ticket/34493 - wrong translation (invalid)
    https://code.djangoproject.com/ticket/34494 - This is suggestion about customizing AdminSite documents (invalid)
    https://code.djangoproject.com/ticket/34496 - ManifestStaticFilesStorage.patterns for sourceMappingURL does not retrieve matched line to return for for example data URI (needsinfo)
    https://code.djangoproject.com/ticket/34498 - error 403 in login in django (invalid)
    https://code.djangoproject.com/ticket/34495 - Queryset update fails when updating parent model field with default ordering on MySQL backend (worksforme)
    https://code.djangoproject.com/ticket/34499 - In tutorial part08, Django debug toolbar shows up in admin site but not in public site (wontfix)

Reviewed/committed:
    https://github.com/django/django/pull/16735 - Fixed #34455 -- Restored i18n_patterns() respect of prefix_default_language argument when fallback language is used.
    https://github.com/django/django/pull/16750 - Fixed #34480 -- Fixed crash of annotations with Chr().
    https://github.com/django/djangoproject.com/pull/1346 - Fixed #1341 -- Updated info about past and present Django Fellows.
    https://github.com/django/django/pull/16749 - Fixed #34394 -- Made ASGIRequest respect FORCE_SCRIPT_NAME.
    https://github.com/django/django/pull/16746 - Fixed #27505 -- Allowed customizing Paginator's error messages.
    https://github.com/django/django/pull/16760 - Fixed #34486 -- Fixed DatabaseOperations.compose_sql() crash with no existing database connection on PostgreSQL.
    https://github.com/django/django/pull/16712 - Fixed #34419 -- Doc'd django.contrib.admin.sites.all_sites.

Reviewed:
    https://github.com/django/django/pull/16756 - Fixed #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates and interval less than 1 day.

Authored:
    https://github.com/django/django/pull/16755 - Fixed #34484, Fixed #34482 -- Fixed cloning/deep cloning HttpRequest, HttpResponse, and their subclasses.
    https://github.com/django/django/pull/16763 - [4.2.x] Refs #34483 -- Fixed utils_tests.test_timesince crash on Python 3.8.
    https://github.com/django/django/pull/16764 - Refs #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates on different days and interval less than 1 day.

Best,
Mariusz

[Natalia Bidart]

Week ending 2023-04-16 (Week 16)

Triaged:
  https://code.djangoproject.com/ticket/34490 - Tests with mirror database not working as expected (invalid)
  https://code.djangoproject.com/ticket/34489 - feature: Support for PostgreSQL table partitioning (needsinfo)

Reviewed:
  https://github.com/django/django/pull/16726 - Solved #10743: Support lookup separators
  https://github.com/django/django/pull/16756 - Fixed #34484, Fixed #34482 -- Fixed cloning/deep cloning HttpRequest, HttpResponse, and their subclasses.
  https://github.com/django/django/pull/16759 - Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect get_list_filter().

Authored:

  https://github.com/django/djangoproject.com/pull/1346 - Fixed #1341 -- Updated info about past and present Django Fellows.

  https://github.com/django/django/pull/16756 - Fixed #34483 -- Fixed timesince()/timeuntil() with timezone-aware dates and interval less than 1 day.

Other/Misc:
  Security mailing list monitoring and follow ups
  More docs reading
  Setup access to various services and projects
  Investigated and commented on https://code.djangoproject.com/ticket/32847 - Adjust models.E025 system check for updated field descriptor setting.

Cheers! Natalia.

[Mariusz Felisiak]

Week ending April 23, 2023

Triaged:
    https://code.djangoproject.com/ticket/34488 - ClearableFileInput widget forgets "Clear" selection when form is not valid. (accepted)
    https://code.djangoproject.com/ticket/34500 - use annotate return feild, Error capture does not work (duplicate)
    https://code.djangoproject.com/ticket/34496 - ManifestStaticFilesStorage.patterns for sourceMappingURL does not retrieve matched for data URI (accepted)
    https://code.djangoproject.com/ticket/34501 - Revert CICharField deprecation (wontfix)
    https://code.djangoproject.com/ticket/34502 - Union giving wrong column ordering even when using .values/.values_list (duplicate)
    https://code.djangoproject.com/ticket/34504 - SSLCertVerificationError on outgoing emails for some mailboxes (needsinfo)
    https://code.djangoproject.com/ticket/34506 - Visual regressions in admin's clearable file input. (created)
    https://code.djangoproject.com/ticket/34505 - Non-deterministic collations doesn't work with unique related fields on PostgreSQL (accepted)
    https://code.djangoproject.com/ticket/34509 - Celery task throwing error (invalid)
    https://code.djangoproject.com/ticket/34508 - Admin Checks Reversed FKs.( modified check_list_display function ) (needsinfo)
    https://code.djangoproject.com/ticket/34507 - AttributeError: Can't pickle local object 'convert_exception_to_response.<locals>.inner' (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/16773 - Used extlinks for PyPI links.

    https://github.com/django/django/pull/16759 - Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect get_list_filter().

    https://github.com/django/django/pull/16632 - Fixed #16055 -- Fixed crash when filtering against char/text GenericRelation relation on PostgreSQL.
    https://github.com/django/django/pull/16641 - Added Irish locale formats.
    https://github.com/django/django/pull/16783 - Fixed #34435 -- Doc'd that JSONField.default must be a callable.
    https://github.com/django/django/pull/16781 - Corrected exception type in safe_join()'s docstring.
    https://github.com/django/django/pull/16692 - Fixed #34440 -- Doc'd that & queryset operator works similar to chaining.
    https://github.com/django/django/pull/16780 - Fixed #34496 -- Fixed handling source maps with data URI in ManifestStaticFilesStorage.
    https://github.com/django/django/pull/16785 - Fixed #34488 -- Made ClearableFileInput preserve "Clear" checked attribute when form is invalid.
    https://github.com/django/django/pull/16788 - Fixed #34505 -- Skipped varchar_pattern_ops/text_pattern_ops index creation when db_collation is set in related field.
    https://github.com/django/django/pull/16791 - Refs #34462 -- Fixed queryset antipattern when processing object deletion.

Reviewed:
    https://github.com/django/django/pull/16771 - Doc'd RemovedInDjangoXXWarning comments in deprecating a feature guide.

Authored:
    https://github.com/django/django/pull/16784 - Added meaningful titles to ..admonition:: directives.
    https://github.com/django/django/pull/16787 - Improved examples in docs about raw SQL queries.
    https://github.com/django/django/pull/16789 - Fixed #34506 -- Fixed margin of ClearableFileInput in admin CSS.

Best,
Mariusz

[Natalia Bidart]

Week ending 2023-04-23 (Week 17)

Triaged:
  https://code.djangoproject.com/ticket/34506 - Visual regressions in admin's clearable file input. (accepted)
  https://code.djangoproject.com/ticket/34507 - AttributeError: Can't pickle local object 'convert_exception_to_response.<locals>.inner' (needsinfo)

Reviewed:
  https://github.com/django/django/pull/16771 - Added RemovedInDjangoXXWarning comments to the deprecating a feature docs.

  https://github.com/django/django/pull/16784 - Added meaningful titles to ..admonition:: directives.

  https://github.com/django/django/pull/16757 - Fixed #34481 -- Added checks for reverse related fields in admin's list_display
  https://github.com/django/django/pull/16636/ - Fixed #34391 -- Added async interface to auth (lots of interesting things to read around this!)
  https://github.com/django/django/pull/14257 - Made SimpleTestCase client attributes cached properties.

PR Housekeeping:
  https://github.com/django/django/pull/7161 - Fixed #25594 -- Propagated validators from model to form fields (closed)
  https://github.com/django/django/pull/8435 - Optimized ModelAdmin.changelist_view if actions are not used (closed)
  https://github.com/django/django/pull/8848 - Allowed (partial) indexes for text fields on MySQL (closed)
  https://github.com/django/django/pull/10708 - Form field label i18n performances fixes (closed)
  https://github.com/django/django/pull/10349 - Fixed #29717 -- Allowed tests to use an existing empty database. (closed)
  https://github.com/django/django/pull/10951 - WIP #30149 -- Empty value selected check in Admin Filter prevents subclassing (closed)
  https://github.com/django/django/pull/11291 - Fixed #30416 -- Restore terminal state when reloading. (asked for update)
  https://github.com/django/django/pull/11981 - Fixed #23051 -- Raise exception on only() calls with reverse fields (asked for update)
  https://github.com/django/django/pull/12090 - Fixed #29058 -- return geom type for GeoDjango fields when using Spatialite backend so that migrations don't fail. (asked for update)
  https://github.com/django/django/pull/12274 - [WIP/RFC] DateField/TimeField: allow for editable=True with auto_now/auto_now_add (closed)
  https://github.com/django/django/pull/13853 - Refs #21429 -- Added SimpleTestCase.assertLogRecords. (asked for update)
  https://github.com/django/django/pull/12285 - URLValidator: clarify comment about maximum length of a host name. (resolved conflict and chasing down who can further comment about the change)
  
Authored:
  https://github.com/django/django/pull/16791 - Refs #34462 -- Fixed query anti-pattern when processing object deletion

Other/Misc:
  Google Summer of Code proposals review.

[Mariusz Felisiak]

Week ending April 30, 2023

Triaged:

    https://code.djangoproject.com/ticket/34229 - "no such column" when combining FilteredRelation and multi-table inheritance models (accepted)
    https://code.djangoproject.com/ticket/34515 - Translatable URL patterns raise 404 for non-English default language when prefix_default_language=False is used. (accepted)
    https://code.djangoproject.com/ticket/34517 - ImageField unnecessarily adds a post_init signal handler to the model (accepted)
    https://code.djangoproject.com/ticket/34518 - "random" template filter crashes on an empty list. (accepted)
    https://code.djangoproject.com/ticket/34519 - Don't send content in responses to HEAD requests (duplicate)
    https://code.djangoproject.com/ticket/34521 - Use __slots__ for template Node classes (accepted)
    https://code.djangoproject.com/ticket/34522 - PUT/PATCH data is not encoded for multipart/form-data in Django Test Client (duplicate)
    https://code.djangoproject.com/ticket/34524 - Error while sending TLS smtp email on "self-signed certificate" server (duplicate)
    https://code.djangoproject.com/ticket/34523 - Model.objects.update_or_create method sometimes raises TransactionManagementError (accepted)
    https://code.djangoproject.com/ticket/34527 - Unexpected behavior with division in aggregation (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/16786 - Fixed #33766 -- Resolved FilteredRelation.condition at referencing time.
    https://github.com/django/django/pull/16776 - Updated admin's XRegExp to 5.1.1.
    https://github.com/django/django/pull/16436 - Refs #31949 -- Made @never_cache and @cache_control() decorators to work with async functions.
    https://github.com/django/django/pull/16796 - Replaced docutils link by PyPI reference.
    https://github.com/django/django/pull/16802 - Fixed #34518 -- Fixed crash of random() template filter with an empty list.
    https://github.com/django/django/pull/16803 - Doc'd that Count("*") is equivalent to COUNT(*) SQL.
    https://github.com/django/django/pull/16807 - Refs #33662 -- Corrected Sitemap.get_languages_for_item() signature in docs.
    https://github.com/django/django/pull/16614 - Fixed #34380 -- Allowed specifying a default URL scheme in forms.URLField.

Reviewed:
    https://github.com/django/django/pull/16757 - Fixed #34481 -- Added system check for reverse related fields in ModelAdmin.list_display.

Authored:
    https://github.com/django/django/pull/16799 - Fixed #34512 -- Restored breadcrumbs on admin app index view.
    https://github.com/django/django/pull/16804 - Avoided creating default form fields in fields_for_model() when declared on form.
    https://github.com/django/django/pull/16810 - Fixed #34515 -- Made LocaleMiddleware prefer language from paths when i18n patterns are used.
    https://github.com/django/django/pull/16812 - Refs #34118, Refs #34504 -- Added backward incompatibility note about EmailBackend.ssl_context.

Best,
Mariusz

[Mohamed El-Kalioby]

Hello everyone,

I’ve opened this issue on the issue tracker, and was asked to post here for the sake of discussion.

In SaaS product, we have set of organizations (customers), each organization is working under its own subdomain under the SaaS domain, and each is completely independent. Each organization will have a super user who shall have access to the Django admin to edit their organization objects. Currently, Django admin only shows the objects which belong to the SITE_ID even with setting the default_manager to the current_site manager and enabling the sites middleware.

I think this behavior is misleading and Django admin shall support sites app, so what do you think?

Best regards

Mohamed ElKalioby

[אורי‎]

Can you link to the ticket?

אורי

u...@speedy.net

--

You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFJxxNcteC-sA5%3Db1JCjMg4bAOgNsd%3DHrzwb152SjOhnZQRC4g%40mail.gmail.com.

[Mohamed El-Kalioby]

Here it is

https://code.djangoproject.com/ticket/34526

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABD5YeH34ivmtsf0Lm4WLkGcsRnL6GNDAKXZEJBMYhwdc-UudA%40mail.gmail.com.

[Natalia Bidart]

Week ending 2023-04-30 (Week 18)

Triaged:
  https://code.djangoproject.com/ticket/34523 - update_or_create not work in parallel insertion
  https://code.djangoproject.com/ticket/34520 - ModelAdmin.fields: wrapping in tuples does not have any effect (each field on separate line) (invalid)
  https://code.djangoproject.com/ticket/34525 - index_together warning after migration to new style (accepted)

Landed:

  https://github.com/django/django/pull/16757 - Fixed #34481 -- Added checks for reverse related fields in admin's list_display

  https://github.com/django/django/pull/16808 - Restored multiprocessing concurrency on coverage.py settings

Reviewed:
  https://github.com/django/django/pull/16777 - Fixed #12780 -- Added compound form/formset validation in ModelAdmin
  https://github.com/django/django/pull/16798 - fix: correct 'decade' computation
  https://github.com/django/django/pull/16797 - Fixed #34515 -- Updated to redirect to request language when from translated default url.

  https://github.com/django/django/pull/16804 - Avoided creating default form fields in fields_for_model() when declared on form.

  https://github.com/django/django/pull/16808 - Restored multiprocessing concurrency on coverage.py settings #16808

PR Cleanup:
  https://github.com/django/django/pull/14499 - Improve accuracy of NullBooleanField deprecation warning hint.
  https://github.com/django/django/pull/14408 - Fixed #32827 -- Adjusted docs on squashing migrations.
  https://github.com/django/django/pull/14082 - docs/ref/databases: rephrase persistent connections section
  https://github.com/django/django/pull/13169 - Add field_name to the non-existing readonly_fields error
  https://github.com/django/django/pull/12712 - Fix #27060: Add indexes identified in constraints to Meta.indexes

Other/Misc:
  Google Summer of Code final review and ranking.
  DjangoCon US travel preparation.
  Deep-dive in the translations framework to assist with the release blocker https://code.djangoproject.com/ticket/34515

Cheers! Natalia.