Fellow Reports - August 2023

118 views
Skip to first unread message

Mariusz Felisiak

unread,
Aug 8, 2023, 6:00:38 AM8/8/23
to django-d...@googlegroups.com

Week ending August 6, 2023

Triaged:
    https://code.djangoproject.com/ticket/34756 - Docs build failure when using Sphinx 7.1.1 (accepted)
    https://code.djangoproject.com/ticket/34754 - CheckConstraint with isnull lookup on JSONField transform None into null jsonb value (accepted)
    https://code.djangoproject.com/ticket/34758 - Paginator.validate_number implementation has undocumented change in 4.2 (invalid)
    https://code.djangoproject.com/ticket/34759 - Confirm/Add support for SpatiaLite 5.1 (accepted)
    https://code.djangoproject.com/ticket/34760 - Drop support for SQLite < 3.26.0 (created)
    https://code.djangoproject.com/ticket/34761 - Drop support for MySQL < 8.0.11. (created)
    https://code.djangoproject.com/ticket/34763 - Should we disallow URLs as user fields? (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/17111 - Fixed #32820 -- Added aria-invalid="true" to fields with errors.
    https://github.com/django/django/pull/17134 - Corrected pycon formatting in some docs.
    https://github.com/django/django/pull/17116 - Simplified django.http.request.split_domain_port().
    https://github.com/django/django/pull/16194 - Fixed #33507 -- Used UUID data type on MariaDB 10.7+.
    https://github.com/django/django/pull/17135 - Fixed #34756 -- Fixed docs build on Sphinx 7.1+.
    https://github.com/django/django/pull/17061 - Fixed #34686 -- Added support for GEOS 3.12.
    https://github.com/django/django/pull/17138 - Fixed #34754 -- Fixed JSONField check constraints validation on NULL values.
    https://github.com/django/django/pull/17144 - Fixed #15799 -- Doc'd that Storage._open() should raise FileNotFoundError when file doesn't exist.
    https://github.com/django/django/pull/17146 - Fixed #34739 -- Added GEOSGeometry.equals_identical() method.

Authored:
    https://github.com/django/django/pull/17130 - Fixed #34750 -- Fixed QuerySet.count() when grouping by unused multi-valued annotations.
    https://github.com/django/django/pull/17137 - Removed unneeded escapes in regexes.
    https://github.com/django/django/pull/17140 - Fixed #34761 -- Dropped support for MySQL < 8.0.11.
    https://github.com/django/django/pull/17141 - Refs #33713 -- Removed unnecessary version check in DatabaseFeatures.update_can_self_select on MariaDB.
    https://github.com/django/django/pull/17143 - Fixed #34760 -- Dropped support for SQLite < 3.27.
    https://github.com/django/django/pull/17148 - Fixed TransactionalTests.test_password_with_at_sign() isolation on Oracle.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 20, 2023, 10:11:38 AM8/20/23
to Django developers (Contributions to Django itself)
Week ending August 13, 2023

Triaged:
    https://code.djangoproject.com/ticket/22055 - 404 page does not display stack trace when Resolver404 is raised from a view (wontfix)
    https://code.djangoproject.com/ticket/34766 - utils.text: slugify misses "l" when converting "ł" (duplicate)
    https://code.djangoproject.com/ticket/34767 - AdminReadonlyField may not show links to related models when the related model has been downcasted (needsinfo)
    https://code.djangoproject.com/ticket/34769 - JSONField key/path transforms tests fail on Oracle 21c. (created)
    https://code.djangoproject.com/ticket/29061 - manage.py makemessages throws syntax error due to incorrectly generated django.pot, again (worksforme)
    https://code.djangoproject.com/ticket/34771 - QuerySet.order_by() crashes on constants that cannot be cast on MySQL. (invalid)
    https://code.djangoproject.com/ticket/34772 - Exception with psycopg3 binary package on Ubuntu 20.04 (needsinfo)
    https://code.djangoproject.com/ticket/34773 - settings.STATICFILES_STORAGE does not return correct value when STORAGES are defined (accepted)
    https://code.djangoproject.com/ticket/34774 - ModelAdmin form validation that cross-validates main form and inline formsets (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/17131 - Fixed #34542 -- Made createsuperuser handle required blank fields in non-interactive mode.
    https://github.com/django/django/pull/17152 - Added IntegerField tests for invalid choices.
    https://github.com/django/django/pull/17112 - Fixed #34586 -- Made QuerySet.create() raise ValueError for reverse one-to-many relations.
    https://github.com/django/django/pull/17106 - Fixed #34692 -- Made autoreloader reset cached template loader for default renderer.
    https://github.com/django/django/pull/15841 - Fixed #33817 -- Added support for python-oracledb and deprecated cx_Oracle.
    https://github.com/django/django/pull/17157 - Fixed #34743 -- Fixed Meta.constraints validation crash when using pk.
    https://github.com/django/django/pull/16622 - Fixed #34362 -- Fixed FilteredRelation() crash on conditional expressions.
    https://github.com/django/django/pull/17163 - Added Uyghur language.

Reviewed:
    https://github.com/django/django/pull/16943 - Fixed #31262 -- Allowed dictionaries in Field.choices for named groups.

Authored:
    https://github.com/django/django/pull/17153 - Refs #34233 -- Bumped required cx_Oracle to 8.3.
    https://github.com/django/django/pull/17154 - Fixed non-deterministic order in SubqueryTests.test_slice_subquery_and_query
    https://github.com/django/django/pull/17155 - Fixed DatabaseFeatures.supports_primitives_in_json_field on Oracle 21c+.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 21, 2023, 7:53:26 AM8/21/23
to Django developers (Contributions to Django itself)
Week ending August 20, 2023

I spent the whole week on a tiny Italian island 🏝️ 🇮🇹 , so didn't work much 🍝 🐙 🦐 🚲 ☀️.

Triaged:
    https://code.djangoproject.com/ticket/34780 - Tests don't pass on Python 3.11.4. (invalid)
    https://code.djangoproject.com/ticket/34782 - Explicit support for In-Reply-To / References in EmailMessage (wontfix)
    https://code.djangoproject.com/ticket/34779 - Serializer makes unnecessary joins (accepted)
    https://code.djangoproject.com/ticket/34785 - Contribution guide comes out non successful (invalid)
    https://code.djangoproject.com/ticket/34786 - Multiple Q objects in the same .filter() behave oddly with ManyToMany relationships (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/17164 - Fixed #34779 -- Avoided unnecessary selection of non-nullable m2m fields without natural keys during serialization.

Authored:
    https://github.com/django/django/pull/17170 - Fixed #34773 -- Fixed syncing DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings with STORAGES.
    https://github.com/django/django/pull/17174 - Fixed utils_tests.test_lazyobject.SimpleLazyObjectPickleTestCase.
    https://github.com/django/django/pull/17175 - Fixed DatabaseCreation.get_test_db_clone_settings() for empty database name on SQLite.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 29, 2023, 1:07:44 AM8/29/23
to Django developers (Contributions to Django itself)
Week ending August 27, 2023

Triaged:
    https://code.djangoproject.com/ticket/34787 - The 'runserver' command doesn't work when run from an installed script on Windows (needsinfo)
    https://code.djangoproject.com/ticket/34788 - Correct NUMBER_GROUPING in Japan. (accepted)
    https://code.djangoproject.com/ticket/34792 - Creating and saving a model using a custom primary key field can yield a bad "id" value on the instance (duplicate)
    https://code.djangoproject.com/ticket/34793 - Django ORM returns None when field has value in BD (invalid)
    https://code.djangoproject.com/ticket/34794 - Multiple file upload issue (invalid)
    https://code.djangoproject.com/ticket/34791 - Prefetch's queryset attribute is ignored when the same nested relation is used multiple times. (accepted)
    https://code.djangoproject.com/ticket/34797 - Django Admin radio fields admin.HORIZONTAL shows as vertical with django-grapelli. (invalid)
    https://code.djangoproject.com/ticket/34798 - Using Django 4.2 with MSSQL 2019 Aggregation Containing Subquery Fails (invalid)
    https://code.djangoproject.com/ticket/34796 - Deleting child table does not delete rows in parent table when using multi-table inheritance (duplicate)
    https://code.djangoproject.com/ticket/34799 - inspectdb fails on tables with cross-schema relations on MySQL. (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16923 - Fixed #33143 -- Raised RuntimeWarning when performing import-time queries.
    https://github.com/django/django/pull/17180 - Fixed #34788 -- Corrected NUMBER_GROUPING for Japanese.
    https://github.com/django/django/pull/17167 - Added tests for model field's choices iterator/iterable values.
    https://github.com/django/django/pull/17181 - Removed unnecessary trailing commas in tests.
    https://github.com/django/django/pull/17182 - Refs #34757 -- Moved HTTP redirect logic to django.test.client.ClientMixin.
    https://github.com/django/django/pull/17114 - Fixed #34744 -- Prevented recreation of migration for constraints with a dict_keys.
    https://github.com/django/django/pull/17188 - Refs #24121 -- Added __repr__() to Message.
    https://github.com/django/django/pull/17196 - Refs #34730 -- Made Message importable from django.contrib.messages.

Authored:

    https://github.com/django/django/pull/17178 - Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
    https://github.com/django/django/pull/17190 - Avoided counting exceptions in AsynClient docs.
    https://github.com/django/django/pull/17184 - Fixed #34709 -- Raised BadRequest for non-UTF-8 requests with the application/x-www-form-urlencoded content type.
    https://github.com/django/django/pull/17192 - Corrected AsyncRequestFactory's docstring.
    https://github.com/django/django/pull/17198 - Refs #33507 -- Doc'd using UUID data type on MariaDB 10.7+ in UUIDField docs.

Best,
Mariusz

Mariusz Felisiak

unread,
Sep 4, 2023, 12:13:57 AM9/4/23
to Django developers (Contributions to Django itself)
Week ending September 3, 2023

Triaged:
    https://code.djangoproject.com/ticket/34802 - django.contrib.admin.actions.delete_selected() should return number of rows deleted via ModelAdmin.delete_queryset() (wontfix)
    https://code.djangoproject.com/ticket/34804 - legacy_algorithm = 'sha1' removed in django4.0 but new algorithm is hardcoded (invalid)
    https://code.djangoproject.com/ticket/34805 - 'Q' object has no attribute 'replace_expressions' (invalid)
    https://code.djangoproject.com/ticket/34803 - Nested OuterRef crashes with AttributeError (accepted)
    https://code.djangoproject.com/ticket/34778 - startproject could use find_spec() rather than import_module() to check for conflicts (accepted)
    https://code.djangoproject.com/ticket/34809 - PyCharm typechecker complains (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/17203 - Fixed #34787 -- Fixed autoreloader crash when run from installed script on Windows.
    https://github.com/django/django/pull/17187 - Fixed #34784 -- Adjusted SHORT_DATE_FORMAT in various French variants.
    https://github.com/django/django/pull/17168 - Fixed #34757 -- Added support for following redirects to AsyncClient.
    https://github.com/django/django/pull/17205 - Fixed #34799 -- Made MySQL introspection skip cross-database relations.
    https://github.com/django/django/pull/17171 - Fixed #34547 -- Deprecated DatabaseOperations.field_cast_sql().
    https://github.com/django/django/pull/16976 - Fixed #34210 -- Added unittest's durations option to the test runner.
    https://github.com/django/django/pull/17081 - Refs #34712 -- Added system check for staticfiles storage in STORAGES setting.
    https://github.com/django/django/pull/17215 - Fixed #34807 -- Avoided circular import between forms, models, and utils' choices.
    https://github.com/django/django/pull/17217 - Fixed #34803 -- Fixed queryset crash when filtering againts deeply nested OuterRef annotations.
    https://github.com/django/django/pull/17211 - Fixed #34768 -- Avoided initializing colorama on non-Windows platforms.
    https://github.com/django/django/pull/17216 - Fixed #34778 -- Avoided importing modules in startapp/startproject.

Authored:
    https://github.com/django/django/pull/17206 - Fixed #34560 -- Updated admin's jQuery to 3.7.1.
    https://github.com/django/django/pull/17218 - Refs #34768 -- Ignored lack of just_fix_windows_console() for colorama < 0.4.6.

Best,
Mariusz
Reply all
Reply to author
Forward
0 new messages