makemessages management command should not touch POT-Creation-Date

[Daniyal Abbasi]

Hi

I was recently working on some git hooks with the makemessages command and I noticed that the "POT-Creation-Date" was always updated even if no strings were added, removed or relocated.

I created a ticket (#33056) and was redirected to #6106 which is the original ticket which was closed over 11 years ago. However, I'd like to bring this into discussion and hoping to open this issue once again.

If the po file exists, the makemessages command uses `msgmerge` in the `write_po_file` method to get the contents of the po file. (Refer this). However, msgmerge is not ran in the update mode using the `--update` flag. 

I propose on added this flag and making other suitable modifications as this causes a lot of issues with source control and git hooks. I've created a sample PR for the same.

Looking forward to hear what everyone thinks about this!

Thanks and regards,

Daniyal Abbasi

[Adam Johnson]

I'm in favour of the change. Leaving the file as-is when no actual data changed just makes sense to me.

The original discussion didn't touch upon the --update flag, so maybe it didn't exist then, or the participants didn't know about it. Its existence really weakens the argument that “we shouldn't redefine the meaning of gettext's header fields”.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/32440770-55aa-4feb-b164-6940ca07838fn%40googlegroups.com.

[אורי‎]

I also find it annoying that one line changes always even if there are no changes in translations. I prefer the file not to change at all if nothing has changed.

אורי

u...@speedy.net

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM0QLFy3hE%2BPwk6%3DLbRP2-OqjaCYounLa6fzU4Q14xSBRw%40mail.gmail.com.

[Paolo Melchiorre]

Hi all,

I'm also in favour of the change, I also find the current behaviour annoying.

Paolo

‪On Tue, Aug 31, 2021 at 1:10 PM ‫אורי‬‎ <u...@speedy.net> wrote:‬
>
> I also find it annoying that one line changes always even if there are no changes in translations. I prefer the file not to change at all if nothing has changed.
>

> On Tue, Aug 31, 2021 at 11:03 AM 'Adam Johnson' via Django developers (Contributions to Django itself) <django-d...@googlegroups.com> wrote:
>>
>> I'm in favour of the change. Leaving the file as-is when no actual data changed just makes sense to me.
>> The original discussion didn't touch upon the --update flag, so maybe it didn't exist then, or the participants didn't know about it. Its existence really weakens the argument that “we shouldn't redefine the meaning of gettext's header fields”.
>>
>> On Mon, 30 Aug 2021 at 23:55, Daniyal Abbasi <abbasi.d...@gmail.com> wrote:
>>>
>>> I was recently working on some git hooks with the makemessages command and I noticed that the "POT-Creation-Date" was always updated even if no strings were added, removed or relocated.
>>> I created a ticket (#33056) and was redirected to #6106 which is the original ticket which was closed over 11 years ago. However, I'd like to bring this into discussion and hoping to open this issue once again.
>>> If the po file exists, the makemessages command uses `msgmerge` in the `write_po_file` method to get the contents of the po file. (Refer this). However, msgmerge is not ran in the update mode using the `--update` flag.
>>> I propose on added this flag and making other suitable modifications as this causes a lot of issues with source control and git hooks. I've created a sample PR for the same.
>>> Looking forward to hear what everyone thinks about this!

--
Paolo Melchiorre

https://www.paulox.net

[Claude Paroz]

As the won't fixer person 11 years ago, I'm also more in favour of the change now, even if it changes a bit the meaning of POT-Creation-Date from "last time the pot file was updated" to "last time a change was detected in the pot file".