Patch uploaded for ticket 12180
Christophe Pettus
problem:
There is a bug in the handling of
InsertQuery.connection.features.can_return_id_from_insert, which is
causing Django 1.1.1 to throw a ProgrammingError exception when
inserting a new object/record into the database, using PostgreSQL
8.4.1, using psycopg2, if that INSERT is the first thing done by a
view on a particular connection to the database, when DATABASE_OPTIONS
autocommit: True is set.
Comments welcome, thanks!
--
-- Christophe Pettus
x...@thebuild.com
Russell Keith-Magee
> I've uploaded a patch for this ticket, which fixes a somewhat obscure
> problem:
Thanks for the patch.
However, as noted in [1], you don't need to post to django-dev just to
tell us you uploaded a patch. The core developers all track
django-updates, which is a mailing list that is notified whenever
something on Trac or SVN is updated. Unless you're asking the
community for a design decision and want to start a broader
discussion, posting to Trac (and keeping the trac metadata -- like the
milestone and 'has patch' flags -- accurate) is sufficient.
[1] http://docs.djangoproject.com/en/1.1/internals/contributing/#id1
Yours
Russ Magee %-)
Christophe Pettus
On Jan 31, 2010, at 7:10 PM, Russell Keith-Magee wrote:
> However, as noted in [1], you don't need to post to django-dev just to
> tell us you uploaded a patch.
OK, sorry for the noise. Since I had uploaded the patch on 11/6/09, I
wanted to make sure I hadn't missed a step in the review process.
Thanks!
Russell Keith-Magee
>
> On Jan 31, 2010, at 7:10 PM, Russell Keith-Magee wrote:
>>
>> However, as noted in [1], you don't need to post to django-dev just to
>> tell us you uploaded a patch.
>
> OK, sorry for the noise. Since I had uploaded the patch on 11/6/09, I
> wanted to make sure I hadn't missed a step in the review process.
The ticket hasn't received attention yet because of the focus of the
development cycle. We've been working primarily on new features since
October. The only bugs we have been paying attention to are those that
are particularly annoying, embarrassing, or resulting from features
that we have added recently.
Looking at the ticket for #12180 specifically, there are two things
missing that would reduce the likelihood of the patch being included
in Django 1.2 final:
1) A test case (or a reasonable explanation of why a test case isn't
necessary or possible)
2) The Milestone flag isn't set. If your ticket doesn't hit this
query [1], then it probably won't ever hit anyone's radar for v1.2.
Yours,
Russ Magee %-)