App label with dot

[Federico Capoano]

Defining the app_label of an AppConfig with a dot, like "myproject.subapp" is allowed, but raises an exception in the migration framework (too many values to unpack).

Did anybody notice this?

Is it supposed to be allowed or not at all?

Best regards

Federico Capoano

[Tim Graham]

app_label "should be a valid Python identifier." Dots aren't allowed.

https://docs.djangoproject.com/en/stable/ref/applications/#django.apps.AppConfig.label

[Federico Capoano]

Thanks Tim, would it be useful to have a more user friendly error message?

--
You received this message because you are subscribed to a topic in the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-developers/3cbMviLrSzI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/134214d9-e3c1-4f74-9920-f0a62d4d675bn%40googlegroups.com.

[Tom Forbes]

Yes, a more friendly error message would be far better here! User-facing runtime exceptions like unpacking errors are never good.

This should be quite a simple change to make, I’d suggest opening a trac ticket first and we can go from there. 

Tom

On 18 Dec 2020, at 16:38, Federico Capoano <federico...@gmail.com> wrote:



You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAERYH6XvS3_z-akSZw_xy8FRHbdZoxeOYN3D_fVyRJ%3D7B9zUFA%40mail.gmail.com.

[Federico Capoano]

Created: https://code.djangoproject.com/ticket/32285#ticket

Not sure if the categorization is correct, I don't see where AppConfig could fit there? Let's continue there.

Thanks 

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/98CF92C9-1E9D-4F56-9D4E-A6F78737002E%40tomforb.es.