Fellow Reports - September 2023
Mariusz Felisiak
Week ending September 10, 2023
Released Django 4.2.5, 4.1.11, and 3.2.21.
Prepared https://code.djangoproject.com/wiki/Version5.1Roadmap.
Triaged:
https://code.djangoproject.com/ticket/10808 - Multiple
inheritance (model-based) broken for __init__ of common fields in
diamond inheritance (invalid)
https://code.djangoproject.com/ticket/34814 - Confirm support
for PostGIS 3.4 (accepted)
https://code.djangoproject.com/ticket/34810 - Calculate
coverage on subprocesses such as django-admin commands (accepted)
https://code.djangoproject.com/ticket/34815 - urls file in
startapp command (duplicate)
https://code.djangoproject.com/ticket/34816 -
GenericForeignKey crashes if content_type_id is changed and
object_id is type incompatible with old object (accepted)
https://code.djangoproject.com/ticket/26836 - Allow
applications to register links in the admin interface (wontfix)
https://code.djangoproject.com/ticket/34819 -
GenericForeignKey.get_prefetch_queryset() (accepted)
https://code.djangoproject.com/ticket/34820 - Migrations
crashes when changing ForeignObject properties. (accepted)
https://code.djangoproject.com/ticket/34821 - Syncing
DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings with STORAGES
can mutate user settings. (created)
https://code.djangoproject.com/ticket/34823 -
assertTemplateUsed() context manager crashes for templates without
names. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17223 - Refs #31262 --
Renamed ChoiceIterator to BaseChoiceIterator.
https://github.com/django/django/pull/17224 - Fixed #34814 --
Confirmed support for PostGIS 3.4.
https://github.com/django/django/pull/17225 - Refs #34233 --
Bumped minimum supported version of docutils to 0.19.
https://github.com/django/django/pull/17101 - Fixed #34730 --
Added contrib.messages.test.MessagesTestMixin.assertMessages().
https://github.com/django/django/pull/16860 - Fixed #31300 --
Added GeneratedField model field.
https://github.com/django/django/pull/17207 - Fixed #34791 --
Fixed incorrect Prefetch()'s cache for singly related objects.
https://github.com/django/django/pull/17234 - Fixed #34816 --
Fixed GenericForeignKey crash when checking cache for primary keys
with different types.
https://github.com/django/django/pull/17240 - Fixed #34820 --
Fixed migrations crash when changing a ForeignObject field.
Authored:
https://github.com/django/django/pull/17236 - Fixed #34821 --
Prevented DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings from
mutating the main STORAGES.
https://github.com/django/django/pull/17239 - Bumped versions
in pre-commit and npm configurations.
Week ending September 17, 2023
Triaged:
https://code.djangoproject.com/ticket/34824 - Migrations
generates two records when ForeignObject.to_fields/from_fields is
not a tuple. (accepted)
https://code.djangoproject.com/ticket/34829 - Django reports
the “mutually exclusive” error for settings that do not contain
STATICFILES_STORAGE. (worksforme)
https://code.djangoproject.com/ticket/34822 - Provide
migration serializer for `_lru_cache_wrapper` (accepted)
https://code.djangoproject.com/ticket/34832 - Use `banner`
landmark or `<header>` element for the admin header area
(accepted)
https://code.djangoproject.com/ticket/34833 - Use a `main`
landmark in the admin interface (accepted)
https://code.djangoproject.com/ticket/34834 - Use `search`
role for the admin changelist search form (accepted)
https://code.djangoproject.com/ticket/34835 - Use a `nav`
element or `navigation` landmark for changelist filters (accepted)
https://code.djangoproject.com/ticket/34836 - Add an optional
argument to MultipleChoiceField to ignore invalid choices.
(wontfix)
https://code.djangoproject.com/ticket/34838 - GeoDjango
database functions incompatible with GeneratedField (accepted)
https://code.djangoproject.com/ticket/34839 - OperationalError
from Psycopg when using Connection Pool (Digital Ocean) Django
4.2.3 psycopg 3.1.9 (duplicate)
https://code.djangoproject.com/ticket/34842 - Unmanaged
read-only generated fields in admin (accepted)
https://code.djangoproject.com/ticket/34844 - Missing
dependency backports with install of 4.1.11 (invalid)
Reviewed/committed:
https://github.com/django/django/pull/17173 - Fixed #34642 --
Added File.open() support for *args and **kwargs.
https://github.com/django/django/pull/17238 - Fixed #34824 --
Prevented unnecessary AlterField when
ForeignObject.from_fields/to_fields is not a tuple.
https://github.com/django/django/pull/17147 - Fixed #34752 --
Fixed handling ASGI http.disconnect for streaming responses.
https://github.com/django/django/pull/17248 - Removed
ChoicesMeta.__contains__() for Python 3.12+.
https://github.com/django/django/pull/17249 - Renamed
ChoicesMeta to ChoicesType.
https://github.com/django/django/pull/17186 - Modernized
enumeration helpers on Python 3.11+.
https://github.com/django/django/pull/17252 - Added more tests
for decorators.
https://github.com/django/django/pull/17057 - Refs #31949 --
Made make_middleware_decorator to work with async functions.
https://github.com/django/django/pull/17260 - Fixed #34833 --
Made admin's main content render in <main> tag.
https://github.com/django/django/pull/17250 - Doc'd
HttpResponse.cookies.
https://github.com/django/django/pull/17261 - Fixed #34834 --
Added role="search" to the admin changelist search form.
https://github.com/django/django/pull/17259 - Fixed #34838 --
Corrected output_field of resolved columns for GeneratedFields.
https://github.com/django/django/pull/17258 - Fixed #34832 --
Made admin's header content render in <header> tag.
https://github.com/django/django/pull/17267 - Fixed #34842 --
Fixed ModelAdmin.readonly_fields crash with GeneratedFields.
https://github.com/django/django/pull/17263 - Fixed #31558 --
Added support for boolean attribute on properties in
ModelAdmin.list_display.
Authored:
https://github.com/django/django/pull/17254 - Corrected logger
in
CsrfViewMiddlewareTestMixin.test_ensures_csrf_cookie_no_logging().
https://github.com/django/django/pull/17265 - Refs #15619 --
Removed deprecated annotation about logging out via GET requests.
https://github.com/django/django/pull/17246 - Bootstrapped
Django 5.1.
https://github.com/django/django/pull/17268 - Corrected
QuerySet.prefetch_realted() note about GenericRelation().
Week ending September 24, 2023
Triaged:
https://code.djangoproject.com/ticket/34848 - Updating
translations catalog for javascript files fails with CommandError
(accepted)
https://code.djangoproject.com/ticket/34846 - Add "Copy"
button to the code snippets in docs. (accepted)
https://code.djangoproject.com/ticket/34849 - Appending
django.contrib.postgres to the INSTALLED_APPS via @modify_settings
crashes. (created)
https://code.djangoproject.com/ticket/34850 - Drop support for
MariaDB 10.4. (created)
https://code.djangoproject.com/ticket/34851 - Drop support for
PostgreSQL 12 and PostGIS 2.5. (created)
https://code.djangoproject.com/ticket/34857 - Date picker
cancel button does not respect color theme/dark mode (accepted)
https://code.djangoproject.com/ticket/34858 - Output field for
combined PositiveIntegerField is not properly resolved. (accepted)
https://code.djangoproject.com/ticket/34855 - Document
CSRF_TRUSTED_ORIGINS relation to SECURE_PROXY_SSL_HEADER.
(wontfix)
https://code.djangoproject.com/ticket/34862 - For clarity, the
`password_reset_email.html` template should have `.txt` extension
(duplicate)
https://code.djangoproject.com/ticket/34863 - sqlite math
functions don't accept character fields as input (wontfix)
https://code.djangoproject.com/ticket/34864 - Add ability to
customise script tags for form media (duplicate)
https://code.djangoproject.com/ticket/34865 - DatabaseWrapper
are not GC and connections are not closed (accepted)
https://code.djangoproject.com/ticket/34867 - [Date Input
Localization] Accept-Language Header Takes Precedence Over
Language Set With Cookie (duplicate)
https://code.djangoproject.com/ticket/34868 - Add K as an
alias for KeyTransform.from_lookup (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/17136 - Fixed #33651 --
Added support for prefetching GenericForeignKey.
https://github.com/django/django/pull/17278 - Simplified
ForeignObject.resolve_related_fields() a bit.
https://github.com/django/django/pull/17286 - Defined
PASSWORD_HASHERS for auth_tests.test_views.ChangelistTests.
https://github.com/django/django/pull/17285 - Refs #31300 --
Added example to GeneratedField release notes.
https://github.com/django/django/pull/17291 - Fixed #34857 --
Made calendar "Cancel" button in admin use color variables.
https://github.com/django/django/pull/17297 - Fixed
JSONField's test_deep_distinct for
DatabaseFeatures.nulls_order_largest=False.
https://github.com/django/django/pull/17293 - Fixed #34848 --
Ignored i18n_catalog.js file when building Django's translations
catalog.
https://github.com/django/django/pull/17299 - Fixed #34858 --
Corrected resolving output_field for PositiveIntegerField.
https://github.com/django/django/pull/17237 - Fixed #34823 --
Fixed assertTemplateUsed() context manager crash on unnamed
templates.
https://github.com/django/django/pull/17301 - Fixed #34861 --
Fixed crash when adding GeneratedFields with some expressions.
Reviewed:
https://github.com/django/django/pull/17276 - Pre-edits for
5.0a1.
https://github.com/django/django/pull/17277 - [5.0.x] Updated
source translation catalogs.
Authored:
https://github.com/django/django/pull/17280 - Isolated test
models for GeneratedFields.
https://github.com/django/django/pull/17281 - Added updating
the Django release process on Trac to release steps.
https://github.com/django/django/pull/17284 - Fixed #34850 --
Dropped support for MariaDB 10.4.
https://github.com/django/django/pull/17288 - Fixed #34851 --
Dropped support for PostgreSQL 12 and PostGIS 2.5.
https://github.com/django/django/pull/17294 - Refs #34851 --
Used PostgreSQL 13 for selenium tests.
https://github.com/django/django/pull/17295 - Fixed #34840 --
Avoided casting string base fields on PostgreSQL.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34866 - Cannot inspect migrations that replace squashed migrations with sqlmigrate (needsinfo)
https://code.djangoproject.com/ticket/34871 - Validation of UniqueConstraint with Case() crashes. (accepted)
https://code.djangoproject.com/ticket/34841 - Reverse migrations model state rendering slow with moderate to large migrations (accepted)
https://code.djangoproject.com/ticket/34870 - Memory leak when using psycopg-c with django hstore (invalid)
https://code.djangoproject.com/ticket/34873 - Add support for GENERIC_PLAN option to QuerySet.explain() on PostgreSQL 16+. (created)
https://code.djangoproject.com/ticket/34874 - Add table_exists() to optimize checks for django_migrations table. (wontfix)
https://code.djangoproject.com/ticket/34876 - Allow password reset token generator to configure timeouts (duplicate)
https://code.djangoproject.com/ticket/34875 - Use RFC 9106 recommendations in Argon2PasswordHasher (wontfix)
https://code.djangoproject.com/ticket/34878 - Autoreload crashes with FORM_RENDERER="django.forms.renderers.TemplatesSetting". (accepted)
https://code.djangoproject.com/ticket/34879 - "Data truncated for column .." for migration changing auto-id-field (worksforme)
https://code.djangoproject.com/ticket/34881 - migrate crashes when renaming model referenced twice by ManyToManyField.through model on SQLite. (accepted)
https://code.djangoproject.com/ticket/34882 - options=0 is not respected when calling AsGeoJSON() (accepted)
https://code.djangoproject.com/ticket/34883 - Allow template tags to set extra data on templates. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17300 - Fixed #34849 -- Avoided raising RuntimeWarning about import-time queries when apps are reinitialized with test tools.
https://github.com/django/django/pull/17242 - Fixed #34825 -- Avoided setting unused connections when initializing parallel workers.
https://github.com/django/django/pull/17314 - Fixed #34877 -- Fixed migrations crash when adding GeneratedField with output_field with params.
https://github.com/django/django/pull/17318 - Fixed #34878 -- Fixed autoreloader crash when FORM_RENDERER is set to TemplatesSetting.
https://github.com/django/django/pull/17321 - Refs #34657 -- Made assertInHTML() use unparsed needle in error messages.
Authored:
https://github.com/django/django/pull/17310 - Fixed #34873 -- Added QuerySet.explain() support for GENERIC_PLAN option on PostgreSQL 16+.
https://github.com/django/django/pull/17311 - Added warning about flatpages and untrusted users.
https://github.com/django/django/pull/17312 - [4.2.x] Refs #34320 -- Skipped SchemaTests.test_rename_field_with_check_to_truncated_name on MariaBD 10.5.2+.
Mariusz