Fellow Reports - August 2021
Mariusz Felisiak
Week ending August 8, 2021
Triaged:
https://code.djangoproject.com/ticket/32981 - raw sql with
postgres jsonb_array_elements no longer deserialises in Django
3.2.5. (duplicate)
https://code.djangoproject.com/ticket/32975 - ModelAdmin for
proxy model with InlineModelAdmin for proxy superclass reference
results in admin.E202(accepted)
https://code.djangoproject.com/ticket/32978 - Improve an error
message on loaddata/dumpdata when PyYAML is not installed.
(wontfix)
https://code.djangoproject.com/ticket/32982 - Tighten up the
check for status codes in HttpResponse (wontfix)
https://code.djangoproject.com/ticket/32984 - Allow overriding
of deletion widget in formsets (accepted)
https://code.djangoproject.com/ticket/32985 - "O valor
\"%(value)s\" tem um formato de data inválido. Deve ser no
formato " "YYY-MM-DD." (invalid)
https://code.djangoproject.com/ticket/32986 - Possible dead or
incorrect code in Lexer.create_token() related to
TRANSLATOR_COMMENT_MARK (accepted)
https://code.djangoproject.com/ticket/32988 - The number of
test databases should not be greater than number of TestCases.
(created)
https://code.djangoproject.com/ticket/32987 - Warn user if
they attempt to have mulitple templatetag libraries with the same
name (accepted)
https://code.djangoproject.com/ticket/27541 - Provide hooks to
override manifest file storage in ManifestFilesMixin. (duplicate)
https://code.djangoproject.com/ticket/32990 - Test the tag_re
regex in template/base.py instead of evaluating it every time
(accepted)
https://code.djangoproject.com/ticket/32991 - Change in
behavior of FileField.url between versions 2.2.16 -> 3.2.5;
returned 'relative' value contains leading slash (invalid)
https://code.djangoproject.com/ticket/32992 - Reverse time
zone conversion in Trunc()/Extract() database functions.
(accepted)
https://code.djangoproject.com/ticket/32994 - Invoking
runtests with a CLI prelude causes utils_tests failures (accepted)
https://code.djangoproject.com/ticket/32995 - Incorrect GROUP
BY in ORM query with Function (duplicate)
https://code.djangoproject.com/ticket/32997 - Errors in 404
templates are hard to debug (invalid)
https://code.djangoproject.com/ticket/32998 - process_view()
is not called on 404 (needsinfo)
Reviewed/committed:
https://github.com/django/django/pull/14721 - Refs #32956 --
Corrected usage of "insure" and "assure".
https://github.com/django/django/pull/14720 - Refs #32956 --
Corrected spelling of "gray".
https://github.com/django/django/pull/13945 - Simplified
serializing HTTP response headers.
https://github.com/django/django/pull/14627 - Fixed #32919 --
Optimized lexing & parsing of templates.
https://github.com/django/django/pull/14723 - Refs #32800 --
Added tests of more CSRF functions.
https://github.com/django/django/pull/14614 - Fixed #31621 --
Added support for '--parallel auto' to test management command.
https://github.com/django/django/pull/14733 - Fixed #32984 --
Allowed customizing a deletion field widget in formsets.
https://github.com/django/django/pull/14732 - Refs #32074 --
Fixed CommandTests.test_subparser_invalid_option on Python 3.10+.
https://github.com/django/django/pull/14727 - Fixed #29063 --
Fixed migrate crash when specifying a name of partially applied
squashed migrations.
https://github.com/django/django/pull/14743 - Fixed #32986 --
Removed unneeded str.find() call in Lexer.create_token().
https://github.com/django/django/pull/12187 - Fixed #7590 --
Allowed customizing a manifest file storage in ManifestFilesMixin.
https://github.com/django/django/pull/14745 - Fixed typo in
regex for IPv6 literals in EmailValidator.
https://github.com/django/django/pull/14719 - Refs #32956 --
Corrected spelling of daylight saving time.
Authored:
https://github.com/django/django/pull/14744 - Fixed #32988 --
Prevented creation of more test databases than TestCases.
https://github.com/django/djangoproject.com/pull/1108 - Added
Coveralls to GitHub actions workflows.
https://github.com/django/django/pull/14737 - Refs #31621 --
Fixed handling --parallel option in test management command and
runtests.py.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/33002 - Make DebugLexer.tokenize() more similar to Lexer.tokenize() (accepted)
https://code.djangoproject.com/ticket/33003 - Micro-optimisation for QuerySet._chain (accepted)
https://code.djangoproject.com/ticket/33005 - Django is saving redundant or empty data in the SQLite database (invalid)
https://code.djangoproject.com/ticket/33004 - Inconsistent / Unexpected handling of assigning unsaved model to Generic Foreign Key (accepted)
https://code.djangoproject.com/ticket/33007 - `form_clean()` performance (accepted)
https://code.djangoproject.com/ticket/33009 - ./manage.py test --keepdb fails when DB permissions are not sufficient (invalid)
https://code.djangoproject.com/ticket/33010 - id to uuid type casting bug in Django 2.2 (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14748 - Fixed #32990 -- Simplified and optimized tag regex.
https://github.com/django/django/pull/14755 - Fixed #33003 -- Removed **kwargs from QuerySet._chain().
https://github.com/django/django/pull/14753 - Fixed #33002 -- Made DebugLexer.tokenize() more closely parallel Lexer.tokenize().
https://github.com/django/django/pull/14752 - Fixed #32993 -- Added AutocompleteJsonView.serialize_result() to allow customization.
https://github.com/django/django/pull/14738 - Refs #29205 -- Added MultiValueField test for rendering of optional subfields.
Authored:
https://github.com/django/django/pull/14760 - Refs #29898 -- Changed ProjectState.real_apps to set.
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33034 - Change % to f-strings in django documentation. (wontfix)
https://code.djangoproject.com/ticket/33021 - Migration crashes when GIN index with gin_trgm_ops is used (invalid)
https://code.djangoproject.com/ticket/33032 - Document django.shortcuts.resolve_url (duplicate)
https://code.djangoproject.com/ticket/33036 - Custom tags with missing context param and no other params throw an unhelpful IndexError (accepted)
https://code.djangoproject.com/ticket/33037 - TruncDay error when using offset timezones on MySQL (duplicate)
https://code.djangoproject.com/ticket/33039 - Django to have conditional column based on another column (invalid)
https://code.djangoproject.com/ticket/33038 - Documentation for exception handling and transactions is misleading. (wontfix)
https://code.djangoproject.com/ticket/33040 - BaseModelForm.is_valid() should document how it modifies the BaseModelForm.instance (invalid)
Reviewed/committed:
https://github.com/django/django/pull/14779 - Fixed #33036 -- Made simple_tag()/inclusion_tag() with takes_context raise TemplateSyntaxError when function has no parameters.
https://github.com/django/django/pull/14772 - Fixed #32994 -- Fixed autoreloader tests when using 'python -m'.
https://github.com/django/django/pull/14765 - Fixed #33014 -- Made ProjectState raise exception when real_apps argument is not a set.
https://github.com/django/django/pull/14764 - Removed reference to non-existent collectstatic --exclude-dirs option.
https://github.com/django/django/pull/14769 - Fixed #33025 -- Avoided accessing the database connections in Query.build_lookup() when not necessary.
https://github.com/django/django/pull/14766 - Fixed #33017 -- Fixed storage engine introspection on MySQL.
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/33042 - Form validator cannot pass ModelMultipleChoiceField by checkbox (invalid)
https://code.djangoproject.com/ticket/33045 - Out-of-the box support for React JS (wontfix)
https://code.djangoproject.com/ticket/33044 - pyproject.toml breaks pip install into user site directory with editable source (accepted)
https://code.djangoproject.com/ticket/33041 - call_command() returns different values for options than manage.py when nargs is specified (invalid)
https://code.djangoproject.com/ticket/33047 - CheckConstraint crashes with GIS lookup and PostGIS backend. (accepted)
https://code.djangoproject.com/ticket/33049 - TabularInline doesn't render properly MultiPolygonField in Django Admin (duplicate)
https://code.djangoproject.com/ticket/33052 - save() on object with pk with default and existing value results in error and not update. (wontfix)
https://code.djangoproject.com/ticket/33051 - Model names with special characters don't highlight in admin site (accepted)
https://code.djangoproject.com/ticket/33037 - TruncDay error when using offset timezones on MySQL (accepted)
https://code.djangoproject.com/ticket/33054 - Support post-commit hooks adding more post-commit hooks (accepted)
https://code.djangoproject.com/ticket/23610 - Removing a null constraint can lead to race conditions with migrations (wontfix)
https://code.djangoproject.com/ticket/33050 - QuerySet.count() on combined queries with select_related() crashes on MySQL. (accepted)
https://code.djangoproject.com/ticket/33055 - Django - Custom Join's F('') includes single quotes in column reference, causing Postgres to think it's string and not a column reference (invalid)
https://code.djangoproject.com/ticket/33057 - Foreign key constraint in m2m tables is not recreated when altering type of referenced primary key on Oracle. (accepted)
https://code.djangoproject.com/ticket/33059 - Form + Formset(s) Class Based View (duplicate)
https://code.djangoproject.com/ticket/33058 - Use DiscoverRunner's logger for logging when running checks (accepted)
https://code.djangoproject.com/ticket/33060 - Add a helper function to make and validate cache keys. (accepted)
https://code.djangoproject.com/ticket/33061 - ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing (accepted)
https://code.djangoproject.com/ticket/33063 - Use string module instead of writing all of characters (wontfix)
https://code.djangoproject.com/ticket/33064 - Created Model is not showing in Django Atomic Trasaction Block (worksforme)
Reviewed/committed:
https://github.com/django/django/pull/14778 - Fixed #33030 -- Fixed broken links to GDAL docs.
https://github.com/django/django/pull/14790 - Refs #10929 -- Allowed NowUTC SQL customization for third-party backends.
https://github.com/django/django/pull/14759 - Fixed #32552 -- Added logger argument to DiscoverRunner.
https://github.com/django/django/pull/14587 - Refs #29898 -- Made ProjectState encapsulate alterations in relations registry.
https://github.com/django/django/pull/14739 - Refs #32919 -- Simplified Lexer.create_token() by reorganizing blocks.
https://github.com/django/django/pull/14799 - Fixed #33046 -- Added note about using length of cached result by QuerySet.count().
https://github.com/django/django/pull/14517 - Refs #32338 -- Made RadioSelect/CheckboxSelectMultiple render in <div> tags.
https://github.com/django/django/pull/14803 - Fixed #33051 -- Fixed highlighting the current model in admin's sidebar with non-ASCII model names.
https://github.com/django/django/pull/14607 - Fixed #32900 -- Improved migrations questioner prompts.
Reviewed:
https://github.com/django/django/pull/14437 - Fixed #33012 -- Added Redis cache backend.
Authored:
https://github.com/django/django/pull/14797 - Refs #29898 -- Changed fields in ProjectState's relation registry to dict.
https://github.com/django/django/pull/14798 - Fixed #32504 -- Updated admin's jQuery to 3.6.0.
Mariusz