Fellow Reports - February 2020

[Mariusz Felisiak]

Week ending February 9, 2020.

Triaged:

https://code.djangoproject.com/ticket/22162 - New filter tags for string processing on templates. (wontfix)
https://code.djangoproject.com/ticket/31222 - Typo in "Reporting bugs and requesting features" docs. (accepted)
https://code.djangoproject.com/ticket/31224 - Add asynchronous views. (created)
https://code.djangoproject.com/ticket/31225 - Use NFD normalization in get_valid_filename(). (wontfix)
https://code.djangoproject.com/ticket/31221 - HStoreField returns str instead of dict during tests. (invalid)
https://code.djangoproject.com/ticket/31226 - Typo in "Submitting patches" docs. (accepted)
https://code.djangoproject.com/ticket/31227 - Doing filter() or exclude() after an intersection(). (invalid)
https://code.djangoproject.com/ticket/31228 - DISTINCT with GROUP_CONCAT() and multiple expressions raises NotSupportedError on SQLite. (accepted)
https://code.djangoproject.com/ticket/31230 - Dynamic fieldset is not showing as per intended. (invalid)
https://code.djangoproject.com/ticket/31231 - ORM doesn't find a row with a SQL null JSONB field. (invalid)
https://code.djangoproject.com/ticket/25341 - Bug: EmailMessage.message ignores bcc field (duplicate)
https://code.djangoproject.com/ticket/31236 - (urls.W005) URL namespace 'admin' isn't unique. (invalid)
https://code.djangoproject.com/ticket/27835 - Make TransactionTestCase raise an error if it accesses non-default database connection without multi_db=True.(invalid)
https://code.djangoproject.com/ticket/31237 - Change assertRaisesMessage and assertWarnsMessage to accept list of expected messages. (wontfix)
https://code.djangoproject.com/ticket/28214 - IndexError for JSONField queries containing percent character in key. (fixed)
https://code.djangoproject.com/ticket/31238 - Django using ASGI server but translations uses thread local. (invalid)
https://code.djangoproject.com/ticket/31240 - FileResponse with temporary file closing connection. (accepted)
https://code.djangoproject.com/ticket/31239 - Add a new exception type for request.GET and request.POST. (wontfix)
https://code.djangoproject.com/ticket/31247 - Created new project. But runserver command fails. (invalid)
https://code.djangoproject.com/ticket/31244 - Admin interface fails to load with file not found on FilePathField model. (invalid)
https://code.djangoproject.com/ticket/31245 - CharField doesn't accept bytestrings in default parameter in Django 2.2. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/12403 - Fixed #31222 -- Fixed typo in docs/internals/contributing/bugs-and-features.txt.
https://github.com/django/django/pull/12409 - Fixed #31226 -- Fixed typo in docs/internals/contributing/writing-code/submitting-patches.txt.
https://github.com/django/django/pull/12397 - Fixed #27604 -- Used the cookie signer to sign message cookies.
https://github.com/django/django/pull/12410 - Fixed #31210 -- Doc'd how to reproduce HttpRequest.is_ajax() in release notes.
https://github.com/django/django/pull/11689 - Simplified imports from django.db and django.contrib.gis.db.
https://github.com/django/django/pull/12406 - Fixed #26813 -- Prevented empty choice in ModelChoiceField with RadioSelect for fields with blank=False.
https://github.com/django/django/pull/12419 - Fixed #31232 -- Changed default SECURE_REFERRER_POLICY to 'same-origin'.
https://github.com/django/django/pull/12418 - Fixed #28528 -- Allowed combining SearchVectors with different configs.
https://github.com/django/django/pull/12414 - Fixed #31233 -- Closed database connections and cursors after use.
https://github.com/django/django/pull/12396 - Fixed #31055 -- Made constraint checks support databases aware.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending February 16, 2020.

Triaged:

https://code.djangoproject.com/ticket/31248 - Missing whitespace in SQL generated for PostGIS indexed with USING. (accepted)
https://code.djangoproject.com/ticket/31249 - select_for_update() with 'of' crashes with models from multi-level inheritance (duplicate)
https://code.djangoproject.com/ticket/31252 - Oracle GIS doesn't support spatial indexes in Meta.indexes. (created)
https://code.djangoproject.com/ticket/31250 - assertXMLEqual() crashes on processing instructions. (accepted)
https://code.djangoproject.com/ticket/31251 - QuerySet.annotate() crashes when grouping by OuterRef(). (accepted)
https://code.djangoproject.com/ticket/31253 - Possible data loss when using caching from async code. (created)
https://code.djangoproject.com/ticket/31256 - Inline widget permision is now based on it's foregin key. (wontfix)
https://code.djangoproject.com/ticket/31255 - Migrations create a redundant RemoveField operation when deleting 2 models with related fields. (accepted)
https://code.djangoproject.com/ticket/31257 - Migrations don't apply changes for decimal_places on MySQL. (worksforme)
https://code.djangoproject.com/ticket/31260 - Enable cookie security if HTTPS is explicity indicated in settings. (wontfix)
https://code.djangoproject.com/ticket/31262 - Support dictionaries in Field.choices for named groups. (accepted)
https://code.djangoproject.com/ticket/31261 - Add support for defining models.Choices fields with dict, tuple, set and list values. (needsinfo)
https://code.djangoproject.com/ticket/31265 - Bug in ModelAdmin.render_change_form()'s has_file_field check. (invalid)
https://code.djangoproject.com/ticket/31264 - ORA-00918: column ambiguously defined django admin. (invalid)
https://code.djangoproject.com/ticket/31268 - Update Algerian Arabic (ar_DZ) locale formats. (accepted)
https://code.djangoproject.com/ticket/31267 - Missing tests cases for credential validation in URLs. (accepted)
https://code.djangoproject.com/ticket/31270 - Documentation for RedirectView.get_redirect_url() doesn't describe its arguments. (accepted)
https://code.djangoproject.com/ticket/31271 - Logged queries may interpolate parameters in the wrong order on Oracle. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12347 - Fixed #31003 -- Doc'd and tested return value of QuerySet.bulk_create().
https://github.com/django/django/pull/12435 - Fixed #31248 -- Added missing space before USING SQL on PostGIS.
https://github.com/django/django/pull/12440 - Fixed #30846 -- Made PostGIS backend respect Index's name argument.
https://github.com/django/django/pull/12430 - Fixed #31253 -- Fixed data loss possibility when using caching from async code.
https://github.com/django/django/pull/12431 - Fixed #31240 -- Properly closed FileResponse when wsgi.file_wrapper is used.
https://github.com/django/django/pull/12434 - Fixed #31246 -- Fixed locking models in QuerySet.select_for_update(of=()) for related fields and parent link fields with multi-table inheritance.
https://github.com/django/django/pull/12427 - Fixed #31241 -- Clarified porting translations of the Django docs to docs.djangoproject.com.
https://github.com/django/django/pull/12374 - Refs #27468 -- Made PasswordResetTokenGenerator use SHA-256 algorithm.
https://github.com/django/django/pull/12441 - Fixed #30261 -- Prevented Form._html_output() from mutating errors when hidden fields have errors.
https://github.com/django/django/pull/12448 - Fixed #31267 -- Added tests cases with empty username or password for URLValidator.
https://github.com/django/django/pull/12446 - Fixed #31250 -- Ignored processing instructions in assertXMLEqual()/assertXMLNotEqual().
https://github.com/django/django/pull/12451 - Fixed #31270 -- Doc'd RedirectView.get_redirect_url() arguments.
https://github.com/django/django/pull/12453 - Fixed #26552 -- Deferred constraint checks when reloading the database with data for tests.

Reviewed:

https://github.com/django/django/pull/11828 - Refs #26601 -- Deprecated passing None as get_response arg to middleware classes.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending February 23, 2020.

Triaged:

https://code.djangoproject.com/ticket/31274 - Use signing infrastructure for session data encoding/decoding. (accepted)
https://code.djangoproject.com/ticket/31279 - PasswordResetView always defaulting to the admin page and not to template. (invalid)
https://code.djangoproject.com/ticket/31277 - System check fields.E340 should be relaxed when DATABASE_ROUTERS is present. (accepted)
https://code.djangoproject.com/ticket/31280 - Rename DEBUG_PROPAGATE_EXCEPTIONS to PROPAGATE_EXCEPTIONS. (wontfix)
https://code.djangoproject.com/ticket/31263 - remote_field model caching issues in RenameModel migration. (needsinfo)
https://code.djangoproject.com/ticket/31272 - Django and JS (from npm module) problem. (invalid)
https://code.djangoproject.com/ticket/31282 - Docs for RelatedManager.set()/add()/remove() incorrectly states that the field the relation points to is acceptable for one-to-many relations. (accepted)
https://code.djangoproject.com/ticket/31281 - Make TestClient run transaction.on_commit actions. (duplicate)
https://code.djangoproject.com/ticket/31286 - Database specific fields checks should be databases aware. (accepted)
https://code.djangoproject.com/ticket/31288 - New ReplaceAuthMiddleware feature. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/12461 - Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed.
https://github.com/django/django/pull/12407 - Fixed #20995 -- Added support for iterables of template names to {% include %} template tag.
https://github.com/django/django/pull/12464 - Fixed #31228 -- Reallowed aggregates to be used with multiple expressions and no DISTINCT on SQLite.
https://github.com/django/django/pull/12364 - Fixed #31187 -- Fixed detecting of existing total ordering in admin changelist when using Meta.constraints.
https://github.com/django/django/pull/12474 - Refs #31224 -- Added BaseHandler.check_response().

Reviewed:

https://github.com/django/django/pull/12466 - Fixed #31282 -- Corrected RelatedManager docs for using add/remove/set with PKs.

Authored:

https://github.com/django/django/pull/12465 - Fixed #31271 -- Preserved ordering when unifying query parameters on Oracle.

https://github.com/django/django/pull/12473 - Fixed tests when run in reverse.

I was off on Thursday and Friday.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending March 1, 2020.

Triaged:

https://code.djangoproject.com/ticket/31296 - Document different config scenarios of full text search configuration. (wontfix)
https://code.djangoproject.com/ticket/31303 - Remove outdated note about symmetrical with m2m relationship from a model to itself. (accepted)
https://code.djangoproject.com/ticket/31294 - Disabled (hidden) inputs don't transmit their data. (invalid)
https://code.djangoproject.com/ticket/31305 - FieldError when doing batch update from the list view. (duplicate)
https://code.djangoproject.com/ticket/31306 - Raise ValidationError on first failure. (wontfix)
https://code.djangoproject.com/ticket/31300 - Add function-based virtual fields on PostgreSQL and Oracle. (wontfix)
https://code.djangoproject.com/ticket/31320 - Prevent BEGIN and COMMIT in RunSQL in atomic migrations. (wontfix)
https://code.djangoproject.com/ticket/31321 - Unexpected behavior of `update_or_create`, misleading flag `created`. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/12487 - Fixed #31303 -- Removed outdated note about symmetrical intermediate table for self-referential ManyToManyField.
https://github.com/django/django/pull/12467 - Fixed #31292 -- Fixed django.contrib.gis.gdal.gdal_full_version() crash.
https://github.com/django/django/pull/12472 - Fixed #31286 -- Made database specific fields checks databases aware.
https://github.com/django/django/pull/12479 - Fixed #31291 -- Renamed salt to mask for CSRF tokens.
https://github.com/django/django/pull/12493 - A few contrib.postgres.search cleanups.
https://github.com/django/django/pull/12484 - Fixed #31289 -- Added hint for USERNAME_FIELD/REQUIRED_FIELDS system check.
https://github.com/django/django/pull/12486 - Fixed #28280 -- Prevented numberformat.format() from formatting large/tiny floats in scientific notation.

https://github.com/django/django/pull/12499 - Fixed #31313 -- Fixed is_upperclass() example in enumeration types docs.
https://github.com/django/django/pull/12500 - Fixed #31312 -- Properly ordered temporal subtraction params on MySQL.
https://github.com/django/django/pull/12477 - Fixed #31185 -- Fixed detecting of unique fields in ForeignKey/ForeignObject checks when using Meta.constraints
https://github.com/django/django/pull/12489 - Fixed #31251 -- Disabled grouping by OuterRef() annotation.
https://github.com/django/django/pull/12497 - Fixed #31310 -- Fixed hints in checks for using intermediate model with ambiguous foreign key.
https://github.com/django/django/pull/12503 - Fixed #31314 -- Raised CommandError when locale is not specified in makemessages.
https://github.com/django/django/pull/12498 - Fixed #31311 -- Removed unneeded escapes in validator regexes.
https://github.com/django/django/pull/12502 - Fixed #31032 -- Updated admin browser support FAQ for 2020.
https://github.com/django/django/pull/12506 - Fixed #31301 -- Fixed crash of QuerySet.bulk_create() with mixed empty and set ForeignKeys to AutoFields on Oracle.
https://github.com/django/django/pull/12485 - Fixed #31293 -- Allowed MultiPartParser to handle double-quoted encoded headers.

Authored:

https://github.com/django/django/pull/12488 - Fixed backends tests on Oracle.

Best regards,

Mariusz