Fellow Reports - January 2024
Mariusz Felisiak
Week ending January 7
Released Django 4.2.9 and 5.0.1.
Triaged:
https://code.djangoproject.com/ticket/35073 - models.SET's
callable is called when there are no objects to update. (accepted)
https://code.djangoproject.com/ticket/35077 - Quering with int
that has bigint in database no longer working. (invalid)
https://code.djangoproject.com/ticket/35078 - Incorrect order
of migration operations when a new FK is added and is part of
constraints as well (duplicate)
https://code.djangoproject.com/ticket/35079 - Meta
indexes/constraints with OpClass on expressions crash. (duplicate)
https://code.djangoproject.com/ticket/35080 - Reconsideration
of HTTP Method Integration in Django for Enhanced HTMX
Compatibility and similar frontend expe (wontfix)
https://code.djangoproject.com/ticket/35081 - Bug when
customized login issue (invalid)
https://code.djangoproject.com/ticket/35082 -
AsyncRequestFactory doesn't pass REMOTE_ADDR when set (invalid)
https://code.djangoproject.com/ticket/35084 - Recommend
reusable app module names use a `django_` prefix (accepted)
https://code.djangoproject.com/ticket/35086 - Add
BoundedCircle support with SpatiaLite 5.1+ (accepted)
https://code.djangoproject.com/ticket/35087 -
DisallowedModelAdminLookup raised when filtering on a ForeignKey
not listed in list_filters (accepted)
https://code.djangoproject.com/ticket/35092 - Expose
additional data in responses from geoip2 queries. (accepted)
https://code.djangoproject.com/ticket/35091 - Allow use of
ipaddress standard library module with django.contrib.gis.geoip2
(accepted)
Reviewed/committed:
https://github.com/django/django/pull/17665 - Updated
feature flags for Oracle 23c.
https://github.com/django/django/pull/17663 - Fixed #35072 --
Corrected Field.choices description in models topic.
https://github.com/django/django/pull/15705 - Improved
variable names in QuerySet.delete().
https://github.com/django/django/pull/17667 - Fixed #35060 --
Deprecated passing positional arguments to Model.save()/asave().
https://github.com/django/django/pull/17666 - Fixed #35075 --
Added deduplicate_items parameter to BTreeIndex.
https://github.com/django/djangoproject.com/pull/1452 - Fixed
#1453 -- Fixed code block indentantion on the Getting started
page.
https://github.com/django/django/pull/17639 - Fixed #33277 --
Disallowed database connections in threads in SimpleTestCase.
https://github.com/django/django/pull/17676 - Refs #33690 --
Updated tutorial for admin dark mode toggle.
https://github.com/django/django/pull/17678 - Refs #34140 --
Fixed blacken-docs pre-commit configuration.
https://github.com/django/django/pull/17677 - Fixed #35084 --
Recommended 'django_' prefix for reusable app modules.
https://github.com/django/django/pull/17693 - Removed obsolete
rpm-related install code.
https://github.com/django/django/pull/17692 - Moved isort
config from setup.cfg to pyproject.toml.
https://github.com/django/django/pull/17691 - Fixed #35086 --
Added support for BoundedCircle on Spatialite 5.1+.
https://github.com/django/django/pull/17701 - Fixed #35088 --
Added support for Collect on MySQL 8.0.24+.
https://github.com/django/django/pull/17705 - Fixed #35091 --
Allowed GeoIP2 querying using IPv4Address/IPv6Address.
Authored:
https://github.com/django/djangoproject.com/pull/1458 -
Removed usage of Python's deprecated distutils.version package.
https://github.com/django/django/pull/17673 - Used
enterClassContext() where appropriate.
https://github.com/django/djangoproject.com/pull/1460 - Fixed
#1459 -- Fixed get_all_doc_versions template tag.
https://github.com/django/django/pull/17695 - Bumped versions
in pre-commit and npm configurations.
Week ending January 14
Created https://code.djangoproject.com/wiki/SummerOfCode2024.
Triaged:
https://code.djangoproject.com/ticket/35090 - Enforce
uniqueness on custom path converters. (accepted)
https://code.djangoproject.com/ticket/34852 - Django Unit
Tests break when using replicated MySQL Cluster v8.0.28 (invalid)
https://code.djangoproject.com/ticket/35094 - Add pure Python
dbshell fallback (wontfix)
https://code.djangoproject.com/ticket/35095 - Monetary values
in Switzerland discrepancy (accepted)
https://code.djangoproject.com/ticket/35097 - Undocumented
behaviour change of utils.dateparse.parse_datetime (invalid)
https://code.djangoproject.com/ticket/35096 - Error messages
in admin forms with class "wide" misaligned (accepted)
https://code.djangoproject.com/ticket/15611 - Readonly fields
not hidden during create (fixed)
https://code.djangoproject.com/ticket/35098 - ValidationError
is being converted into a 500 Internal Server Error response
(invalid)
https://code.djangoproject.com/ticket/35099 - Combining
QuerySets with "|" or "&" mutates right-hand side. (accepted)
https://code.djangoproject.com/ticket/35100 - Simplify
initialization of databases in the GeoIP2 wrapper (accepted)
https://code.djangoproject.com/ticket/35102 - Performance
regression on Model.objects.count() between Django 4.2 and 5.0
(accepted)
https://code.djangoproject.com/ticket/35108 - Have
SingleObjectMixin.get_object handle ValidationError/ValueError
(wontfix)
https://code.djangoproject.com/ticket/35109 - Enhance
`showmigrations` to only write leafs nodes (most recent
migrations) to stdout, if desired (wontfix)
https://code.djangoproject.com/ticket/35111 - DateField's
__range and __in lookups against expressions produce invalid
values on SQLite. (accepted)
https://code.djangoproject.com/ticket/35107 - How to write a
management command that reads from stdin should be documented
(wontfix)
Reviewed/committed:
https://github.com/django/django/pull/17700 - Fixed #35087
-- Reallowed filtering against foreign keys not listed in
ModelAdmin.list_filters.
https://github.com/django/django/pull/17707 - Fixed #33481 --
Clarified remove_stale_contenttypes data loss warning.
https://github.com/django/django/pull/17713 - Refs #28404 --
Split test_null_display_for_field() test.
https://github.com/django/django/pull/17710 - Fixed #35096 --
Corrected alignment for error lists in admin "wide" forms.
https://github.com/django/django/pull/17698 - Made management
command examples more consistent in docs.
https://github.com/django/django/pull/17702 - Fixed #28404 --
Made displaying values in admin respect Field's empty_values.
https://github.com/django/django/pull/17706 - Fixed #35092 --
Exposed extra fields for GeoIP2.country() and GeoIP2.city()
responses.
https://github.com/django/django/pull/17718 - Fixed #35100 --
Reworked GeoIP2 database initialization.
https://github.com/django/django/pull/17720 - Refs #28404 --
Made displaying property values in admin respect non-None empty
values.
https://github.com/django/django/pull/17727 - Avoided nested
transactions in SkippingClassTestCase.
https://github.com/django/django/pull/17615 - Fixed #35028 --
Disabled server-side bindings for named cursors on psycopg >=
3.
Authored:
https://github.com/django/django/pull/17717 - Fixed #34769
-- Fixed key transforms on Oracle 21c+.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/35113 - Adding urls.py file while creating new app using startapp command (duplicate)
https://code.djangoproject.com/ticket/35114 - Create a tests directory instead of tests.py when a new app is created (wontfix)
https://code.djangoproject.com/ticket/35112 - Confusing animation of admin date picker buttons (accepted)
https://code.djangoproject.com/ticket/34613 - add support for Partitioned cookies (accepted)
https://code.djangoproject.com/ticket/35115 - Empty footer element in main section of admin layout (accepted)
https://code.djangoproject.com/ticket/35117 - Add support for Hectare unit to Area (accepted)
https://code.djangoproject.com/ticket/34961 - Add a max_length parameter to EmailValidator (wontfix)
https://code.djangoproject.com/ticket/24721 - Add "test extensions" (e.g. something similar to mail.outbox for messages) (duplicate)
https://code.djangoproject.com/ticket/35120 - Stack overflow in render method when many instances of included template (needsinfo)
https://code.djangoproject.com/ticket/35121 - Links in the admin should use the --link-fg color. (created)
https://code.djangoproject.com/ticket/35122 - --prune should take app_label into account then checking squashed migrations. (accepted)
https://code.djangoproject.com/ticket/35123 - Migrate prune for apps that are deleted (wontfix)
https://code.djangoproject.com/ticket/35126 - forms.NullBooleanField's validation logic is surprising (invalid)
https://code.djangoproject.com/ticket/35128 - Soft-deletion feature (duplicate)
https://code.djangoproject.com/ticket/35129 - Support customize ForeignKey DDL when db_constraint=False (invalid)
Reviewed/committed:
https://github.com/django/django/pull/17730 - Fixed #35102 -- Optimized Expression.identity and friends.
https://github.com/django/django/pull/17592 - Fixed #28344 -- Allowed customizing queryset in Model.refresh_from_db()/arefresh_from_db().
https://github.com/django/django/pull/17712 - Fixed #34949 -- Clarified when UniqueConstraints with include/nulls_distinct are not created.
https://github.com/django/django/pull/17737 - Fixed #35112 -- Removed previous/next month animation in admin calendar widget.
https://github.com/django/django/pull/17732 - Fixed #35111 -- Fixed compilation of DateField __in/__range rhs on SQLite and MySQL.
https://github.com/django/django/pull/17742 - Used more specific link to email backends in EMAIL_BACKEND docs.
https://github.com/django/django/pull/17740 - Improved --list-tags help text for check management command.
https://github.com/django/django/pull/17739 - Fixed #35117 -- Added support for the hectare unit in Area.
https://github.com/django/django/pull/17344 - Fixed #31700 -- Made makemigrations command display meaningful symbols for each operation.
https://github.com/django/django/pull/17745 - Refs #35058 -- Added is_3d and set_3d() to OGRGeometry.
https://github.com/django/django/pull/17751 - Fixed #35121 -- Corrected color for links in the admin.
https://github.com/django/django/pull/17744 - Fixed #34910 -- Improved color contrast for add/change icons in admin.
https://github.com/django/django/pull/17756 - Updated "Dive Into Python" links.
Authored:
https://github.com/django/code.djangoproject.com/pull/147 - Added black to GitHub actions.
https://github.com/django/django/pull/17752 - Corrected forms imports in forms_tests/tests/test_forms.py.
https://github.com/django/django/pull/17758 - Fixed #35127 -- Made Model.full_clean() ignore GeneratedFields.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/35132 - Django admin dark mode leaves the main container light. (worksforme)
https://code.djangoproject.com/ticket/35134 - "Select all" checkbox in admin model view doesn't work in Django 5.0.1 (worksforme)
https://code.djangoproject.com/ticket/35133 - Make @method_decorator to work with async methods. (duplicate)
https://code.djangoproject.com/ticket/35130 - Document how to manually close database connections (accepted)
https://code.djangoproject.com/ticket/35135 - FilteredRelation fails when rhs of the condition is a queryset (accepted)
https://code.djangoproject.com/ticket/35139 - Performing a save() with an ImageField where width_field or height_field is set results in an extra read operation (duplicate)
https://code.djangoproject.com/ticket/35141 - CACHE_MIDDLEWARE_SECONDS can be set to a float but has to be an int (accepted)
https://code.djangoproject.com/ticket/35143 - Improve accessibility of error page(s) with semantic HTML (accepted)
https://code.djangoproject.com/ticket/35142 - DATE and DATETIME settings have no effect since USE_L10N was deprecated (needsinfo)
https://code.djangoproject.com/ticket/35144 - Inconsistency in apostrophe symbols of translatable strings. And broken translations (invalid)
https://code.djangoproject.com/ticket/35145 - Django admin’s dark theme should set color-scheme property for vanilla HTML components (accepted)
https://code.djangoproject.com/ticket/35148 - Missed request cleanup for async views (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/17680 - Fixed tutorial 'background.gif' reference.
https://github.com/django/django/pull/17761 - Added more WKT and WKB tests.
https://github.com/django/djangoproject.com/pull/1462 - Fixed favicon URLs in search description.
https://github.com/django/django/pull/17766 - Fixed #35130 -- Doc'd django.db.close_old_connections().
https://github.com/django/code.djangoproject.com/pull/149 - JS cleanups.
https://github.com/django/django/pull/17768 - Refs #35058 -- Deprecated OGRGeometry.coord_dim setter.
https://github.com/django/django/pull/17769 - Refs #33517 -- Prevented __second lookup from returning fractional seconds on Oracle.
https://github.com/django/django/pull/17747 - Fixed #32923 -- Refactored out Field._clean_bound_field().
https://github.com/django/code.djangoproject.com/pull/146 - Update trac 1.4.4.
https://github.com/django/django/pull/17774 - Fixed #35115 -- Made admin's footer render in <footer> tag.
https://github.com/django/code.djangoproject.com/pull/155 - Fixed #151 -- Fixed styling issues on ticket detail page.
https://github.com/django/code.djangoproject.com/pull/158 - Fixed leftover genshi syntax in template.
https://github.com/django/code.djangoproject.com/pull/156 - Link to the proper favicon.
https://github.com/django/django/pull/17696 - Refs #35058 -- Added support for measured geometries to GDAL Point.
https://github.com/django/code.djangoproject.com/pull/166 - Some more fixes in trackhacks.css.
https://github.com/django/django/pull/17782 - Updated Python license for 2024.
https://github.com/django/code.djangoproject.com/pull/167 - Fix spamfilter admin configuration page.
https://github.com/django/code.djangoproject.com/pull/168 - Fixed login/logout/logged as items in metanav.
https://github.com/django/django/pull/17786 - Refs #35058 -- Made centroid available on all geometry types.
Authored:
https://github.com/django/code.djangoproject.com/pull/160 - Fixed #159 -- Used TracSpamFilter compatible with 1.4.
https://github.com/django/django/pull/17778 - Applied Black's 2024 stable style.
https://github.com/django/django/pull/17779 - Bumped versions in Github actions configuration.
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/35153 - FORMAT_MODULE_PATH not acting as I expected. (accepted)
https://code.djangoproject.com/ticket/35154 - QuerySet implements `contains` but not `__contains__` (wontfix)
https://code.djangoproject.com/ticket/35155 - Internal 500 error when deleting company model on production server (invalid)
https://code.djangoproject.com/ticket/35157 - "AttributeError: 'QuerySet' object has no attribute 'copy'" combining FilteredRelation with subquery (duplicate)
https://code.djangoproject.com/ticket/35159 - dumpdata crashes on querysets with prefetch_related(). (accepted)
https://code.djangoproject.com/ticket/35160 - m2m_changed not trigerred when ManyToManyField in autocomplete list (needsinfo)
https://code.djangoproject.com/ticket/35163 - sqlite3.OperationalError: no such column: django_migrations.id (worksforme)
https://code.djangoproject.com/ticket/35162 - Adding a BinaryField, TextField, JSONField, or GeometryField with a db_default crashes on MySQL (accepted)
https://code.djangoproject.com/ticket/35164 - PermissionError: Permission denied: site-packages (invalid)
Reviewed/committed:
https://github.com/django/django/pull/17788 - [5.0.x] Updated translations from Transifex.
https://github.com/django/django/pull/17777 - Refs #35058 -- Added support for measured geometries to GDAL LineString.
https://github.com/django/django/pull/17725 - Fixed #24128 -- Made admindocs TemplateDetailView respect template_loaders.
https://github.com/django/django/pull/17776 - Fixed #35141 -- Clarified the expected type of CACHE_MIDDLEWARE_SECONDS setting.
https://github.com/django/django/pull/17771 - Fixed #35135 -- Made FilteredRelation raise ValueError on querysets as rhs.
https://github.com/django/django/pull/17764 - Corrected BaseCommand.check() signature in docs.
https://github.com/django/django/pull/17760 - Fixed #29280 -- Made the transactions behavior configurable on SQLite.
https://github.com/django/django/pull/17796 - Made cosmetic edits to rocket SVG in the "Congrats" page.
https://github.com/django/django/pull/17787 - Fixed #35143 -- Improved accessibility of 404/500 debug pages.
https://github.com/django/django/pull/17800 - Refs #35058 -- Added support for measured geometries to GDAL Polygon.
https://github.com/django/django/pull/17803 - Fixed #35156 -- Removed outdated note about not supporting foreign keys by SQLite.
https://github.com/django/django/pull/17794 - Fixed #35152 -- Added en_CA locale formats.
https://github.com/django/django/pull/17783 - Removed mention of designers in DTL design philosophy.
https://github.com/django/django/pull/17694 - Changed packing recommendation to use pyproject.toml in reusable apps docs.
https://github.com/django/django/pull/17795 - Fixed #35147 -- Added backward incompatibility note about filtering against overflowing integers.
https://github.com/django/code.djangoproject.com/pull/171 - Used a plain HTML form for DjangoProject login.
https://github.com/django/django/pull/17817 - Fixed #35162 -- Fixed a crash when adding fields with db_default on MySQL.
https://github.com/django/django/pull/17813 - Fixed #35149 -- Fixed crashes of db_default with unresolvable output field.
Authored:
https://github.com/django/django/pull/17801 - Fixed #35159 -- Fixed dumpdata crash when base querysets use prefetch_related().
Mariusz