adding raw flag parameter to post_save & pre_save signals

632 views
Skip to first unread message

Graham Carlyle

unread,
Sep 4, 2007, 10:25:19 AM9/4/07
to Django developers
Any chance the pre_save & post_save signals sent by the
django.db.base.models.Model.save could have the raw flag passed as an
additional parameter to them?

My app uses theses signals to apply some common post save functionality
to a bunch of models. But loading fixtures causes problems as my app's
post_save work relies on consistent data.

I could have overridden the save method on these models to achieve the
same effect but it seemed cleaner from the post_save signal.

The work resulting from #4459 made the serialiser code skip a custom
save method by calling the base class's save and passing a raw
parameter. Passing the raw flag to the post & pre save signals seems a
natural extension of this.

thanks
Graham

Graham Carlyle

unread,
Sep 6, 2007, 7:41:44 AM9/6/07
to django-d...@googlegroups.com
Hello,

No-ones responded to my initial email. So is this the wrong place to
raise this request? Should I have posted to django-users? Should I raise
a ticket for this?

thanks,
Graham

Russell Keith-Magee

unread,
Sep 6, 2007, 8:39:12 AM9/6/07
to django-d...@googlegroups.com
On 9/6/07, Graham Carlyle <graham....@maplecroft.net> wrote:
>
> Hello,
>
> No-ones responded to my initial email. So is this the wrong place to
> raise this request? Should I have posted to django-users? Should I raise
> a ticket for this?

Apologies - we're not ignoring you - we're just busy.

This is the right forum for a suggestion like this. A ticket would
also be advisable, as it gives us a way of tracking the idea, whatever
the final decision.

Regarding the idea itself - we need to make sure there won't be any
unintended side effects of changing the parameters to the signal, but
other than that, the idea seems reasonable to me.

Yours,
Russ Magee %-)

Reply all
Reply to author
Forward
0 new messages