Fellow Reports - September 2022
Mariusz Felisiak
Week ending
September 11, 2022
Released Django 4.1.1.
Triaged:
https://code.djangoproject.com/ticket/33980 - "Save and add
another" redirects to the list instead of empty form (duplicate)
https://code.djangoproject.com/ticket/33982 - TypeError
creating DB table SQL with ExclusionConstraint as Statement
returned instead of str (accepted)
https://code.djangoproject.com/ticket/33984 - Related
managers cache gets stale after saving a fetched model with new
PK (accepted)
https://code.djangoproject.com/ticket/33986 - Code formatters
should be looked up before template rendering in
startapp/startproject (accepted)
https://code.djangoproject.com/ticket/33987 - values() and
db_column aliases do not play nicely together (invalid)
https://code.djangoproject.com/ticket/33988 -
URLValidator()('http:////test.com/') raise TypeError (duplicate)
https://code.djangoproject.com/ticket/33989 -
filter_horizontal/filter_vertical giving "This field is
required" error even when objects are selected. (duplicate)
https://code.djangoproject.com/ticket/29345 - Migrations that
recreate constraints can fail on PostgreSQL if table is not in
public schema (duplicate)
https://code.djangoproject.com/ticket/33992 -
QuerySet.annotate() with subquery and aggregation crashes.
(accepted)
https://code.djangoproject.com/ticket/33996 - Inconsistent
behavior of CheckConstraints validation on None values.
(accepted)
https://code.djangoproject.com/ticket/33995 - Rendering
empty_form crashes when empty_permitted is passed to form_kwargs
(accepted)
https://code.djangoproject.com/ticket/33997 - Possible to
change default select statemant for objects.all() (needsinfo)
https://code.djangoproject.com/ticket/33999 - Efficient
filter with join on soft link. (wontfix)
https://code.djangoproject.com/ticket/33998 - Use alternates
and i18n generate duplicated URLs in the sitemap (needsinfo)
https://code.djangoproject.com/ticket/34001 -
ForeignKey.formfield(): allow override for all kwargs
(needsinfo)
https://code.djangoproject.com/ticket/34003 -
PasswordResetView, PasswordResetDoneView,
PasswordResetConfirmView & PasswordResetCompleteView not
discovering custom template (invalid)
https://code.djangoproject.com/ticket/34002 -
PasswordResetView should work with AbstractBaseUser subclasses
without is_active field. (wontfix)
https://code.djangoproject.com/ticket/34004 - DateTimeField
for Forms does not always respect input_formats (invalid)
Reviewed/committed:
https://github.com/django/django/pull/16028 - Fixed #33937 --
Optimized serialization of related m2m fields without natural
keys.
https://github.com/django/django/pull/15766 - Fixed #33616 --
Allowed registering callbacks that can fail in
transaction.on_commit().
https://github.com/django/django/pull/16034 - Refs #33616 --
Updated BaseDatabaseWrapper.run_on_commit comment.
https://github.com/django/django/pull/16035 - Fixed #33982 --
Fixed migrations crash when adding model with
ExclusionConstraint.
https://github.com/django/django/pull/16037 - Fixed #33992 --
Fixed queryset crash when aggregating over a group containing
Exists.
https://github.com/django/django/pull/15974 - Used CSS flex
and <nav> for ModelAdmin.date_hierarchy.
https://github.com/django/django/pull/16032 - Fixed #33975 --
Fixed __in lookup when rhs is a queryset with annotate() and
alias().
https://github.com/django/django/pull/16041 - Fixed #33995 --
Fixed FormSet.empty_form crash when empty_permitted is passed to
form_kwargs.
Authored:
https://github.com/django/django/pull/16036 - Refs #24179 --
Fixed selenium tests for offset of admin selector boxes in
fieldset.
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/26511 - Document KeyTextTransform() and KeyTransform(). (wontfix)
https://code.djangoproject.com/ticket/34006 - close_old_connections() unconditionally closes connections inside atomic blocks if default autocommit = 1 (duplicate)
https://code.djangoproject.com/ticket/34007 - Single-field conditional UniqueContraint validation errors are classified as non-field-errors (accepted)
https://code.djangoproject.com/ticket/34008 - UpdateView failed to obtain the request data for the PUT request mode (needsinfo)
https://code.djangoproject.com/ticket/34009 - migrations.RunPython runs queries against wrong database (invalid)
https://code.djangoproject.com/ticket/34011 - Implement bulk_create auto-incrementing pk assignment on MySQL when possible (duplicate)
https://code.djangoproject.com/ticket/34010 - Parallel tests don't work with spawn. (needsinfo)
https://code.djangoproject.com/ticket/34014 - DecimalValidator fails to validate 0 in scientific notation (0E+1 or 0E+2) (accepted)
https://code.djangoproject.com/ticket/34015 - "Related Field got invalid lookup: startswith" on CharField ForeignKey (duplicate)
https://code.djangoproject.com/ticket/34013 - order_by() crashes with annotated JSONObject fields. (accepted)
https://code.djangoproject.com/ticket/34012 - QuerySet.order_by() silently skips non-existing fields on related fields. (accepted)
https://code.djangoproject.com/ticket/34016 - QuerySet.values_list() crash on simple ArrayAgg. (accepted)
https://code.djangoproject.com/ticket/34017 - Mention that when using Argon2PasswordHasher, this means Argon2id gets used (accepted)
https://code.djangoproject.com/ticket/34018 - Typo in ref/contrib/flatpages.txt. (accepted)
https://code.djangoproject.com/ticket/34019 - "Extending Django's default user" section refers to a deleted note (accepted)
Reviewed/committed:
https://github.com/django/django/pull/16046 - Fixed #34000 -- Fixed numberformat.format() crash on empty strings.
https://github.com/django/django/pull/16049 - Refs #31335 -- Added more tests for removing composed Meta constraints/indexes on foreign keys.
https://github.com/django/django/pull/15254 - Fixed #31335 -- Fixed removing composed Meta constraints/indexes on foreign keys on MySQL.
https://github.com/django/django/pull/16038 - Fixed #33996 -- Fixed CheckConstraint validation on NULL values.
https://github.com/django/django/pull/15937 - Fixed #29186 -- Fixed pickling HttpRequest and subclasses.
https://github.com/django/django/pull/16057 - Described Article-Reporter relationship in many-to-one topic.
https://github.com/django/django/pull/15757 - Changed camel case variable to snake case in contrib.admin.
https://github.com/django/django/pull/16055 - Fixed #33994 -- Corrected position of extrastyle and extrahead blocks in admin base template.
https://github.com/django/django/pull/16040 - Refs #28333 -- Explicitly ordered outer qualify query on window filtering.
https://github.com/django/django/pull/16016 - Fixed #33966 -- Added support for using KeyTextTransform from lookup.
https://github.com/django/django/pull/16061 - Fixed #34018 -- Fixed typo in docs/ref/contrib/flatpages.txt.
https://github.com/django/django/pull/16065 - Fixed #34019 -- Removed obsolete references to "model design considerations" note.
https://github.com/django/django/pull/16069 - Fixed #34017 -- Doc'd that Argon2id variant is used by Argon2PasswordHasher.
https://github.com/django/django/pull/16067 - Fixed #34014 -- Fixed DecimalValidator validating 0 in positive exponent scientific notation.
https://github.com/django/django/pull/16064 - Fixed #34016 -- Fixed QuerySet.values()/values_list() crash on ArrayAgg() and JSONBAgg().
Authored:
https://github.com/django/django/pull/16058 - Used first-interaction for GitHub action with welcome message.
https://github.com/django/django/pull/16062 - Fixed permissions for GitHub action with welcome message.
Mariusz Felisiak
I was in Porto and participated in the Django Con Europe conference.
Triaged:
https://code.djangoproject.com/ticket/34021 - collect_translations (invalid)
https://code.djangoproject.com/ticket/34022 - admin:logout fails to log out non-staff users (wontfix)
https://code.djangoproject.com/ticket/34023 - inlines variable not bound in loop in ModelAdmin._create_formsets (accepted)
https://code.djangoproject.com/ticket/34015 - Registering lookups on relation fields should be supported. (accepted)
https://code.djangoproject.com/ticket/34026 - WKBReader.read() crashes on strings. (accepted)
https://code.djangoproject.com/ticket/34029 - Use case that require QuerySet.extra (invalid)
https://code.djangoproject.com/ticket/34033 - Admin light/dark theme switch needs to convey its state for screen reader users (accepted)
https://code.djangoproject.com/ticket/34031 - Option to remove "all" option in admin SimpleListFilter (wontfix)
https://code.djangoproject.com/ticket/34032 - Base authentication Backend should raise NotImplemented on needed methods (wontfix)
https://code.djangoproject.com/ticket/34036 - Low text contrast over light blue backgrounds in admin light theme (accepted)
https://code.djangoproject.com/ticket/34037 - Low text contrast for grey buttons in admin light theme (accepted)
https://code.djangoproject.com/ticket/34042 - Screen reader issues with admin navigation sidebar. (accepted)
https://code.djangoproject.com/ticket/34041 - Accessibility improvements for admin breadcrumbs. (accepted)
https://code.djangoproject.com/ticket/34039 - Admin search bar is too small to use on small screens (accepted)
https://code.djangoproject.com/ticket/34038 - Low text contrast and no visual cues for links within body text in admin UI (accepted)
https://code.djangoproject.com/ticket/34035 - ImageField doesn't consider EXIF rotation when storing width and height (wontfix)
https://code.djangoproject.com/ticket/34036 - Low text contrast over light blue backgrounds in admin light theme (accepted)
https://code.djangoproject.com/ticket/34046 - tox.ini contains version pinnings at the wrong places (accepted)
https://code.djangoproject.com/ticket/34048 - Do not add cache control header if is set to false or a falsy value (needsinfo)
https://code.djangoproject.com/ticket/34049 - Admin - Scrollbar appears without overflowing content (accepted)
https://code.djangoproject.com/ticket/34053 - JS tests depend on Cloudflare CDN for every run (needsinfo)
https://code.djangoproject.com/ticket/34027 - Changing CharField type referenced by ForeignKey crashes on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/34054 - Create a topic about fixtures (accepted)
Reviewed/committed:
https://github.com/django/django/pull/16078 - Fixed #34024 -- Fixed crash when aggregating querysets with Q objects annotations.
https://github.com/django/django/pull/16089 - Fixed #34023 -- Added inline argument to user_deleted_form().
https://github.com/django/django/pull/16085 - Fixed #34033 -- Improved accessibility of switch button for dark mode in the admin.
https://github.com/django/django/pull/16083 - Fixed #34026 -- Fixed WKBReader.read() crash on string input.
https://github.com/django/django/pull/16098 - Fixed #34046 -- Fixed pinning flake8 and isort versions in tox.ini.
https://github.com/django/django/pull/16109 - Fixed #34049 -- Fixed displaying SVGs patterns.
https://github.com/django/django/pull/16105 - Fixed #34037 -- Improved color contrast for close buttons in admin.
https://github.com/django/django/pull/16087 - Fixed #34027 -- Fixed migrations crash when altering type of char/text fields referenced by foreign key on PostgreSQL.
Authored:
https://github.com/django/django/pull/16074 - Refs #34012 -- Added test for ordering by transform of related fields.
https://github.com/django/django/pull/16076 - Fixed #34015 -- Allowed filtering by transforms on relation fields.
Triaged:
https://code.djangoproject.com/ticket/34052 - migrate --check still emits signals if database is up to date (accepted)
https://code.djangoproject.com/ticket/34045 - Admin changelist checkboxes do not have labels (accepted)
https://code.djangoproject.com/ticket/34025 - Autocomplete field fills all empty required fields references to the same model when added a choice in popup. (accepted)
https://code.djangoproject.com/ticket/34047 - Admin Page - Stretch The Search Block (duplicate)
https://code.djangoproject.com/ticket/34056 - Update the deprecated password list used by CommonPasswordValidator to a more recent list (accepted)
https://code.djangoproject.com/ticket/34060 - Creating CheckConstraint on JSONField with __exact lookup on key transforms crashes on Oracle. (created)
https://code.djangoproject.com/ticket/34059 - Validation of check constraints on JSONField key transforms with None produces invalid SQL on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/34058 - Widening AutoField to BigAutoField, fails to widen the sequence. (accepted)
https://code.djangoproject.com/ticket/34061 - Model validations should be run on save() (wontfix)
https://code.djangoproject.com/ticket/34065 - The website especially the tutorial page wastes precious screen real estate (invalid)
https://code.djangoproject.com/ticket/34064 - USE_THOUSAND_SEPARATOR docs clarification of override by locale (wontfix)
https://code.djangoproject.com/ticket/34067 - django.core.Paginator wrong query slicing (needsinfo)
Reviewed/committed:
https://github.com/django/django/pull/16104 - Fixed #26975 -- Clarified how Django looks for fixture files.
https://github.com/django/django/pull/16106 - Refs #34041 -- Added navigation landmark to breadcrumbs in admin.
https://github.com/django/django/pull/16097 - Bumped minimum Sphinx version to 4.5.0 in docs/requirements.txt.
https://github.com/django/django/pull/15845 - Improved migrate help text for the --check option.
https://github.com/django/django/pull/16114 - Fixed #34040 -- Removed autofocus from admin search box.
https://github.com/django/django/pull/16117 - Fixed #34050 -- Replaced invalid chars in migration names with '_'.
https://github.com/django/django/pull/16119 - Completed test coverage for createsuperuser command.
https://github.com/django/django/pull/16124 - Doc'd when pre_save() is called with Model.save()'s update_fields.
https://github.com/django/django/pull/16082 - Fixed #33464 -- Resolved output_field for combined numeric expressions with MOD operator.
https://github.com/django/django/pull/16120 - Fixed #34052 -- Made migrate --check don't emit signals and output when up to date.
https://github.com/django/django/pull/16116 - Fixed #34051 -- Made makemigrations --check exit before making migrations.
https://github.com/django/django/pull/16079 - Fixed #34025 -- Fixed selecting ModelAdmin.autocomplete_fields after adding/changing related instances via popups.
https://github.com/django/django/pull/16125 - Improved error message for ASCIIUsernameValidator.
https://github.com/django/django/pull/16127 - Fixed #34056 -- Updated the list of common passwords for CommonPasswordValidator.
https://github.com/django/django/pull/16129 - Fixed #34010 -- Made parallel tests using spawn set up Django.
https://github.com/django/django/pull/16094 - Fixed #33026 -- Mentioned RequestFactory in testing tools docs.
https://github.com/django/django/pull/16072 - Fixed #32095 -- Made QuerySet.update_or_create() save only fields passed in defaults or with custom pre_save().
https://github.com/django/django/pull/16030 - Clarified how to reference RelatedObjectDoesNotExist exceptions.
Authored:
https://github.com/django/django/pull/16118 - Removed unnecessary MySQL workaround in timezones tests.
https://github.com/django/django/pull/16130 - Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test.
https://github.com/django/django/pull/16134 - Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL.
https://github.com/django/django/pull/16135 - Refs #33984 -- Added test for creating copies of model instances with inherited m2m fields.
https://github.com/django/django/pull/16138 - Refs #34058 -- Fixed changing/deleting sequences when altering pre-Django 4.1 auto fields on PostgreSQL.
https://github.com/django/django/pull/16140 - Fixed #33984 -- Reverted "Fixed #32980 -- Made models cache related managers."
Best,
Mariusz