Commits

[Daniele Procida]

Greetings all, I hope Father Christmas/La Befana/Christkind/the midwinter (assuming that you are in the northern hemisphere) gift-bringer of your culture has brought you some useful things.

I'd like to make a request about commits to the develop branch.

Would it be possible for us to have a dual-key policy for commits, like they have for nuclear weapons launches?

That is, if X thinks that a commit is ready for merging into the core, someone else should also give it assent. Nothing more difficult to obain than "it looks good to me" on IRC should be required (again, same as for nuclear launches).

Best wishes,

Daniele

[Christopher Glass]

+1 (if my vote still counts)

Merry Christmas + Happy new year everyone!

- Chris

[Jonas Obrist]

@Chris: Yes your vote still counts.

On topic: We de-facto had this a while back. At least everyone with the commit bit was highly encouraged to run any non-trivial changes (note: trivial changes in my mind are typo fixes in docs, and not much more) by another committer (or a few known members of the community). That might've slowed things down a bit, but I'm absolutely in favor of making this official. Ideally changes are done via pull requests and then merged by someone else, but that might be too much of a hassle (or promote the use of the evil "merge" button).

+1

Jonas