[patch] Add a few missing bits for OS X support

[Rafael Espíndola]

The attached patch is not complete, but it adds enough features and
fixes to let distcc pump build a slightly patched version of firefox
on OS X.

What the patch does is

* add support for -isysroot and -arch
* Fix a really nasty corner case:
* CompressFiles::Compress uses os.makedirs to create a directory
(foo) for one compilation unit
* Another compilation unit does the equivalent of '#include "foo/../bar.h"'
* The compilation unit uses no other file in foo
* We conclude that we don't have to create a dummy
foo/forcing_technique_271828

Cheers,
Rafael

[Rafael Espíndola]

I attached the wrong file the first time.

Cheers,
Rafael

[Rafael Ávila de Espíndola]

Sorry, should patches be sent to distcc-...@googlegroups.com or
dis...@lists.samba.org?

Cheers,
Rafael

[Rafael Ávila de Espíndola]

ccing dis...@lists.samba.org

Cheers,
Rafael

[Rafael Ávila de Espíndola]

Resending since it looks like the previous message fell through the cracks.

[Fergus Henderson]

Thanks for the patch.

--
You received this message because you are subscribed to the "distcc-patches" list.
To post to this list, send email to <distcc-...@googlegroups.com>.
To unsubscribe from this list, send email to <distcc-patche...@googlegroups.com>.
For archives and more options, see <http://groups.google.com/group/distcc-patches>.

[Rafael Espíndola]

On 21 December 2011 13:39, Fergus Henderson <fer...@google.com> wrote:
> Thanks for the patch.

Ping?

Cheers,
Rafael

[Rafael Espíndola]

2012/3/6 Rafael Espíndola <rafael.e...@gmail.com>:

> On 21 December 2011 13:39, Fergus Henderson <fer...@google.com> wrote:
>> Thanks for the patch.
>
> Ping?

Ping?

Cheers,
Rafael

[Fergus Henderson]

Sorry for the very slow response to this patch.

The patch looks good, except for the part 

+  def include_sysroot(self):

+    # FIXME: Is this the correct precedence for isysroot and sysroot?

+    if self.sysroot:

+      return self.sysroot

+    return self.isysroot

where the correct precedence is the other way around.

I have changed that part so that isysroot takes precedence, and submitted this CL as revision 783 in the distcc svn repository.

On Tue, Dec 20, 2011 at 6:43 PM, Rafael Ávila de Espíndola <rafael.e...@gmail.com> wrote:

The attached patch is not complete, but it adds enough features and
fixes to let distcc pump build a slightly patched version of firefox
on OS X.

What the patch does is

* add support for -isysroot and -arch
* Fix a really nasty corner case:
  * CompressFiles::Compress uses os.makedirs to create a directory
(foo)  for one compilation unit
  * Another compilation unit does the equivalent of '#include
"foo/../bar.h"'
  * The compilation unit uses no other file in foo
  * We conclude that we don't have to create a dummy
foo/forcing_technique_271828

Cheers,
Rafael

--
You received this message because you are subscribed to the "distcc-patches" list.
To post to this list, send email to <distcc-...@googlegroups.com>.
To unsubscribe from this list, send email to <distcc-patche...@googlegroups.com>.
For archives and more options, see <http://groups.google.com/group/distcc-patches>.

--

Fergus Henderson <fer...@google.com>

"Defend the user, exclude no one, and create magic." -- Eric Schmidt.