WebRTC svn revision used by Chrome stable?

[ait]

After reading the posts in the forum. I learned the following two methods to deduce the svn trunk/branch revision that chrome stable uses.

Method 1: https://code.google.com/p/chromium/issues/detail?id=176944#c7

As the link suggests: (a) chrome://version -> get the official build (b) Get the webrtc revison from the DEPS file at http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?revision=######

Method 2: https://groups.google.com/forum/#!topic/discuss-webrtc/x-5ELhVE1ow

As sugested: (a) Go to http://src.chromium.org/viewvc/chrome/releases/ (b) Search for the DEPS file for stable chrome revision for eg. 30.0.1599.69 (c) Get the webrtc revision from DEPS file (d) And sync to "/branches/X.YZ/webrtc@X" & for talk:

'/stable/talk@X'

Now, which method should I use if I want to sync to the same 'webrtc' and 'talk' code that the current chrome stable is using?

[PhistucK]

The second method.

I believe the first gets you the initial branch version, without bug fixes and code merged during the dev, beta and stable release periods.

☆PhistucK

--
 
---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Emanuele Bizzarri]

Hi,
I'm trying to write  .gclient file to do that work:

solutions = [
  { "name"        : "r338",
    "url"         : "http://webrtc.googlecode.com/svn/branches/3.38@4739",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {    
        "../chromium_deps"                  : None,
        "third_party/libvpx"                : "http://src.chromium.org/svn/trunk/deps/third_party/libvpx@212364",
        "third_party/jsoncpp/source"        : None,
        "third_party/libjingle/source/talk" : "http://webrtc.googlecode.com/svn/stable/talk@4533"
    },
    "safesync_url": "",
    "custom_vars" : {
        "root_dir": "r338"
    }
  } 
]
cache_dir = None


I haven't (yet) checked if all third party versions are the same between chrome 30.0.1599.69 and webrtc 3.38.

I also added jsoncpp to custom_deps because the svn url contained inside webrtc 3.38 DEPS doesn't work.
I can't understand why custom_deps jsoncpp override doesn't work:

Error: Command svn checkout http://jsoncpp.svn.sourceforge.net/svnroot/jsoncpp/t
runk/jsoncpp@248  --revision 248 --non-interactive --ignore-ext
ernals returned non-zero exit status 1

It continues to use the url specified inside webrtc 3.38 DEPS.

I removed also ../chromium_deps because it contains a ref to jsoncpp,
but gclient continues to download all files from webrtc 3.38 DEPS.

Can you tell me what I'm doing wrong?

Thank you,

Emanuele

[emanuele bizzarri]

The only way I've found for now is to specify a fake DEPS file and then manually add dependencies I want.

solutions = [

  { "name"        : "r338",

    "url"         : "http://webrtc.googlecode.com/svn/branches/3.38@4739",

    "deps_file"   : "DEPS_fake",

    "custom_deps" : {

        "r338/third_party/libvpx"                : "http://src.chromium.org/svn/trunk/deps/third_party/libvpx@212364",

        "r338/third_party/jsoncpp/source"        : "http://svn.code.sf.net/p/jsoncpp/code/trunk/jsoncpp@248",

        "r338/third_party/libjingle/source/talk" : "http://webrtc.googlecode.com/svn/stable/talk@4533"

    }

  }  

]

In this case I have to add r338 for every dep.

Please tell me if you have a better way to do that, or why custom_deps override doesn't work in my case.

Now my question for webrtc team is:

How does Chromium team know that webrtc 3.38 is the most stable?

Can we have a way to know which branch can be put in production, without checking Chromium version?

For example, I see that there are many version that follow 3.38. Are them all more stable than the "stable folder"?

Thank you,

Emanuele

☆PhistucK

To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrtc+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
 
---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.

To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrtc+unsubscribe@googlegroups.com.

[ait]

Even I believe that Method-2 is probably the one used by Chrome Stable. But, it will be great if someone from the chrome team could confirm the same.

The simplicity of Method-1 being that you just need to supply the revision number of the stable branch to gclient and your done. But with Method-2 you need to pull ../webrtc from ../branches/.. and talk from ../stable/talk@rev and also take care of the the third party projects. But if this is the way to sync to the code used by chrome-stable, then its worth the effort.