Contributing build gn files

25 views
Skip to first unread message

Cody Barnes

unread,
Aug 10, 2022, 1:50:24 AMAug 10
to discuss-webrtc
I'd like to contribute a modification to a build file (see  How to build static multithread debug dll (MDd) / multithread dll (MD) (google.com)  for details).  However, the /build directory is in the .gitignore list. I assume that there is a good reason for this.  Can anyone provide guidance on contributing changes to build files?

Philipp Hancke

unread,
Aug 10, 2022, 2:36:18 AMAug 10
to discuss...@googlegroups.com
This has been tried before:
but sadly was not approved hence you will need to carry a fork of chromium’s build repository

Cody Barnes <concept...@gmail.com> schrieb am Mi. 10. Aug. 2022 um 08:50:
I'd like to contribute a modification to a build file (see  How to build static multithread debug dll (MDd) / multithread dll (MD) (google.com)  for details).  However, the /build directory is in the .gitignore list. I assume that there is a good reason for this.  Can anyone provide guidance on contributing changes to build files?

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/b456fe3e-16d3-4e25-ae6e-76a7c1021018n%40googlegroups.com.

Cody Barnes

unread,
Aug 11, 2022, 12:19:10 AMAug 11
to discuss-webrtc
I see that you requested to have the proposed patch re-reviewed. Thank you! Any project that uses C++/CLI requires the shared crt.
Reply all
Reply to author
Forward
0 new messages