naming convention of release branches

139 views
Skip to first unread message

Alexandre GOUAILLARD

unread,
Jan 26, 2019, 2:36:46 AM1/26/19
to discuss...@googlegroups.com
likely a question for the googlers, maybe Patrick?

the latest 73 branch which was cut yesterday is using "m73" as a name, instead of "73" as the previous branches did. Is there a reason to break the naming convention (and all the automated scripts which depend on it) ?

$ git branch -a

* (HEAD detached at origin/master)

  master

[...]

  remotes/branch-heads/58

  remotes/branch-heads/59

  remotes/branch-heads/60

  remotes/branch-heads/61

  remotes/branch-heads/62

  remotes/branch-heads/63

  remotes/branch-heads/64

  remotes/branch-heads/65

  remotes/branch-heads/66

  remotes/branch-heads/67

  remotes/branch-heads/68

  remotes/branch-heads/69

  remotes/branch-heads/70

  remotes/branch-heads/71

  remotes/branch-heads/72

  remotes/branch-heads/m73

  remotes/branch-heads/phoglund-test

  remotes/origin/HEAD -> origin/master

  remotes/origin/infra/config

  remotes/origin/lkgr

  remotes/origin/master



--
Alex. Gouaillard, PhD, PhD, MBA
------------------------------------------------------------------------------------
President - CoSMo Software Consulting, Singapore
------------------------------------------------------------------------------------

mbon...@webrtc.org

unread,
Jan 26, 2019, 4:24:08 AM1/26/19
to discuss-webrtc
Hi Alexandre, we updated our branching process and unfortunately this changed the branch naming convention.

If it is a problem, next week I can try to change it back to ## instead of m##. On the other hand, m## explicitly mentions that the branch is a milestone, which is a nice. Let me know how problematic is this change.

Alexandre GOUAILLARD

unread,
Jan 26, 2019, 8:40:00 AM1/26/19
to discuss...@googlegroups.com
thanks for the info,

the surprise is unfortunate. In the absence of prior communication on the matter we were not sure wether it was a change in a the naming convention or an oversight. if it remains the same in the foreseeable future, we can handle it. 

I'll change our script right away to change branch naming convention between 72 and 73.

thanks.

regards,

Dr. Alex.

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/2f1c6b30-e6e5-4d3f-8ba4-c85493b9b842%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

mbon...@webrtc.org

unread,
Jan 28, 2019, 3:23:35 AM1/28/19
to discuss-webrtc
Yes, it will remain the same for the foreseeable future.

Sorry for not sending out a PSA for this change, I will keep that in mind if something will change in the future but as I wrote above, this should be quite stable and not expected to change again.


On Saturday, January 26, 2019 at 2:40:00 PM UTC+1, Alexandre GOUAILLARD wrote:
thanks for the info,

the surprise is unfortunate. In the absence of prior communication on the matter we were not sure wether it was a change in a the naming convention or an oversight. if it remains the same in the foreseeable future, we can handle it. 

I'll change our script right away to change branch naming convention between 72 and 73.

thanks.

regards,

Dr. Alex.

Alexandre GOUAILLARD

unread,
Jan 28, 2019, 10:38:55 PM1/28/19
to discuss...@googlegroups.com
thanks.

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

José Luis Millán

unread,
Feb 11, 2019, 12:13:23 PM2/11/19
to discuss...@googlegroups.com
I'm not even seeing branch-heads/m73. The last branch I see is branch-heads/72.

Has there been any change on this regard?

Screenshot 2019-02-11 at 12.12.27.png


For more options, visit https://groups.google.com/d/optout.


--
José Luis Millán

Jiawei Ou

unread,
Feb 11, 2019, 1:09:00 PM2/11/19
to discuss...@googlegroups.com
You probably need to git fetch to see that.


For more options, visit https://groups.google.com/d/optout.
--
Sent from my nondescript tablet that doesn't pay me to advertise it. Excuse brevity.

José Luis Millán

unread,
Feb 11, 2019, 3:11:15 PM2/11/19
to discuss...@googlegroups.com
I must be doing something really bad:


Screenshot 2019-02-11 at 14.44.33.png

Screenshot 2019-02-11 at 14.43.24.png


For more options, visit https://groups.google.com/d/optout.


--
José Luis Millán

José Luis Millán

unread,
Feb 11, 2019, 3:25:26 PM2/11/19
to discuss...@googlegroups.com
I can see m73 in a branch in a new checkout with `fetch --no-hooks webrtc`, but not in the original one.
--
José Luis Millán

José Luis Millán

unread,
Feb 11, 2019, 4:15:44 PM2/11/19
to discuss...@googlegroups.com
Hi,

For the records, `gclient sync --with_branch_heads && git pull` made it.

I recall that I used `gclient sync --nohooks --no-history` the first time I sync'ed the project due to a limited Internet BW I had at that time. Maybe that '--no-history' has something to do.
--
José Luis Millán
Reply all
Reply to author
Forward
0 new messages