Pulling a particular version of webrtc using the fetch mechanism -after the move to git for chromium

[Faraz Khan]

I've been using the following .gclient file successfully till the recent change that moved webrtc over to fetch chromium from git:

solutions = [
  { "name"        : "src",
    "url"         : "http://webrtc.googlecode.com/svn/trunk@7533",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "safesync_url": "",
  },
]

Unfortunately - this no longer works. The current version of webrtc used in chrome stable is 7533 from its DEPS file. If I pull using this gclient file (and do the setup_links.py etc) stuff, webrtc fails to build since many chromium dependencies are never pulled (like ffmpeg , usrsctp, etc). 

However everything works fine if I use the official method of doing a  'fetch webrtc' first. Inspecting the gclient file in this guy reveals something different:

solutions = [

  {

    "managed": False,

    "name": "src",

    "url": "https://chromium.googlesource.com/external/webrtc.git",

    "custom_deps": {},

    "deps_file": "DEPS",

    "safesync_url": "",

  },

]

Seems like its using git to fetch webrtc? Redoing things this way is fine by me  except I would love some help on how to pin this webrtc version to the one used by the current chrome stable which i'm looking up from: https://chromium.googlesource.com/chromium/src.git/+/39.0.2171.71

Any help would be appreciated. Thanks. 

[Alexandre GOUAILLARD]

gclient config http://webrtc.googlecode.com/svn/trunk

gclient sync --force -r 7533

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Alex. Gouaillard, PhD, PhD, MBA

------------------------------------------------------------------------------------

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

------------------------------------------------------------------------------------

sg.linkedin.com/agouaillard

• 
  

[Faraz Khan]

Alex,
I know that should work in theory but does that actually work for you (in the sense that webrtc compiles correctly after this sync).

Mine fails to find a lot of chromium deps.

You received this message because you are subscribed to a topic in the Google Groups "discuss-webrtc" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/discuss-webrtc/BvWIAyc0qrQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to discuss-webrt...@googlegroups.com.

[Alexandre GOUAILLARD]

I have not tested with this revision number specifically, but our automated builds are using this command and have been stable for quite some time now.

for which target platform (win/mac/ios/android) and configuration (del/deb, 32/64, ...) are you building? I will give it a shot for you.

[Faraz Khan]

Thanks! I've tested it on mac osx / 64 specifically. Maybe it works for other configs but I gave up after this didnt work since osx is a major platform for us :)

Is there a way to work directly with git that you know of? Maybe give it a commit version and reset to that directly? I guess I dont understand the currently relationship between webrtc's git and SVN repositories... Are two different repo's being maintained?

--

Faraz Khan

Simple Collaboration Screensharing

www.screenhero.com

[Alexandre GOUAILLARD]

hum, I hadn't looked at it for a long time, since we haven t experienced problem with our solution.

<rant>I still dislike the fact that one need to learn chrome development env and toolset to be able to simply build libwebrtc.</rant>

it looks like the git tree in chrome/external and the svn tree are mirroring each other almost in real time, so I guess you're free to use one or the other. I don't know which one is the master and which one is the slave, but as long as they are the same and in sync, you're good. You have a one to one mapping between a svn rev and a git hash as well (linear history) so I don't see why using git with a hash instead of svn with rev number would change, as you are getting the same source code, and your problem come from later. 

let me give it a try with 7533, i ll get back to you.

Alex.

[Faraz Khan]

Thanks alex! Let me know. I'll try again as well!

[Alexandre GOUAILLARD]

hi faraz,

apparently i had never compile in 64 bits. let me iron that out first.

i tried mac 32 bits rev 7533 and had no problem.

Alex.

[Faraz Khan]

Alex,

Weird! Let me try that again myself and will get back to you!

[Alexandre GOUAILLARD]

no problem. The only hiccup was changing "trunk" to "src" for 32 bits, so it was not painful.

In the meantime, I'm adding 64 bits compilation support in my scripts. I'll let you know.

Cheers.

[Faraz Khan]

Alex,

Pulling a fresh tree (and not updating the previous one) works fine! thanks!

[Alexandre GOUAILLARD]

great,

thanks for letting us know.