framesReceived stats

[Jozsef Vass]

Hello,

We recently ran into a codec error issue in our Android implementation. This prompted me to check how framesReceived are counted. W3C stats document says these are the frames received by the network before decoding.

I am looking at ReceiveStatisticsProxy::OnDecodedFrame(), which counts decoded key frames and delta frames. In WebRtcVideoReceiveChannel::WebRtcVideoReceiveStream::GetVideoReceiverInfo() you have:

 info.frames_received = stats.frame_counts.key_frames + stats.frame_counts.delta_frames;

This then propagates to CreateInboundRTPStreamStatsFromVideoReceiverInfo().

This is probably not a big deal, but is my description correct?

Thank you.

Jozsef

[Philipp Hancke]

what version are you on?

https://chromiumdash.appspot.com/commits?commit=bff7ad9c86294a49d85d1afcb1e6bf763fabb464&platform=Windows landed in M144 

--
This list falls under the WebRTC Code of Conduct - https://webrtc.org/support/code-of-conduct.
---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/discuss-webrtc/CACHtiy_uAta6AtvUR3BriiCvfWREfUwZrrQtrr6V8omcGP6tGg%40mail.gmail.com.

[Jozsef Vass]

Our mobile is in the process of upgrading to M146, but my test was on M130. Thank you so much!

Jozsef

To view this discussion visit https://groups.google.com/d/msgid/discuss-webrtc/CADxkKiL-44hSoX2M9w%3Den-7_46JtLOdVEf3HZotbbfWj9Ho_cA%40mail.gmail.com.

[Philipp Hancke]

heh, that bug was indeed *very* unhelpful when debugging decoding failures ;-)

To view this discussion visit https://groups.google.com/d/msgid/discuss-webrtc/CACHtiy908oq8LjEcSzNSMpceh_%2BT85-kE60KsHqHnxsWHj_Z_w%40mail.gmail.com.

[Jozsef Vass]

Just a quick follow up, now it looks like keyFramesDecoded is actually key frames received.

Jozsef

To view this discussion visit https://groups.google.com/d/msgid/discuss-webrtc/CADxkKiKDhggbu32APgGt3tCGu-JJOiNyx2eWbawvA9DzrSYv4g%40mail.gmail.com.

[Philipp Hancke]

duh, thanks for pointing that out! Fix is up here:

  https://webrtc-review.googlesource.com/c/src/+/494400

 

To view this discussion visit https://groups.google.com/d/msgid/discuss-webrtc/CACHtiy_LcczeyJEKQNaA%3DFXZL2SHUHw6WzJbUhuUxd30p%3DZZ5Q%40mail.gmail.com.