Add Mediatek into H264 support list

[marti...@mediatek.com]

Hi,

Is it okay to submit the following patches into WebRTC?

If yes, how can Mediatek make it happened?

Thank you very much!!

diff --git a/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java b/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java

index 44572cb..b26e60c 100644

--- a/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java

+++ b/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java

@@ -72,7 +72,7 @@ public class MediaCodecVideoDecoder {

   private static final String[] supportedVp9HwCodecPrefixes = {"OMX.qcom.", "OMX.Exynos."};

   // List of supported HW H.264 decoders.

   private static final String[] supportedH264HwCodecPrefixes = {

-      "OMX.qcom.", "OMX.Intel.", "OMX.Exynos."};

+      "OMX.qcom.", "OMX.Intel.", "OMX.Exynos.", "OMX.MTK"};

diff --git a/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java b/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java

index 258ef96..08eb940 100644

--- a/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java

+++ b/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java

@@ -127,8 +127,10 @@ public class MediaCodecVideoEncoder {

       "OMX.qcom.", Build.VERSION_CODES.KITKAT, BitrateAdjustmentType.NO_ADJUSTMENT);

   private static final MediaCodecProperties exynosH264HwProperties = new MediaCodecProperties(

       "OMX.Exynos.", Build.VERSION_CODES.LOLLIPOP, BitrateAdjustmentType.FRAMERATE_ADJUSTMENT);

+  private static final MediaCodecProperties mtkH264HwProperties = new MediaCodecProperties(

+      "OMX.MTK", Build.VERSION_CODES.LOLLIPOP, BitrateAdjustmentType.NO_ADJUSTMENT);

   private static final MediaCodecProperties[] h264HwList =

-      new MediaCodecProperties[] {qcomH264HwProperties, exynosH264HwProperties};

+      new MediaCodecProperties[] {qcomH264HwProperties, exynosH264HwProperties, mtkH264HwProperties};

Martin Liu

[Patrik Höglund]

Hi Martin!

Please send us a patch, and a reviewer will have a look at it.

Read

https://webrtc.org/contributing/

https://webrtc.org/native-code/development/

for instructions on how to make patches.

/ P

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrtc+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/78ae178a-736d-4a66-a2d0-0723f9744521%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jose Javier Alvarez]

Hey @Martin Liu, 

I tried it already some time ago in branch 62 and results were terrible for Mediatek devices. The video was not working fine. 

In which branch have you tried it? Is video working fine for you?

Cheers,

Jose Javier.

[shakeeb nazmus]

Hi all,

Anybody has been able to use mediatek's hardware encoder and decoder with webrtc library for android?

Thanks,

Shakeeb