Missing include files base\logging_buildflags.h and base\debug\debugging_buildflags.h

[Philip Davis]

Hi, I'm trying to build webrtc (tried m78 and m79) but the compiler is complaining about two missing files:

Broken include references:

1. https://chromium.googlesource.com/chromium/src/+/master/base/logging.h#22

2. https://chromium.googlesource.com/chromium/src/+/master/base/location.h#15

Am I looking in the wrong place? Do I need to download some additional source code?

Thanks,

Phil

[Mirko Bonadei]

That file is not part of WebRTC but it is part of Chromium. It is generated at build time here: https://cs.chromium.org/chromium/src/base/BUILD.gn?l=2123&rcl=409610fca8c94015bd216768c6c15cd5a3564826. If you use GN/ninja and the code is up to date everything should just work.

[Philip Davis]

Can you be more specific about "If [I] use GN/ninja"?

This is what I did:

fetch webrtc

cd src
git checkout branch-heads/m79
gclient sync

gen out\x64\Release --args="...some args..."

ninja -C out\x64\Release

[Mirko Bonadei]

Ok, this is a good starting point. To be more specific I need to know the GN args you are using.

[Philip Davis]

is_debug=false
use_rtti=true
is_win_fastlink=true
rtc_use_h264=true
ffmpeg_branding="Chrome"
target_cpu="x64"
symbol_level=0
rtc_build_json=true
rtc_build_examples=false
rtc_build_opus=false
rtc_build_tools=false
rtc_include_ilbc=false
rtc_include_opus=false
rtc_include_pulse_audio=false
rtc_include_tests=false
target_winuwp_family="server"
target_winuwp_version="8.0"
visual_studio_version="2019"

[Philip Davis]

Ah, sorry... I should clarify. Webrtc built correctly. I'm building an application that links in webrtc and it is the application that is failing to build because of the missing files.

[Kiran Thind]

Try changing rtc_include_tests to true.

Sent from my iPhone

On Nov 6, 2019, at 9:46 AM, Philip Davis <mrphili...@gmail.com> wrote:



Ah, sorry... I should clarify. Webrtc built correctly. I'm building an application that links in webrtc and it is the application that is failing to build because of the missing files.

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-webrt...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/discuss-webrtc/4c715e70-b546-42e3-a41d-ed762c060c29%40googlegroups.com.

[Mirko Bonadei]

Ok, one of the two files is pulled into a TU form https://cs.chromium.org/chromium/src/base/logging.h?l=22&rcl=9873826d9010dbc3d97806899dca3f47365fc96e and the only way for WebRTC to #include Chromium's base/logging.h is if the GN argument build_with_chromium is true (https://cs.chromium.org/chromium/src/third_party/webrtc/rtc_base/BUILD.gn?l=262-269&rcl=492fdf40fe59d6bd0fd2ff0074e8f59c6ec5120e). You are not explicitly setting it and that should be false (see https://cs.chromium.org/chromium/src/third_party/webrtc/build_overrides/build.gni?l=17&rcl=e07d3b432ab6892d2705bdb75da3c30dd656b1d4) when building standalone WebRTC (not from the Chromium build). So it is possible you are building //third_party/webrtc from the Chromium's repo?

[Philip Davis]

Thanks, Kiran. I tried changing all of my false flags to true (except is_debug), did "ninja -C out\x64\Release -t clean" followed by "ninja -C out\x64\Release" and still the two files were not generated.

 

On Wednesday, November 6, 2019 at 8:01:36 PM UTC-5, Kiran wrote:

Try changing rtc_include_tests to true.

Sent from my iPhone

On Nov 6, 2019, at 9:46 AM, Philip Davis <mrphili...@gmail.com> wrote:



Ah, sorry... I should clarify. Webrtc built correctly. I'm building an application that links in webrtc and it is the application that is failing to build because of the missing files.

--

---
You received this message because you are subscribed to the Google Groups "discuss-webrtc" group.

To unsubscribe from this group and stop receiving emails from it, send an email to discuss...@googlegroups.com.

[Philip Davis]

I was loosely following the build instructions at https://sourcey.com/articles/building-and-installing-webrtc-on-windows (very old), which does not appear to explicitly instruct the tooling to pull webrtc from one place or another.

It says to download depot_tools from https://storage.googleapis.com/chrome-infra/depot_tools.zip ... does gclient take some configuration that points it at a standalone webrtc?

would "fetch webrtc" pull from //third_party/webrtc?

Thanks Mirko.

[Amol Agarwal]

I am also facing the same problem on M76 also.
Anyone find the solution of this?

Thanks
Amol

[Bryan Angelo]

I am experiencing the same issue.  I am able to build webrtc standalone but am unable to link against it as logging_buildflags.h does not exist.

root@38155dc907b7:/opt/webrtc/src# gn gen out/Release --args='is_debug=false'

Done. Made 1113 targets from 245 files in 463ms

root@38155dc907b7:/opt/webrtc/src# ninja -C out/Release

ninja: Entering directory `out/Release'

[4616/4616] STAMP obj/default.stamp

root@38155dc907b7:/opt/webrtc/src# find . -name logging_buidflags\*

root@38155dc907b7:/opt/webrtc/src# grep logging_buildflags base/*.h

base/logging.h:#include "base/logging_buildflags.h"

root@38155dc907b7:/opt/webrtc/src#

Is the expectation that the consumer of libwebrtc must define logging_buildflags.h?