ice candidate iceGatheringState complete

[Bryan Paluch]

I noticed that in Canary 26.0.1410.0 that webkitRTCPeerConnection.onicecandidate callbacks no long emit events that are missing the candidate object to notify the app that candidate gathering is complete. 

I've started using this to detect gathering complete:

var pc = new webkitRTCPeerConnection(pc_config, pc_constraints);

pc.onicecandidate = this._onIceCandidate;

pc.ongatheringchange = function(event){

  if(event.currentTarget.iceGatheringState === "complete"){

    console.log("Ice Gathering complete");

    this.emitSignalingMessage({target: this.get('currentTarget'), type: 'icefinished'}); //Do your custom logic

  }

}

Is this right? It works, I'm just curious if this will change, or if I should actually be testing something else on that event. 

Thanks,

Bryan

[Kaiduan Xie]

Try the following code,

function onIceCandidate(event) {
if (event.candidate) {
sendMessage({type: 'candidate',
label: event.candidate.sdpMLineIndex,
id: event.candidate.sdpMid,
candidate: event.candidate.candidate});
} else {
console.log("End of candidates.");
}
}

/Kaiduan

> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "discuss-webrtc" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to discuss-webrt...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[Bryan Paluch]

By "callbacks no long emit events that are missing the candidate object to notify the app that candidate gathering is complete"
I mean that function will never fire with an event that will fail the if statement.

If you are running that code and rely on the else statement to do something, (i.e notify the other side that ice candidates are done, so you can create a sip INVITE), then it will not work in the latest canary.

That's how I used to fire my end of candidates event (And still do for backwards support.)

[Kaiduan Xie]

Have you tried the above code? This is from apprtc.appspot.com and is
based on webkit source code.

/Kaiduan

[Justin Uberti]

Yeah, I see this too in M26 canary. Can you file a bug?

Mallinath, please take a look.

[Benjamin Schwartz]

This is a result of the patch at

https://codereview.chromium.org/12210111/patch/2002/5005

The OnIceComplete hander has been removed.  I think this was a miscommunication about the desired Chrome behavior.

To maintain the NULL candidate behavior, the code that was previously listening to OnIceComplete could be placed in OnIceGatheringChange, listening to kIceGatheringComplete.

[Justin Uberti]

OK, we'll need to fix that. IceGatheringState is not exposed via its own callback to JS, oncandidate(null) is the way it is implicitly signaled. There is an iceGatheringState accessor though if you want to poll the state.

[Bryan Paluch]

You can also use the ongatheringchange callback then test event.currentTarget.iceGatheringState. Instead of polling. 

[Bryan Paluch]

added issue to tracker : http://code.google.com/p/webrtc/issues/detail?can=2&start=0&num=100&q=&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Status%20Owner%20Summary&groupby=&sort=&id=1393