Libyuv changes can now be reviewed on Gerrit!

[Aaron Gable]

Hey libyuv devs,

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply to this repository:

https://chromium.googlesource.com/libyuv/libyuv

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-base PolyGerrit UI. You can switch between UIs using the link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

In a few weeks, assuming things are working smoothly, we will switch the default so that all reviews will go to Gerrit, and you'll no longer need to pass the --gerrit flag. We'll communicate the timeline for that flag change clearly, and you can track the work towards it here:

https://bugs.chromium.org/p/chromium/issues/detail?id=665585

Thanks,

Aaron

[Aaron Gable]

A big thank you to everyone who tested PolyGerrit, uploaded or reviewed CLs there, and filed bugs against us to improve it. Thanks to your feedback, we're now ready to change the default code review system for pdfium.

On Tuesday, Jan 24, I will submit a CL changing the default code review system for libyuv.

Any currently in-flight CLs you have on Rietveld will be unaffected; you can finish reviewing and landing them as normal. Once you sync your checkout past the above commits, any new CLs you upload will go to Gerrit instead. If for some reason you really need to upload a change to Rietveld anyway, you can do so with `git cl upload --rietveld`.

Again, this doc and this faq should answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

Thanks,

Aaron

[Frank Barchard]

In the old system, I could do git cl try from the command line, and see the results in the review.

PolyGerrit doesnt seem to have any visual way to confirm try bots passed?

Shouldnt there be a way to start a 'dry run' from the UI?

On Thu, Jan 19, 2017 at 11:46 AM, Aaron Gable <aga...@google.com> wrote:

A big thank you to everyone who tested PolyGerrit, uploaded or reviewed CLs there, and filed bugs against us to improve it. Thanks to your feedback, we're now ready to change the default code review system for pdfium.

On Tuesday, Jan 24, I will submit a CL changing the default code review system for libyuv.

Any currently in-flight CLs you have on Rietveld will be unaffected; you can finish reviewing and landing them as normal. Once you sync your checkout past the above commits, any new CLs you upload will go to Gerrit instead. If for some reason you really need to upload a change to Rietveld anyway, you can do so with `git cl upload --rietveld`.

Again, this doc and this faq should answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polyg...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

Thanks,

Aaron

On Fri, Nov 18, 2016 at 4:16 PM Aaron Gable <aga...@google.com> wrote:

Hey libyuv devs,

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply to this repository:

https://chromium.googlesource.com/libyuv/libyuv

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-base PolyGerrit UI. You can switch between UIs using the link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polyg...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

[Aaron Gable]

Yes, "git cl try" still works -- it sets the "Commit-Queue +1" label on the code review, which triggers the CQ to run a dry-run. (The Commit-Queue +2 label triggers a full CQ run and commit.) When those bots run, rectangles similar to those on Rietveld show up underneath the patch files, changing colors depending on the try run state. Finally, you can start a dry run via the UI either by setting the CQ+1 label manually (in the Reply dialog) or by clicking the "Dry Run" button which appears in the row of buttons in the upper right corner.

You can see these in action on this CL of mine. The recent CQ+1 label (see message at the very bottom) was set via "git cl try", and there is a box for the "Depot Tools Presubmit" bot underneath the patch files.

On Thu, Jan 19, 2017 at 3:07 PM Frank Barchard <fbar...@google.com> wrote:

In the old system, I could do git cl try from the command line, and see the results in the review.

PolyGerrit doesnt seem to have any visual way to confirm try bots passed?

Shouldnt there be a way to start a 'dry run' from the UI?

On Thu, Jan 19, 2017 at 11:46 AM, Aaron Gable <aga...@google.com> wrote:

A big thank you to everyone who tested PolyGerrit, uploaded or reviewed CLs there, and filed bugs against us to improve it. Thanks to your feedback, we're now ready to change the default code review system for pdfium.

On Tuesday, Jan 24, I will submit a CL changing the default code review system for libyuv.

Any currently in-flight CLs you have on Rietveld will be unaffected; you can finish reviewing and landing them as normal. Once you sync your checkout past the above commits, any new CLs you upload will go to Gerrit instead. If for some reason you really need to upload a change to Rietveld anyway, you can do so with `git cl upload --rietveld`.

Again, this doc and this faq should answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

Thanks,

Aaron

On Fri, Nov 18, 2016 at 4:16 PM Aaron Gable <aga...@google.com> wrote:

Hey libyuv devs,

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply to this repository:

https://chromium.googlesource.com/libyuv/libyuv

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-base PolyGerrit UI. You can switch between UIs using the link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

[Henrik Kjellander]

As can be seen on https://chromium-review.googlesource.com/c/430321/ libyuv don't yet have the CQ button or the Commit-Queue label, but Aaron is working on it, so expect this to arrive soon!

On Friday, January 20, 2017 at 12:18:10 AM UTC+1, Aaron Gable wrote:

Yes, "git cl try" still works -- it sets the "Commit-Queue +1" label on the code review, which triggers the CQ to run a dry-run. (The Commit-Queue +2 label triggers a full CQ run and commit.) When those bots run, rectangles similar to those on Rietveld show up underneath the patch files, changing colors depending on the try run state. Finally, you can start a dry run via the UI either by setting the CQ+1 label manually (in the Reply dialog) or by clicking the "Dry Run" button which appears in the row of buttons in the upper right corner.

You can see these in action on this CL of mine. The recent CQ+1 label (see message at the very bottom) was set via "git cl try", and there is a box for the "Depot Tools Presubmit" bot underneath the patch files.

On Thu, Jan 19, 2017 at 3:07 PM Frank Barchard <fbar...@google.com> wrote:

In the old system, I could do git cl try from the command line, and see the results in the review.

PolyGerrit doesnt seem to have any visual way to confirm try bots passed?

Shouldnt there be a way to start a 'dry run' from the UI?

On Thu, Jan 19, 2017 at 11:46 AM, Aaron Gable <aga...@google.com> wrote:

A big thank you to everyone who tested PolyGerrit, uploaded or reviewed CLs there, and filed bugs against us to improve it. Thanks to your feedback, we're now ready to change the default code review system for pdfium.

On Tuesday, Jan 24, I will submit a CL changing the default code review system for libyuv.

Any currently in-flight CLs you have on Rietveld will be unaffected; you can finish reviewing and landing them as normal. Once you sync your checkout past the above commits, any new CLs you upload will go to Gerrit instead. If for some reason you really need to upload a change to Rietveld anyway, you can do so with `git cl upload --rietveld`.

Again, this doc and this faq should answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polyg...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

Thanks,

Aaron

On Fri, Nov 18, 2016 at 4:16 PM Aaron Gable <aga...@google.com> wrote:

Hey libyuv devs,

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply to this repository:

https://chromium.googlesource.com/libyuv/libyuv

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-base PolyGerrit UI. You can switch between UIs using the link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polyg...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

[Aaron Gable]

libyuv now has a commit queue! Use "git cl set-commit" or click the "Submit to CQ" button to land your change through the commit queue. You can still use "git cl try", or click the "CQ Dry Run" button, to run all the tests without committing afterwards.

You can see it in action on this CL: https://chromium-review.googlesource.com/c/430992/

On Thu, Jan 19, 2017 at 11:04 PM Henrik Kjellander <kjell...@google.com> wrote:

As can be seen on https://chromium-review.googlesource.com/c/430321/ libyuv don't yet have the CQ button or the Commit-Queue label, but Aaron is working on it, so expect this to arrive soon!

[Aaron Gable]

All relevant changes have been made! Once you've synced your checkout to tip of tree, your next upload will automatically go to Gerrit.

Thanks, everybody!

Aaron