CMake errors on Win

[roxlu]

Hey,

I just wanted to compile libyuv on Windows but got an error with the intall step.  Some things:

- The convert target file is pointing to a wrong location; use $<TARGET_FILE:converrt> instead. 

- Why rename the convert target during the install step? Why not rename the target (because renaming a executable is not cross platform;i.e. the .exe is removed)

- Not sure why but the static and shared library gave cmake errors; I suspect character encoding issues.

I've fixed the install steps by using these command; though I'm not renaming the convert target.

INSTALL(PROGRAMS $<TARGET_FILE:convert> DESTINATION bin)

INSTALL(TARGETS ${ly_lib_static} DESTINATION lib)

INSTALL(TARGETS ${ly_lib_shared} LIBRARY DESTINATION lib)

INSTALL(DIRECTORY ${PROJECT_SOURCE_DIR}/include/ DESTINATION include)

roxlu

[Frank Barchard]

I dont maintain the cmake myself, so rely on contributions from folks like you.

The rename was likely meant to avoid a name clash with the linux tool 'convert'.

I'll start by filing a bug

https://bugs.chromium.org/p/libyuv/issues/detail?id=695

The libyuv convert tool isnt intended to be useful... its a test app.  So removing it from the cmake might be the simpliest.

Renaming the tool itself to yuvconvert might be a good solution, longer term, so that it doesnt clash.

The psnr tool is actually useful, so that could be added.

--
You received this message because you are subscribed to the Google Groups "discuss-libyuv" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-libyuv+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.