asm compiler issue in VS2010 (patch included)

[Steve Browne]

There's an issue compiling in VS2010 because HAS_SCALEADDROW_AVX is not defined, but this is not checked before defining ScaleAddRow_AVX2. It just a simple matter of putting the if defined around it. See the attached patch.

Thanks

[Frank Barchard]

That change is already in git head version of libyuv, which is r1562

You seem to be on r1444 did you get it using the svn repository?

If so can you switch to the git version?

https://code.google.com/p/libyuv/wiki/GettingStarted

On Tue, Jan 5, 2016 at 1:19 PM, Steve Browne <swbr...@gmail.com> wrote:

There's an issue compiling in VS2010 because HAS_SCALEADDROW_AVX is not defined, but this is not checked before defining ScaleAddRow_AVX2. It just a simple matter of putting the if defined around it. See the attached patch.

Thanks

--
You received this message because you are subscribed to the Google Groups "discuss-libyuv" group.
To unsubscribe from this group and stop receiving emails from it, send an email to discuss-libyuv+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Steve Browne]

Oops yes you are correct. The source page has no mention of the git repo and only the svn link. I did notice the git related files in there, but I figured they would be in sync. Sorry about that. Luckily it looks like svn isn't too far behind to where there are API breaking changes or something that would make my code irrelevant.

Anyway, thanks for pointing me in the right direction.

On Tuesday, January 5, 2016 at 6:09:18 PM UTC-5, Frank Barchard wrote:

That change is already in git head version of libyuv, which is r1562

You seem to be on r1444 did you get it using the svn repository?

If so can you switch to the git version?

https://code.google.com/p/libyuv/wiki/GettingStarted

On Tue, Jan 5, 2016 at 1:19 PM, Steve Browne <swbr...@gmail.com> wrote:

There's an issue compiling in VS2010 because HAS_SCALEADDROW_AVX is not defined, but this is not checked before defining ScaleAddRow_AVX2. It just a simple matter of putting the if defined around it. See the attached patch.

Thanks

--
You received this message because you are subscribed to the Google Groups "discuss-libyuv" group.

To unsubscribe from this group and stop receiving emails from it, send an email to discuss-libyu...@googlegroups.com.

[Frank Barchard]

I've made the change to SVN in r1445, if you want to try syncing up what you have.

https://code.google.com/p/libyuv/source/list

A bug was created track this issue

https://code.google.com/p/libyuv/issues/detail?id=541

It would be best if you:

1. upgrade to VS2013 to benefit from AVX2

Also consider clangcl build, which supports 64 bit assembly, and is Visual C compatible.

VS2010 support is deprecated and the code will start to decay.  Patches accepted, but VS2010 doesnt get tested.

2. upgrade to git version of libyuv, to get the latest improvements.

To unsubscribe from this group and stop receiving emails from it, send an email to discuss-libyuv+unsubscribe@googlegroups.com.