Notifications

[Martin Bruse]

So, I'm looking at the code, and it looks like you get notifications for phases even when you're eliminated.

Is this true, or am I just confused?

If it's true, is it something we want? Shouldn't I turn that off - I imagine it will feels a bit spammy to get notifications for games where you're already gone...?

[tttppp123]

I can now confirm this is true!

Obviously testing this was the only reason I allowed myself to be eliminated from a game!

[Martin Bruse]

But of course.

Should it be turned off? I think so, but I'd love to hear other opinions.

On Tue, May 29, 2018, 22:41 tttppp123 <tttp...@gmail.com> wrote:

I can now confirm this is true!

Obviously testing this was the only reason I allowed myself to be eliminated from a game!

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-de...@googlegroups.com.
To post to this group, send email to diplic...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[tttppp123]

It definitely should be turned off. It potentially should even be turned off when you have no options for a phase.

Another approach would be to make games mutable, but I think this would just be used to mute them when you were eliminated.

My vote is for muted if a player has no options.

[Martin Bruse]

I want notifications even when I don't have options, if I'm not eliminated: I'm curious as to what happened in the game.

WDYT?

[tttppp123]

I wouldn't mind missing the notification for a retreat phase if I get one for the adjustment phase.

Perhaps there's an 'out by one' issue here though. With my suggestion players might not be notified that they'd been eliminated. Maybe you should get no notification if you had no options last phase and no options this phase? This still potentially means no notification for Fall Adjustment if you weren't attacked and can't build.

I'm happy to follow games I've been knocked out of by checking back.

There's also a question around chats. I always want to receive direct messages, even if I've been knocked out, but I can imagine wanting to turn off the Everyone chat after being knocked out.

[Martin Bruse]

I suggest a compromise:

I remove the notifications for things that we can assume nobody wants, which is right now only (I think) new phases in games where you were eliminated last phase.

Notifications for phases where you have zero options, or 'Everyone' chats where you are eliminated, can be handled later - possibly as config options. Sound good?

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-dev+unsubscribe@googlegroups.com.

[Martin Bruse]

I submitted https://github.com/zond/diplicity/commit/4967487aa9f3e59d9d86ee2b76484d949b0cd092 that should remove new phase notifications for players that were eliminated in the phase before.

Not yet pushed, waiting for Tom to review it - we have no tests for the notifications :/

[Gabe]

I would say a mute option might be less bug-prone, just let the user mute any game they decide they dont want to hear from.