[Dillo-dev] patch for dillo and openssl 1.1

[Globe Trotter]

Hello,

Dillo's https stopped working on F26. It turned out that that was because of the move to openssl v1.1. The kind folks (in particular Matias Ellert) made a patch for F26 which works for both the old version of dillo with openssl v1.0 and v1.1.

I am including his patch here in case there is interest in merging this upstream (which is the best place to put it).

Best wishes!

[Jun Ebihara]

NetBSD 8.99.14 contains OpenSSL 1.1.0g 2 Nov 2017.

to support dillo+enableSSL+OpenSSL 1.1.0g,
need this patch for pkgsrc packaging system workaround.

http://mail-index.netbsd.org/pkgsrc-changes/2018/03/24/msg173237.html

+--- dpi/https.c.orig 2015-06-30 14:06:08.000000000 +0000
++++ dpi/https.c
+@@ -476,7 +476,11 @@ static int handle_certificate_problem(SS
+ case X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT:
+ /*Either self signed and untrusted*/
+ /*Extract CN from certificate name information*/
++#if OPENSSL_VERSION_NUMBER < 0x10100000L
+ if ((cn = strstr(remote_cert->name, "/CN=")) == NULL) {
++#else
++ if ((cn = strstr(X509_get_subject_name(remote_cert), "/CN=")) == NULL) {
++#endif
+ strcpy(buf, "(no CN given)");
+ } else {
+ char *cn_end;

--
Jun Ebihara

_______________________________________________
Dillo-dev mailing list
Dill...@dillo.org
http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

[Globe Trotter]

Is it possible to mergen this and release a maintenance release. This is an important patch and would be very helpful in keeping dillo current and updated on some distributions.

[Johannes Hofmann]

Hi,

thanks for the patch! I'll try to get this merged.

Cheers,
Johannes

[Johannes Hofmann]

Hi,

I committed the patch to the 3.0.5 branch.
Please test and give feedback.

Cheers,
Johannes

[Globe Trotter]

Sorry for the delay in getting to this. The patch works for me.

[Johannes Hofmann]

Hi,

thanks for the feedback. I'll try to roll a release candidate soon.

Cheers,
Johannes

[Globe Trotter]

Thanks! And thanks for all your efforts!